Subject: Re: bug#27043: [PATCH] gnu: Add python-asn1crypto.

From: Arun Isaac <[email-masked]>
Date: Wed, 24 May 2017 13:24:41 +0530

Thanks for the patch! :-)

Leo Famulari writes:

> * gnu/packages/crypto.scm (python-asn1crypto, python2-asn1crypto): New variables.

I think we should put this package in gnu/packages/python.scm. Packages
like python-cryptography are in python.scm.

> +(define-public python-asn1crypto
> +  (package
> +    (name "python-asn1crypto")
> +    (version "0.22.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "asn1crypto" version))

Release tarballs are availabe on the project's github page. Why not use
those?

> +    (arguments
> +     '(#:tests? #f)) ; Tests are not distributed via PyPi.

The github release tarballs have tests. Could you package them?

> +    (home-page "https://github.com/wbond/asn1crypto")
> +    (synopsis "ASN.1 parser and serializer in Python")
> +    (description "Fast ASN.1 parser and serializer with definitions for private
> +keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7, PKCS#8,
> +PKCS#12, PKCS#5, X.509 and TSP.")

The description should be in full sentences.