Subject: Re: bug#27043: [PATCH] gnu: Add python-asn1crypto.

From: Leo Famulari <[email-masked]>
Date: Thu, 25 May 2017 15:44:29 -0400

On Wed, May 24, 2017 at 01:24:41PM +0530, Arun Isaac wrote:
> Leo Famulari writes:
> > * gnu/packages/crypto.scm (python-asn1crypto, python2-asn1crypto): New variables.
> 
> I think we should put this package in gnu/packages/python.scm. Packages
> like python-cryptography are in python.scm.

There are performance issues with Guile 2.2, and the huge (gnu packages
python) module is really a pathological case [0]. So, if a new package
makes sense in other modules, I'll be adding them in those other
modules, at least until the compiler performance is improved.

https://lists.gnu.org/archive/html/guile-devel/2017-05/msg00033.html

> > +        (uri (pypi-uri "asn1crypto" version))
> 
> Release tarballs are availabe on the project's github page. Why not use
> those?
> 
> > +    (arguments
> > +     '(#:tests? #f)) ; Tests are not distributed via PyPi.
> 
> The github release tarballs have tests. Could you package them?

Aha! Good catch.

> 
> > +    (description "Fast ASN.1 parser and serializer with definitions for private
> > +keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7, PKCS#8,
> > +PKCS#12, PKCS#5, X.509 and TSP.")
> 
> The description should be in full sentences.

Indeed, fixed!

Thanks for the review!

Pushed as 10e65d5e5adde4e17bae47f0b59b36df264ded39