Subject: bug#27043: closed (Re: bug#27043: [PATCH] gnu: Add python-asn1crypto.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 25 May 2017 19:45:01 +0000

Your bug report

#27043: [PATCH] gnu: Add python-asn1crypto.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
27043: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27043
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#27043: [PATCH] gnu: Add python-asn1crypto.
From: Leo Famulari <[email-masked]>
To: Arun Isaac <[email-masked]>
Cc: [email-masked]
Date: Thu, 25 May 2017 15:44:29 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

On Wed, May 24, 2017 at 01:24:41PM +0530, Arun Isaac wrote:
> Leo Famulari writes:
> > * gnu/packages/crypto.scm (python-asn1crypto, python2-asn1crypto): New variables.
> 
> I think we should put this package in gnu/packages/python.scm. Packages
> like python-cryptography are in python.scm.

There are performance issues with Guile 2.2, and the huge (gnu packages
python) module is really a pathological case [0]. So, if a new package
makes sense in other modules, I'll be adding them in those other
modules, at least until the compiler performance is improved.

https://lists.gnu.org/archive/html/guile-devel/2017-05/msg00033.html

> > +        (uri (pypi-uri "asn1crypto" version))
> 
> Release tarballs are availabe on the project's github page. Why not use
> those?
> 
> > +    (arguments
> > +     '(#:tests? #f)) ; Tests are not distributed via PyPi.
> 
> The github release tarballs have tests. Could you package them?

Aha! Good catch.

> 
> > +    (description "Fast ASN.1 parser and serializer with definitions for private
> > +keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7, PKCS#8,
> > +PKCS#12, PKCS#5, X.509 and TSP.")
> 
> The description should be in full sentences.

Indeed, fixed!

Thanks for the review!

Pushed as 10e65d5e5adde4e17bae47f0b59b36df264ded39

Subject: [PATCH] gnu: Add python-asn1crypto.
From: Leo Famulari <[email-masked]>
To: [email-masked]
Date: Tue, 23 May 2017 15:42:27 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/crypto.scm (python-asn1crypto, python2-asn1crypto): New variables.
---
 gnu/packages/crypto.scm | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 856308afe..86cd777ef 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -51,7 +51,8 @@
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix build-system cmake)
-  #:use-module (guix build-system gnu))
+  #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python))
 
 (define-public libsodium
   (package
@@ -414,3 +415,27 @@ utility as a demonstration of the @code{scrypt} key derivation function.
 @code{Scrypt} is designed to be far more resistant against hardware brute-force
 attacks than alternative functions such as @code{PBKDF2} or @code{bcrypt}.")
     (license license:bsd-2)))
+
+(define-public python-asn1crypto
+  (package
+    (name "python-asn1crypto")
+    (version "0.22.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "asn1crypto" version))
+        (sha256
+         (base32
+          "06pd1bglyisjnjkgc5dc24b498q9r8fmvwkfn0janr9i1mjdvfnb"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:tests? #f)) ; Tests are not distributed via PyPi.
+    (home-page "https://github.com/wbond/asn1crypto")
+    (synopsis "ASN.1 parser and serializer in Python")
+    (description "Fast ASN.1 parser and serializer with definitions for private
+keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7, PKCS#8,
+PKCS#12, PKCS#5, X.509 and TSP.")
+    (license license:expat)))
+
+(define-public python2-asn1crypto
+  (package-with-python2 python-asn1crypto))
-- 
2.13.0