GNU bug report logs - #27024
25.2: gud.el: wrong menu :visible for pdb

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#27024: closed (25.2: gud.el: wrong menu :visible for pdb)
Date: Sat, 27 May 2017 12:18:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 27 May 2017 15:17:00 +0300
with message-id <8360gmijer.fsf <at> gnu.org>
and subject line Re: bug#27024: 25.2: gud.el: wrong menu :visible for pdb
has caused the debbugs.gnu.org bug report #27024,
regarding 25.2: gud.el: wrong menu :visible for pdb
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
27024: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27024
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Charles A. Roelli" <charles <at> aurox.ch>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2: gud.el: wrong menu :visible for pdb
Date: Mon, 22 May 2017 20:33:26 +0200

The "stop" entry in `gud-menu-map' (line 158):

    ([stop]	menu-item "Stop" gud-stop-subjob
		  :visible (or (not (memq gud-minor-mode '(gdbmi pdb)))
			       (gdb-show-stop-p)))

has a :visible entry that calls `gdb-show-stop-p' if `gud-minor-mode' is 
either
`gdbmi' or `pdb'.  This function is only related to gdb and isn't loaded 
by running
just pdb, so it can cause an error during redisplay (but interestingly,
it doesn't seem to happen all the time while running pdb -- or maybe the 
error is
caught somehow).

Does anyone understand why this check for pdb is here?  It seems to be a 
mistake,
but it has been there for more than 7 years...

Otherwise, could someone please remove the check for pdb?  Thanks.

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Charles A. Roelli" <charles <at> aurox.ch>
Cc: 27024-done <at> debbugs.gnu.org
Subject: Re: bug#27024: 25.2: gud.el: wrong menu :visible for pdb
Date: Sat, 27 May 2017 15:17:00 +0300

> From: "Charles A. Roelli" <charles <at> aurox.ch>
> Date: Mon, 22 May 2017 20:33:26 +0200
> 
> The "stop" entry in `gud-menu-map' (line 158):
> 
>      ([stop]	menu-item "Stop" gud-stop-subjob
> 		  :visible (or (not (memq gud-minor-mode '(gdbmi pdb)))
> 			       (gdb-show-stop-p)))
> 
> has a :visible entry that calls `gdb-show-stop-p' if `gud-minor-mode' is 
> either
> `gdbmi' or `pdb'.  This function is only related to gdb and isn't loaded 
> by running
> just pdb, so it can cause an error during redisplay (but interestingly,
> it doesn't seem to happen all the time while running pdb -- or maybe the 
> error is
> caught somehow).
> 
> Does anyone understand why this check for pdb is here?  It seems to be a 
> mistake,
> but it has been there for more than 7 years...
> 
> Otherwise, could someone please remove the check for pdb?  Thanks.

Thanks, I've modified the test to not call gdb-show-stop-p in pdb
mode.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.