From unknown Sat Aug 09 22:09:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27021: [PATCH 2/2] gnu: node: Use unbundled dependencies. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 May 2017 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27021 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 27021@debbugs.gnu.org Cc: Jelle Licht X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.149547622710029 (code B ref -1); Mon, 22 May 2017 18:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 May 2017 18:03:47 +0000 Received: from localhost ([127.0.0.1]:33182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCrgI-0002bh-Oq for submit@debbugs.gnu.org; Mon, 22 May 2017 14:03:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCrgE-0002bG-7i for submit@debbugs.gnu.org; Mon, 22 May 2017 14:03:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCrg8-0007HW-GG for submit@debbugs.gnu.org; Mon, 22 May 2017 14:03:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53047) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dCrg8-0007HP-DP for submit@debbugs.gnu.org; Mon, 22 May 2017 14:03:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCrg7-0005Zx-EI for guix-patches@gnu.org; Mon, 22 May 2017 14:03:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCrg3-0007Ej-0w for guix-patches@gnu.org; Mon, 22 May 2017 14:03:35 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:34161) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dCrg2-0007EQ-RP for guix-patches@gnu.org; Mon, 22 May 2017 14:03:30 -0400 Received: by mail-wm0-f50.google.com with SMTP id 123so13603896wmg.1 for ; Mon, 22 May 2017 11:03:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hTZWokIQvdWJN9Ga1JxLY9M7LbaeDYYuycyccz781xw=; b=B0l1t0Sb3mVXfNQ7N4UaXqq7UZYncYZWX1DKfzr3H5m2+xo9DBeh/MWn706tmnBe7+ 8ETD42RtNgdpeZUa4DwAMWxmMOBVH4nNEXEGkHrmMHRBllanxMF2m3pPVFKflM/gkBnR HYl9nzZL7WfIA7D40/xDHPZ/Nrg5iQdS9Pg++Dkw7vUsMaA691lES7p96ZhmF6KYsvMy sLPNu44c2jZqpscBpSPJ/I0jO9OzqIxp0D284uQdmV5QyPEQfyH5Y3IZfNAopkYERZfE GHY8dmZpxhNJAxD6GlkqY9glt/UaIy7hi0B/0druNpwludWrhVmdQBlRMEnf0AOLJRnO xdgQ== X-Gm-Message-State: AODbwcABIB1HBdi7rfy1s8a/qZ4h0YuOh4+XCq6CdtD/1BjpQOSc49ND uHGehy0BlwE8bA== X-Received: by 10.80.171.166 with SMTP id u35mr18471567edc.92.1495476209818; Mon, 22 May 2017 11:03:29 -0700 (PDT) Received: from localhost.localdomain (50709B36.static.ziggozakelijk.nl. [80.112.155.54]) by smtp.gmail.com with ESMTPSA id b25sm14538391edc.58.2017.05.22.11.03.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 11:03:29 -0700 (PDT) From: Jelle Licht Date: Mon, 22 May 2017 20:03:21 +0200 Message-Id: <20170522180321.20388-2-jlicht@fsfe.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170522180321.20388-1-jlicht@fsfe.org> References: <20170522180321.20388-1-jlicht@fsfe.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser. [arguments]: Add configure flags for using system libraries. --- gnu/packages/node.scm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index 91f1839b6..b3ecfc843 100644 --- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -26,6 +26,7 @@ #:use-module (guix download) #:use-module (guix build-system gnu) #:use-module (gnu packages) + #:use-module (gnu packages adns) #:use-module (gnu packages base) #:use-module (gnu packages compression) #:use-module (gnu packages gcc) @@ -33,7 +34,8 @@ #:use-module (gnu packages linux) #:use-module (gnu packages perl) #:use-module (gnu packages python) - #:use-module (gnu packages tls)) + #:use-module (gnu packages tls) + #:use-module (gnu packages web)) (define-public node (package @@ -54,6 +56,8 @@ '(#:configure-flags '("--shared-openssl" "--shared-zlib" "--shared-libuv" + "--shared-cares" + "--shared-http-parser" "--without-snapshot") #:phases (modify-phases %standard-phases @@ -123,7 +127,9 @@ ("util-linux" ,util-linux) ("which" ,which))) (inputs - `(("libuv" ,libuv) + `(("c-ares" ,c-ares) + ("http-parser" ,http-parser) + ("libuv" ,libuv) ("openssl" ,openssl) ("zlib" ,zlib))) (synopsis "Evented I/O for V8 JavaScript") -- 2.13.0 From unknown Sat Aug 09 22:09:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jelle Licht Subject: bug#27021: closed (Re: bug#27021: [PATCH 2/2] gnu: node: Use unbundled dependencies.) Message-ID: References: <87a863y1px.fsf@fastmail.com> <20170522180321.20388-2-jlicht@fsfe.org> X-Gnu-PR-Message: they-closed 27021 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 27021@debbugs.gnu.org Date: Tue, 23 May 2017 16:32:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1495557122-23669-1" This is a multi-part message in MIME format... ------------=_1495557122-23669-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #27021: [PATCH 2/2] gnu: node: Use unbundled dependencies. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 27021@debbugs.gnu.org. --=20 27021: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27021 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1495557122-23669-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 27021-done) by debbugs.gnu.org; 23 May 2017 16:31:11 +0000 Received: from localhost ([127.0.0.1]:34950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDCiF-00068h-8v for submit@debbugs.gnu.org; Tue, 23 May 2017 12:31:11 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDCiD-00068X-35 for 27021-done@debbugs.gnu.org; Tue, 23 May 2017 12:31:09 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CE3CD209C2; Tue, 23 May 2017 12:31:08 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Tue, 23 May 2017 12:31:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=nR3gYT/gOsM5PJQQbo/4zDCilQKl/fN0/HKZ7KzKL lI=; b=fLq0FP+WjN6TUF7KjgQNuqnocv34rUlAbW3JEqkaBzMydTIgBd+kj/Bs8 o0mTX8PrCD3AJipJHYKv9/7aKFkPgO+OVVTAHHc7wYM56CTy4DD2TG1ppT9L5qE4 7DV9PKs5b7/2mNlnn3/fMrMb3UJRfMOiG2+vYKwCRjGpfeggEKA01zaBV43VgUkJ txN4LUd/cBBKekzKHjKQPCNQrNNuO1SFmQc51wUS6aNAk/yyUU4D2499nGIQlLsR CCStrLihmXmLZgChqzFHje5efLzzQC9y+FDi0X2nRmaMN4oSK0C5GT1c1ZKpObjV /M8feT9ugz7+ZYMsGUsp0wQK+fLKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=nR3gYT/gOsM5PJQQbo /4zDCilQKl/fN0/HKZ7KzKLlI=; b=q87w+YkgC12+UDAwgq4Du+PinTcDPzLQjT 9VugsVD5TmeoxFZkeZ6+Hzx1kvD2O+PezG9ncQI4EteXpTmQOsMtDsh26b+jC8Nt MPIqKzINN7FWPWxR65TaIPVTKCh8YDUGWJBOsX4vzoIowOzKk82lnVcRkxp4SCuU 9ExUb9xNE1SFg4vQIZ4vJZpS0BgWRwE4H6AMrs+P+MyHQCcWfdZ4t3sCRwTlWp5M 1rW4vWaZTu/FR3sa2kT0CvkcGiZt8WzpDMzgoQWD7iPR8coHM7WzMVt6C6xqKNVP sdtuVNG/lUFlHevrzQo5I2PpMWcmNGPExhyXaA5VtnqZ7iHdkWRg== X-ME-Sender: X-Sasl-enc: 9RW3ogyn2P55iEQZIYAGGgj+3gx2/MKsBiYO9KVlRxdk 1495557068 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 5490A7E7C6; Tue, 23 May 2017 12:31:08 -0400 (EDT) From: Marius Bakke To: Jelle Licht , 27021-done@debbugs.gnu.org Subject: Re: bug#27021: [PATCH 2/2] gnu: node: Use unbundled dependencies. In-Reply-To: <20170522180321.20388-2-jlicht@fsfe.org> References: <20170522180321.20388-1-jlicht@fsfe.org> <20170522180321.20388-2-jlicht@fsfe.org> User-Agent: Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Tue, 23 May 2017 18:31:06 +0200 Message-ID: <87a863y1px.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27021-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Jelle Licht writes: > * gnu/packages/node.scm (node): Update to 7.10.0. > (node)[arguments]: Disabled more tests. > * gnu/packages/patches/node-9077.patch: Delete incompatible patch file. > Recreate patch file from node pull request 9077. [...] > * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser. > [arguments]: Add configure flags for using system libraries. Thanks for these patches! I updated the TODO comment about http-parser to say "TODO: Purge the bundled copies from the source". I tried to do that with a source 'snippet', but the Makefile expects to build these targets, so it will take some work. Would you mind looking into it? :-) Regardless, I've applied these patches for now. Thanks for maintaining this package! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkkY8oACgkQoqBt8qM6 VPoMOggAzP0Jbiycu9KpcieieJ8YiBDFD3ZjyP0rWav+qPADucN9C8MLhHQCq3VD Q2bkwWnHOJHgB8VtwbSMrZnQg88mUj1AplmlJXvwxuRnu2V/nZ2vW7DQeCZ0CRqs Dp1m6x3h8+2xDPcBkzQHUHVDI4lGLBVOS2K7ExIDEGLBU3WBwQfNYK6WT0z9psnT 7rzL6Gm0gKUlvAjBBItCQ675A93kiw0t6GACwDdQXkUBAygm+XUflcK++oeiX9fC AdMmOEqkAEFAZqg4vu9koUxZa5Jgp6oATXLMEgeEd6H3ib9EgWt+PIsxqq3MXyiN 6mTHdNnFqVPGSp8ac5c9y221cNcIrQ== =Kj1i -----END PGP SIGNATURE----- --=-=-=-- ------------=_1495557122-23669-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 May 2017 18:03:47 +0000 Received: from localhost ([127.0.0.1]:33182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCrgI-0002bh-Oq for submit@debbugs.gnu.org; Mon, 22 May 2017 14:03:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCrgE-0002bG-7i for submit@debbugs.gnu.org; Mon, 22 May 2017 14:03:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCrg8-0007HW-GG for submit@debbugs.gnu.org; Mon, 22 May 2017 14:03:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53047) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dCrg8-0007HP-DP for submit@debbugs.gnu.org; Mon, 22 May 2017 14:03:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCrg7-0005Zx-EI for guix-patches@gnu.org; Mon, 22 May 2017 14:03:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCrg3-0007Ej-0w for guix-patches@gnu.org; Mon, 22 May 2017 14:03:35 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:34161) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dCrg2-0007EQ-RP for guix-patches@gnu.org; Mon, 22 May 2017 14:03:30 -0400 Received: by mail-wm0-f50.google.com with SMTP id 123so13603896wmg.1 for ; Mon, 22 May 2017 11:03:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hTZWokIQvdWJN9Ga1JxLY9M7LbaeDYYuycyccz781xw=; b=B0l1t0Sb3mVXfNQ7N4UaXqq7UZYncYZWX1DKfzr3H5m2+xo9DBeh/MWn706tmnBe7+ 8ETD42RtNgdpeZUa4DwAMWxmMOBVH4nNEXEGkHrmMHRBllanxMF2m3pPVFKflM/gkBnR HYl9nzZL7WfIA7D40/xDHPZ/Nrg5iQdS9Pg++Dkw7vUsMaA691lES7p96ZhmF6KYsvMy sLPNu44c2jZqpscBpSPJ/I0jO9OzqIxp0D284uQdmV5QyPEQfyH5Y3IZfNAopkYERZfE GHY8dmZpxhNJAxD6GlkqY9glt/UaIy7hi0B/0druNpwludWrhVmdQBlRMEnf0AOLJRnO xdgQ== X-Gm-Message-State: AODbwcABIB1HBdi7rfy1s8a/qZ4h0YuOh4+XCq6CdtD/1BjpQOSc49ND uHGehy0BlwE8bA== X-Received: by 10.80.171.166 with SMTP id u35mr18471567edc.92.1495476209818; Mon, 22 May 2017 11:03:29 -0700 (PDT) Received: from localhost.localdomain (50709B36.static.ziggozakelijk.nl. [80.112.155.54]) by smtp.gmail.com with ESMTPSA id b25sm14538391edc.58.2017.05.22.11.03.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 11:03:29 -0700 (PDT) From: Jelle Licht To: guix-patches@gnu.org Subject: [PATCH 2/2] gnu: node: Use unbundled dependencies. Date: Mon, 22 May 2017 20:03:21 +0200 Message-Id: <20170522180321.20388-2-jlicht@fsfe.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170522180321.20388-1-jlicht@fsfe.org> References: <20170522180321.20388-1-jlicht@fsfe.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit Cc: Jelle Licht X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser. [arguments]: Add configure flags for using system libraries. --- gnu/packages/node.scm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index 91f1839b6..b3ecfc843 100644 --- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -26,6 +26,7 @@ #:use-module (guix download) #:use-module (guix build-system gnu) #:use-module (gnu packages) + #:use-module (gnu packages adns) #:use-module (gnu packages base) #:use-module (gnu packages compression) #:use-module (gnu packages gcc) @@ -33,7 +34,8 @@ #:use-module (gnu packages linux) #:use-module (gnu packages perl) #:use-module (gnu packages python) - #:use-module (gnu packages tls)) + #:use-module (gnu packages tls) + #:use-module (gnu packages web)) (define-public node (package @@ -54,6 +56,8 @@ '(#:configure-flags '("--shared-openssl" "--shared-zlib" "--shared-libuv" + "--shared-cares" + "--shared-http-parser" "--without-snapshot") #:phases (modify-phases %standard-phases @@ -123,7 +127,9 @@ ("util-linux" ,util-linux) ("which" ,which))) (inputs - `(("libuv" ,libuv) + `(("c-ares" ,c-ares) + ("http-parser" ,http-parser) + ("libuv" ,libuv) ("openssl" ,openssl) ("zlib" ,zlib))) (synopsis "Evented I/O for V8 JavaScript") -- 2.13.0 ------------=_1495557122-23669-1-- From unknown Sat Aug 09 22:09:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27021: [PATCH 2/2] gnu: node: Use unbundled dependencies. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 23 May 2017 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27021 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 27021-done@debbugs.gnu.org Received: via spool by 27021-done@debbugs.gnu.org id=D27021.149556035828522 (code D ref 27021); Tue, 23 May 2017 17:26:02 +0000 Received: (at 27021-done) by debbugs.gnu.org; 23 May 2017 17:25:58 +0000 Received: from localhost ([127.0.0.1]:35007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDDZF-0007Py-V9 for submit@debbugs.gnu.org; Tue, 23 May 2017 13:25:58 -0400 Received: from mail.fsfe.org ([217.69.89.162]:44822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDDZE-0007Pk-3k for 27021-done@debbugs.gnu.org; Tue, 23 May 2017 13:25:56 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.fsfe.org (Postfix) with ESMTP id C09EA63BAF2 for <27021-done@debbugs.gnu.org>; Tue, 23 May 2017 19:25:49 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.fsfe.org Received: from mail.fsfe.org ([127.0.0.1]) by localhost (cavendish.fsfeurope.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wkkiMiw8r9lE for <27021-done@debbugs.gnu.org>; Tue, 23 May 2017 19:25:49 +0200 (CEST) Received: by mail-io0-f182.google.com with SMTP id f102so101553700ioi.2 for <27021-done@debbugs.gnu.org>; Tue, 23 May 2017 10:25:49 -0700 (PDT) X-Gm-Message-State: AODbwcBHBBCCeNqZN4mOIpAPqCRjBIp/qZWIVFh4jCDIPzm79ny99+uu 9AppwOY+F1Y+OAzENwBF9Vhj6LXKNg== X-Received: by 10.107.164.29 with SMTP id n29mr26475347ioe.227.1495560346908; Tue, 23 May 2017 10:25:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.9.150 with HTTP; Tue, 23 May 2017 10:25:46 -0700 (PDT) In-Reply-To: <87a863y1px.fsf@fastmail.com> References: <20170522180321.20388-1-jlicht@fsfe.org> <20170522180321.20388-2-jlicht@fsfe.org> <87a863y1px.fsf@fastmail.com> From: Jelle Licht Date: Tue, 23 May 2017 19:25:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Content-Type: multipart/alternative; boundary="001a11464426384aa305503447a1" X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --001a11464426384aa305503447a1 Content-Type: text/plain; charset="UTF-8" No problem, I use this stuff quite often. I noticed the problem with the bundled copies in the source as well, but ran into the same issues you mention here. Maybe I will look into it when the next node version is released. 2017-05-23 18:31 GMT+02:00 Marius Bakke : > Jelle Licht writes: > > > * gnu/packages/node.scm (node): Update to 7.10.0. > > (node)[arguments]: Disabled more tests. > > * gnu/packages/patches/node-9077.patch: Delete incompatible patch file. > > Recreate patch file from node pull request 9077. > > [...] > > > * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser. > > [arguments]: Add configure flags for using system libraries. > > Thanks for these patches! I updated the TODO comment about http-parser > to say "TODO: Purge the bundled copies from the source". I tried to do > that with a source 'snippet', but the Makefile expects to build these > targets, so it will take some work. Would you mind looking into it? :-) > > Regardless, I've applied these patches for now. Thanks for maintaining > this package! :-) > --001a11464426384aa305503447a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
No problem, I use this stuff quite often.
I noticed the problem with the bundled copies in the source as well, but= ran into the same issues you mention here.
Maybe I will look into= it when the next node version is released.

2017-05-23 18:31 GMT= +02:00 Marius Bakke <mbakke@fastmail.com>:
Jelle Licht <jlich= t@fsfe.org> writes:

> * gnu/packages/node.scm (node): Update to 7.10.0.
> (node)[arguments]: Disabled more tests.
> * gnu/packages/patches/node-9077.patch: Delete incompatible patch= file.
> Recreate patch file from node pull request 9077.

[...]

> * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser. > [arguments]: Add configure flags for using system libraries.

Thanks for these patches! I updated the TODO comment about http-parser
to say "TODO: Purge the bundled copies from the source". I tried = to do
that with a source 'snippet', but the Makefile expects to build the= se
targets, so it will take some work. Would you mind looking into it? :-)

Regardless, I've applied these patches for now. Thanks for maintaining<= br> this package! :-)

--001a11464426384aa305503447a1--