GNU bug report logs - #27021
[PATCH 2/2] gnu: node: Use unbundled dependencies.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27021 in the body.
You can then email your comments to 27021 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: guix-patches <at> gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>
Subject: [PATCH 2/2] gnu: node: Use unbundled dependencies.
Date: Mon, 22 May 2017 20:03:21 +0200

* gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser.
[arguments]: Add configure flags for using system libraries.
---
 gnu/packages/node.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 91f1839b6..b3ecfc843 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -26,6 +26,7 @@
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
+  #:use-module (gnu packages adns)
   #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages gcc)
@@ -33,7 +34,8 @@
   #:use-module (gnu packages linux)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages python)
-  #:use-module (gnu packages tls))
+  #:use-module (gnu packages tls)
+  #:use-module (gnu packages web))
 
 (define-public node
   (package
@@ -54,6 +56,8 @@
      '(#:configure-flags '("--shared-openssl"
                            "--shared-zlib"
                            "--shared-libuv"
+                           "--shared-cares"
+                           "--shared-http-parser"
                            "--without-snapshot")
        #:phases
        (modify-phases %standard-phases
@@ -123,7 +127,9 @@
        ("util-linux" ,util-linux)
        ("which" ,which)))
     (inputs
-     `(("libuv" ,libuv)
+     `(("c-ares" ,c-ares)
+       ("http-parser" ,http-parser)
+       ("libuv" ,libuv)
        ("openssl" ,openssl)
        ("zlib" ,zlib)))
     (synopsis "Evented I/O for V8 JavaScript")
-- 
2.13.0

Message #10 received at 27021-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Jelle Licht <jlicht <at> fsfe.org>, 27021-done <at> debbugs.gnu.org
Subject: Re: bug#27021: [PATCH 2/2] gnu: node: Use unbundled dependencies.
Date: Tue, 23 May 2017 18:31:06 +0200

[Message part 1 (text/plain, inline)]

Jelle Licht <jlicht <at> fsfe.org> writes:

> * gnu/packages/node.scm (node): Update to 7.10.0.
> (node)[arguments]: Disabled more tests.
> * gnu/packages/patches/node-9077.patch: Delete incompatible patch file.
> Recreate patch file from node pull request 9077.

[...]

> * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser.
> [arguments]: Add configure flags for using system libraries.

Thanks for these patches! I updated the TODO comment about http-parser
to say "TODO: Purge the bundled copies from the source". I tried to do
that with a source 'snippet', but the Makefile expects to build these
targets, so it will take some work. Would you mind looking into it? :-)

Regardless, I've applied these patches for now. Thanks for maintaining
this package! :-)

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 27021-done <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 27021-done <at> debbugs.gnu.org
Subject: Re: bug#27021: [PATCH 2/2] gnu: node: Use unbundled dependencies.
Date: Tue, 23 May 2017 19:25:46 +0200

[Message part 1 (text/plain, inline)]

No problem, I use this stuff quite often.
I noticed the problem with the bundled copies in the source as well, but
ran into the same issues you mention here.
Maybe I will look into it when the next node version is released.

2017-05-23 18:31 GMT+02:00 Marius Bakke <mbakke <at> fastmail.com>:

> Jelle Licht <jlicht <at> fsfe.org> writes:
>
> > * gnu/packages/node.scm (node): Update to 7.10.0.
> > (node)[arguments]: Disabled more tests.
> > * gnu/packages/patches/node-9077.patch: Delete incompatible patch file.
> > Recreate patch file from node pull request 9077.
>
> [...]
>
> > * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser.
> > [arguments]: Add configure flags for using system libraries.
>
> Thanks for these patches! I updated the TODO comment about http-parser
> to say "TODO: Purge the bundled copies from the source". I tried to do
> that with a source 'snippet', but the Makefile expects to build these
> targets, so it will take some work. Would you mind looking into it? :-)
>
> Regardless, I've applied these patches for now. Thanks for maintaining
> this package! :-)
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.