GNU bug report logs - #27004
[PATCH] * gnu: surfraw: Fix broken symlinks in manpages.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27004 in the body.
You can then email your comments to 27004 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <at> pragmatique.xyz
To: guix-patches <at> gnu.org
Cc: ng0 <ng0 <at> no-reply.pragmatique.xyz>
Subject: [PATCH] * gnu: surfraw: Fix broken symlinks in manpages.
Date: Sat, 20 May 2017 09:07:27 +0000

From: ng0 <ng0 <at> no-reply.pragmatique.xyz>

* gnu/packages/web.scm (surfraw)[arguments]: Add new 'compress-elvi.1sr' phase.
---
 gnu/packages/web.scm | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index bcc20bfdd..2fb3144cd 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2016 Rene Saavedra <rennes <at> openmailbox.org>
 ;;; Copyright © 2016 Ben Woodcroft <donttrustben <at> gmail.com>
 ;;; Copyright © 2016 Clément Lassieur <clement <at> lassieur.org>
-;;; Copyright © 2016, 2017 ng0 <contact.ng0 <at> cryptolab.net>
+;;; Copyright © 2016, 2017 ng0 <ng0 <at> no-reply.pragmatique.xyz>
 ;;; Copyright © 2016, 2017 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2016 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2016 Bake Timmons <b3timmons <at> speedymail.org>
@@ -4229,6 +4229,17 @@ handling many of the web standards in use today.")
                (base32
                 "1fy4ph5h9kp0jzj1m6pfylxnnmgdk0mmdppw76z9jhna4jndk5xa"))))
     (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'compress-elvi.1sr
+           (lambda* (#:key outputs #:allow-other-keys)
+             ;; The manpages of the elvis are symlinks to elvi.1sr.gz
+             ;; but elvi.1sr does not get compress by our manpage phase.
+             (let* ((out (assoc-ref %outputs "out"))
+                    (man (string-append out "/share/man/man1")))
+               (with-directory-excursion man
+                 (zero? (system* "gzip" "elvi.1sr")))))))))
     (inputs
      `(("perl" ,perl)
        ("perl-www-opensearch" ,perl-www-opensearch)
-- 
2.13.0

Message #10 received at 27004-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: ng0 <at> pragmatique.xyz
Cc: 27004-done <at> debbugs.gnu.org
Subject: Re: bug#27004: [PATCH] * gnu: surfraw: Fix broken symlinks in
 manpages.
Date: Thu, 22 Jun 2017 10:47:05 -0400

[Message part 1 (text/plain, inline)]

ng0 <at> pragmatique.xyz writes:

> * gnu/packages/web.scm (surfraw)[arguments]: Add new 'compress-elvi.1sr' phase.

Nice catch.

>      (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'compress-elvi.1sr
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             ;; The manpages of the elvis are symlinks to elvi.1sr.gz
> +             ;; but elvi.1sr does not get compress by our manpage phase.

Changed "compress" to "compressed".

> +             (let* ((out (assoc-ref %outputs "out"))
> +                    (man (string-append out "/share/man/man1")))
> +               (with-directory-excursion man
> +                 (zero? (system* "gzip" "elvi.1sr")))))))))
>      (inputs
>       `(("perl" ,perl)
>         ("perl-www-opensearch" ,perl-www-opensearch)

LGTM otherwise.
Pushed to master as e81fd90e2f8a38248b4b0c6b883305528acc9a9e.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.