GNU bug report logs - #26988
Add desktop-file-utils to all gtk applications

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: iyzsong <at> member.fsf.org (宋文武)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26988: closed (Add desktop-file-utils to all gtk applications)
Date: Mon, 03 Jul 2017 15:38:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 03 Jul 2017 23:32:11 +0800
with message-id <87eftx1qpw.fsf <at> member.fsf.org>
and subject line Re: bug#26988: Add desktop-file-utils to all gtk applications
has caused the debbugs.gnu.org bug report #26988,
regarding Add desktop-file-utils to all gtk applications
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26988: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26988
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Subject: Add desktop-file-utils to all gtk applications
Date: Thu, 18 May 2017 23:01:11 +0200

Hi,

these are two patches I propose we add in order to add desktop-file-utils to all gtk applications.  This means that the profile hook would pick up the desktop files (as soon as possible).

One patch moves desktop-file-utils from (gnu packages gnome) to (gnu packages freedesktop).  I suggest we apply this patch to all branches - since they don't change anything in the build.

The other patch adds desktop-file-utils as propagated-input to gtk+-2 (and by inheritance to gtk+ 3, too).  That would imply entail all gtk applications.  Therefore, it should only go to core-updates.

[Message part 3 (message/rfc822, inline)]

From: iyzsong <at> member.fsf.org (宋文武)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 26988-done <at> debbugs.gnu.org
Subject: Re: bug#26988: Add desktop-file-utils to all gtk applications
Date: Mon, 03 Jul 2017 23:32:11 +0800

Marius Bakke <mbakke <at> fastmail.com> writes:

> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>>
>>> Hi Marius,
>>> Hi 宋文武,

Hello Marius and Danny,


>>> Marius Bakke <mbakke <at> fastmail.com> wrote:
>>>
>>>> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>>>> 
>>>> > these are two patches I propose we add in order to add
>>>> > desktop-file-utils to all gtk applications.  This means that the
>>>> > profile hook would pick up the desktop files (as soon as possible).  
>>>> 
>>>> So if I read (guix profiles) correctly, the hook only runs when
>>>> 'desktop-file-utils' is referenced. Would checking for a gtk reference
>>>> as well not achieve the same effect? Or is that too expensive?

Yes, it will work better.  It's expensive slightly by adding the
latest version of desktop-file-utils into the profile closure, but
the 'xdg-mime-database' does that already.

>>> [...]
>>
>> IIUC, the idea is to run the hook every time a package with a ".desktop"
>> file has changed. Even if we propagate "desktop-file-utils" from say,
>> GTK+ and Qt, it won't catch some cases where we add the ".desktop" file
>> manually such as "rxvt-unicode".

Yes, but normally one would have other applications that using GTK+ or
GLib, which will make the hook run.

So I end up with modify the profile hook to test for GLib, it should
work in most cases.

Thanks for the patches!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.