From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 17:01:29 2017 Received: (at submit) by debbugs.gnu.org; 18 May 2017 21:01:29 +0000 Received: from localhost ([127.0.0.1]:53932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBSY5-0006vY-Du for submit@debbugs.gnu.org; Thu, 18 May 2017 17:01:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBSY4-0006vL-EO for submit@debbugs.gnu.org; Thu, 18 May 2017 17:01:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBSXy-0006fG-OF for submit@debbugs.gnu.org; Thu, 18 May 2017 17:01:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39024) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dBSXy-0006fC-LA for submit@debbugs.gnu.org; Thu, 18 May 2017 17:01:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBSXx-0004tz-Kc for guix-patches@gnu.org; Thu, 18 May 2017 17:01:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBSXu-0006Zh-JQ for guix-patches@gnu.org; Thu, 18 May 2017 17:01:21 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:46146) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dBSXu-0006YP-DD for guix-patches@gnu.org; Thu, 18 May 2017 17:01:18 -0400 Received: from localhost (178.113.140.102.wireless.dyn.drei.com [178.113.140.102]) by dd1012.kasserver.com (Postfix) with ESMTPSA id C5F0C1CA1FEF for ; Thu, 18 May 2017 23:01:15 +0200 (CEST) Date: Thu, 18 May 2017 23:01:11 +0200 From: Danny Milosavljevic To: guix-patches@gnu.org Subject: Add desktop-file-utils to all gtk applications Message-ID: <20170518230111.53a91ffe@scratchpost.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, these are two patches I propose we add in order to add desktop-file-utils to all gtk applications. This means that the profile hook would pick up the desktop files (as soon as possible). One patch moves desktop-file-utils from (gnu packages gnome) to (gnu packages freedesktop). I suggest we apply this patch to all branches - since they don't change anything in the build. The other patch adds desktop-file-utils as propagated-input to gtk+-2 (and by inheritance to gtk+ 3, too). That would imply entail all gtk applications. Therefore, it should only go to core-updates. From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 17:18:01 2017 Received: (at 26988) by debbugs.gnu.org; 18 May 2017 21:18:02 +0000 Received: from localhost ([127.0.0.1]:53956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBSo5-0007K6-K3 for submit@debbugs.gnu.org; Thu, 18 May 2017 17:18:01 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:52146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBSo3-0007Jy-Al for 26988@debbugs.gnu.org; Thu, 18 May 2017 17:17:59 -0400 Received: from dayas.3.home (178.113.140.102.wireless.dyn.drei.com [178.113.140.102]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 80EE11CA1FF3; Thu, 18 May 2017 23:17:55 +0200 (CEST) From: Danny Milosavljevic To: 26988@debbugs.gnu.org Subject: [PATCH] gnu: Move desktop-file-utils to (gnu packages freedesktop). Date: Thu, 18 May 2017 23:07:26 +0200 Message-Id: <20170518210726.6425-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.1 In-Reply-To: <20170518230111.53a91ffe@scratchpost.org> References: <20170518230111.53a91ffe@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/gnome.scm (desktop-file-utils): Move from here ... * gnu/packages/freedesktop.scm (desktop-file-utils): to here. --- gnu/packages/freedesktop.scm | 32 ++++++++++++++++++++++++++++++++ gnu/packages/gnome.scm | 32 -------------------------------- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm index 85a6c8b26..dfc88986f 100644 --- a/gnu/packages/freedesktop.scm +++ b/gnu/packages/freedesktop.scm @@ -927,3 +927,35 @@ library to access fingerprint readers, over the D-Bus interprocess communication bus. This daemon layer above libfprint solves problems related to applications simultaneously competing for fingerprint readers.") (license license:gpl2+))) + +(define-public desktop-file-utils + (package + (name "desktop-file-utils") + (version "0.23") + (source (origin + (method url-fetch) + (uri (string-append "https://www.freedesktop.org/software/" name + "/releases/" name "-" version ".tar.xz")) + (sha256 + (base32 + "119kj2w0rrxkhg4f9cf5waa55jz1hj8933vh47vcjipcplql02bc")))) + (build-system gnu-build-system) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("glib" ,glib))) + (home-page "http://www.freedesktop.org/wiki/Software/desktop-file-utils/") + (synopsis "Utilities for working with desktop entries") + (description + "This package contains a few command line utilities for working with +desktop entries: + +desktop-file-validate: validates a desktop file and prints warnings/errors + about desktop entry specification violations. + +desktop-file-install: installs a desktop file to the applications directory, + optionally munging it a bit in transit. + +update-desktop-database: updates the database containing a cache of MIME types + handled by desktop files.") + (license license:gpl2+))) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 47dcc91dc..e7b1577f3 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -656,38 +656,6 @@ Specification, the icon naming utility maps the icon names used by the GNOME and KDE desktops to the icon names proposed in the specification.") (license license:lgpl2.1+))) -(define-public desktop-file-utils - (package - (name "desktop-file-utils") - (version "0.23") - (source (origin - (method url-fetch) - (uri (string-append "https://www.freedesktop.org/software/" name - "/releases/" name "-" version ".tar.xz")) - (sha256 - (base32 - "119kj2w0rrxkhg4f9cf5waa55jz1hj8933vh47vcjipcplql02bc")))) - (build-system gnu-build-system) - (native-inputs - `(("pkg-config" ,pkg-config))) - (inputs - `(("glib" ,glib))) - (home-page "http://www.freedesktop.org/wiki/Software/desktop-file-utils/") - (synopsis "Utilities for working with desktop entries") - (description - "This package contains a few command line utilities for working with -desktop entries: - -desktop-file-validate: validates a desktop file and prints warnings/errors - about desktop entry specification violations. - -desktop-file-install: installs a desktop file to the applications directory, - optionally munging it a bit in transit. - -update-desktop-database: updates the database containing a cache of MIME types - handled by desktop files.") - (license license:gpl2+))) - (define-public gnome-icon-theme (package (name "gnome-icon-theme") From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 17:19:46 2017 Received: (at 26988) by debbugs.gnu.org; 18 May 2017 21:19:46 +0000 Received: from localhost ([127.0.0.1]:53961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBSpm-0007Mh-2L for submit@debbugs.gnu.org; Thu, 18 May 2017 17:19:46 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:52312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBSpj-0007MY-Vy for 26988@debbugs.gnu.org; Thu, 18 May 2017 17:19:44 -0400 Received: from dayas.3.home (178.113.140.102.wireless.dyn.drei.com [178.113.140.102]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 09D971CA1FF3; Thu, 18 May 2017 23:19:42 +0200 (CEST) From: Danny Milosavljevic To: 26988@debbugs.gnu.org Subject: [PATCH] gnu: gtk+-2: Add desktop-file-utils to propagated-inputs. Date: Thu, 18 May 2017 23:19:37 +0200 Message-Id: <20170518211937.27335-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.1 In-Reply-To: <20170518230111.53a91ffe@scratchpost.org> References: <20170518230111.53a91ffe@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/gtk.scm (gtk+-2)[propagated-inputs]: Add desktop-file-utils. --- gnu/packages/gtk.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm index dffa2baf3..cf40c59dc 100644 --- a/gnu/packages/gtk.scm +++ b/gnu/packages/gtk.scm @@ -604,6 +604,7 @@ is part of the GNOME accessibility project.") (outputs '("out" "doc")) (propagated-inputs `(("atk" ,atk) + ("desktop-file-utils" ,desktop-file-utils) ; Used by profile hook. ("gdk-pixbuf" ,gdk-pixbuf+svg) ("pango" ,pango))) (inputs From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 19:05:27 2017 Received: (at 26988) by debbugs.gnu.org; 19 May 2017 23:05:27 +0000 Received: from localhost ([127.0.0.1]:55756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBqxb-0001zU-H4 for submit@debbugs.gnu.org; Fri, 19 May 2017 19:05:27 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBqxZ-0001zM-47 for 26988@debbugs.gnu.org; Fri, 19 May 2017 19:05:26 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A581A20B56; Fri, 19 May 2017 19:05:24 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Fri, 19 May 2017 19:05:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=Z0S5vgLl4x5JNeJFzNSgpViohp1QDzulqUTy5bl78 iM=; b=HnP8pGz2qgwlK5qM20v6QkJPR86YUqg5WxIV9zLp0iaiF7uA+3adrYbdF na96V94RdDUv7i5+PUtiUp1TpZWnyNAyBY4GrwDCyLI6snX3L1MBP0N9xxLie1yl d/MbngEiKfYxeGLYdGqtxr9+4jIixMNmFaVChCyx+ifilso2ZsfjjYL+aPbYnMoK fc4Fk/A1s+aPtGT2OsVMamc+Vka3avTpjDh3bMUJR0ztRZG/2IErGfB+MR7fqNue 8F0iaNttUCRWfG01qQEon8h8oFdCftVrCaeyV8NeDlVo0yp5smgWb519YvHSw1RH +05J1DKzeVtRaiJFvBd/MbpfnqFlw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=Z0S5vgLl4x5JNeJFzN SgpViohp1QDzulqUTy5bl78iM=; b=oMFRKGrhgjhMvEqqWyf8aH5DyIz85RXWXr rzwmueplrOr4QUbBuEDQ7uqVptx70LAcBDOeU0pmhWvReOzVstJnXoNomGi8zd3r chnEIgQWowdF9vuHKEPBs4SsXvVBpsqv6NEHAuySnPLq6ymT9ez5uOW2STVm/EH1 ufs10mnRgwjwvq5+LaSpkjjmV7ZWO1ByDO8YG1Ys+9SLDl7tmahav/5d0w7P0fLn 8SSermxnoClsmI6hPab0MUv0b2gD0EZtTF/0fr8b9TUfAdMdrgW4QywQlpNp5q9A 8VgxvPeYkP0YxuVOKkUszUFs/kROH6ufw5foZE0eJYLyRzKxLabQ== X-ME-Sender: X-Sasl-enc: 96n2t6S7HGZDgKmJpMUj4cVaPAf88+JBBwxosnEqCiLQ 1495235124 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 4013B7E81F; Fri, 19 May 2017 19:05:24 -0400 (EDT) From: Marius Bakke To: Danny Milosavljevic , 26988@debbugs.gnu.org Subject: Re: bug#26988: Add desktop-file-utils to all gtk applications In-Reply-To: <20170518230111.53a91ffe@scratchpost.org> References: <20170518230111.53a91ffe@scratchpost.org> User-Agent: Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Sat, 20 May 2017 01:05:22 +0200 Message-ID: <87inkwa1n1.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > these are two patches I propose we add in order to add > desktop-file-utils to all gtk applications. This means that the > profile hook would pick up the desktop files (as soon as possible). So if I read (guix profiles) correctly, the hook only runs when 'desktop-file-utils' is referenced. Would checking for a gtk reference as well not achieve the same effect? Or is that too expensive? > One patch moves desktop-file-utils from (gnu packages gnome) to (gnu > packages freedesktop). I suggest we apply this patch to all branches > - since they don't change anything in the build. Adding it to 'master' would be sufficient, no? It will be merged to 'staging' and 'core-updates' in due time. I don't see a good reason to move it though, but no strong opinion. Make sure all dependent packages still finds it! > The other patch adds desktop-file-utils as propagated-input to gtk+-2 > (and by inheritance to gtk+ 3, too). That would imply entail all gtk > applications. Therefore, it should only go to core-updates. Not just all gtk applications, but also anything depending on those. Can you add a comment about why we propagate 'desktop-file-utils' from gtk? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkfejIACgkQoqBt8qM6 VPomVggAw13bEkQs51OTVRUlOiA+KfxtkJUKS0fO1dm75PTFocAm2wDYjsHHyHIs ZUPDtzwN0P1ZXbal8OrhQ+7dQfwBy9oTmjRlX54O5h6RMly9D6euwj4XD5rWnMZQ dquSH2hj9HSn+4fACRAd9Om1zLKvbL+intlZPh4jgn8evlOIVFa2s4mxmhUF3pXj mCN3V9P7EvkaN7XLStPfleMi/MmDYiRn2NNnEGdLht4s9qb4PFvb1DkZLJoCm4ZK n+/qp16f7KnZG+iZ6tquJPJprx4TMCS0vlAxKDcH4A8oIQfBUCp1tiQABXbyxKyh plEG2pWeOwG/8h7F5yViauFf1amRaQ== =VnV9 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 09:04:19 2017 Received: (at 26988) by debbugs.gnu.org; 20 May 2017 13:04:19 +0000 Received: from localhost ([127.0.0.1]:56140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dC43O-00015W-PZ for submit@debbugs.gnu.org; Sat, 20 May 2017 09:04:19 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:34122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dC43M-00015M-OE for 26988@debbugs.gnu.org; Sat, 20 May 2017 09:04:17 -0400 Received: from localhost (178.113.140.102.wireless.dyn.drei.com [178.113.140.102]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 99F361CA006C; Sat, 20 May 2017 15:04:14 +0200 (CEST) Date: Sat, 20 May 2017 15:04:11 +0200 From: Danny Milosavljevic To: Marius Bakke , =?UTF-8?Q?=E5=AE=8B=E6=96=87?= =?UTF-8?Q?=E6=AD=A6?= Subject: Re: bug#26988: Add desktop-file-utils to all gtk applications Message-ID: <20170520150411.21c3e0aa@scratchpost.org> In-Reply-To: <87inkwa1n1.fsf@fastmail.com> References: <20170518230111.53a91ffe@scratchpost.org> <87inkwa1n1.fsf@fastmail.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988 Cc: 26988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Marius, Hi =E5=AE=8B=E6=96=87=E6=AD=A6, On Sat, 20 May 2017 01:05:22 +0200 Marius Bakke wrote: > Danny Milosavljevic writes: >=20 > > these are two patches I propose we add in order to add > > desktop-file-utils to all gtk applications. This means that the > > profile hook would pick up the desktop files (as soon as possible). =20 >=20 > So if I read (guix profiles) correctly, the hook only runs when > 'desktop-file-utils' is referenced. Would checking for a gtk reference > as well not achieve the same effect? Or is that too expensive? That would probably work as well. But the idea is KDE would eventually use the XDG desktop cache, too (maybe = it already does - no idea). Any other desktop environments that don't rein= vent the wheel in that regard would use desktop-file-utils as well - and th= at's the package that actually contains the "update-desktop-database" execu= table for updating the XDG desktop cache. Right now the "xdg-desktop-database" profile hook doesn't need its own magi= cal packages but it just uses the existing desktop-file-utils reference for= actually updating the desktop database. At least I think that's the idea there. =E5=AE=8B=E6=96=87=E6=AD=A6 wrote = the update-desktop-database part in the profile hook... =E5=AE=8B=E6=96=87= =E6=AD=A6, what do you think? > > One patch moves desktop-file-utils from (gnu packages gnome) to (gnu > > packages freedesktop). I suggest we apply this patch to all branches > > - since they don't change anything in the build. =20 >=20 > Adding it to 'master' would be sufficient, no? It will be merged to > 'staging' and 'core-updates' in due time. > I don't see a good reason to move it though, but no strong opinion.=20 desktop-file-utils is a freedesktop project. If we don't move it and if KDE used desktop-file-utils (as it should), we'd= have KDE depend on Gnome. Also, it causes module reference cycles if we don't move it. I don't like = those - even though they seem to work in this instance. I think moving it is preferrable to having it sit there, waiting to make th= e module cycles explode. >Make sure all dependent packages still finds it! Yes, I should add a reference to (gnu packages freedesktop) in (gnu package= s xfce), (gnu packages game-development) and (gnu packages engineering) in = the next version. If we did move it in all branches, I mean also in wip-installer etc, I thin= k it would prevent any merging problems - since git uses file hashes as com= mits - and people would not have to take care whether this branch has alrea= dy moved it or not. Moving wouldn't cause any rebuilds and fallout would be minimal - the risk = would be very low. > > The other patch adds desktop-file-utils as propagated-input to gtk+-2 > > (and by inheritance to gtk+ 3, too). That would [entail rebuilding] al= l gtk > > applications. Therefore, it should only go to core-updates. =20 >=20 > Not just all gtk applications, but also anything depending on those. Can > you add a comment about why we propagate 'desktop-file-utils' from gtk? There's one: + ("desktop-file-utils" ,desktop-file-utils) ; Used by profile hook. Do you mean we should add some more text? From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 19:00:30 2017 Received: (at 26988) by debbugs.gnu.org; 20 May 2017 23:00:30 +0000 Received: from localhost ([127.0.0.1]:57457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCDMM-0005da-1O for submit@debbugs.gnu.org; Sat, 20 May 2017 19:00:30 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCDMJ-0005dR-3A for 26988@debbugs.gnu.org; Sat, 20 May 2017 19:00:27 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2AA6620998; Sat, 20 May 2017 19:00:24 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Sat, 20 May 2017 19:00:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=/we5WTpsliJ7KewnrV6FOCCkNcRu2/oy5dSUATxmx CQ=; b=iZQrzURb49itBe6RCvQVitXQKUoV7RnulBkuz3TxZ4XpjLucv5W2OOmmx jzU8Mvd1mWVPvUqtnLz2SMMMtL9Ahfi4uJMEaPFloCbZo37B6tJG9Nd8yH8ItgYV UtVhviat+mYXm/CAVLNKitrzrzzv7jyNr36os5MRov50gXWUYjuoKyOzhYfD20y/ ZT7b2WhXKVBgjqbVFFGgOv/464a91rYNx+OG5IVbRAiek7ARLE1nZylrQNASt7BL Abn/B0avYXo4PvtMCp7JeDi/tLTUhONlIwd/fxY6ihcOimmd9Jrc0tmGfWw4G9Dr TeQCa1scHPhsMsc+lUQSzxIspibfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=/we5WTpsliJ7KewnrV 6FOCCkNcRu2/oy5dSUATxmxCQ=; b=KIfDKQzMVUqW9fbeEbPvQ/TUXoSz0ParhM B25Q20ztEpic5vBKC0eQyyjSEszpr3SlJuBwtgPYnHbOnuBX6Ifco2cXwS1LSFqA jW2bJakP0Z9blyJ/xACNvu0GLPOyhXTayE3OorAvL7YDcCD2wArRRiQ6JkawG+s0 N5615mgeA54rJb0HTXrnQ6Amw+GkZpgqh++zBLkNb0VxIYNCEEzGjynZhWe9wOOI Omt7xwQd/Fs/A+vjD8y2JXpXnHmNey0ozgj14fRURawJhCtEL2YMfRB8TXmqxbTk FuLFwpqIIm9oXi7LVhHdfCio8W0RxxX6hQioDmhVWrjfJMlPPZMQ== X-ME-Sender: X-Sasl-enc: AJWZRHUskwcbwCa4ZkpuSKv55axXeij84x4V8m0ZZtsZ 1495321223 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id A2EBA7E545; Sat, 20 May 2017 19:00:23 -0400 (EDT) From: Marius Bakke To: Danny Milosavljevic , =?utf-8?B?5a6L5paH5q2m?= Subject: Re: bug#26988: Add desktop-file-utils to all gtk applications In-Reply-To: <20170520150411.21c3e0aa@scratchpost.org> References: <20170518230111.53a91ffe@scratchpost.org> <87inkwa1n1.fsf@fastmail.com> <20170520150411.21c3e0aa@scratchpost.org> User-Agent: Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Sun, 21 May 2017 01:00:22 +0200 Message-ID: <87h90f5e2h.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988 Cc: 26988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Danny Milosavljevic writes: > Hi Marius, > Hi =E5=AE=8B=E6=96=87=E6=AD=A6, > > On Sat, 20 May 2017 01:05:22 +0200 > Marius Bakke wrote: > >> Danny Milosavljevic writes: >>=20 >> > these are two patches I propose we add in order to add >> > desktop-file-utils to all gtk applications. This means that the >> > profile hook would pick up the desktop files (as soon as possible).=20= =20 >>=20 >> So if I read (guix profiles) correctly, the hook only runs when >> 'desktop-file-utils' is referenced. Would checking for a gtk reference >> as well not achieve the same effect? Or is that too expensive? > > That would probably work as well. > > But the idea is KDE would eventually use the XDG desktop cache, too (mayb= e it already does - no idea). Any other desktop environments that don't re= invent the wheel in that regard would use desktop-file-utils as well - and = that's the package that actually contains the "update-desktop-database" exe= cutable for updating the XDG desktop cache. > > Right now the "xdg-desktop-database" profile hook doesn't need its own ma= gical packages but it just uses the existing desktop-file-utils reference f= or actually updating the desktop database. IIUC, the idea is to run the hook every time a package with a ".desktop" file has changed. Even if we propagate "desktop-file-utils" from say, GTK+ and Qt, it won't catch some cases where we add the ".desktop" file manually such as "rxvt-unicode". I wonder if there is a more generic thing we could test for.. Maybe libx11? Obviously lots of false positives, but the hook is not *that* expensive. Thoughts? >> > One patch moves desktop-file-utils from (gnu packages gnome) to (gnu >> > packages freedesktop). I suggest we apply this patch to all branches >> > - since they don't change anything in the build.=20=20 >>=20 >> Adding it to 'master' would be sufficient, no? It will be merged to >> 'staging' and 'core-updates' in due time. > >> I don't see a good reason to move it though, but no strong opinion.=20 > > desktop-file-utils is a freedesktop project. > > If we don't move it and if KDE used desktop-file-utils (as it should), we= 'd have KDE depend on Gnome. Ah, ok. Makes sense. > If we did move it in all branches, I mean also in wip-installer etc, I th= ink it would prevent any merging problems - since git uses file hashes as c= ommits - and people would not have to take care whether this branch has alr= eady moved it or not. IME, git usually recognizes cherry-picks as the same change, but not always. I think the problem is that "cherry-pick" is smart, it can adapt to some fairly complicated context changes unlike e.g. "patch". So, even if the cherry-pick succeeds, the file and context can be very different. For example, I recently tested merging a branch with 600+ cherry-picks back to 'master'. That went mostly-well, but there were some very difficult conflicts in all files that had changed in the other branch (and the duplicate branch history did not help). In short, I think we should prefer merging to cherry-picks whenever possible. Merging is equally smart, so if cherry-pick works "out of the box" merge will too. And they definitely do not prevent merging problems, quite the opposite! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkgyoYACgkQoqBt8qM6 VPoIGAf9FJF29v2UKiAvYX29k02Lq1PjToF1itdyzVXFW62HcbSIw6bdD5bG99tm vAdzenpiULQwhYxo4ISDme1qUnWl7HmUZSKiPvMBWeDqYamIMrhDZEmX2yNm+1dW JR6yHF9MFHIUL9etyvSJCGZowLSJdGwmulEV47Ihdpk14jF+GAeADW7JaP67Bye2 BtWeNu7zRPuNpB7EpGjbJXSWM0cH2KD55oc3dp1VuwjryJap8a/GtBxnNaUACj/M beZ8ByTXKA9xjdAi+feyNAp8dZRK2l5x//7S9UDQ+tkgw2fLtit6C/eEqAzUZn0z ob2v1oIhNVZlILa67f225XElLJyjMw== =GnQB -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 22:32:28 2017 Received: (at 26988) by debbugs.gnu.org; 21 May 2017 02:32:28 +0000 Received: from localhost ([127.0.0.1]:57556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCGfQ-0005ip-8t for submit@debbugs.gnu.org; Sat, 20 May 2017 22:32:28 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCGfL-0005ie-54 for 26988@debbugs.gnu.org; Sat, 20 May 2017 22:32:23 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8886F20996; Sat, 20 May 2017 22:32:18 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Sat, 20 May 2017 22:32:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=MB4kUYceswq/0x5XsngdI3/37C1yQCQ3TjaltfRAk Gw=; b=3CKJE3lMSmFCcUglHoOKM+HEeW3vl4D14ETjeXQLnUL0AiP9zze120Iix DoXD+/58Azl3hIX/jblznqH6NdWSsiWxiic8mPIArRcqtzyuWJiXvamd6w/7QdGe 7gEtwvUojYOPDw8oZzzX70wxiOJV8+sw7vUYUAsYHua2eFtGYASaat+IfWdb0EKA RKuymbCxdi4X4k3nMJqmDM7IcRZ9m+gYzDJE4RevtnImJXh6XIF/ZFuSjqtdLLz4 xz1e/rgCaRBg+eosByKdzqXNsosqh96wjB5UKqstQY2ohIwI0V9Y/aMTsdQbKsf6 2hNnuNxazOX1ih4NaA6VhOIPpHTwQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=MB4kUYceswq/0x5Xsn gdI3/37C1yQCQ3TjaltfRAkGw=; b=OoMrlFnlMr1pdiPB5pjnkNnnHqJg4bEwiC mqNcyWVHepBv26XVvc4dJBz9Ef2jbmNxmJ4aXdGTTPuhZqNoFWlRh1Ws1BJ1ON4y KHm96o/eSafXPbpiT0s0sx7Q82GbmgvdNEUjGb41ZtRrkLJZT2oWIGNo5DKkT4/R svi9KGGWsSfD/G2W7mvZcsZ96vdfe4dR8z5ZcFW1DimlDg2XdF+GippaM6M/e3TY R2EujAr57B68XYgv5Aty8+Z1pWqPotrH3tiN7zVtqckjNYYfY8tH3bvChziYwvGL PQjUsg40IfgXiv6352uMXEB+A3OpZqy6zKYK7VaNk/Lf5XKcGjKw== X-ME-Sender: X-Sasl-enc: TQQcCyCopD8VAI/e5Ov9HCVxGuxFIPIGLydSiWSWyy/G 1495333938 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B8B37E6E5; Sat, 20 May 2017 22:32:17 -0400 (EDT) From: Marius Bakke To: Danny Milosavljevic , =?utf-8?B?5a6L5paH5q2m?= Subject: Re: bug#26988: Add desktop-file-utils to all gtk applications In-Reply-To: <87h90f5e2h.fsf@fastmail.com> References: <20170518230111.53a91ffe@scratchpost.org> <87inkwa1n1.fsf@fastmail.com> <20170520150411.21c3e0aa@scratchpost.org> <87h90f5e2h.fsf@fastmail.com> User-Agent: Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Sun, 21 May 2017 04:32:16 +0200 Message-ID: <87efvj549b.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988 Cc: 26988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Marius Bakke writes: > Danny Milosavljevic writes: > >> Hi Marius, >> Hi =E5=AE=8B=E6=96=87=E6=AD=A6, >> >> On Sat, 20 May 2017 01:05:22 +0200 >> Marius Bakke wrote: >> >>> Danny Milosavljevic writes: >>>=20 >>> > these are two patches I propose we add in order to add >>> > desktop-file-utils to all gtk applications. This means that the >>> > profile hook would pick up the desktop files (as soon as possible).= =20=20 >>>=20 >>> So if I read (guix profiles) correctly, the hook only runs when >>> 'desktop-file-utils' is referenced. Would checking for a gtk reference >>> as well not achieve the same effect? Or is that too expensive? >> >> That would probably work as well. >> >> But the idea is KDE would eventually use the XDG desktop cache, too (may= be it already does - no idea). Any other desktop environments that don't r= einvent the wheel in that regard would use desktop-file-utils as well - and= that's the package that actually contains the "update-desktop-database" ex= ecutable for updating the XDG desktop cache. >> >> Right now the "xdg-desktop-database" profile hook doesn't need its own m= agical packages but it just uses the existing desktop-file-utils reference = for actually updating the desktop database. > > IIUC, the idea is to run the hook every time a package with a ".desktop" > file has changed. Even if we propagate "desktop-file-utils" from say, > GTK+ and Qt, it won't catch some cases where we add the ".desktop" file > manually such as "rxvt-unicode". A dirty workaround could be to add a reference to some dummy store item in the 'patch-dot-desktop-files' phase. Maybe a hidden "mimeinfo-helper" package and inject a reference to it directly in the '.desktop' files. And then test for that in the profile hook. Sounds a bit hacky, but should not cause any compatibility issues, and avoids the artificial 'desktop-file-utils' reference at 122MiB. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkg/DAACgkQoqBt8qM6 VPopugf+NbuZ2Ar1npkkE/DMIwt5gfOC3a5L8dghDbb0TwtlEAl6SOr0fN/jc3az AcMenvDkxuBvz/mrNj/oxiK6ZlLoU8DwJ1qHYC/3oTVY7PbnjK/WVURnJ00K0gGU AMb/R1FuZY3Z2WmoS0mJ8/NvSmwvdUgVcI+WLhQWIrR/Bhf+gIReSC0FGw0o8wXy Me0s7m/VoC7BRXcPCBLx9ojBXQo3KsN4y/zLYtL5729d93O9TRhRHDNB49VHnaLn EFCpS87g+vtFWoGFUphI+q9gw4ddFDJw/rN4EWK0cuWnB+ZSR5zgSgP0pJQf34RS 1N7KFWithAUZD8R0szwOVjgihBg1cQ== =FICT -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 05 15:22:14 2017 Received: (at 26988) by debbugs.gnu.org; 5 Jun 2017 19:22:14 +0000 Received: from localhost ([127.0.0.1]:58052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHxZu-0007Sm-25 for submit@debbugs.gnu.org; Mon, 05 Jun 2017 15:22:14 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:48130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHxZs-0007SR-3p for 26988@debbugs.gnu.org; Mon, 05 Jun 2017 15:22:12 -0400 Received: from dayas.3.home (77.118.242.17.wireless.dyn.drei.com [77.118.242.17]) by dd1012.kasserver.com (Postfix) with ESMTPSA id BEE0A1CA0026; Mon, 5 Jun 2017 21:22:09 +0200 (CEST) From: Danny Milosavljevic To: 26988@debbugs.gnu.org Subject: [PATCH v2 0/2] Add desktop-file-utils to all gtk applications. Date: Mon, 5 Jun 2017 21:22:00 +0200 Message-Id: <20170605192202.18820-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.1 In-Reply-To: <20170518230111.53a91ffe@scratchpost.org> References: <20170518230111.53a91ffe@scratchpost.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Danny Milosavljevic (2): gnu: Move desktop-file-utils to (gnu packages freedesktop). gnu: gtk+-2: Add desktop-file-utils to propagated-inputs. gnu/packages/engineering.scm | 1 + gnu/packages/freedesktop.scm | 32 ++++++++++++++++++++++++++++++++ gnu/packages/game-development.scm | 1 + gnu/packages/gnome.scm | 32 -------------------------------- gnu/packages/gtk.scm | 1 + gnu/packages/xfce.scm | 1 + 6 files changed, 36 insertions(+), 32 deletions(-) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 05 15:22:14 2017 Received: (at 26988) by debbugs.gnu.org; 5 Jun 2017 19:22:14 +0000 Received: from localhost ([127.0.0.1]:58054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHxZu-0007So-9l for submit@debbugs.gnu.org; Mon, 05 Jun 2017 15:22:14 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:48132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHxZs-0007ST-BG for 26988@debbugs.gnu.org; Mon, 05 Jun 2017 15:22:12 -0400 Received: from dayas.3.home (77.118.242.17.wireless.dyn.drei.com [77.118.242.17]) by dd1012.kasserver.com (Postfix) with ESMTPSA id E7F211CA0565; Mon, 5 Jun 2017 21:22:10 +0200 (CEST) From: Danny Milosavljevic To: 26988@debbugs.gnu.org Subject: [PATCH v2 1/2] gnu: Move desktop-file-utils to (gnu packages freedesktop). Date: Mon, 5 Jun 2017 21:22:01 +0200 Message-Id: <20170605192202.18820-2-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.1 In-Reply-To: <20170605192202.18820-1-dannym@scratchpost.org> References: <20170518230111.53a91ffe@scratchpost.org> <20170605192202.18820-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/gnome.scm (desktop-file-utils): Move from here ... * gnu/packages/freedesktop.scm (desktop-file-utils): ... to here. * gnu/packages/engineering.scm: Import (gnu packages freedesktop). * gnu/packages/game-development.scm: Import (gnu packages freedesktop). * gnu/packages/xfce.scm: Import (gnu packages freedesktop). --- gnu/packages/engineering.scm | 1 + gnu/packages/freedesktop.scm | 32 ++++++++++++++++++++++++++++++++ gnu/packages/game-development.scm | 1 + gnu/packages/gnome.scm | 32 -------------------------------- gnu/packages/xfce.scm | 1 + 5 files changed, 35 insertions(+), 32 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index 7ad93653e..e835a5da9 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -44,6 +44,7 @@ #:use-module (gnu packages curl) #:use-module (gnu packages flex) #:use-module (gnu packages fontutils) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages gd) #:use-module (gnu packages gettext) #:use-module (gnu packages ghostscript) diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm index 85a6c8b26..dfc88986f 100644 --- a/gnu/packages/freedesktop.scm +++ b/gnu/packages/freedesktop.scm @@ -927,3 +927,35 @@ library to access fingerprint readers, over the D-Bus interprocess communication bus. This daemon layer above libfprint solves problems related to applications simultaneously competing for fingerprint readers.") (license license:gpl2+))) + +(define-public desktop-file-utils + (package + (name "desktop-file-utils") + (version "0.23") + (source (origin + (method url-fetch) + (uri (string-append "https://www.freedesktop.org/software/" name + "/releases/" name "-" version ".tar.xz")) + (sha256 + (base32 + "119kj2w0rrxkhg4f9cf5waa55jz1hj8933vh47vcjipcplql02bc")))) + (build-system gnu-build-system) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("glib" ,glib))) + (home-page "http://www.freedesktop.org/wiki/Software/desktop-file-utils/") + (synopsis "Utilities for working with desktop entries") + (description + "This package contains a few command line utilities for working with +desktop entries: + +desktop-file-validate: validates a desktop file and prints warnings/errors + about desktop entry specification violations. + +desktop-file-install: installs a desktop file to the applications directory, + optionally munging it a bit in transit. + +update-desktop-database: updates the database containing a cache of MIME types + handled by desktop files.") + (license license:gpl2+))) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 6d9e4061d..56dedefd7 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -38,6 +38,7 @@ #:use-module (gnu packages databases) #:use-module (gnu packages documentation) #:use-module (gnu packages fontutils) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages fribidi) #:use-module (gnu packages glib) #:use-module (gnu packages gnunet) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 84ae1cf2f..f5efb44f8 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -702,38 +702,6 @@ Specification, the icon naming utility maps the icon names used by the GNOME and KDE desktops to the icon names proposed in the specification.") (license license:lgpl2.1+))) -(define-public desktop-file-utils - (package - (name "desktop-file-utils") - (version "0.23") - (source (origin - (method url-fetch) - (uri (string-append "https://www.freedesktop.org/software/" name - "/releases/" name "-" version ".tar.xz")) - (sha256 - (base32 - "119kj2w0rrxkhg4f9cf5waa55jz1hj8933vh47vcjipcplql02bc")))) - (build-system gnu-build-system) - (native-inputs - `(("pkg-config" ,pkg-config))) - (inputs - `(("glib" ,glib))) - (home-page "http://www.freedesktop.org/wiki/Software/desktop-file-utils/") - (synopsis "Utilities for working with desktop entries") - (description - "This package contains a few command line utilities for working with -desktop entries: - -desktop-file-validate: validates a desktop file and prints warnings/errors - about desktop entry specification violations. - -desktop-file-install: installs a desktop file to the applications directory, - optionally munging it a bit in transit. - -update-desktop-database: updates the database containing a cache of MIME types - handled by desktop files.") - (license license:gpl2+))) - (define-public gnome-icon-theme (package (name "gnome-icon-theme") diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index c8786dd69..d7d1372dd 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@ -39,6 +39,7 @@ #:use-module (gnu packages xdisorg) #:use-module (gnu packages web) #:use-module (gnu packages fontutils) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages image) #:use-module (gnu packages gnome) #:use-module (gnu packages pdf) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 05 15:22:14 2017 Received: (at 26988) by debbugs.gnu.org; 5 Jun 2017 19:22:14 +0000 Received: from localhost ([127.0.0.1]:58056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHxZu-0007Sv-LA for submit@debbugs.gnu.org; Mon, 05 Jun 2017 15:22:14 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:48140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHxZt-0007Sf-Dj for 26988@debbugs.gnu.org; Mon, 05 Jun 2017 15:22:13 -0400 Received: from dayas.3.home (77.118.242.17.wireless.dyn.drei.com [77.118.242.17]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 779A11CA07D8; Mon, 5 Jun 2017 21:22:12 +0200 (CEST) From: Danny Milosavljevic To: 26988@debbugs.gnu.org Subject: [PATCH v2 2/2] gnu: gtk+-2: Add desktop-file-utils to propagated-inputs. Date: Mon, 5 Jun 2017 21:22:02 +0200 Message-Id: <20170605192202.18820-3-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.1 In-Reply-To: <20170605192202.18820-1-dannym@scratchpost.org> References: <20170518230111.53a91ffe@scratchpost.org> <20170605192202.18820-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/gtk.scm (gtk+-2)[propagated-inputs]: Add desktop-file-utils. --- gnu/packages/gtk.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm index 1d9ee1524..67dc3c9a8 100644 --- a/gnu/packages/gtk.scm +++ b/gnu/packages/gtk.scm @@ -605,6 +605,7 @@ is part of the GNOME accessibility project.") (outputs '("out" "doc")) (propagated-inputs `(("atk" ,atk) + ("desktop-file-utils" ,desktop-file-utils) ; Used by profile hook. ("gdk-pixbuf" ,gdk-pixbuf+svg) ("pango" ,pango))) (inputs From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 15 04:27:17 2017 Received: (at 26988) by debbugs.gnu.org; 15 Jun 2017 08:27:17 +0000 Received: from localhost ([127.0.0.1]:48499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLQ7Z-0003Sl-6O for submit@debbugs.gnu.org; Thu, 15 Jun 2017 04:27:17 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:54336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLQ7X-0003Sd-Q4 for 26988@debbugs.gnu.org; Thu, 15 Jun 2017 04:27:16 -0400 Received: from localhost (178.113.219.28.wireless.dyn.drei.com [178.113.219.28]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 9E4651CA0593 for <26988@debbugs.gnu.org>; Thu, 15 Jun 2017 10:27:13 +0200 (CEST) Date: Thu, 15 Jun 2017 10:27:11 +0200 From: Danny Milosavljevic To: 26988@debbugs.gnu.org Subject: Re: [PATCH v2 1/2] gnu: Move desktop-file-utils to (gnu packages freedesktop). Message-ID: <20170615102711.7bc7085d@scratchpost.org> In-Reply-To: <20170605192202.18820-2-dannym@scratchpost.org> References: <20170518230111.53a91ffe@scratchpost.org> <20170605192202.18820-1-dannym@scratchpost.org> <20170605192202.18820-2-dannym@scratchpost.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Pushed only this patch to master as 324b0040f4ac493ef11f82712db2c9abcc6b92ca. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 03 11:37:27 2017 Received: (at 26988-done) by debbugs.gnu.org; 3 Jul 2017 15:37:27 +0000 Received: from localhost ([127.0.0.1]:50543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS3Pj-00034z-Fn for submit@debbugs.gnu.org; Mon, 03 Jul 2017 11:37:27 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:55510 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS3Ph-00034o-Gw for 26988-done@debbugs.gnu.org; Mon, 03 Jul 2017 11:37:25 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id B1FD151176D; Mon, 3 Jul 2017 17:37:21 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR002 X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED, T_HEADER_FROM_DIFFERENT_DOMAINS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id e783b0e9; Mon, 3 Jul 2017 15:32:11 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Marius Bakke Subject: Re: bug#26988: Add desktop-file-utils to all gtk applications References: <20170518230111.53a91ffe@scratchpost.org> <87inkwa1n1.fsf@fastmail.com> <20170520150411.21c3e0aa@scratchpost.org> <87h90f5e2h.fsf@fastmail.com> <87efvj549b.fsf@fastmail.com> Date: Mon, 03 Jul 2017 23:32:11 +0800 In-Reply-To: <87efvj549b.fsf@fastmail.com> (Marius Bakke's message of "Sun, 21 May 2017 04:32:16 +0200") Message-ID: <87eftx1qpw.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988-done Cc: Danny Milosavljevic , 26988-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Marius Bakke writes: > Marius Bakke writes: > >> Danny Milosavljevic writes: >> >>> Hi Marius, >>> Hi =E5=AE=8B=E6=96=87=E6=AD=A6, Hello Marius and Danny, >>> Marius Bakke wrote: >>> >>>> Danny Milosavljevic writes: >>>>=20 >>>> > these are two patches I propose we add in order to add >>>> > desktop-file-utils to all gtk applications. This means that the >>>> > profile hook would pick up the desktop files (as soon as possible).= =20=20 >>>>=20 >>>> So if I read (guix profiles) correctly, the hook only runs when >>>> 'desktop-file-utils' is referenced. Would checking for a gtk reference >>>> as well not achieve the same effect? Or is that too expensive? Yes, it will work better. It's expensive slightly by adding the latest version of desktop-file-utils into the profile closure, but the 'xdg-mime-database' does that already. >>> [...] >> >> IIUC, the idea is to run the hook every time a package with a ".desktop" >> file has changed. Even if we propagate "desktop-file-utils" from say, >> GTK+ and Qt, it won't catch some cases where we add the ".desktop" file >> manually such as "rxvt-unicode". Yes, but normally one would have other applications that using GTK+ or GLib, which will make the hook run. So I end up with modify the profile hook to test for GLib, it should work in most cases. Thanks for the patches! From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 03 13:08:28 2017 Received: (at 26988-done) by debbugs.gnu.org; 3 Jul 2017 17:08:28 +0000 Received: from localhost ([127.0.0.1]:50579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS4po-0005Gt-By for submit@debbugs.gnu.org; Mon, 03 Jul 2017 13:08:28 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:53154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS4pl-0005Gj-Nb for 26988-done@debbugs.gnu.org; Mon, 03 Jul 2017 13:08:26 -0400 Received: from localhost (178.113.214.100.wireless.dyn.drei.com [178.113.214.100]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 4C4631CA0466; Mon, 3 Jul 2017 19:08:23 +0200 (CEST) Date: Mon, 3 Jul 2017 19:08:20 +0200 From: Danny Milosavljevic To: iyzsong@member.fsf.org (=?utf-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) Subject: Re: bug#26988: Add desktop-file-utils to all gtk applications Message-ID: <20170703190820.473d59c4@scratchpost.org> In-Reply-To: <87eftx1qpw.fsf@member.fsf.org> References: <20170518230111.53a91ffe@scratchpost.org> <87inkwa1n1.fsf@fastmail.com> <20170520150411.21c3e0aa@scratchpost.org> <87h90f5e2h.fsf@fastmail.com> <87efvj549b.fsf@fastmail.com> <87eftx1qpw.fsf@member.fsf.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988-done Cc: Marius Bakke , 26988-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi =E5=AE=8B=E6=96=87=E6=AD=A6, On Mon, 03 Jul 2017 23:32:11 +0800 iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) wrote: > >> GTK+ and Qt, it won't catch some cases where we add the ".desktop" file > >> manually such as "rxvt-unicode". =20 How about just adding desktop-file-utils as a native-input to rxvt-unicode = (and other few special cases) with a comment saying that's because of the d= esktop file? > So I end up with modify the profile hook to test for GLib, it should > work in most cases. Glib is a basic C library that hasn't much to do with GUI. I think that if= you check for glib you'll run the hook for system daemons, dbus etc. Glib is basically the runtime library that makes C sane to use for any purp= ose. Also, desktop-file-utils itself requires glib so make sure you don't enter = an endless loop :) From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 04 07:46:01 2017 Received: (at 26988-done) by debbugs.gnu.org; 4 Jul 2017 11:46:02 +0000 Received: from localhost ([127.0.0.1]:51221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSMHJ-0000L8-Nb for submit@debbugs.gnu.org; Tue, 04 Jul 2017 07:46:01 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:55754 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSMHI-0000Kv-ID for 26988-done@debbugs.gnu.org; Tue, 04 Jul 2017 07:46:01 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 4543150DA24; Tue, 4 Jul 2017 13:45:55 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR002 X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED, T_HEADER_FROM_DIFFERENT_DOMAINS autolearn=disabled version=3.4.0 Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id f8a4ac97; Tue, 4 Jul 2017 11:40:40 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Danny Milosavljevic Subject: Re: bug#26988: Add desktop-file-utils to all gtk applications References: <20170518230111.53a91ffe@scratchpost.org> <87inkwa1n1.fsf@fastmail.com> <20170520150411.21c3e0aa@scratchpost.org> <87h90f5e2h.fsf@fastmail.com> <87efvj549b.fsf@fastmail.com> <87eftx1qpw.fsf@member.fsf.org> <20170703190820.473d59c4@scratchpost.org> Date: Tue, 04 Jul 2017 19:40:39 +0800 In-Reply-To: <20170703190820.473d59c4@scratchpost.org> (Danny Milosavljevic's message of "Mon, 3 Jul 2017 19:08:20 +0200") Message-ID: <87eftw4eh4.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26988-done Cc: Marius Bakke , 26988-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) A profile hook checks manifest entries for some condition, then usually adding a item to the profile's united output. In case of the current 'xdg-desktop-database', it checks if any entry has a reference of glib, then adding the 'mimeinfo.cache' to the profile. So, ... Danny Milosavljevic writes: > Hi =E5=AE=8B=E6=96=87=E6=AD=A6, > > On Mon, 03 Jul 2017 23:32:11 +0800 > iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) wrote: > >> >> GTK+ and Qt, it won't catch some cases where we add the ".desktop" fi= le >> >> manually such as "rxvt-unicode". > > How about just adding desktop-file-utils as a native-input to rxvt-unicod= e (and other few special cases) with a comment saying that's because of the= desktop file? In the sitution where you have rxvt-unicode but not any glib based applications in your profile, this will ensure the 'mimeinfo.cache' got built. But since there are no glib based things, I guess it won't be used. > >> So I end up with modify the profile hook to test for GLib, it should >> work in most cases. > > Glib is a basic C library that hasn't much to do with GUI. I think that = if you check for glib you'll run the hook for system daemons, dbus etc. Yeah, the hook only run once for all the packages in the profile. From unknown Fri Aug 15 20:57:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 02 Aug 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator