From unknown Fri Aug 15 12:48:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26987 <26987@debbugs.gnu.org> To: bug#26987 <26987@debbugs.gnu.org> Subject: Status: guix pull without guile-ssh. Reply-To: bug#26987 <26987@debbugs.gnu.org> Date: Fri, 15 Aug 2025 19:48:41 +0000 retitle 26987 guix pull without guile-ssh. reassign 26987 guix submitter 26987 Mathieu Othacehe severity 26987 important thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 15:53:52 2017 Received: (at submit) by debbugs.gnu.org; 18 May 2017 19:53:52 +0000 Received: from localhost ([127.0.0.1]:53851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBRUe-0005Fx-9K for submit@debbugs.gnu.org; Thu, 18 May 2017 15:53:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBRUb-0005Fk-GN for submit@debbugs.gnu.org; Thu, 18 May 2017 15:53:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBRUV-0006Vo-LO for submit@debbugs.gnu.org; Thu, 18 May 2017 15:53:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dBRUV-0006VL-ID for submit@debbugs.gnu.org; Thu, 18 May 2017 15:53:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBRUU-0008ST-DR for bug-guix@gnu.org; Thu, 18 May 2017 15:53:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBRUP-0006Hb-Ja for bug-guix@gnu.org; Thu, 18 May 2017 15:53:42 -0400 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:37829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dBRUP-0006Fv-CB for bug-guix@gnu.org; Thu, 18 May 2017 15:53:37 -0400 Received: by mail-wm0-x235.google.com with SMTP id d127so64146823wmf.0 for ; Thu, 18 May 2017 12:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=YgL7N38H3uTvKbPC/m9CkqRKbg8lwe3yhjmK1tUQ4QE=; b=M5BUc4TV8KkqCZQhU3md64dVFFxfQ87rFrr9acM4PfAb7W4Myoj4c2C6XpaobCyWkr /OnkpI7QJXIyqAxV52rOXT4/KBb5NLhcwuUH8gsVhgbCK2u6yVIF1jYiDNW3sfpKFWXj XcWZsAZpRH0bGHbs4b2dZ4crRe1HtXMSQufSLxT2bENJdmFDeNEnGiD4f6sPybmKvUuh ijsQsO8xHiITZ/QNGtUka9nuuFjECKVQCUyfnnoxh9EX9oIpNr8ZDjqFLnXMiqEG2b9Z n5whKkRJ+xML8aOnfEkZWZxyBb7O5+i4YZyG62XhtXW2Mns5Me6lmHZ80Fg3r6FvaDvF I4vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=YgL7N38H3uTvKbPC/m9CkqRKbg8lwe3yhjmK1tUQ4QE=; b=HlxOjiC7x9q10pDpMd6V2bIMHbfDMdvqWo7EzMrlrWvXol+c51qbdAM0TivtkRLrAA onfhJMlrr4th+h06SfL5IhUJfYn9CLAD59ZTuwey/g2ddPG0gUqL+aIewZt13IqI4lY4 QFpGytoIAnZL27iew2a/oqrVqQacwgrjwomvGkjlZhciVyfi/Q4mrOjIUk2QBavhfpcL HjzXw/TUOoo/G4aTowhziOZY4YC+u8a58T/Jv7WEZ6qsafxw6CwkkaK8T2C4chwRLzCU yGAW8nJH/h95ZLB1NHq72bfHYBzxFWjmSdT9VGIDJOOQuCv2B1L9AhkD3bhKqyl5Wuhv Cu9g== X-Gm-Message-State: AODbwcATSgo4jrbCU+feifVwetKGYxMJSSEccA8SrBQM+mTsvubs1jng WW5rhkbcN/0DDIvo X-Received: by 10.28.131.85 with SMTP id f82mr4095871wmd.141.1495137215761; Thu, 18 May 2017 12:53:35 -0700 (PDT) Received: from cervin (85-169-37-239.rev.numericable.fr. [85.169.37.239]) by smtp.gmail.com with ESMTPSA id t30sm375498wrc.24.2017.05.18.12.53.34 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 May 2017 12:53:35 -0700 (PDT) User-agent: mu4e 0.9.18; emacs 25.2.1 From: Mathieu Othacehe To: bug-guix@gnu.org Subject: guix pull without guile-ssh. Date: Thu, 18 May 2017 21:53:34 +0200 Message-ID: <87lgpuuekh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, If Guile-SSH is not detected, depends-on-guile-ssh? will be called here: --8<---------------cut here---------------start------------->8--- (guix build pull) (let* ((files (remove (if (false-if-exception (resolve-interface '(ssh session))) (const #f) depends-on-guile-ssh?) (all-scheme-files out))) --8<---------------cut here---------------end--------------->8--- Thus, source-module-closure is called with a file. However, source-module-closure is expecting a module list like '((guix ...)). This result in the following error while running guix pull: --8<---------------cut here---------------start------------->8--- In ./guix/modules.scm: 118:4 0 (module-closure _ #:select? _ #:dependencies _) ./guix/modules.scm:118:4: In procedure module-closure: ./guix/modules.scm:118:4: Throw to key `match-error' with args `("match" "no matching pattern" "/gnu/store/0slxknjvjwhp31qryv42419vqwjrjifb-guix-latest/guix.scm")'. builder for `/gnu/store/lq6ga13k75ljrdnqam9jm1q92cv4g0pm-guix-latest.drv' failed with exit code 1 --8<---------------cut here---------------end--------------->8--- I'm not sure how to fix it. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 03:56:36 2017 Received: (at 26987) by debbugs.gnu.org; 19 May 2017 07:56:36 +0000 Received: from localhost ([127.0.0.1]:54322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBcm4-0007Fz-IR for submit@debbugs.gnu.org; Fri, 19 May 2017 03:56:36 -0400 Received: from mail-wr0-f169.google.com ([209.85.128.169]:34882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBcm1-0007FN-Q4 for 26987@debbugs.gnu.org; Fri, 19 May 2017 03:56:34 -0400 Received: by mail-wr0-f169.google.com with SMTP id z52so11442190wrc.2 for <26987@debbugs.gnu.org>; Fri, 19 May 2017 00:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=+EpC2VFLnL5Ua5BYE/We16wQo4fziwNznqqdnJc7yhs=; b=K9DZL8LMv9pf1xob882FkplyAgeJxnXXBayVO+P3VQwKEJzxIpp1vYtHJhuemTOGPp nTwgZ1F34De/mU/27CMvMU37K4QlE0O6GuOWonN/JK2E7grcLCeHkA5fCX/refu1TJIg 6x0VQrIaM/TBZ4xVUAEf62AFksR+twB0N9x2oYcxXQymYoOyUCXtttra1DpQ+MtJx+q1 X0HDP29nFQ6ReSCHkUmX8D90M4TvHHZyvKrAQLqqiHsmUc2txr2Rlitjo5hEuzlqsuT5 gUfjgrrEpO0RTcroHZBeJERrvY992EciJ9UCUmMSCuxswl/PV+/bTXo9h+P4wAvqUDgq swqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+EpC2VFLnL5Ua5BYE/We16wQo4fziwNznqqdnJc7yhs=; b=b9ofp4cy8/9jFJ7+zaN4ZhxoczUoV65DJD+1XI3Es6tp42BmFRqcWuu9rvEmybZPaN kXfVLQEtC+YyP6JLu/nGtw3W3ya7qhQz+27l8SIQ0sbT8zAc+38PZUKQ8ZPyksfcOSr+ wiVRfopuhJaE7uV/XbZTDFW9LnuVEX0JObNyK7nYof+hZtqNnJUPz13UOsQ792npcuz+ iHg0yVvD5IurDkI20TFyVK44Rzyis7gDI3344s2MWfVyb3C+jhDzD8BGkxuk37sek4Or AdCQ9Gxh5RD10Tkn+rhmAnvTXc1vYwJRJDQJlpTsguPlSE4PKqyUTQ62cTFCR8PSlAYD d9NA== X-Gm-Message-State: AODbwcBtipxu62ltvvyz/zaeo2YM6Q5weBKGLxjyUEg/d9lpuPwphS9P rMISOcJI6SqVAQ== X-Received: by 10.223.142.135 with SMTP id q7mr1941705wrb.180.1495180588076; Fri, 19 May 2017 00:56:28 -0700 (PDT) Received: from cervin.8.8.8.8 (85-169-37-239.rev.numericable.fr. [85.169.37.239]) by smtp.gmail.com with ESMTPSA id 4sm2444709wry.31.2017.05.19.00.56.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 May 2017 00:56:27 -0700 (PDT) From: Mathieu Othacehe To: 26987@debbugs.gnu.org Subject: [PATCH 0/2] Fix compilation list construction. Date: Fri, 19 May 2017 09:56:21 +0200 Message-Id: <20170519075623.13836-1-m.othacehe@gmail.com> X-Mailer: git-send-email 2.13.0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26987 Cc: Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, Here are two patches to fix compilation list construction. It seems to work but I'm higly unsure this is the right thing to do. Plus, while testing I could not add #:use-modules (guix discovery) and had to write that instead : ((@@ (guix discovery) scheme-modules) directory) Thanks, Mathieu Mathieu Othacehe (2): build: pull: Fix compilation list construction. guix: modules: Export module-name->file-name. guix/build/pull.scm | 31 ++++++++----------------------- guix/modules.scm | 1 + 2 files changed, 9 insertions(+), 23 deletions(-) -- 2.13.0 From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 03:56:37 2017 Received: (at 26987) by debbugs.gnu.org; 19 May 2017 07:56:37 +0000 Received: from localhost ([127.0.0.1]:54324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBcm4-0007G1-P8 for submit@debbugs.gnu.org; Fri, 19 May 2017 03:56:36 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBcm2-0007FO-MZ for 26987@debbugs.gnu.org; Fri, 19 May 2017 03:56:34 -0400 Received: by mail-wm0-f65.google.com with SMTP id v4so16524385wmb.2 for <26987@debbugs.gnu.org>; Fri, 19 May 2017 00:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VU5q2Bp3yfByjnBpU4qOuUjWWRye8DFiVlxCkZFdSxM=; b=gj93Dgu7OmFoX5F2gw7xeLvVG9p3g9KIheUQlk53vsWBzqDRKfssRmLhHRJ53Qk3vv PiFZ6y+t2xdY1a+KjtwJQLkgY81gJ5Yu/NyZ/hP5RGwtRhcRtHpNkEL7Iiy3geW3qNFF opNb9hC4vrtI4Zzr+Ytk7LpF2Ee+6J9ewdegwVZ/9s7i62cB7d+osDqm1uya6JoIqbp7 x7UcnjEMDepgPzRFYbmpEJoy1bU8tDOPpeNynk2Xsr7bz6j2kZD/uF0FZ/t9Kqh4hexY FEjBGCBqkCprL4DMrv4RtDM3VE4q76FsNbdOXIPv67BB38czK9L0Z2EbNy59GQ2mY3qB 7CDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VU5q2Bp3yfByjnBpU4qOuUjWWRye8DFiVlxCkZFdSxM=; b=DQiHi6tW1Yp3IwxH+QmfCD78RYIXyUMB/jFRDiY7uhIE5bmxIU24MjeQHUQKwhEnTP Sbre3KV+uq+LAsjGKugPukrZaPwlPlFew9CtUNbNZbHxElgQoTfGbHMfWhL5BRstGkGf MIJHF1TMN1K5DKHomKkH1/w4QotBb7CyLdYRpV6mEI4+suC0Wk55MOg6IUJkNiBNw9tt WhlfYKm8HxjhPE9xJPG2nGbBQMXd5P3vzc0tuLycUQLZXkXpztP4NS3cDVYUafC2XT3j 5r1Y1yl980vryR2Wwvq0RGpv5pZ4t2g0dNDqInO1uT9c4AYEqCI+tZw4CrO+dSUwzLF2 WrQQ== X-Gm-Message-State: AODbwcDVtOr+OdsNng5P+OZbw4GEhCd5B1jU6CjZz4Fq1BfHKQA7XcXF pjGunA++eq1apA== X-Received: by 10.28.41.66 with SMTP id p63mr4831354wmp.88.1495180588947; Fri, 19 May 2017 00:56:28 -0700 (PDT) Received: from cervin.8.8.8.8 (85-169-37-239.rev.numericable.fr. [85.169.37.239]) by smtp.gmail.com with ESMTPSA id 4sm2444709wry.31.2017.05.19.00.56.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 May 2017 00:56:28 -0700 (PDT) From: Mathieu Othacehe To: 26987@debbugs.gnu.org Subject: [PATCH 1/2] guix: modules: Export module-name->file-name. Date: Fri, 19 May 2017 09:56:22 +0200 Message-Id: <20170519075623.13836-2-m.othacehe@gmail.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170519075623.13836-1-m.othacehe@gmail.com> References: <20170519075623.13836-1-m.othacehe@gmail.com> X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26987 Cc: Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) * guix/modules.scm (module-name->file-name): Export it. --- guix/modules.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/guix/modules.scm b/guix/modules.scm index 8c63f21a9..26c38e8d2 100644 --- a/guix/modules.scm +++ b/guix/modules.scm @@ -23,6 +23,7 @@ #:use-module (ice-9 match) #:export (source-module-closure live-module-closure + module-name->file-name guix-module-name?)) ;;; Commentary: -- 2.13.0 From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 03:56:37 2017 Received: (at 26987) by debbugs.gnu.org; 19 May 2017 07:56:37 +0000 Received: from localhost ([127.0.0.1]:54326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBcm5-0007G8-0f for submit@debbugs.gnu.org; Fri, 19 May 2017 03:56:37 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBcm3-0007FQ-O9 for 26987@debbugs.gnu.org; Fri, 19 May 2017 03:56:36 -0400 Received: by mail-wm0-f49.google.com with SMTP id d127so77517298wmf.0 for <26987@debbugs.gnu.org>; Fri, 19 May 2017 00:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W7ZD8e/wz2HHAJNPrcX13A0/hZ9Ycg7dgTtFmnJQnm0=; b=vJ80yGr5vUTOrht4i/Ak7iOw021WLOkWq3cxHi4jkBVpjCZsu49YrAs3ABdJ1UzGOX SmneAqmiLQDZFujXpOQQxpmik23ocseXOLirgB2F1Rjug637hPSSg9btuyuCbaI3mVaz dlJfUlnkMArrZlxdRLeWOp+yfAZ3g1q1Vs6KIuNf7aLSq8rFsfYPcKEmfYeCbGUQ+aQo Ax+mLnSWZpUNTt450dagUvVIjFF2nrJqyW11aNBJj2OYkQz2eaYGb7/F8N8vZSo3eaOu ZtgwsuUACG/Hqb1GlgUIt35Dd74njKK90NsplBNzIqEKswJ7rQKM7lUJFy9DDYZzDK/L 7PiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W7ZD8e/wz2HHAJNPrcX13A0/hZ9Ycg7dgTtFmnJQnm0=; b=rEYG7vIN2nAJV1omU6a/JMA1lAWIUB1J9DrmAHR/ciCP20HLTW2nL6WAVPADQbi1lo CIQMNBBQysDotG76YJR3R/ekYp3oE9VDKeqignLH+mETj0UjlQNmfQ/5y9xhOM+254pK juqqO7/AVFxOfHd6p6xA33OAjJ/uNqnk5D6Xw3LjBFs85ZVBnzFlKi5eZp8xqLMKDZVw Eo+THM71b5ADQKOy8AxVqtoEX/wCz3S5P9FuRoSXBNOqTjstohPMolBPhP9DuV6qFD49 rSH6+sBMVdlCLctDCJD52X+ealLhp1KirNKXPEBxqc2blashQrzS12H0OCbujWkmTWHt Kj3A== X-Gm-Message-State: AODbwcCTfxOiQEYlkOUlVpRJp3JWSUcNbG1fo5GAVshIrY5fJSdWZkTy gUZJirg+Ol2kPg== X-Received: by 10.28.67.130 with SMTP id q124mr5537124wma.17.1495180589938; Fri, 19 May 2017 00:56:29 -0700 (PDT) Received: from cervin.8.8.8.8 (85-169-37-239.rev.numericable.fr. [85.169.37.239]) by smtp.gmail.com with ESMTPSA id 4sm2444709wry.31.2017.05.19.00.56.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 May 2017 00:56:29 -0700 (PDT) From: Mathieu Othacehe To: 26987@debbugs.gnu.org Subject: [PATCH 2/2] build: pull: Fix compilation list construction. Date: Fri, 19 May 2017 09:56:23 +0200 Message-Id: <20170519075623.13836-3-m.othacehe@gmail.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170519075623.13836-1-m.othacehe@gmail.com> References: <20170519075623.13836-1-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26987 Cc: Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * guix/build/pull.scm (depends-on-guile-ssh?): Remove. (all-scheme-files): Use "scheme-modules" to detect all loadable modules in given directory and rebuild a file list from those modules. --- guix/build/pull.scm | 31 ++++++++----------------------- 1 file changed, 8 insertions(+), 23 deletions(-) diff --git a/guix/build/pull.scm b/guix/build/pull.scm index d2e0404b1..e6ec71a54 100644 --- a/guix/build/pull.scm +++ b/guix/build/pull.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2013, 2014, 2016, 2017 Ludovic Courtès ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer +;;; Copyright © 2017 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. ;;; @@ -36,26 +37,14 @@ ;;; ;;; Code: -(define (depends-on-guile-ssh? file) - "Return true if FILE is a Scheme source file that depends, directly or -indirectly, on Guile-SSH." - (find (match-lambda - (('ssh _ ...) #t) - (_ #f)) - (source-module-closure file #:select? (const #t)))) - (define (all-scheme-files directory) "Return a sorted list of Scheme files found in DIRECTORY." - ;; Load guix/ modules before gnu/ modules to get somewhat steadier - ;; progress reporting. - (sort (filter (cut string-suffix? ".scm" <>) - (find-files directory "\\.scm")) - (let ((guix (string-append directory "/guix")) - (gnu (string-append directory "/gnu"))) - (lambda (a b) - (or (and (string-prefix? guix a) - (string-prefix? gnu b)) - (stringfile-name module))) + modules))) (cond-expand (guile-2.2 (use-modules (language tree-il optimize) @@ -145,11 +134,7 @@ containing the source code. Write any debugging output to DEBUG-PORT." ;; Compile the .scm files. Load all the files before compiling them to ;; work around (FIXME). ;; Filter out files depending on Guile-SSH when Guile-SSH is missing. - (let* ((files (remove (if (false-if-exception - (resolve-interface '(ssh session))) - (const #f) - depends-on-guile-ssh?) - (all-scheme-files out))) + (let* ((files (all-scheme-files out)) (total (length files))) (let loop ((files files) (completed 0)) -- 2.13.0 From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 04:18:25 2017 Received: (at 26987) by debbugs.gnu.org; 19 May 2017 08:18:25 +0000 Received: from localhost ([127.0.0.1]:54348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBd7B-0007mc-LR for submit@debbugs.gnu.org; Fri, 19 May 2017 04:18:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBd7A-0007mQ-3L for 26987@debbugs.gnu.org; Fri, 19 May 2017 04:18:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBd6z-0000iC-Tr for 26987@debbugs.gnu.org; Fri, 19 May 2017 04:18:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBd6z-0000i8-QX; Fri, 19 May 2017 04:18:13 -0400 Received: from [193.50.110.84] (port=41658 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBd6z-0007Uy-93; Fri, 19 May 2017 04:18:13 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mathieu Othacehe Subject: Re: bug#26987: [PATCH 1/2] guix: modules: Export module-name->file-name. References: <20170519075623.13836-1-m.othacehe@gmail.com> <20170519075623.13836-2-m.othacehe@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Fri, 19 May 2017 10:18:11 +0200 In-Reply-To: <20170519075623.13836-2-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Fri, 19 May 2017 09:56:22 +0200") Message-ID: <87inkxi7jw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26987 Cc: 26987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Mathieu Othacehe skribis: > * guix/modules.scm (module-name->file-name): Export it. OK! From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 08:59:03 2017 Received: (at 26987) by debbugs.gnu.org; 19 May 2017 12:59:03 +0000 Received: from localhost ([127.0.0.1]:54565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBhUl-00011I-22 for submit@debbugs.gnu.org; Fri, 19 May 2017 08:59:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBhUj-00010m-Po for 26987@debbugs.gnu.org; Fri, 19 May 2017 08:59:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBhUa-0008NU-QR for 26987@debbugs.gnu.org; Fri, 19 May 2017 08:58:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBhUa-0008NQ-MC; Fri, 19 May 2017 08:58:52 -0400 Received: from [193.50.110.84] (port=44322 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBhUZ-0007cL-TB; Fri, 19 May 2017 08:58:52 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mathieu Othacehe Subject: Re: bug#26987: [PATCH 2/2] build: pull: Fix compilation list construction. References: <20170519075623.13836-1-m.othacehe@gmail.com> <20170519075623.13836-3-m.othacehe@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Fri, 19 May 2017 14:58:48 +0200 In-Reply-To: <20170519075623.13836-3-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Fri, 19 May 2017 09:56:23 +0200") Message-ID: <87o9updmuv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26987 Cc: 26987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mathieu Othacehe skribis: > * guix/build/pull.scm (depends-on-guile-ssh?): Remove. > (all-scheme-files): Use "scheme-modules" to detect all loadable > modules in given directory and rebuild a file list from those modules. > --- > guix/build/pull.scm | 31 ++++++++----------------------- > 1 file changed, 8 insertions(+), 23 deletions(-) > > diff --git a/guix/build/pull.scm b/guix/build/pull.scm > index d2e0404b1..e6ec71a54 100644 > --- a/guix/build/pull.scm > +++ b/guix/build/pull.scm > @@ -1,6 +1,7 @@ > ;;; GNU Guix --- Functional package management for GNU > ;;; Copyright =C2=A9 2013, 2014, 2016, 2017 Ludovic Court=C3=A8s > ;;; Copyright =C2=A9 2015 Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer > +;;; Copyright =C2=A9 2017 Mathieu Othacehe > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -36,26 +37,14 @@ > ;;; > ;;; Code: >=20=20 > -(define (depends-on-guile-ssh? file) > - "Return true if FILE is a Scheme source file that depends, directly or > -indirectly, on Guile-SSH." > - (find (match-lambda > - (('ssh _ ...) #t) > - (_ #f)) > - (source-module-closure file #:select? (const #t)))) > - > (define (all-scheme-files directory) > "Return a sorted list of Scheme files found in DIRECTORY." > - ;; Load guix/ modules before gnu/ modules to get somewhat steadier > - ;; progress reporting. > - (sort (filter (cut string-suffix? ".scm" <>) > - (find-files directory "\\.scm")) > - (let ((guix (string-append directory "/guix")) > - (gnu (string-append directory "/gnu"))) > - (lambda (a b) > - (or (and (string-prefix? guix a) > - (string-prefix? gnu b)) > - (string + (let ((modules (map module-name > + ((@@ (guix discovery) scheme-modules) directory)))) > + (map (lambda (module) > + (string-append directory "/" > + (module-name->file-name module))) > + modules))) >=20=20 > (cond-expand > (guile-2.2 (use-modules (language tree-il optimize) > @@ -145,11 +134,7 @@ containing the source code. Write any debugging out= put to DEBUG-PORT." > ;; Compile the .scm files. Load all the files before compiling them= to > ;; work around (FIXME). > ;; Filter out files depending on Guile-SSH when Guile-SSH is missing. > - (let* ((files (remove (if (false-if-exception > - (resolve-interface '(ssh session))) > - (const #f) > - depends-on-guile-ssh?) > - (all-scheme-files out))) > + (let* ((files (all-scheme-files out)) > (total (length files))) I think this patch does to thing: (1) fixing the bug at hand, and (2) using (guix discovery). For (1), I think this should work: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/build/pull.scm b/guix/build/pull.scm index d2e0404b1..84629f6b0 100644 --- a/guix/build/pull.scm +++ b/guix/build/pull.scm @@ -39,10 +39,15 @@ (define (depends-on-guile-ssh? file) "Return true if FILE is a Scheme source file that depends, directly or indirectly, on Guile-SSH." + (let ((module (call-with-input-file file + (lambda (port) + (match (read port) + (('define-module name _ ...) + name)))))) (find (match-lambda (('ssh _ ...) #t) (_ #f)) - (source-module-closure file #:select? (const #t)))) + (source-module-closure module #:select? (const #t))))) (define (all-scheme-files directory) "Return a sorted list of Scheme files found in DIRECTORY." --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 DQpXRFlUPw0KDQpMdWRv4oCZLg0K --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 09:55:38 2017 Received: (at 26987) by debbugs.gnu.org; 19 May 2017 13:55:38 +0000 Received: from localhost ([127.0.0.1]:55442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBiNW-0002Wr-9t for submit@debbugs.gnu.org; Fri, 19 May 2017 09:55:38 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBiNU-0002Wl-Ki for 26987@debbugs.gnu.org; Fri, 19 May 2017 09:55:36 -0400 Received: by mail-wm0-f45.google.com with SMTP id v15so87499980wmv.1 for <26987@debbugs.gnu.org>; Fri, 19 May 2017 06:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=KPky80rf6BsLHlJ2p8nJlwBxkc2Tg2N/DmtHV/SZyik=; b=RpYz2MKnEceMN3JzCxPsMAaPMhTf/bAO4CsVdfZ2sF1MhWxROmgG2biTMsMIK62GbI tuxkt5lm+ArV9stidUcUkUBa5k7ZnfzBVuwa80K6pVbnqqd0u5kEPWG8dnAXsgvfHhMh f8HgAyRZighF6dVwwtTM0O/dOW6sLfMSqXcDo+XMyin5MltMVLaNTDo46oHGWGExCMAL 3wqawUJRmDrnLU1P9nGlEXpZGqZ3ueFWLkoV8VlW3em+O+LgS5x7WVbhanvCeLdvpzpY j10Hbmr07KCnWINJ/DZnWo41MdGP/v/3bJtMfIPNWxsmtGctq5hUxos49klZxU3ARz/0 bqKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=KPky80rf6BsLHlJ2p8nJlwBxkc2Tg2N/DmtHV/SZyik=; b=pnz1NXAvZauWqDEqhOmaxhSllteA9gSrJqxQoUvBAPYarnfN3ampRMUG3yaakaECtZ KaN52EdpggSIZMOUPUYusIfhXIDOL3E62ic+lXBX/owUJhS0erpedFWiiWEdjT/tMWAa SjA+HbwyZnCIVuJTimF/OPKtLd2jcykhWDKzbBZVfdzdLzKBo6C+jDG/CT+6ikKT8LIf D5cw4K3pRxdgOHwZKhWqMfUr1nLJ1iFTlEPYEAnCylV0D6tjiEXQHVLlnhuKj3lENLka nYUnFAYPLi7eQR8g5+oS1IIkDAfN/CIRCuHThagTEwNuuyhSPfVPkYEYnjFIh3BrDgGg X5Aw== X-Gm-Message-State: AODbwcD3nd1NqO+2+z+pcOx4DSf6xuJjM4MEw3m38mZnhzKS6e63IYlI /4lozsgg/2Rvhg== X-Received: by 10.28.54.91 with SMTP id d88mr1469548wma.9.1495202130813; Fri, 19 May 2017 06:55:30 -0700 (PDT) Received: from zbook ([46.218.109.88]) by smtp.gmail.com with ESMTPSA id o200sm6572156wmg.22.2017.05.19.06.55.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 May 2017 06:55:29 -0700 (PDT) References: <20170519075623.13836-1-m.othacehe@gmail.com> <20170519075623.13836-3-m.othacehe@gmail.com> <87o9updmuv.fsf@gnu.org> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#26987: [PATCH 2/2] build: pull: Fix compilation list construction. In-reply-to: <87o9updmuv.fsf@gnu.org> Date: Fri, 19 May 2017 15:55:31 +0200 Message-ID: <86wp9d7xyk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26987 Cc: 26987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Ludo, It seems better but I can't get it to work neither : > (find (match-lambda > (('ssh _ ...) #t) > (_ #f)) > - (source-module-closure file #:select? (const #t)))) > + (source-module-closure module #:select? (const #t))))) ^ we need a list here. > > (define (all-scheme-files directory) > "Return a sorted list of Scheme files found in DIRECTORY." > > WDYT? So with --8<---------------cut here---------------start------------->8--- (define (depends-on-guile-ssh? file) "Return true if FILE is a Scheme source file that depends, directly or indirectly, on Guile-SSH." (let ((module (call-with-input-file file (lambda (port) (match (read port) (('define-module name _ ...) name)))))) (find (match-lambda (('ssh _ ...) #t) (_ #f)) (source-module-closure (list module) #:select? (const #t))))) --8<---------------cut here---------------end--------------->8--- I get, --8<---------------cut here---------------start------------->8--- ((@@ (guix build pull) depends-on-guile-ssh?) "/home/mathieu/guix/guix/ssh.scm") ERROR: In procedure open-file: ERROR: Wrong type (expecting string): #f --8<---------------cut here---------------end--------------->8--- I'm having a hard time tring to understand ,trace output. Mathieu From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 10:26:24 2017 Received: (at 26987) by debbugs.gnu.org; 19 May 2017 14:26:24 +0000 Received: from localhost ([127.0.0.1]:55477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBirI-00051i-78 for submit@debbugs.gnu.org; Fri, 19 May 2017 10:26:24 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:35424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBirG-00051S-JH for 26987@debbugs.gnu.org; Fri, 19 May 2017 10:26:22 -0400 Received: by mail-wr0-f171.google.com with SMTP id z52so18345497wrc.2 for <26987@debbugs.gnu.org>; Fri, 19 May 2017 07:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=pB4AMpLxijzCzPVmA/9O42y779qFiq/xoGXfEeLh/vo=; b=NKkrMninDP/Xw8p3kVF5tMZOrh1mScfObPkXaYMRCH2/0PcUaPSwJ2AtblrqEvVADn /vq6qe1rcksc/vDXEex/TkRqoTI7SNKJFILBdh/acwL1+wrJt8dinSG2gwy1pzEstp7V 7zM1sqVBtE5iuoMwT8PJNTM2fWlkCyoA3RwNLUtIWBLGivGRF4R85vH/73pQmt6K3iae ouwr8YpoddHTd8frJd0fryIMeO5elhFcmJ7/uPO9ZeH9Sm++ds3XlKcetUDLfgF2uBl1 GOZqJ8n26D0Sl03209kekko8DfhWGTmUqyGqOX/qy2A1Y42RWvaqz3mKF8spe3MYkSOS tbSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=pB4AMpLxijzCzPVmA/9O42y779qFiq/xoGXfEeLh/vo=; b=b1J1D/5NUSbKzpXh+9PqijeYPiGluoq+/tghpJxCXQ0qTmQPuDihlAL3VeUOVEXFfl vvBhsnpA4eIIW5WYOy5JiX60PwbkawfjBdfM0+eqlbvI0w+AH4eUv+ikEBqQvO5E7Jny bAmZvxf0iOIPwUuM3WlAo8dGkJ7SOXckVytnTXkcEr71jNpPJSoym2BN8QdofEW8PfR0 EYUP1CPmXSG1IeuM3JC4fwmTUqtD0ni4kxWF/ST9Sd4AsNopnFHk2v0Ikz8UeHONrK5J lIU6gvHXcxhkh4AhwODvFa2oqjuo6KW1XqAXMTsgCFdpPVzGVqbxQ2/ESTtduADCRXv2 +taA== X-Gm-Message-State: AODbwcCoUO49paoB95sghKTSknY6i2fg6FnbP7D0vyHrdkWvDQKRCkLU 89/UWHDwRi7P4Q== X-Received: by 10.223.183.16 with SMTP id l16mr3789121wre.42.1495203976736; Fri, 19 May 2017 07:26:16 -0700 (PDT) Received: from zbook ([46.218.109.88]) by smtp.gmail.com with ESMTPSA id p107sm2623039wrb.64.2017.05.19.07.26.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 May 2017 07:26:15 -0700 (PDT) References: <20170519075623.13836-1-m.othacehe@gmail.com> <20170519075623.13836-3-m.othacehe@gmail.com> <87o9updmuv.fsf@gnu.org> <86wp9d7xyk.fsf@gmail.com> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#26987: [PATCH 2/2] build: pull: Fix compilation list construction. In-reply-to: <86wp9d7xyk.fsf@gmail.com> Date: Fri, 19 May 2017 16:26:17 +0200 Message-ID: <86vaow9b3q.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26987 Cc: 26987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > I'm having a hard time tring to understand ,trace output. I get why, it's because guile-ssh is not in my %load-path. So loading "ssh/session.scm" fails in "source-module-dependencies". It's a bit of a vicious circle here : if resolve-interface '(ssh session) fails, depends-on-guile-ssh? will fail too. I'm note sure we can depend on source-module-closure to do the job here. Mathieu From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 11:41:55 2017 Received: (at 26987) by debbugs.gnu.org; 19 May 2017 15:41:55 +0000 Received: from localhost ([127.0.0.1]:55522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBk2N-0006nX-4F for submit@debbugs.gnu.org; Fri, 19 May 2017 11:41:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBk2M-0006nL-2W for 26987@debbugs.gnu.org; Fri, 19 May 2017 11:41:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBk2D-0000UP-QL for 26987@debbugs.gnu.org; Fri, 19 May 2017 11:41:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBk2D-0000UK-LZ; Fri, 19 May 2017 11:41:45 -0400 Received: from [193.50.110.84] (port=45838 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBk2D-0007iU-3T; Fri, 19 May 2017 11:41:45 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mathieu Othacehe Subject: Re: bug#26987: [PATCH 2/2] build: pull: Fix compilation list construction. References: <20170519075623.13836-1-m.othacehe@gmail.com> <20170519075623.13836-3-m.othacehe@gmail.com> <87o9updmuv.fsf@gnu.org> <86wp9d7xyk.fsf@gmail.com> <86vaow9b3q.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Fri, 19 May 2017 17:41:42 +0200 In-Reply-To: <86vaow9b3q.fsf@gmail.com> (Mathieu Othacehe's message of "Fri, 19 May 2017 16:26:17 +0200") Message-ID: <878tlsetvt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26987 Cc: 26987@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Mathieu Othacehe skribis: >> I'm having a hard time tring to understand ,trace output. > > I get why, it's because guile-ssh is not in my %load-path. So loading > "ssh/session.scm" fails in "source-module-dependencies". > > It's a bit of a vicious circle here : if resolve-interface '(ssh > session) fails, depends-on-guile-ssh? will fail too. > > I'm note sure we can depend on source-module-closure to do the job here. Oh, got it. Hmm, needs more thought. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 18:02:34 2017 Received: (at control) by debbugs.gnu.org; 20 May 2017 22:02:34 +0000 Received: from localhost ([127.0.0.1]:57403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCCSI-0000Mj-Cy for submit@debbugs.gnu.org; Sat, 20 May 2017 18:02:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCCSF-0000MW-VW for control@debbugs.gnu.org; Sat, 20 May 2017 18:02:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCCS7-0008LH-TA for control@debbugs.gnu.org; Sat, 20 May 2017 18:02:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCCS7-0008LD-QW for control@debbugs.gnu.org; Sat, 20 May 2017 18:02:23 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:51830 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dCCS7-0005Jx-16 for control@debbugs.gnu.org; Sat, 20 May 2017 18:02:23 -0400 Date: Sun, 21 May 2017 00:02:20 +0200 Message-Id: <8760gv5gr7.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #26987 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) severity 26987 important From debbugs-submit-bounces@debbugs.gnu.org Thu May 25 08:33:17 2017 Received: (at 26987-done) by debbugs.gnu.org; 25 May 2017 12:33:17 +0000 Received: from localhost ([127.0.0.1]:37043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDrx7-0004qb-3F for submit@debbugs.gnu.org; Thu, 25 May 2017 08:33:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDrx6-0004qP-3G for 26987-done@debbugs.gnu.org; Thu, 25 May 2017 08:33:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDrwx-0008Ag-I5 for 26987-done@debbugs.gnu.org; Thu, 25 May 2017 08:33:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDrwx-0008Aa-Ec; Thu, 25 May 2017 08:33:07 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:58000 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dDrww-0004dp-Ov; Thu, 25 May 2017 08:33:07 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mathieu Othacehe Subject: Re: bug#26987: [PATCH 2/2] build: pull: Fix compilation list construction. References: <20170519075623.13836-1-m.othacehe@gmail.com> <20170519075623.13836-3-m.othacehe@gmail.com> <87o9updmuv.fsf@gnu.org> <86wp9d7xyk.fsf@gmail.com> <86vaow9b3q.fsf@gmail.com> Date: Thu, 25 May 2017 14:33:04 +0200 In-Reply-To: <86vaow9b3q.fsf@gmail.com> (Mathieu Othacehe's message of "Fri, 19 May 2017 16:26:17 +0200") Message-ID: <87wp95xgjj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26987-done Cc: 26987-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Mathieu Othacehe skribis: >> I'm having a hard time tring to understand ,trace output. > > I get why, it's because guile-ssh is not in my %load-path. So loading > "ssh/session.scm" fails in "source-module-dependencies". > > It's a bit of a vicious circle here : if resolve-interface '(ssh > session) fails, depends-on-guile-ssh? will fail too. > > I'm note sure we can depend on source-module-closure to do the job here. I believe this is fixed by commit 20ed093977cc80ba1729c38e05ae7955a38069a6, which follows a modification to the =E2=80=98source-module-closure=E2=80=99 so that callers can catch missing-dependency errors. Please let me know what you think! After that, you should be able to reinstate the (guix git) commit, provided build-aux/build-self.scm does: (define guile-git (package-for-current-guile "guile-git" "guile2.2-git" "guile2.0-git")) and passes that down to =E2=80=98build-guix=E2=80=99. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 02 05:16:08 2017 Received: (at 26987-done) by debbugs.gnu.org; 2 Jun 2017 09:16:08 +0000 Received: from localhost ([127.0.0.1]:50512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGigi-0005KM-3V for submit@debbugs.gnu.org; Fri, 02 Jun 2017 05:16:08 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGigg-0005Ja-9t for 26987-done@debbugs.gnu.org; Fri, 02 Jun 2017 05:16:06 -0400 Received: by mail-wm0-f51.google.com with SMTP id n195so19281958wmg.1 for <26987-done@debbugs.gnu.org>; Fri, 02 Jun 2017 02:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=VO8210wFyJNas1Er8gNsUcjT4p/5hXOT2Rjp7ZeUaxU=; b=cwm8mv9CZofvDXX7VQWPw7h2sIiVA9osOfhzopdluiLhbT0sOsfFAsypRzSFUPekBL W+Jo+DFwq3Pksil3fnc6cGf3fLyvAOYmH1sM8ilsxKpcLJnQgkScUuAZ03MzY1GXyKhY EbJ2v2sufYVExuhriH07d8u4IrQ17K/2IbdWgaO7kaxBF7BxfFVztR9ElqbGv4VxRYza c0wSVgKsjHxGr7MiaKfokaohrgHXiswROo2xGuuYFXAFljY+XBx8RfXYD+XjvNqZQjXh ozPy5RJaWkt+GN9KczSnuLQmSyGQ66oIPjoQ+UPEw1Gpk/Gu0pLMEMnwGWz0Ky6QuOpg DEOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=VO8210wFyJNas1Er8gNsUcjT4p/5hXOT2Rjp7ZeUaxU=; b=JdiQxNjraBT5rsnaHJOOoTa6q28EXUrbyHSPc7KeC9e4udQ3km9L7yBEIvUQQV0GHX IXS0WiW1fYaE7/IZgZqN6atv7sYrHEeAtnUTmbiCMlLmn+pAR73/AtPyC7AoQNPMUZMr aXBexifSBmIg9PYpghn3I5c9p+gTc8EN3u354oT4+sDgL30IG9tS7ECylT/8xScG8jYI 4zDDMnO7gf492JRhRHanjK16UKEH2kEQEgbLPnYT/xe7kjPRIr24Z07IgXLyEVBfJ2S8 HVdsE1/N2X8mwTulG9+GsmgU19oAMRjh/QPhq2MK/7esfzCB9nIvnl/OH1uAL5KMFwSV qYxA== X-Gm-Message-State: AODbwcCd5GtSYK+4Ill8wXu6pjTvnJQuCZcg369//eBWDhMII62pIQLI ZILO8mQ2y0kz8Aid X-Received: by 10.28.197.129 with SMTP id v123mr632473wmf.101.1496394960463; Fri, 02 Jun 2017 02:16:00 -0700 (PDT) Received: from zbook ([46.218.109.88]) by smtp.gmail.com with ESMTPSA id 39sm22842861wru.50.2017.06.02.02.15.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Jun 2017 02:15:59 -0700 (PDT) References: <20170519075623.13836-1-m.othacehe@gmail.com> <20170519075623.13836-3-m.othacehe@gmail.com> <87o9updmuv.fsf@gnu.org> <86wp9d7xyk.fsf@gmail.com> <86vaow9b3q.fsf@gmail.com> <87wp95xgjj.fsf@gnu.org> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Amirouche Subject: Re: bug#26987: [PATCH 2/2] build: pull: Fix compilation list construction. In-reply-to: <87wp95xgjj.fsf@gnu.org> Date: Fri, 02 Jun 2017 11:16:04 +0200 Message-ID: <86k24ukawb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26987-done Cc: 26987-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Hi Ludo, > I believe this is fixed by commit > 20ed093977cc80ba1729c38e05ae7955a38069a6, which follows a modification > to the ‘source-module-closure’ so that callers can catch > missing-dependency errors. > > Please let me know what you think! It seems ok, thanks for fixing it ! > > After that, you should be able to reinstate the (guix git) commit, > provided build-aux/build-self.scm does: > > (define guile-git > (package-for-current-guile "guile-git" > "guile2.2-git" > "guile2.0-git")) ^ for guile2.0-git, we need to define guile2.0-bytestructures, so I tried to package it, and I get the following error : --8<---------------cut here---------------start------------->8--- ice-9/boot-9.scm:109:20: In procedure #8--- It is something introduced in bytestructures commit 91d042e, that works on 2.2 but not on 2.0, I have no idea why ! Amirouche any idea ? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 02 11:10:01 2017 Received: (at 26987-done) by debbugs.gnu.org; 2 Jun 2017 15:10:01 +0000 Received: from localhost ([127.0.0.1]:51728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGoDA-00079z-QE for submit@debbugs.gnu.org; Fri, 02 Jun 2017 11:10:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGoD9-00079o-W3 for 26987-done@debbugs.gnu.org; Fri, 02 Jun 2017 11:10:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGoD0-0006D8-MC for 26987-done@debbugs.gnu.org; Fri, 02 Jun 2017 11:09:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGoD0-0006Cw-Ir; Fri, 02 Jun 2017 11:09:50 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:37098 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dGoCz-0004Hs-Qn; Fri, 02 Jun 2017 11:09:50 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mathieu Othacehe Subject: Re: bug#26987: [PATCH 2/2] build: pull: Fix compilation list construction. References: <20170519075623.13836-1-m.othacehe@gmail.com> <20170519075623.13836-3-m.othacehe@gmail.com> <87o9updmuv.fsf@gnu.org> <86wp9d7xyk.fsf@gmail.com> <86vaow9b3q.fsf@gmail.com> <87wp95xgjj.fsf@gnu.org> <86k24ukawb.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 Prairial an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Fri, 02 Jun 2017 17:09:47 +0200 In-Reply-To: <86k24ukawb.fsf@gmail.com> (Mathieu Othacehe's message of "Fri, 02 Jun 2017 11:16:04 +0200") Message-ID: <87o9u65suc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26987-done Cc: 26987-done@debbugs.gnu.org, Amirouche X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Mathieu, Mathieu Othacehe skribis: >> I believe this is fixed by commit >> 20ed093977cc80ba1729c38e05ae7955a38069a6, which follows a modification >> to the =E2=80=98source-module-closure=E2=80=99 so that callers can catch >> missing-dependency errors. >> >> Please let me know what you think! > > It seems ok, thanks for fixing it ! > >> >> After that, you should be able to reinstate the (guix git) commit, >> provided build-aux/build-self.scm does: >> >> (define guile-git >> (package-for-current-guile "guile-git" >> "guile2.2-git" >> "guile2.0-git")) > ^ > for guile2.0-git, > we need to define guile2.0-bytestructures, so I tried to package it, > and I get the following error : > > ice-9/boot-9.scm:109:20: In procedure # ice-9/boot-9.scm:109:20: re-exporting local variable: cstring-pointer > > It is something introduced in bytestructures commit 91d042e, that works > on 2.2 but not on 2.0, I have no idea why ! It would be nice to have guile2.0-git, but note that it does not *have* to exist: =E2=80=98package-for-current-guile=E2=80=99 returns #f if none of= the packages exists, and (guix build pull) skips modules that lack their dependencies. So I would first suggest to re-add (guix git), and later see with Amirouche et al. what could be done to get Guile-Git on 2.0. Does that make sense? Thanks, Ludo=E2=80=99. From unknown Fri Aug 15 12:48:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 01 Jul 2017 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator