From unknown Sun Jun 22 07:36:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26953: [PATCH] 26.0.50; svg-line uses incorrect parameters Resent-From: Ari Roponen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2017 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26953 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 26953@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14949469682290 (code B ref -1); Tue, 16 May 2017 15:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 May 2017 15:02:48 +0000 Received: from localhost ([127.0.0.1]:48912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAdzs-0000as-DX for submit@debbugs.gnu.org; Tue, 16 May 2017 11:02:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAdzr-0000ag-Bm for submit@debbugs.gnu.org; Tue, 16 May 2017 11:02:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAdzl-0008EW-Jh for submit@debbugs.gnu.org; Tue, 16 May 2017 11:02:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36521) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dAdzl-0008ES-HE for submit@debbugs.gnu.org; Tue, 16 May 2017 11:02:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAdzk-0004V9-IV for bug-gnu-emacs@gnu.org; Tue, 16 May 2017 11:02:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAdzj-0008EA-RG for bug-gnu-emacs@gnu.org; Tue, 16 May 2017 11:02:40 -0400 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:35000) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dAdzj-0008Du-KP for bug-gnu-emacs@gnu.org; Tue, 16 May 2017 11:02:39 -0400 Received: by mail-lf0-x22d.google.com with SMTP id j1so21371868lfh.2 for ; Tue, 16 May 2017 08:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=cJ0W+T7L9RLfmGOECmj4FOHP1aQbW/tZqOJPACYECD0=; b=jJraf1KrpBvZJJU6l6Bp3R/e02UcmJoa22WiZr4Ki3ApQSp4AKTcpGbRK6fCKBSGj9 xdc3hbcw9uxgdPoMY8EYAjLQjPdm2jIiib0AzqloopZYH6VYlFvc0zE9ofqSO+oI6R7i zymELBh28lZkoBpge0NhXYZ3ITvZ64LwjPhXXKeACJeTeT/xLIRJpT/Li2D8iN4v0Y3Z gDMojZ3PWDZw33jZ6NWki2SwM+4RFLgf+Mt8cKfHh8RIhWOXSQJZhHwB42T1/HDcbwZ/ s1XY4exoe38bwWRtAbwSAZKZIADm4YxKytfKYm7H7cOfExzBQLeqodoRXQCM+ZUtlBSv zLbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=cJ0W+T7L9RLfmGOECmj4FOHP1aQbW/tZqOJPACYECD0=; b=sChAscLpTQkIYKBqH91NQCinrNBk8njTnu75eJpmWU6gdwFdumXippCzdBTfssCbvq yl6Xnm6YTpGGeE/P+ayQOVMmw6vkHWJJHUJZLpw7AFAHgPmycdbTVGDqGWg36Acrxtrf 42RX/ajgMx8NIoBTtWEx72M3PHHaWOtZqO0NPMJSDaDOlBW2+IV9bDAZclXf7Mg+Lg+r lb7cK9BqFiQpo2tq0b4KnjGbl9jDWNVny0aIS+NFbsoFxfjShdXU0uv+fdoqVbT9vCx0 eopZMEcoDBiqypOsXkzyFgzg6paDkRzkPBS9VXAFl3XYJVWsX3rq5Hh65NfLoEzOiz3r bkQw== X-Gm-Message-State: AODbwcDYGh7ttvFeErxTn3uXkWwzbn+nFE5mjxGYUtlx7CI0oTIebndv zErPTxF6UZFGIWg6PJw= X-Received: by 10.25.234.216 with SMTP id y85mr3272991lfi.25.1494946957726; Tue, 16 May 2017 08:02:37 -0700 (PDT) Received: from arirop ([2001:2003:54fb:ca31:890:24b1:a54b:53e5]) by smtp.gmail.com with ESMTPSA id h67sm391731lfh.24.2017.05.16.08.02.36 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 May 2017 08:02:36 -0700 (PDT) From: Ari Roponen Date: Tue, 16 May 2017 18:02:35 +0300 Message-ID: <87k25g975g.fsf@arirop> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This code should draw a horizontal line: (require 'svg) (let ((svg (svg-create 50 50 :stroke-color "black"))) (svg-line svg 0 25 50 25) (svg-insert-image svg)) but it draws a diagonal one instead. The following patch fixes the problem. * lisp/svg.el (svg-line): Use correct parameters. diff --git a/lisp/svg.el b/lisp/svg.el index cb924f8163..fc1a6d60e1 100644 --- a/lisp/svg.el +++ b/lisp/svg.el @@ -107,8 +107,8 @@ svg-line svg (dom-node 'line `((x1 . ,x1) - (x2 . ,y1) - (y1 . ,x2) + (x2 . ,x2) + (y1 . ,y1) (y2 . ,y2) ,@(svg--arguments svg args))))) From unknown Sun Jun 22 07:36:41 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ari Roponen Subject: bug#26953: closed (Re: bug#26953: [PATCH] 26.0.50; svg-line uses incorrect parameters) Message-ID: References: <87k25g975g.fsf@arirop> X-Gnu-PR-Message: they-closed 26953 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 26953@debbugs.gnu.org Date: Sun, 21 May 2017 00:16:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1495325762-3316-1" This is a multi-part message in MIME format... ------------=_1495325762-3316-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #26953: [PATCH] 26.0.50; svg-line uses incorrect parameters which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 26953@debbugs.gnu.org. --=20 26953: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26953 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1495325762-3316-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 26953-done) by debbugs.gnu.org; 21 May 2017 00:15:25 +0000 Received: from localhost ([127.0.0.1]:57517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCEWr-0000qj-IT for submit@debbugs.gnu.org; Sat, 20 May 2017 20:15:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCEWq-0000qW-4B for 26953-done@debbugs.gnu.org; Sat, 20 May 2017 20:15:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCEWj-0008Ew-Nh for 26953-done@debbugs.gnu.org; Sat, 20 May 2017 20:15:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCEWj-0008Es-KT for 26953-done@debbugs.gnu.org; Sat, 20 May 2017 20:15:17 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dCEWj-00027V-7T; Sat, 20 May 2017 20:15:17 -0400 From: Glenn Morris To: 26953-done@debbugs.gnu.org Subject: Re: bug#26953: [PATCH] 26.0.50; svg-line uses incorrect parameters References: <87k25g975g.fsf@arirop> X-Spook: explosion Telecommunications bullion Critical X-Ran: AS_7~C)~\WeJX;#H/>8)!vMb7CFUe62uV%sijkLiK*Br<.9>x*MnCfid.VpL!-iuVwMT'> X-Hue: brightcyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sat, 20 May 2017 20:15:17 -0400 In-Reply-To: <87k25g975g.fsf@arirop> (Ari Roponen's message of "Tue, 16 May 2017 18:02:35 +0300") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26953-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Version: 26.1 Thanks; applied as 547f78c813c. ------------=_1495325762-3316-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 May 2017 15:02:48 +0000 Received: from localhost ([127.0.0.1]:48912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAdzs-0000as-DX for submit@debbugs.gnu.org; Tue, 16 May 2017 11:02:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAdzr-0000ag-Bm for submit@debbugs.gnu.org; Tue, 16 May 2017 11:02:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAdzl-0008EW-Jh for submit@debbugs.gnu.org; Tue, 16 May 2017 11:02:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36521) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dAdzl-0008ES-HE for submit@debbugs.gnu.org; Tue, 16 May 2017 11:02:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAdzk-0004V9-IV for bug-gnu-emacs@gnu.org; Tue, 16 May 2017 11:02:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAdzj-0008EA-RG for bug-gnu-emacs@gnu.org; Tue, 16 May 2017 11:02:40 -0400 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:35000) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dAdzj-0008Du-KP for bug-gnu-emacs@gnu.org; Tue, 16 May 2017 11:02:39 -0400 Received: by mail-lf0-x22d.google.com with SMTP id j1so21371868lfh.2 for ; Tue, 16 May 2017 08:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=cJ0W+T7L9RLfmGOECmj4FOHP1aQbW/tZqOJPACYECD0=; b=jJraf1KrpBvZJJU6l6Bp3R/e02UcmJoa22WiZr4Ki3ApQSp4AKTcpGbRK6fCKBSGj9 xdc3hbcw9uxgdPoMY8EYAjLQjPdm2jIiib0AzqloopZYH6VYlFvc0zE9ofqSO+oI6R7i zymELBh28lZkoBpge0NhXYZ3ITvZ64LwjPhXXKeACJeTeT/xLIRJpT/Li2D8iN4v0Y3Z gDMojZ3PWDZw33jZ6NWki2SwM+4RFLgf+Mt8cKfHh8RIhWOXSQJZhHwB42T1/HDcbwZ/ s1XY4exoe38bwWRtAbwSAZKZIADm4YxKytfKYm7H7cOfExzBQLeqodoRXQCM+ZUtlBSv zLbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=cJ0W+T7L9RLfmGOECmj4FOHP1aQbW/tZqOJPACYECD0=; b=sChAscLpTQkIYKBqH91NQCinrNBk8njTnu75eJpmWU6gdwFdumXippCzdBTfssCbvq yl6Xnm6YTpGGeE/P+ayQOVMmw6vkHWJJHUJZLpw7AFAHgPmycdbTVGDqGWg36Acrxtrf 42RX/ajgMx8NIoBTtWEx72M3PHHaWOtZqO0NPMJSDaDOlBW2+IV9bDAZclXf7Mg+Lg+r lb7cK9BqFiQpo2tq0b4KnjGbl9jDWNVny0aIS+NFbsoFxfjShdXU0uv+fdoqVbT9vCx0 eopZMEcoDBiqypOsXkzyFgzg6paDkRzkPBS9VXAFl3XYJVWsX3rq5Hh65NfLoEzOiz3r bkQw== X-Gm-Message-State: AODbwcDYGh7ttvFeErxTn3uXkWwzbn+nFE5mjxGYUtlx7CI0oTIebndv zErPTxF6UZFGIWg6PJw= X-Received: by 10.25.234.216 with SMTP id y85mr3272991lfi.25.1494946957726; Tue, 16 May 2017 08:02:37 -0700 (PDT) Received: from arirop ([2001:2003:54fb:ca31:890:24b1:a54b:53e5]) by smtp.gmail.com with ESMTPSA id h67sm391731lfh.24.2017.05.16.08.02.36 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 May 2017 08:02:36 -0700 (PDT) From: Ari Roponen To: bug-gnu-emacs@gnu.org Subject: [PATCH] 26.0.50; svg-line uses incorrect parameters Date: Tue, 16 May 2017 18:02:35 +0300 Message-ID: <87k25g975g.fsf@arirop> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This code should draw a horizontal line: (require 'svg) (let ((svg (svg-create 50 50 :stroke-color "black"))) (svg-line svg 0 25 50 25) (svg-insert-image svg)) but it draws a diagonal one instead. The following patch fixes the problem. * lisp/svg.el (svg-line): Use correct parameters. diff --git a/lisp/svg.el b/lisp/svg.el index cb924f8163..fc1a6d60e1 100644 --- a/lisp/svg.el +++ b/lisp/svg.el @@ -107,8 +107,8 @@ svg-line svg (dom-node 'line `((x1 . ,x1) - (x2 . ,y1) - (y1 . ,x2) + (x2 . ,x2) + (y1 . ,y1) (y2 . ,y2) ,@(svg--arguments svg args))))) ------------=_1495325762-3316-1--