GNU bug report logs - #26908
Fwd: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26908 in the body.
You can then email your comments to 26908 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jean-Christophe Helary <jean.christophe.helary <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Fwd: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification
Date: Sat, 13 May 2017 22:36:11 +0900

[Message part 1 (text/plain, inline)]

Since nobody reacted in the last 3 days, I guess that means there is nothing to change, so I'm sending the patch here.

Jean-Christophe 

> Begin forwarded message:
> 
> From: Jean-Christophe Helary <jean.christophe.helary <at> gmail.com>
> Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification
> Date: May 10, 2017 23:26:04 GMT+9
> To: Emacs developers <emacs-devel <at> gnu.org>
> 
> Hopefully last fixes.
> 
> I've added the \\(?: ... \\) parens to make sure we capture any potential issue with \|.
> 
> Is there anything else I've missed ?
> 
> Jean-Christophe 
> 
> 
> ===========================
> Add optional regexps for subr-x.el trimming functions
> 
> * lisp/emacs-lisp/subr-x.el (string-trim-left, string-trim-right, string-trim): add optional regexps that default on the original behavior.
> ===========================
> 
> 
> 

[Message part 2 (text/html, inline)]

[subr-x.el.diff (application/octet-stream, attachment)]

[Message part 4 (text/html, inline)]

Message #8 received at 26908 <at> debbugs.gnu.org (full text, mbox):

From: Jean-Christophe Helary <jean.christophe.helary <at> gmail.com>
To: 26908 <at> debbugs.gnu.org
Cc: emacs-devel <emacs-devel <at> gnu.org>
Subject: Re: bug#26908: Fwd: Trimming strings,
 /emacs/lisp/emacs-lisp/subr-x.el modification
Date: Wed, 17 May 2017 07:21:19 +0900

[Message part 1 (text/plain, inline)]

Nobody is interested in checking/commiting that ? If it's something I should not have touched in the first place, please somebody tell me to drop it...

Jean-Christophe

> On May 13, 2017, at 22:36, Jean-Christophe Helary <jean.christophe.helary <at> gmail.com> wrote:
> 
> Since nobody reacted in the last 3 days, I guess that means there is nothing to change, so I'm sending the patch here.
> 
> Jean-Christophe 
> 
>> Begin forwarded message:
>> 
>> From: Jean-Christophe Helary <jean.christophe.helary <at> gmail.com <mailto:jean.christophe.helary <at> gmail.com>>
>> Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification
>> Date: May 10, 2017 23:26:04 GMT+9
>> To: Emacs developers <emacs-devel <at> gnu.org <mailto:emacs-devel <at> gnu.org>>
>> 
>> Hopefully last fixes.
>> 
>> I've added the \\(?: ... \\) parens to make sure we capture any potential issue with \|.
>> 
>> Is there anything else I've missed ?
>> 
>> Jean-Christophe 
>> 
>> 
>> ===========================
>> Add optional regexps for subr-x.el trimming functions
>> 
>> * lisp/emacs-lisp/subr-x.el (string-trim-left, string-trim-right, string-trim): add optional regexps that default on the original behavior.
>> ===========================
>> 
>> 
> <subr-x.el.diff>
>> 

[Message part 2 (text/html, inline)]

Message #11 received at 26908 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jean-Christophe Helary <jean.christophe.helary <at> gmail.com>
Cc: 26908 <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: Re: bug#26908: Fwd: Trimming strings,
 /emacs/lisp/emacs-lisp/subr-x.el modification
Date: Wed, 17 May 2017 05:26:31 +0300

> From: Jean-Christophe Helary <jean.christophe.helary <at> gmail.com>
> Date: Wed, 17 May 2017 07:21:19 +0900
> Cc: emacs-devel <emacs-devel <at> gnu.org>
> 
> Nobody is interested in checking/commiting that ?

I usually wait for a week at least, to let people comment.  So please
be a bit more patient.

Thanks for working on this.

Message #14 received at 26908 <at> debbugs.gnu.org (full text, mbox):

From: Jean-Christophe Helary <jean.christophe.helary <at> gmail.com>
To: 26908 <at> debbugs.gnu.org
Cc: emacs-devel <emacs-devel <at> gnu.org>
Subject: Re: bug#26908: Fwd: Trimming strings,
 /emacs/lisp/emacs-lisp/subr-x.el modification
Date: Wed, 17 May 2017 12:41:05 +0900

Thank you Eli. I was not aware of the procedure. I have no problem waiting :)

JC

> On May 17, 2017, at 11:26, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Jean-Christophe Helary <jean.christophe.helary <at> gmail.com>
>> Date: Wed, 17 May 2017 07:21:19 +0900
>> Cc: emacs-devel <emacs-devel <at> gnu.org>
>> 
>> Nobody is interested in checking/commiting that ?
> 
> I usually wait for a week at least, to let people comment.  So please
> be a bit more patient.
> 
> Thanks for working on this.

Message #19 received at 26908-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jean-Christophe Helary <jean.christophe.helary <at> gmail.com>
Cc: 26908-done <at> debbugs.gnu.org
Subject: Re: bug#26908: Fwd: Trimming strings,
 /emacs/lisp/emacs-lisp/subr-x.el modification
Date: Fri, 19 May 2017 14:30:00 +0300

> From: Jean-Christophe Helary <jean.christophe.helary <at> gmail.com>
> Date: Sat, 13 May 2017 22:36:11 +0900
> 
> Since nobody reacted in the last 3 days, I guess that means there is nothing to change, so I'm sending the patch here.

Thanks, pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.