GNU bug report logs - #26903
[PATCH] gnu: admin: add nnn.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Ethan R. Jones" <doubleplusgood23 <at> gmail.com>
Subject: bug#26903: closed (Re: bug#26903: [PATCH] gnu: admin: add nnn.)
Date: Sat, 13 May 2017 16:00:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#26903: [PATCH] gnu: admin: add nnn.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 26903 <at> debbugs.gnu.org.

-- 
26903: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26903
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: "Ethan R. Jones" <doubleplusgood23 <at> gmail.com>, 26903-done <at> debbugs.gnu.org
Cc: "Ethan R. Jones" <doubleplusgood23 <at> gmail.com>
Subject: Re: bug#26903: [PATCH] gnu: admin: add nnn.
Date: Sat, 13 May 2017 17:58:57 +0200

[Message part 3 (text/plain, inline)]

Hello Ethan!

Thanks for this patch! I updated the commit message to follow the
ChangeLog-style convention we use, and did some slight editorialisation:

@@ -2134,11 +2134,11 @@ you are running, what theme or icon set you are using, etc.")
 (define-public nnn
   (package
     (name "nnn")
-    (version "v1.1")
+    (version "1.1")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://github.com/jarun/nnn/"
-                                  "archive/" version ".tar.gz"))
+                                  "archive/v" version ".tar.gz"))
               (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
@@ -2174,10 +2174,9 @@ you are running, what theme or icon set you are using, etc.")
         "CC=gcc")))
     (home-page "https://github.com/jarun/nnn")
     (synopsis "Terminal file browser")
-    (description "nnn is a fork of noice, a blazing-fast lightweight
-terminal file browser with easy keyboard shortcuts for navigation,
-opening files and running tasks.  noice is developed considering
-terminal based systems.  There is no config file and mime associations
-are hard-coded.  However, the incredible user-friendliness and
-speed make it a perfect utility on modern distros.")
+    (description "@command{nnn} is a fork of @command{noice}, a blazing-fast
+lightweight terminal file browser with easy keyboard shortcuts for
+navigation, opening files and running tasks.  There is no config file and
+mime associations are hard-coded.  The incredible user-friendliness and speed
+make it a perfect utility on modern distros.")
     (license license:bsd-2)))

Pushed as a76ca052d6e772164586bb1b4b2b8c69af783666 !

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: "Ethan R. Jones" <doubleplusgood23 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: "Ethan R. Jones" <doubleplusgood23 <at> gmail.com>
Subject: [PATCH] gnu: admin: add nnn.
Date: Sat, 13 May 2017 01:00:43 -0400

---
 gnu/packages/admin.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index ff0431999..d16ef77df 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2130,3 +2130,54 @@ logo, or any ASCII file of your choice.  The main purpose of Neofetch is to be
 used in screenshots to show other users what operating system or distribution
 you are running, what theme or icon set you are using, etc.")
     (license license:expat)))
+
+(define-public nnn
+  (package
+    (name "nnn")
+    (version "v1.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/jarun/nnn/"
+                                  "archive/" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1hww4385f81lyy30fx2rb4wchfi79dpgl7yylnfxvf27a4h2mkhm"))))
+    (build-system gnu-build-system)
+    (inputs `(("ncurses" ,ncurses)
+              ("readline" ,readline)))
+    (arguments
+     '(#:tests? #f ; no tests
+       #:phases
+       ;; We do not provide `ncurses.h' within an `ncursesw'
+       ;; sub-directory, so patch the source accordingly.  See
+       ;; <http://bugs.gnu.org/19018>.
+       ;; Thanks to gtypist maintainer.
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-curses-lib
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* "Makefile"
+                 (("-lncursesw")
+                  "-lncurses"))
+               (substitute* "nnn.c"
+                 (("ncursesw\\/curses.h")
+                  "ncurses.h")))
+             #t))
+         (delete 'configure))
+       #:make-flags
+       (list
+        (string-append "PREFIX="
+                       (assoc-ref %outputs "out"))
+        (string-append "-Wl,-rpath="
+                       %output "/lib")
+        "CC=gcc")))
+    (home-page "https://github.com/jarun/nnn")
+    (synopsis "Terminal file browser")
+    (description "nnn is a fork of noice, a blazing-fast lightweight
+terminal file browser with easy keyboard shortcuts for navigation,
+opening files and running tasks.  noice is developed considering
+terminal based systems.  There is no config file and mime associations
+are hard-coded.  However, the incredible user-friendliness and
+speed make it a perfect utility on modern distros.")
+    (license license:bsd-2)))
-- 
2.12.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.