From debbugs-submit-bounces@debbugs.gnu.org Thu May 11 19:35:21 2017 Received: (at submit) by debbugs.gnu.org; 11 May 2017 23:35:21 +0000 Received: from localhost ([127.0.0.1]:39397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8xc8-0000y9-SQ for submit@debbugs.gnu.org; Thu, 11 May 2017 19:35:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8xc6-0000xh-58 for submit@debbugs.gnu.org; Thu, 11 May 2017 19:35:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8xby-0000rW-Fd for submit@debbugs.gnu.org; Thu, 11 May 2017 19:35:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: *** X-Spam-Status: No, score=3.3 required=5.0 tests=BAYES_50, RECEIVED_FROM_WINDOWS_HOST,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8xby-0000rP-BY for submit@debbugs.gnu.org; Thu, 11 May 2017 19:35:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8xbv-0002Mm-Kq for bug-gnu-emacs@gnu.org; Thu, 11 May 2017 19:35:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8xbr-0000mP-K3 for bug-gnu-emacs@gnu.org; Thu, 11 May 2017 19:35:07 -0400 Received: from mail-sy3aus01on0124.outbound.protection.outlook.com ([104.47.117.124]:13152 helo=AUS01-SY3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8xbq-0000jf-Kg for bug-gnu-emacs@gnu.org; Thu, 11 May 2017 19:35:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenpointcomms.onmicrosoft.com; s=selector1-tenpoint-co-nz; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=utr40iAp850VJInJBck/U8ywDvNcsQnERxA6aQN9RNE=; b=T0vFM1lft6K6zX4PGeoHKJxGl+rtYn0Q1veXDKXwN6uTQOosATzEi2XBohtbC4pGLkWQ8VNUMJmN2lI2AJDeHAQxveU2oK0FEkxWWIUGGEJ7e66lmIq97Zx2YUtcH7/Fh8MtP45dONZP2WYyYi2bO304gDKhWmJ79jHy1D3ElHg= Authentication-Results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=tenpoint.co.nz; Received: from jupiter.local (125.239.122.5) by ME1PR01MB0961.ausprd01.prod.outlook.com (10.169.166.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Thu, 11 May 2017 23:34:55 +0000 From: Nick Helm User-agent: mu4e 0.9.18; emacs 25.2.1 To: Subject: 25.2; whitespace-mode does not turn off correctly Date: Fri, 12 May 2017 11:34:33 +1200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [125.239.122.5] X-ClientProxiedBy: ME1PR01CA0098.ausprd01.prod.outlook.com (10.171.8.31) To ME1PR01MB0961.ausprd01.prod.outlook.com (10.169.166.19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e3893db-eead-437a-eaf2-08d498c654a1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075); SRVR:ME1PR01MB0961; X-Microsoft-Exchange-Diagnostics: 1; ME1PR01MB0961; 3:QMIDT5KRUazPJeF8/tEE5Mzf9kGsQM+/BFHdENBemp9C70/GDBH8P6nY9k6dEPVeY9CUqb+ekq6zs+UvzvSvxCHFiy0AbQTFddaQO5cyO1OG0/BDIis2qUpTjBeApCeVvaE0rFxywbqa47fOtWi38/IQTwLdD3WHLzkyNLRvEVp27aTNyntJ6Dfv1l1jxV94KGd/tdQpI19ZJ3QosiPBHxfY2QrqnMXKxZKI5qz+RSXGK0chQ6q37whQiUMwNwTS3P6fAhe9KHO9v8meJhSbNmKOYC7t1cIUL0ZEZNeXslw=; 25:L/0mNGcQ8wvp9F7uyh1JIYn89yiLqYv7qp71MnQzb0Urlqi0/p/Cr8d16LEdpIq+s2B4a+TAMfAirznYfD+kaPMvrL24phGlhQ97M7yqv4K9KlHPd6IHRqtYAmXrko6mYTwhRq6upSnQY5g30MPeyptN3U8k3oEnZbePxuKGiDgQFFUKih7TqOV0YTqxTUFQerti+v2RyIBxCQdGfO9IftAda3Vs/Q9zrywgwvCSe5+HxPjWDaNStis0DtuhPCh9WmGUQNNETlVqMPsykLAZid9faFmxVDdp2Mbxq6Izrs0GyqNoP2PIQYH9jOzYy+4n3vY6VjVsQWWNrlpG/5wqZkwDCknBOYne7w5q0p6wpavGq4AjeDLpNq6sxh9pVqsoPC71Fg0VKzWy24sDLzcp+gzHbKn2D1Tkm3RPS+gM8DrGKRH7zmPhhLFIdLHthhMYWULKr89Pd3+StzC7YO0S0G4cQ1ehZA4SgPINb17PACE= X-Microsoft-Exchange-Diagnostics: 1; ME1PR01MB0961; 31:cPDo6cccmO81TGJo9IAjRKJ1j+E3A7b9Kvmsc/BbQAmMbz7TbJ/5RHZ9AXHGdBBgX6HPGProS7bQVKoshPiR4b9zxhfk6GVV4nvkGhB3a2b+lilLGUf/BzEzxJktuFCCbb72oLRCxrrXG3VJMYrAdH3zFVqSAnql4D4UVv/TY+x7n8M5THuRYlKm12ntLspU8gJz/+w2YyY3wVfqeB+UJpCb1p7qw+ZLPiyaXamyLAffefpfnpjeW+NBr8X8vSw6cnPk4hjf85Yra8Zx/DwlOw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(20161123558100)(20161123560025)(2016111802025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(6043046)(6072148); SRVR:ME1PR01MB0961; BCL:0; PCL:0; RULEID:; SRVR:ME1PR01MB0961; X-Microsoft-Exchange-Diagnostics: 1; ME1PR01MB0961; 4:2VlYiZPcyjDKH0J1oYYTcp4amjV+Xc7s1d1DF6zWtQylMY5Sq9a0k01Q9D/1PKT15oxklck5f5apeHD1bnE9TAFLUFvrqiltIlAaqH61MNMIikQIjnp88kZ8XsceOlFrWto62JngqOzf5X8i01XEKTGKhhHUHwI2RCzYPuyXq6UTzqy6BPdjwRj2ysZsqRKN0AHZGQ2FQOueNddFzN5JUkBqzdF5snfnw0oLM+aIV0eTENkObHy5PhRANzgrFsc+wm14BXLUzoWtkKX3xxV5Usqm6QBp6keOuER65iAEB5F24ix5nPndOOGKy9kvVLh5Pm8K1qkUgoMWd7OBUFKe/HQVQZIXQ0qBuixBTZFx3stcb2md4fn2yHEGNcIyO1LJN4VD2/PN+0EEVCv2AsQOQDZhDbJy6pTt0Em7c/hsimc6ZpxwcHZdOwScAltBv2Zu7Z3mATb2K3b0EoovyO29aak9yQKTovZrIdfJZ9sJUur+QE/SDIGzzg6GsdM7fHahnJSX2mxeyxr4TlHWfG60zlvgGH6ldXxoE0Smk4BDg9K/rrsZpMy6wMDuW0M9zTvtSr3z82FEk/6bi+nMDdDULDEpRKXBp+ycAWyhIyHBLb0nAD/bdjXdvF0bw4+A4WQi+eZXtk1+zWHS55mFpfwi9AovDGmYriLjySafCND8S8CypdwZWlTQst8xnYI5gtYUhCl9gZQqyEpURt9c0LwHJnKfvrS7t6HLmqomGCgnA+4Sf6rGg3EPBBEbegx32nWkUApZSDEEQoZ4oQn3CYQM5TbmnFb1Y48vbiqxKw2FCABgyQW4rku4LeF1KBOwgvkc X-Forefront-PRVS: 0304E36CA3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39410400002)(39400400002)(39830400002)(39450400003)(377424004)(81166006)(551544002)(6512007)(25786009)(189998001)(6486002)(5890100001)(6506006)(86362001)(8676002)(478600001)(36756003)(3846002)(74482002)(6116002)(54356999)(50986999)(5003940100001)(33646002)(66066001)(53936002)(110136004)(38730400002)(6666003)(42186005)(2906002)(42882006)(6916009)(5660300001)(50466002)(48376002)(7736002)(47776003)(305945005)(2351001); DIR:OUT; SFP:1102; SCL:1; SRVR:ME1PR01MB0961; H:jupiter.local; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; ME1PR01MB0961; 23:5gtLI8IpmUCNRdHVX9e73gPbi6iQr5BOc9AI+0ANR?= =?us-ascii?Q?d3tO7q/R8AGJrCncKX2fgj6Xxdhu4IMCZqRhNBtx5QH0VU3ILJ96/HvFAQQD?= =?us-ascii?Q?zNUu3Qmb3DoL4qg0V9GY/MwPUFE1sVtmqkoomua71+QzblBJv5OLgci7XmJf?= =?us-ascii?Q?BHC4Z5TWphezHYGqV/VPHG3KYds7eWiIHVLi6ogFiLXqfeOgJi3n3jF82251?= =?us-ascii?Q?uGVTTZWlzNddqdBqKVCbEAYxbITPjyROxoUfxSiKa0J2LoQ9PdbSpcQX5vib?= =?us-ascii?Q?DB5Dj6/avqq0+XBSWny4mL5jVyzlBOKc/V3uREiC5mwVjz4jLWQvZhlxKYao?= =?us-ascii?Q?G7oMqEX5CYkAnTXM/7ziT1lY+iMHYT2nxR9JjPKJTx2dmZ1dIcjZn7c90ELC?= =?us-ascii?Q?nbursgFYdo72zdUN3JJh1CjpIvSIeelNfWi76Gmfn8XKguhOjduWhpOymLtP?= =?us-ascii?Q?O+s+IT9GuLua+/s/L8V1fJOblSdI0r1x0pFVcgAwi837Jkb5cNmqguKHoqeb?= =?us-ascii?Q?4yluya0h7CoGHNjrfww55uS1XazXTadcCLebJMfXFvkGNs2HN6PywrZ4WCWA?= =?us-ascii?Q?R/68bb4EkFa8H3cCnho7R21RYY4en2Oca/vH1o8oBHi/FC8OSIMd8hWwDajJ?= =?us-ascii?Q?A9dNV6atX37d0u3IBAYAAY8PpE5SbPoz5rwP4WoNPEMQnHWrF198egnrpA8x?= =?us-ascii?Q?7WO3SEXa9uXMA16p59/ZaAJBvs0VpE7H+31/+kIACqdjqULkCq51s1jIf9oj?= =?us-ascii?Q?uVE8urZyCoJQ7VjhZGuOwCKr0dX4ZfsxTiFvJouenq6e19PVYHt5U6DwYtjG?= =?us-ascii?Q?h8+e9jMZeVMCyry1YF3R1+oAq4/Ehi/cPOiVBNjso/YEETq9HL8GZIIuJP71?= =?us-ascii?Q?gauz8SumE1zhF17whaxBn7P0qrV9XdYOpb4E31nTt1whNNtQi7IJWtMb31xz?= =?us-ascii?Q?Zd+/UPM3JknEgns4C4mSoM+R7UOUMeYJ9hcV5/N4ZvBBz/ndxIiV+9KmgusF?= =?us-ascii?Q?Cp+K0IhxGAYhYnCU285dZrqoKman3BEauRmR5dk5c8uhpzNbs61VSEI6MRTV?= =?us-ascii?Q?Q/htZAds0wiAc53lYC65xDUcm4c?= X-Microsoft-Exchange-Diagnostics: 1; ME1PR01MB0961; 6:H0S4L1rhdvta82+vALK6kojPJCxV5ZFF7EA/Q4R7iDEWVxj0twYCSsn1iPaXAsrI923cO0pV1plz02c+/5xPPQcuPht8/SrfMIwlIKND4dJ7frXH1gX+vnOHKaHcE8gF5vfOYzExK9Z+rtVDE1s0bkRKMBZgPmlKCPUdTYtotwodCUhzqSvwGQ09w+gAgAJJYgVnGc8eVxQOrTa4mWOnrSORsRdP4otUaR6tFIDwnpVp+3reJ49W3mdXk52F4L455GrLr9u0HGLfdFMRhdK9JBlY/8XLVEEUUc0N7mti62Xalt8JFRs+TaZ5XiPqbZBq2oWHaYgQonhRp0Hm0XfjfigzEXWjts2aHWu42jApWh4Yej3VXb9k3mr9f/zYfuz2pgSlU4+nBzptqSsSzNmVAnt1GqpfE0lRvgLVPpkVW4zLvjWXtocEkDZEaVk5so9P/j/WA8pYV/vvrFol5yXPa75Azo7ooxVZvoWeKwvVsJC5h6lcAT9V3aKC+5JoMDCEnEp8NSydghcheHFA5DYY+A==; 5:HH4SktaHg2ox4yCGHNwjD3jaVn57SeoG6hh3U2+zK5ZAezssvix/PRB1ODtVm7BpEJXDOYG0KaeF7IQzTUI6CAh6y/4L1K8vWR/AJ5KvlGIZwau5WHMLEAL07X4572T8oMOGuHivs9variuSN9oDMg==; 24:qTQ2Q40bhtMyyVtolzAVg21ZUwlb2cfGi4462FIjMnVrU3ZC5NmzMiSMCR6hHVcgD9+2/YErt7YxSqhvJnt7Hu8kTScT9VE8wbOZSEGPvCI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; ME1PR01MB0961; 7:r3Qpi9IY6231j8kYGRM/NZcNJBbOepJkWvKCTyWryO8+nv0SjG1Bt4cdxxVm3L+2DDVtzs+OTKiLp041SZsleNeI1LMfl3aEdDjQVMByDIRHp/QuD7/PeiUNHJZWhy7Ow+PoYO3QMqahQWLxsNAkRuBxlP+AvkJKUMi3nIsgreRswxmJRPc8+LesDkP/JsOCSBMUiRh7SuIHECxBiOa/Yi8JQGPRgshfJdDRHy7cLgQxI24aVLyvjgkLhOY0wovrzFqi0CVw01hK+VcqBuPHOX4YE0ACglTJGLrkxC1RCduOJAvEGHp+wJl+dSOy7ozGjNmR8JtB0i9yFkSlZHJo6w== X-OriginatorOrg: tenpoint.co.nz X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2017 23:34:55.4884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: ME1PR01MB0961 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Emacs -Q C-u 20 SPC RET RET RET RET ; type some random whitespace M-x global-whitespace-mode M-x whitespace-mode M-x whitespace-mode The last command should toggle local whitespace-mode off, but note that the whitespace display characters are not properly removed from the current buffer. I had a look at whitespace.el and I think the problem lies in `whitespace-display-char-on'. Among other things, this function stores the buffer display table and replaces it with a temporary display table to show whitespace chars. The original is restored when the mode is turned off. However, with global-whitespace-mode active, there is already a temporary display table in place, which whitespace-mode incorrectly picks up and stores, clobbering the original display table in the process. When whitespace-mode is turned off, it restores the temporary display table set by global-whitespace-mode, which leads to the problem. Here's a little patch to check if global-whitespace-mode is active before storing the display table. I've tried this for a few days with no obvious problems. --- whitespace-a.el 2017-05-12 00:59:34.000000000 +1200 +++ whitespace-b.el 2017-05-12 01:02:26.000000000 +1200 @@ -2496,9 +2496,10 @@ (let (vecs vec) ;; Remember whether a buffer has a local display table. (unless whitespace-display-table-was-local - (setq whitespace-display-table-was-local t - whitespace-display-table - (copy-sequence buffer-display-table)) + (setq whitespace-display-table-was-local t) + (unless global-whitespace-mode + (setq whitespace-display-table + (copy-sequence buffer-display-table))) ;; Assure `buffer-display-table' is unique ;; when two or more windows are visible. (setq buffer-display-table In GNU Emacs 25.2.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911)) of 2017-04-22 built on builder10-9.porkrind.org Windowing system distributor 'Apple', version 10.3.1504 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES Important settings: value of $LANG: en_NZ.UTF-8 locale-coding-system: utf-8-unix Major mode: Messages Minor modes in effect: recentf-mode: t savehist-mode: t ivy-mode: t global-eldoc-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t transient-mark-mode: t Recent messages: Loading /Users/nick/.emacs.d/config/mc/mc-run-once.list...done Emacs start-up time: 1.0 seconds For information about GNU Emacs and the GNU system, type C-h C-a. Loading /Users/nick/.emacs.d/config/recentf/recentf.history...done Cleaning up the recentf list...done (0 removed) user-error: The mark is not set now, so there is no region s-b is undefined [2 times] Load-path shadows: /Users/nick/.emacs.d/lisp/org/ox hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox /Users/nick/.emacs.d/lisp/org/ox-texinfo hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-texinfo /Users/nick/.emacs.d/lisp/org/ox-publish hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-publish /Users/nick/.emacs.d/lisp/org/ox-org hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-org /Users/nick/.emacs.d/lisp/org/ox-odt hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-odt /Users/nick/.emacs.d/lisp/org/ox-md hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-md /Users/nick/.emacs.d/lisp/org/ox-man hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-man /Users/nick/.emacs.d/lisp/org/ox-latex hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-latex /Users/nick/.emacs.d/lisp/org/ox-icalendar hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-icalendar /Users/nick/.emacs.d/lisp/org/ox-html hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-html /Users/nick/.emacs.d/lisp/org/ox-beamer hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-beamer /Users/nick/.emacs.d/lisp/org/ox-ascii hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ox-ascii /Users/nick/.emacs.d/lisp/org/org hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org /Users/nick/.emacs.d/lisp/org/org-w3m hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-w3m /Users/nick/.emacs.d/lisp/org/org-version hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-version /Users/nick/.emacs.d/lisp/org/org-timer hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-timer /Users/nick/.emacs.d/lisp/org/org-table hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-table /Users/nick/.emacs.d/lisp/org/org-src hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-src /Users/nick/.emacs.d/lisp/org/org-rmail hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-rmail /Users/nick/.emacs.d/lisp/org/org-protocol hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-protocol /Users/nick/.emacs.d/lisp/org/org-plot hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-plot /Users/nick/.emacs.d/lisp/org/org-pcomplete hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-pcomplete /Users/nick/.emacs.d/lisp/org/org-mouse hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-mouse /Users/nick/.emacs.d/lisp/org/org-mobile hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-mobile /Users/nick/.emacs.d/lisp/org/org-mhe hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-mhe /Users/nick/.emacs.d/lisp/org/org-macs hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-macs /Users/nick/.emacs.d/lisp/org/org-macro hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-macro /Users/nick/.emacs.d/lisp/org/org-loaddefs hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-loaddefs /Users/nick/.emacs.d/lisp/org/org-list hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-list /Users/nick/.emacs.d/lisp/org/org-irc hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-irc /Users/nick/.emacs.d/lisp/org/org-install hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-install /Users/nick/.emacs.d/lisp/org/org-inlinetask hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-inlinetask /Users/nick/.emacs.d/lisp/org/org-info hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-info /Users/nick/.emacs.d/lisp/org/org-indent hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-indent /Users/nick/.emacs.d/lisp/org/org-id hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-id /Users/nick/.emacs.d/lisp/org/org-habit hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-habit /Users/nick/.emacs.d/lisp/org/org-gnus hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-gnus /Users/nick/.emacs.d/lisp/org/org-footnote hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-footnote /Users/nick/.emacs.d/lisp/org/org-feed hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-feed /Users/nick/.emacs.d/lisp/org/org-faces hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-faces /Users/nick/.emacs.d/lisp/org/org-eshell hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-eshell /Users/nick/.emacs.d/lisp/org/org-entities hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-entities /Users/nick/.emacs.d/lisp/org/org-element hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-element /Users/nick/.emacs.d/lisp/org/org-docview hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-docview /Users/nick/.emacs.d/lisp/org/org-datetree hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-datetree /Users/nick/.emacs.d/lisp/org/org-ctags hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-ctags /Users/nick/.emacs.d/lisp/org/org-crypt hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-crypt /Users/nick/.emacs.d/lisp/org/org-compat hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-compat /Users/nick/.emacs.d/lisp/org/org-colview hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-colview /Users/nick/.emacs.d/lisp/org/org-clock hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-clock /Users/nick/.emacs.d/lisp/org/org-capture hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-capture /Users/nick/.emacs.d/lisp/org/org-bibtex hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-bibtex /Users/nick/.emacs.d/lisp/org/org-bbdb hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-bbdb /Users/nick/.emacs.d/lisp/org/org-attach hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-attach /Users/nick/.emacs.d/lisp/org/org-archive hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-archive /Users/nick/.emacs.d/lisp/org/org-agenda hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/org-agenda /Users/nick/.emacs.d/lisp/org/ob hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob /Users/nick/.emacs.d/lisp/org/ob-tangle hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-tangle /Users/nick/.emacs.d/lisp/org/ob-table hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-table /Users/nick/.emacs.d/lisp/org/ob-sqlite hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-sqlite /Users/nick/.emacs.d/lisp/org/ob-sql hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-sql /Users/nick/.emacs.d/lisp/org/ob-shen hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-shen /Users/nick/.emacs.d/lisp/org/ob-screen hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-screen /Users/nick/.emacs.d/lisp/org/ob-scheme hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-scheme /Users/nick/.emacs.d/lisp/org/ob-scala hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-scala /Users/nick/.emacs.d/lisp/org/ob-sass hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-sass /Users/nick/.emacs.d/lisp/org/ob-ruby hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-ruby /Users/nick/.emacs.d/lisp/org/ob-ref hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-ref /Users/nick/.emacs.d/lisp/org/ob-R hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-R /Users/nick/.emacs.d/lisp/org/ob-python hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-python /Users/nick/.emacs.d/lisp/org/ob-plantuml hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-plantuml /Users/nick/.emacs.d/lisp/org/ob-picolisp hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-picolisp /Users/nick/.emacs.d/lisp/org/ob-perl hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-perl /Users/nick/.emacs.d/lisp/org/ob-org hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-org /Users/nick/.emacs.d/lisp/org/ob-octave hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-octave /Users/nick/.emacs.d/lisp/org/ob-ocaml hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-ocaml /Users/nick/.emacs.d/lisp/org/ob-mscgen hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-mscgen /Users/nick/.emacs.d/lisp/org/ob-maxima hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-maxima /Users/nick/.emacs.d/lisp/org/ob-matlab hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-matlab /Users/nick/.emacs.d/lisp/org/ob-makefile hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-makefile /Users/nick/.emacs.d/lisp/org/ob-lob hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-lob /Users/nick/.emacs.d/lisp/org/ob-lisp hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-lisp /Users/nick/.emacs.d/lisp/org/ob-lilypond hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-lilypond /Users/nick/.emacs.d/lisp/org/ob-ledger hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-ledger /Users/nick/.emacs.d/lisp/org/ob-latex hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-latex /Users/nick/.emacs.d/lisp/org/ob-keys hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-keys /Users/nick/.emacs.d/lisp/org/ob-js hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-js /Users/nick/.emacs.d/lisp/org/ob-java hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-java /Users/nick/.emacs.d/lisp/org/ob-io hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-io /Users/nick/.emacs.d/lisp/org/ob-haskell hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-haskell /Users/nick/.emacs.d/lisp/org/ob-gnuplot hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-gnuplot /Users/nick/.emacs.d/lisp/org/ob-fortran hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-fortran /Users/nick/.emacs.d/lisp/org/ob-exp hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-exp /Users/nick/.emacs.d/lisp/org/ob-eval hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-eval /Users/nick/.emacs.d/lisp/org/ob-emacs-lisp hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-emacs-lisp /Users/nick/.emacs.d/lisp/org/ob-dot hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-dot /Users/nick/.emacs.d/lisp/org/ob-ditaa hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-ditaa /Users/nick/.emacs.d/lisp/org/ob-css hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-css /Users/nick/.emacs.d/lisp/org/ob-core hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-core /Users/nick/.emacs.d/lisp/org/ob-comint hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-comint /Users/nick/.emacs.d/lisp/org/ob-clojure hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-clojure /Users/nick/.emacs.d/lisp/org/ob-calc hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-calc /Users/nick/.emacs.d/lisp/org/ob-C hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-C /Users/nick/.emacs.d/lisp/org/ob-awk hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-awk /Users/nick/.emacs.d/lisp/org/ob-asymptote hides /Users/nick/Desktop/Emacs.app/Contents/Resources/lisp/org/ob-asymptote Features: (shadow face-remap emacsbug colir color recentf tree-widget wid-edit time em-term term disp-table ehelp esh-opt esh-ext mu4e desktop frameset mu4e-speedbar speedbar sb-image ezimage dframe mu4e-main mu4e-context mu4e-view cal-menu calendar cal-loaddefs epa derived browse-url comint ansi-color mu4e-headers mu4e-compose mu4e-draft mu4e-actions rfc2368 smtpmail sendmail mu4e-mark mu4e-message html2text mu4e-proc mu4e-utils doc-view subr-x image-mode mu4e-lists mu4e-vars message format-spec rfc822 mml mml-sec epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader hl-line cl mu4e-meta dired-x dired savehist smex ido seq counsel jka-compr esh-util etags xref project ring swiper ivy delsel ivy-overlay ffap url-parse auth-source cl-seq eieio byte-opt bytecomp byte-compile cl-extra cconv eieio-core cl-macs gnus-util mm-util help-fns help-mode mail-prsvr password-cache url-vars multiple-cursors mc-hide-unmatched-lines-mode mc-separate-operations rectangular-region-mode mc-mark-pop mc-mark-more mc-cycle-cursors mc-edit-lines multiple-cursors-core advice rect nh-posmark nh-resize nh-macdict markdown-mode thingatpt noutline outline easy-mmode easymenu iso-transl nh-tax nh-move-lines gv flyspell ispell linum plain-theme edmacro kmacro cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 291871 101436) (symbols 48 29250 0) (miscs 40 60 296) (strings 32 44032 118873) (string-bytes 1 1279925) (vectors 16 44379) (vector-slots 8 762963 80102) (floats 8 452 191) (intervals 56 708 164) (buffers 976 19)) From debbugs-submit-bounces@debbugs.gnu.org Fri May 12 02:20:12 2017 Received: (at 26892) by debbugs.gnu.org; 12 May 2017 06:20:13 +0000 Received: from localhost ([127.0.0.1]:39629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d93vw-0005ua-Nr for submit@debbugs.gnu.org; Fri, 12 May 2017 02:20:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d93vu-0005uO-PZ for 26892@debbugs.gnu.org; Fri, 12 May 2017 02:20:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d93vm-0002eR-KS for 26892@debbugs.gnu.org; Fri, 12 May 2017 02:20:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d93vm-0002eM-HL; Fri, 12 May 2017 02:20:02 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1708 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d93vl-0002u1-Tj; Fri, 12 May 2017 02:20:02 -0400 Date: Fri, 12 May 2017 09:19:52 +0300 Message-Id: <837f1ma96f.fsf@gnu.org> From: Eli Zaretskii To: Nick Helm In-reply-to: (message from Nick Helm on Fri, 12 May 2017 11:34:33 +1200) Subject: Re: bug#26892: 25.2; whitespace-mode does not turn off correctly References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26892 Cc: 26892@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Nick Helm > Date: Fri, 12 May 2017 11:34:33 +1200 > > Emacs -Q > C-u 20 SPC RET RET RET RET ; type some random whitespace > M-x global-whitespace-mode > M-x whitespace-mode > M-x whitespace-mode > > The last command should toggle local whitespace-mode off, but note that the > whitespace display characters are not properly removed from the current > buffer. > > I had a look at whitespace.el and I think the problem lies in > `whitespace-display-char-on'. Among other things, this function stores the > buffer display table and replaces it with a temporary display table to show > whitespace chars. The original is restored when the mode is turned off. > > However, with global-whitespace-mode active, there is already a temporary > display table in place, which whitespace-mode incorrectly picks up and stores, > clobbering the original display table in the process. When whitespace-mode is > turned off, it restores the temporary display table set by > global-whitespace-mode, which leads to the problem. > > Here's a little patch to check if global-whitespace-mode is active before > storing the display table. I've tried this for a few days with no obvious > problems. Did you try running whitespace-tests with this change, and if so, did they pass? If the tests pass, would you mind to please add a new test for this bug? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun May 14 20:26:37 2017 Received: (at 26892) by debbugs.gnu.org; 15 May 2017 00:26:37 +0000 Received: from localhost ([127.0.0.1]:45205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dA3qP-0007CM-0K for submit@debbugs.gnu.org; Sun, 14 May 2017 20:26:37 -0400 Received: from mail-sy3aus01on0112.outbound.protection.outlook.com ([104.47.117.112]:30641 helo=AUS01-SY3-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dA3qM-0007C5-I5 for 26892@debbugs.gnu.org; Sun, 14 May 2017 20:26:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenpointcomms.onmicrosoft.com; s=selector1-tenpoint-co-nz; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=D9QKxadRiSQmOKts+8+5fQ0FAtV7xTLxZ7EeShqpzHY=; b=CUJKnmxqQn+yBzkP/rzBIlXi3nO+UM4JUVJUWYdLJ/Adr1xzN/LjVeNSVt3se1K1C6IfHMCTmQXaCMlfPRzx2qBlB5ygzhjqDX0EoZ8bJSugBUd02piKSRE6xcMwBXViFSQdOV1ujq2lQ8UfWgvn04bv+wpftIWLZ50JX4WVxjU= Authentication-Results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=tenpoint.co.nz; Received: from jupiter.local (125.239.122.5) by SYXPR01MB0974.ausprd01.prod.outlook.com (10.169.178.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Mon, 15 May 2017 00:26:19 +0000 From: Nick Helm References: <837f1ma96f.fsf@gnu.org> User-agent: mu4e 0.9.18; emacs 25.2.1 In-Reply-To: <837f1ma96f.fsf@gnu.org> To: <26892@debbugs.gnu.org> Subject: Re: bug#26892: 25.2; whitespace-mode does not turn off correctly Date: Mon, 15 May 2017 12:26:14 +1200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Originating-IP: [125.239.122.5] X-ClientProxiedBy: SYXPR01CA0117.ausprd01.prod.outlook.com (10.171.33.154) To SYXPR01MB0974.ausprd01.prod.outlook.com (10.169.178.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8b29b404-b3a5-4f34-a786-08d49b2901ee X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075); SRVR:SYXPR01MB0974; X-Microsoft-Exchange-Diagnostics: 1; SYXPR01MB0974; 3:9D4c1mQl1QgMdumkhTO0cVCHXbWTIGyGWosvfGbuO1Fvccc8e1tO1s789bOQKH1KPDy15+Q+TD+xlKEQuOZ24wWMemIohxfgm/r1TxKdTU5zKZCyTxWmD/65IvaAlzhLpLnGcjrFiWUcYpLmtYpSAdbY5aghFNWXbOMhMmzhYtox5llrbdDLvXni196epW2u7mJl864YN9zcrNUL1Mestr2E4GepL7AT3NmCAu6lhR+HXtIlqAx+ThC3aa9yJWSq+piGWSKf13VAZEMI6r3fbMH7UGml5zmMRL5NI2Dc/sXgALVnS4GUrbtqWJAeG8Vy; 25:aX3lJ9AmTUNmx/Ql/U1gl4Zxgz3gdONk2/SQ4zR8fOWnoZiah709Qtgbf/5fGZMhe0O/OxKgDjreU4m3XrxC73XYH6vpvGE22p1FWNKAaC8fNTWpwAchmJdz/xN6P3uWgVjtWaqSy5vXsyDKAYY5e6pvp3o6OBtlmpNNiJq6lboymX0fCzpqakRy1cFAxW47TmdhuMOjNyiKki3ibTujZaeLX4ZNE+eQZ+ZpoJcqAg7NKvxGISVX4Qef8oDi+8hSvHsCFGwRUabM0k88Z12odY+qb45bp0j56Ty4DoB+4Kn8jblDb9m1Q9RUIYe+ZxQ5XzlC3b7xIp6opiveUXe7PV3ZHpsmhlRemqWYqqh0QsmgEfpZ7HwNiHGPFBQ4Fqov89j4QaOqCxfp6u1iVrM+JrrGRBg63IDZBwBj3ipqQv0eU3q/kHIcetO1nnVAaHMHJMlm8/AZpM9q94oPk6pWifkhhYKzBjqE1zdLbN19MRtnRS+MppfNhm+5bWmUxfVcyFroAxMceNyyX9K0J5z1aQ== X-Microsoft-Exchange-Diagnostics: 1; SYXPR01MB0974; 31:mKzXdc4rojdrk4b1TkFBN63dFE3G9ssT2XXIpsi8KsHnrXfXPUu0gQyRcJGwUDGye/U2OiZiljj73QI+JPYhKcGGyHFUxcHFpQyOaM+yC6Uys/xABOb/GbOfxcogEZFKTV6ozHcc6n6qCu/ykNaAWJMKtyvuqGwVZ1/iBxosjm5jbfv1gw6NrORa6vrBVMbjHJn9jfsp23X55oNasM6zklww1bth5hdyRGLFvJo1PDLpU3HRcXZThHqLKxiXLLBIYU/HmElJK7aA+VI5h/5uZrK/cpyxI6QukyoY87oXq/ao29hKjZJvEL9LoEHnIyzA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(102415395)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(6041248)(2016111802025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(6072148)(6043046); SRVR:SYXPR01MB0974; BCL:0; PCL:0; RULEID:; SRVR:SYXPR01MB0974; X-Microsoft-Exchange-Diagnostics: 1; SYXPR01MB0974; 4:YzK+qfvupsDBjVeX66AVKLINJun2whnsFlSNYwT+CP0VH39DHckZffQIkAEPL2QXcNNCuyAnhgrEnINrWrqOMYBJ/ck5YW4kYYWcRqEJq1UcDPndyQlIpyDYLxiU2zxUJjcIdKYkMNeLI8XWUD5Z7/ACxl3WaAEt6FCC8c6/IRODPCaAfN5WUY06s6Lxel95KPBwtNmQmwT/Xtiytc8MNNEjzDMRka6qCa/N7d74+6u+qdo1QD1i8Pt+tf3POFrLX5CHgRcIQcn07JG/CUMmbzYHPkahuKaVXDZMpZjA2AufgnlFZ2bekaKNmK3ETp02sMMtLMoeX+r9p+AGjpZZexjz/8pinZfYrqfkslP/SBoSYj58dhhUBCtUmMF7gzRyZsYiKDmzzsEU0eoj+U0g3LYmvR2Nyqoo0ZPXs72DVIXq7WMcMMi5XpvFeo38w71m99IvxLWEuMYTO9bXHCYbFU+d56yp5MMeWDwe75fAGm8uCcKxp3zGfXKkUR/wiKJtCfvhc1H6K2bcA1sNIZXZzL4VBz41Zu5GzsUxi5aTgSD53RMwP9r6xs8vQXHv7cAwrgKutWDPe7drv9ucv7De2jnuFrJd4mMgZ8cWlDjm7McrOMyR2kV9pYvzYhoBsMl9oXDLOHQ+w0f/BPpLSs5rpMZIVnTq5TpgIWhO0Z9mTF8qwW/pSv1oI2RCXBQg/yilIWZzPrQ7FpCijcgu64WQT3R+DcURydbezTWNcI/3WgI0yjrIuaoIqrtaGKBWCOe7soENepc65h/ejY5YprCWdLkwJQkLJjP6jcgLqRk6H9lseRs+dFszJGcO6w0+/TnEsucwtFU2RNPqOM2RQ5hNjA== X-Forefront-PRVS: 0308EE423E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39830400002)(39410400002)(39450400003)(39400400002)(8676002)(5890100001)(81166006)(6506006)(6246003)(5660300001)(6486002)(6512007)(84326002)(25786009)(4610100001)(86362001)(83506001)(6666003)(305945005)(5000100001)(4810100001)(6916009)(42882006)(2950100002)(7736002)(36756003)(4326008)(478600001)(42186005)(66066001)(2906002)(3846002)(6116002)(568964002)(2351001)(189998001)(50986999)(76176999)(38730400002)(110136004)(53936002)(33646002)(54356999)(74482002)(4001350100001); DIR:OUT; SFP:1102; SCL:1; SRVR:SYXPR01MB0974; H:jupiter.local; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SYXPR01MB0974; 23:B9stpXkRqtacmY3t0DHqXJStb8K+EGfSXR2q8TzhO?= =?us-ascii?Q?9XEpVx4XFN6XRY33okfET8NUOUluwIMxPmdAcE+ctjCHogkBFivzEtm1oXYB?= =?us-ascii?Q?7J8AA6v/zofRov6MHN2J8Tkq8oB3+gIZqSCbaT2wrKlmPNNgL+fKH7lIu1ZU?= =?us-ascii?Q?18ea7MbiVVNbJiDhmUQiW8NlI2BPlSClicui+t8cJWZnjqAHg9YDK0LSVYBZ?= =?us-ascii?Q?8QKwV2s415vVahpaRZkeBYmapKocnGlILlhy5AXJ/1awL2DqO/p9iu7rl9bZ?= =?us-ascii?Q?k9zpKExOTXoRhkwBVLpqI9ylt+wJkcgqcF4YSwZEVCMKIWB0T5YILVLMlWx7?= =?us-ascii?Q?vgIEPlrml2av9Em3XAVP1ctDrilB12CNYolHq/TlorQV8x34WP34ERpJnQ9T?= =?us-ascii?Q?1aqDc/kgjZk+i0JMaanbUmu3S2QMc3pqvF0eKx+tsSvU0MoaHAxkgtpsLhNZ?= =?us-ascii?Q?Rdibfja+UUqzI77sbdKU/1ed13MMfz90usYTxLY8FRDkkT3PtnFD9oh+1xuR?= =?us-ascii?Q?9/aySkU9OQv+mmSM7BRFvXRr3oWSzOgIF94y0B3PHKoDt6WfER65+W0gmWU2?= =?us-ascii?Q?0iEI6nQouCfFPKRQV1ottpWJ2USwBpe7MrdpmtmhTpYVbpLTBmWrOrebaz/C?= =?us-ascii?Q?7Q3uC0SSd+/+f0i1Hq4dufCWcWYj2tS27FSkf66SE8Uezc7tRNLQC9Zi1z20?= =?us-ascii?Q?LEolvuFpcgHsgAWe63FTDf5KJ2VTjcW5L9xvwWRJ13/K6G9rV0pDX1sYFWZL?= =?us-ascii?Q?WgBs32btBDNw26fmLz9UFEFGCrebyFmNpy/ZICbboNVmPHqR4Qh/3A/Jm0uM?= =?us-ascii?Q?nzBrWj1ga460z6/0CN+PQjUjgfMgYRcyv/utm1hUX3/b0XfxsQw436LmpP3f?= =?us-ascii?Q?In1k0EJF9nk+qJ6XNxMJgGy8xR2Zyg370pZlHnTz76QtlEmT60X+oqefffGp?= =?us-ascii?Q?nkJuPKqAlKmmhzRsygRZHMdPEzyxcKnTguC9Y7BtgBQQ8AkEwx6A4A0Rzzb+?= =?us-ascii?Q?FRs+4VO8ZUuH8OqNoVeW/TgPDOREZDgWX/GtGwUZJ9xIQnC3rdX8VOP67088?= =?us-ascii?Q?DvrIjqSUwyqeatETF0gbiS+HkHLtFC5WY2tOgye2cCLSfKYtA5Ehc14V4Pg1?= =?us-ascii?Q?0hxG1btyn1MmQApkNJbUzsuVocLttvR20Lrl9g7jxeISkB8CjV2oN6D+x2jF?= =?us-ascii?Q?zbCMMCMNKDCfpI=3D?= X-Microsoft-Exchange-Diagnostics: 1; SYXPR01MB0974; 6:itWzMH3KzJx+gHaodZWWA4ISLTm6B1asESV8lP2PMkOdNmdfmidvqKiN5YLmrowi53hLz+GVWWhQJ7Wz41VZ+uG3ePW7LrgxQ62APm+iSgzX9ljFRyZdIvLdkH2n+fCs5vCBvBEbnEdlYqCs1JFcqBOaQ7BUD8jPTTvdWTXpdV6vLu3IQzMDrMdOCOO2S0rMfkfaSE9q8d0/d2BOlyi1cZa/vitj/dy1ocVsRZ7hQCtw5NaYlyE+mU1obN6bOVn5cU4RV0WgqCLeOOAS4EbOxoNSBcDC35IFtoGV4ICrj6sMrKgownhZsHpvS9FZIvme6u74YNQlteouHA3E4JsT5+7iqizA52RelelHdFGwVWZhr3dkj7bkEqwyrfPn7UmjShekVNPT+/G80QraFiAEz81xYpWAv0mEX+ZUxIJgCemmAKTPP1VgzmrOeKdXtX3hps/LQNCS3iMhbGskuGeCMqaVIkVmXzt+JjW7gSn3dEKijdXIcRHkzD5Jo/0l9BlaRSjZpfBL6h+B49Gljt5yWg==; 5:HaxEm5U6WCoAQ57YfRkYunhADA7kR7qaB0RO4MS9mY2OZcs5azy2O9Fmsug5puvyMQ/Q0HO0DotxsMVxcSCfOGzQ8LnK5szT1dCS624IFMJ79Jre6yK5/Bvw5FoO+Xi4XD9z6qFz7Ripfkw/sZDm1Q==; 24:hvTqwEHa5ymXBBynMMSrgM4IZ2gZLkePf4HiRt2W/weT62RzyvstYdIKjHl0UMrMezMTm0m4ypIY6AvQdlF4jQCmAWBupasEupR3uIEPMW8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SYXPR01MB0974; 7:kPV6NuO1juPI4wruOrwiFbeI57vQTFsZ5D5e8tYd1p4O4g0xwaLylFteKch6TCSRHq/hohwVjju1kwEixUHj3LHIuZv0hycg7ghCnwA9ucotq+VLMsXjmmzdJABFaLEdYv+FZIawoIladyuWMeQshYwWdphROdGObk3eRaDaBC1Wnb1a4ejFL6sH782DNaW011sg0nLY3/XSvHIHLm/02nv3wkFyjvEpILLGRM0iq4aBm4hMStJCf3lLp/udyc6efOF7w5Oz9F0q10t8exaBUie4Z/jAFh6wXGKEfux+ZUYnbrd2Ayz0IrR4jwMXZ4KID2EoLVto3SOXb3ppexYczA== X-OriginatorOrg: tenpoint.co.nz X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2017 00:26:19.2092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SYXPR01MB0974 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26892 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain > Did you try running whitespace-tests with this change, and if so, did > they pass? Yes, all tests pass. > If the tests pass, would you mind to please add a new test for this > bug? I've written a new test and confirmed it catches this problem. I also tweaked the original patch to handle another instance of the same bug. Patches for whitespace.el and whitespace-tests.el are attached. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename="whitespace-tests.patch" --- whitespace-tests-a.el 2017-05-12 23:11:38.000000000 +1200 +++ whitespace-tests-b.el 2017-05-15 01:55:43.000000000 +1200 @@ -47,6 +47,31 @@ (should (equal (whitespace-tests--cleanup-string "a \n\t \n\n") "a \n")))) +(ert-deftest whitespace-tests-display-tables () + "Test whitespace stores and restores the buffer display table - bug26892." + (with-temp-buffer + (whitespace-mode -1) ; turn off in case global ws mode is active + (let ((whitespace-style '(space-mark tab-mark newline-mark)) + (whitespace-display-mappings '((space-mark 32 [183] [46]) + (space-mark 160 [164] [95]) + (newline-mark 10 [36 10]) + (tab-mark 9 [187 9] [92 9]))) + (buffer-display-table nil)) + ;test the display table actually changes + (should-not (equal nil + (progn (whitespace-mode 1) + buffer-display-table))) + ;test the display table restores correctly + (should (equal nil + (progn (whitespace-mode -1) + buffer-display-table))) + ;test the stored display table is preserved + (should (equal nil + (progn (whitespace-mode 1) + (whitespace-mode 1) + (whitespace-mode -1) + buffer-display-table)))))) + (provide 'whitespace-tests) ;;; whitespace-tests.el ends here --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename="whitespace.patch" --- whitespace-a.el 2017-05-14 14:12:59.000000000 +1200 +++ whitespace-b.el 2017-05-15 01:11:30.000000000 +1200 @@ -2496,9 +2496,10 @@ (let (vecs vec) ;; Remember whether a buffer has a local display table. (unless whitespace-display-table-was-local - (setq whitespace-display-table-was-local t - whitespace-display-table - (copy-sequence buffer-display-table)) + (setq whitespace-display-table-was-local t) + (unless (or whitespace-mode global-whitespace-mode) + (setq whitespace-display-table + (copy-sequence buffer-display-table))) ;; Assure `buffer-display-table' is unique ;; when two or more windows are visible. (setq buffer-display-table --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 08:28:12 2017 Received: (at 26892-done) by debbugs.gnu.org; 19 May 2017 12:28:12 +0000 Received: from localhost ([127.0.0.1]:54519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBh0u-0000Im-73 for submit@debbugs.gnu.org; Fri, 19 May 2017 08:28:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBh0t-0000Ia-Bi for 26892-done@debbugs.gnu.org; Fri, 19 May 2017 08:28:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBh0k-0006LT-TN for 26892-done@debbugs.gnu.org; Fri, 19 May 2017 08:28:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBh0k-0006LB-QU; Fri, 19 May 2017 08:28:02 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3564 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBh0k-00074r-52; Fri, 19 May 2017 08:28:02 -0400 Date: Fri, 19 May 2017 15:27:52 +0300 Message-Id: <83mva92fqv.fsf@gnu.org> From: Eli Zaretskii To: Nick Helm In-reply-to: (message from Nick Helm on Mon, 15 May 2017 12:26:14 +1200) Subject: Re: bug#26892: 25.2; whitespace-mode does not turn off correctly References: <837f1ma96f.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26892-done Cc: 26892-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Nick Helm > CC: Eli Zaretskii > Date: Mon, 15 May 2017 12:26:14 +1200 > > I've written a new test and confirmed it catches this problem. I also > tweaked the original patch to handle another instance of the same bug. > > Patches for whitespace.el and whitespace-tests.el are attached. Thanks, pushed. A couple of notes, for the future: . The test at first failed for me, and needed some tweaking, because whitespace-mode refuses to turn on in batch mode. I guess you ran the tests in interactive mode? You should run tests in batch. . The patch was not applicable without manual editing, because it used file names like whitespace-a.el, which don't exist. Please in the future submit patches produced against the correct file names, preferably with "git diff" or somesuch. . Please include with the patch a ChangeLog-style commit log message (see CONTRIBUTE for details). . Finally, this contribution exhausts the amount of changes we can accept from you without legal paperwork, so I encourage you to start the paperwork rolling, for us to be able to accept your future contributions. (I can send you the forms off-list if you want.) Thanks again for working on this. From debbugs-submit-bounces@debbugs.gnu.org Sun May 21 19:11:29 2017 Received: (at 26892-done) by debbugs.gnu.org; 21 May 2017 23:11:29 +0000 Received: from localhost ([127.0.0.1]:59744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCa0W-0000HG-RY for submit@debbugs.gnu.org; Sun, 21 May 2017 19:11:29 -0400 Received: from mail-sy3aus01on0090.outbound.protection.outlook.com ([104.47.117.90]:45074 helo=AUS01-SY3-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCa0U-0000H2-Ib for 26892-done@debbugs.gnu.org; Sun, 21 May 2017 19:11:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenpointcomms.onmicrosoft.com; s=selector1-tenpoint-co-nz; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Tlb6KSN7JXBVtdSiCzcfYn/+obrHrPH2mfFvGPGOMKA=; b=HEjoQNCYliSUCby/WA6GmD2uMGpAMZicOIjTzaTyDqwhVSZ+WHLWOCPLMSI8N7FUR3EunzTHLlPoAt74NYeZYQru3C/xMSNXVqOpRzDixbEkLvmVwc+IdmWAW13EoW/gqhTOYVhIR7Xalq7y/6MASV7be5HKFdgRErvckxU1Kcw= Authentication-Results: debbugs.gnu.org; dkim=none (message not signed) header.d=none;debbugs.gnu.org; dmarc=none action=none header.from=tenpoint.co.nz; Received: from jupiter.local (125.239.122.5) by SY3PR01MB0971.ausprd01.prod.outlook.com (10.169.171.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Sun, 21 May 2017 23:11:14 +0000 From: Nick Helm References: <837f1ma96f.fsf@gnu.org> <83mva92fqv.fsf@gnu.org> User-agent: mu4e 0.9.18; emacs 25.2.1 In-Reply-To: <83mva92fqv.fsf@gnu.org> To: Eli Zaretskii Subject: Re: bug#26892: 25.2; whitespace-mode does not turn off correctly Date: Mon, 22 May 2017 11:11:11 +1200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [125.239.122.5] X-ClientProxiedBy: SY3PR01CA0101.ausprd01.prod.outlook.com (10.173.248.34) To SY3PR01MB0971.ausprd01.prod.outlook.com (10.169.171.22) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SY3PR01MB0971: X-MS-Office365-Filtering-Correlation-Id: e39dda7b-258e-40df-a830-08d4a09eae0c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075); SRVR:SY3PR01MB0971; X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 3:9K8m8c/UAmRoHR2PRirHHVwm9yPxfQwQWNUVj9oQZhFpxknPrTYZNJ2AlfCnZZuu0GC5XsxYiaKb4yKMDwtKRoDSbECh5OAMSZX0TNkV5UNa6lNNQQkXnrC4zD6CCD4+hJ2t91h/rbUW0jqGYgqvdjYbRgiwany1euS3NJRIhku7ph8v9HKLbBCMxPLG9IsTJuebuEWmPxZDaHLu2+CcABiGijapnlTGpvKvpzAvpptzMuNW6Iu+jVLbcJCIbMIDOK+MPybSZuRgLl6utgV4loMgdGDeB0Rdsfv6yXej2O1EyA/UiXdh2wGl074l1/fv; 25:qk4q0tI0wyJZ/N8MO+JrtxofnxUuXsrANclZ3gn5PUVWiV8djjFzel0rIClU7YZj9mWB3ZO4Cc99j80IEVLlUP3I8oYDAocN451397ePJVXgMK67yBlTIXt+E4v+HFn4QPnpT0ynrQnUw1D8Bo6O9fNRcSnuHar6eTn9mTnsDNrlwziaXnUfbPR30xsrqXOG1eEDr5UIKjEev7qLUSKCfYcqEtmZVwWhaG2+D8EqCkw5fE7U2PdPaPqpD4N9NfASjZ1s5jjoVf1DM8xPtR1BKuXMWl8YL4VvQCoAtDNDuZU5iqO1vzArmh9bbbHcP/aFozIZuG+FnG3Eo5Oaedz5Iq3HCKS6V0O+uwWsGiyiF87Vz6fbq+H9Fbrk+lziDeBTMf84uXMPw9K+RYKx7kZ5TtWoR/wQgipW8KeyPuOKlygUUymgXyT3fEGHvYJbpjnh5GAVdhnz80Tfc/M8nh52wF00omHF5Vn/1hRgqBdD5JU= X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 31:ixfPPENeqyAVyP5WkhGnkFuDRmYCRQRa0COWrUlcOBwr3UzPEzgfdwCLoY4LLlEFQSkGjqOKqwOuO9mWkUzU0fSBj6JAJK/fp0cJGPs62ylBN6jx2OMLdj5rq0NoehpXQQ1rGZ7TVXb3WmLkScy3v2xfEROj6pZj4vf1DXjorlc+NGxA6qcFmt23y+TpzdsYyuHOcXGRRnaDVP+yPgnLjsh//W0exv2IMic53R3Dr/KdJxr0zbTeSq2au9QkCm83waVay4wHL6qWZf5CdOPbLg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123558100)(2016111802025)(201703131423075)(201703061421075)(20161123560025)(20161123564025)(6043046)(6072148); SRVR:SY3PR01MB0971; BCL:0; PCL:0; RULEID:; SRVR:SY3PR01MB0971; X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 4:/Le1s23ne6ZS/KrY7vExnGVX87sFOFf3IeLeDJl+AWrBBneyDhlUAlDjpCr5P/CNbZOmnxf+tPz0c4x4rp0x5B0JRNPvtI1smkWCmZgFg3CGduJC9wk6XoJiOK5Hmg981BJvplmxeXNnQ+Jshs1sUtDhHPO+w4fFugMX1/87pl3TudvGvfL2VXeufVPXJgnPIAJW9tacZpkG38KpQmrZq3SP5luWjmJOrNF9KvvPmGkqocUw8Fp7mTo4NZO/kdS3e3iCTs48Qhro/4HK5WS7kT1IrWDyZzpCdD6r+RE2ZNEfr8+5siSxJ5Dmua1m+N0YcCYX1mwsD8Mjr3SJ8+XvqtP6Tj92aClnpE81zn4JSHO/wGiIsyG5nT7ACeKIQOZSS9xyfpr6SEl50PFdfBVVidhNmCNDa08o+UkyducVRa8Yvf8lAPRdY8CWjm2Ifi3Wo1FYAKU8ogmKoLAGGcgN46edONQfdOoiLM1hpSJ+rnnKFy/mzvr3mCdvoqcxTK+Sg9D5eGhCSwM4ggm3Cv4VjSIZvUmmLRD7/zd7kjTTnfRR0hargaGsrWP7X2NR89tbyKfuLJ0AIP6D6GTOKfceUe/ja5N4iWhsULkaWxsxJBqaXBy/5AGa+J5koI8xZe81vHP8ZOPJfOFeicUoAFc9iaW4LhUWGnm638mUL/BpDsb/U+R5O0iEK8Qy9DRj+kfx1SUaxbhQ/VdNuxkVEsHh6xvWFJG8rnHmshpCn4jKbaGPCaRDxAzFDMcQPSuIO7nO X-Forefront-PRVS: 03142412E2 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39400400002)(39450400003)(36756003)(229853002)(5660300001)(508600001)(81166006)(2950100002)(53936002)(6916009)(6512007)(42882006)(8676002)(6666003)(74482002)(7736002)(3846002)(6116002)(6246003)(86362001)(110136004)(83506001)(25786009)(38730400002)(4326008)(6486002)(6506006)(42186005)(33646002)(5003940100001)(345774005)(76176999)(54356999)(50986999)(189998001)(93886004)(4001350100001)(48376002)(2906002)(47776003)(66066001)(305945005)(50466002); DIR:OUT; SFP:1102; SCL:1; SRVR:SY3PR01MB0971; H:jupiter.local; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SY3PR01MB0971; 23:gSvQEUmE+qRXeZEWK6v8KljjRqoqKIkrtJhU9o1x/?= =?us-ascii?Q?h25poVO5DJJVE6rkUHafNdxRuQNKuC2xEL9jbesID2uqUU/vcxUqYepWNvos?= =?us-ascii?Q?4abOXCM8scYgdBknJW6B4Ion6IoWq9YqiYf8Urhzv74pDWfVQimdgrzURl0u?= =?us-ascii?Q?gAqNnfvh8by7sWSXqM7lf0EvQfF7q1SjNnXif4X6ObQuwHI3xJz+8YRk3S1v?= =?us-ascii?Q?ziygNtsszcYBc5S9FN/nhG9GWyJ2D8rBraA846V1Vzj5FOMv7sC0AGYV/woC?= =?us-ascii?Q?oq/+6BjJKS9eIYG5lcEf9Vcr2IFzgtqGqfpG8UFKp+HBS6IrVzppD3VRzgrl?= =?us-ascii?Q?FiI+U9K/+EP8u+qYaHGIa5fmV6P4POUfhDNsItHxnLoFPHO7v57OIhANHiSd?= =?us-ascii?Q?k4opsoVDt//jMb7LO5xMSCRLMVNkqFU0inEV2g1Kbfcx/vh0+MyFWZJ/6b0y?= =?us-ascii?Q?Ks8J5f+0NikIHVDIgQQhXkhxjV5vjpFfHHIz+8qhgOUQNZfVQdRNuhKS7Ekb?= =?us-ascii?Q?oTpzVjvn/maJufOXHbpI1PaVXYSsKEYOam2piHLUfdkANapojyWDk7+Z5jOZ?= =?us-ascii?Q?I8B2Ti/ntjbbuqEidjVvXithO1JENc45uWDnMs5MUyIAIJJwmfplVyf1MHqk?= =?us-ascii?Q?uS6YGI8lvvHQiP0wpBIVGteGo1seJDshieqDNdlix6Pib5qP80u+4K/6kVHy?= =?us-ascii?Q?j8PsDvtS1MQTjcZtw3ULSG+shJ+vxZ+zHGIL2nODXoFPxdPo40DIjw2u50SO?= =?us-ascii?Q?4t4cCrkpo+c1ScSXVF+3R2P02m7kg8ZLKOjbFysxi3oPlBzyMYSTozRaXW67?= =?us-ascii?Q?DHiu3YB6Ng8N4av2mtZ1F308bxCNtpHdKnj3J9NRLJKsPptJSmUB2fTIPJGv?= =?us-ascii?Q?xmD5+Pl+iT+aU0/VMVThky3vL59mUD3sg1edev7zz+0UTpBi/6TEvUpdIQvA?= =?us-ascii?Q?l1pdhD8PkUgHU2WqJCEao57lzWJjnXth5aWIOCHwO5IfIpt/fzDlgElxCxnC?= =?us-ascii?Q?yuTqDq1h8dBrJaoZEqB73q0r65MKSG6Pvq5e7uQbHaV48A1BwPZ6NbIVvAOd?= =?us-ascii?Q?e2PMVkeVHqw2/98lJ3NbietUc2phK63qHWI7h0dZiN2PioAz6r3yceHYGVEa?= =?us-ascii?Q?QRcMvdPNlk=3D?= X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 6:BwoTmC+jC+r6xcUsvkMcSAFeIaTqH22fCOBSn4ieaZQTlLnp+27Kst49zYkVznHP9bUrSkZARFT+FewDmT4fRehTdWmckBaKUUGoxRlH6XDzBi4sRImH+mwi8NrN8dUVzbwzFGni2BMdiPzssbVMcrzvvx0ek+nohz3V5r6AZscmWElSTxVTPhUUKKKxHDd6JW1QMi7+VhMx3rgvj9GVCtMjJk7oFjk/WaIonW+6BK2Wk53sBkgPFOSmz0+UcxWJz6c365FS1i7hVJmUAtqkYeA2/jiPtODm/piiJdryyDvaQLcM8OMkOZGSsOoTILGkGmezp+II+owJAfTuO0EJg0kBXw/guf3CvFDvSa7YZZ2Slxwh54cggFnqJIJXwEPjWgMbE+Z+fgcVpI/db6bsYN4y7LS/AzeomlAXF/LpxAaCZKOcNspi2wli28IQBOBQ14yoc0oz1iFz+5+tKKtlqgd2aPnOjmA+A1jJqH50XHtQL1tPuTgBDdTunTRAFOKMJ4q5jRZWQb9f9SI23wHYpg==; 5:mE3t+MYpWrTmS5PDtpmiQ5c5r5UYLzYXLIb0GX6LGzDLTbK4kB+7QYkM2QDROTAjSC5B1ADXBn1FrkXK0yh2htTpUJQriHn7T2icKqAEPK624jm7Le9xozUA75XX+IuIQMQ3wN0m2K0CAl/uMQ9HNA==; 24:mcFJkX6XbH9WF8TWcCsM/+o6ny/KuU31HZni9uwqWy/ZRowQ2svt7kuj3JjwDdQ3M/se4TP4VQlWlpiRWjjvGgXNUfPs/vyrxCRZY8C+iQU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 7:C7uY0bydK5oqKsBXAvYVVMHa5yXkLyUAh7JuC6EewZfIMoOTipNm7I5UnlL/bSB2EVBpJFS/wBZ8HO5YY9g26p7nrNzoxEkgS0qwCrR/Bvr3hytqaxYrDi+w5SIkklMM8jhHNqx/j0W3TbBbiB2BczGDTAfCiTphjf73KmPlBXpbmgUfpKzn2sWdH4MxWl0YiC0MU6EcJ2d/kZOwnMJp+3nHeUtd5NLfeDjxoMLJ7OPIPa40eICBmdw2HUd/YZbl4ErQ80LxpWEDxlXj/lxeN79Wn1wGpMzDMN3U2QrMSXLj0UpZkQsZS2EOwj3ZxQzR6tE1886NCLXRLyVZmV3NHg== X-OriginatorOrg: tenpoint.co.nz X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2017 23:11:14.8852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY3PR01MB0971 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26892-done Cc: 26892-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > A couple of notes, for the future: > > . The test at first failed for me, and needed some tweaking, because > whitespace-mode refuses to turn on in batch mode. I guess you ran > the tests in interactive mode? You should run tests in batch. Sorry, yes, I did. I read about batch testing in the manual, but didn't click that most tests need to run that way. Of course they do, now that I think about it. > . The patch was not applicable without manual editing, because it > used file names like whitespace-a.el, which don't exist. Please in > the future submit patches produced against the correct file names, > preferably with "git diff" or somesuch. > > . Please include with the patch a ChangeLog-style commit log message > (see CONTRIBUTE for details). > > . Finally, this contribution exhausts the amount of changes we can > accept from you without legal paperwork, so I encourage you to > start the paperwork rolling, for us to be able to accept your > future contributions. (I can send you the forms off-list if you > want.) I'd like to keep contributing where I can, so please do send the paperwork when you have a moment. Thank you for the feedback and for fixing up the code. It is very much appreciated! From debbugs-submit-bounces@debbugs.gnu.org Mon May 22 00:11:08 2017 Received: (at 26892) by debbugs.gnu.org; 22 May 2017 04:11:08 +0000 Received: from localhost ([127.0.0.1]:59817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCegW-0000Yg-8C for submit@debbugs.gnu.org; Mon, 22 May 2017 00:11:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCegU-0000YC-3r for 26892@debbugs.gnu.org; Mon, 22 May 2017 00:11:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCegL-0005fS-3w for 26892@debbugs.gnu.org; Mon, 22 May 2017 00:11:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCegK-0005eP-T1; Mon, 22 May 2017 00:10:57 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4263 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dCegJ-0007UL-U0; Mon, 22 May 2017 00:10:56 -0400 Date: Mon, 22 May 2017 07:10:43 +0300 Message-Id: <83d1b1o7jw.fsf@gnu.org> From: Eli Zaretskii To: Nick Helm In-reply-to: (message from Nick Helm on Mon, 22 May 2017 11:11:11 +1200) Subject: Re: bug#26892: 25.2; whitespace-mode does not turn off correctly References: <837f1ma96f.fsf@gnu.org> <83mva92fqv.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26892 Cc: 26892@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Nick Helm > CC: <26892-done@debbugs.gnu.org> > Date: Mon, 22 May 2017 11:11:11 +1200 > > . Finally, this contribution exhausts the amount of changes we can > > accept from you without legal paperwork, so I encourage you to > > start the paperwork rolling, for us to be able to accept your > > future contributions. (I can send you the forms off-list if you > > want.) > > I'd like to keep contributing where I can, so please do send the > paperwork when you have a moment. Sent off-list. > Thank you for the feedback and for fixing up the code. It is very much > appreciated! You are very welcome. From unknown Sun Jun 22 03:54:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 19 Jun 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator