From debbugs-submit-bounces@debbugs.gnu.org Thu May 11 14:32:07 2017 Received: (at submit) by debbugs.gnu.org; 11 May 2017 18:32:07 +0000 Received: from localhost ([127.0.0.1]:39052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8ssg-0003DX-Qf for submit@debbugs.gnu.org; Thu, 11 May 2017 14:32:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@bnc3.mailjet.com>) id 1d8ssf-0003D0-3c for submit@debbugs.gnu.org; Thu, 11 May 2017 14:32:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@bnc3.mailjet.com>) id 1d8ssY-0005Fj-2U for submit@debbugs.gnu.org; Thu, 11 May 2017 14:31:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34935) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@bnc3.mailjet.com>) id 1d8ssX-0005FY-U1 for submit@debbugs.gnu.org; Thu, 11 May 2017 14:31:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@bnc3.mailjet.com>) id 1d8ssT-0005GK-Fk for guix-patches@gnu.org; Thu, 11 May 2017 14:31:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@bnc3.mailjet.com>) id 1d8ssL-00056t-LP for guix-patches@gnu.org; Thu, 11 May 2017 14:31:53 -0400 Received: from o177.p9.mailjet.com ([87.253.234.177]:57926) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@bnc3.mailjet.com>) id 1d8ssL-000542-3c for guix-patches@gnu.org; Thu, 11 May 2017 14:31:45 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:x-csa-complaints: x-mj-mid:content-type; bh=P7O5Y3ct33vZqpfpFu2hUcl0ZD4=; b=mx65lL4Yp5vclPYFzTLDO47bVjk2B+WqG5z4hCnYF/vkypm+/JSoI8Wm1 QvewhYNE/KoqYNHGGIgKrbo8B9tZTocVNxTR1FJLUBWA2gD3Y8xUbWn7uG/3 fMpLxkTLJ9bnSGTRGhOzZNXDUHKVZVz38sUG2z+slcMxpgnDeWqVqk= Message-Id: <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: guix-patches@gnu.org Subject: Tests for emacs-clojure-mode Date: Fri, 12 May 2017 00:01:05 +0530 X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O1Lk8rb2DSoyqPAz-6kBaAwAFgUc Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Please find attached a patch set for adding ert-runner, emacs-ansi, emacs-commander, and enabling tests for emacs-clojure-mode. = --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=series.patch >From 52c39f301978ec7081f43466aec5211185eb43dd Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 11 May 2017 23:23:30 +0530 Subject: [PATCH 1/4] gnu: Add emacs-ansi. * gnu/packages/emacs.scm (emacs-ansi): New variable. --- gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 41fc240e1..a95cf519b 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -4646,3 +4646,30 @@ addition of surrounding pairs, such as parantheses and quotes, in evil mode.") comment out lines of code in evil mode. It provides @code{gcc} to comment out lines, and @code{gc} to comment out the target of a motion.") (license license:gpl3+))) + +;; Tests for emacs-ansi have a circular dependency with ert-runner, and +;; therefore cannot be run +(define-public emacs-ansi + (package + (name "emacs-ansi") + (version "0.4.1") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/rejeep/ansi.el/archive/v" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "13jj4vbi98j3p17hs99bmy7g21jd5h4v3wpxk4pkvhylm3bfwjw8")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-dash" ,emacs-dash) + ("emacs-s" ,emacs-s))) + (home-page "https://github.com/rejeep/ansi.el") + (synopsis "Convert strings to ANSI") + (description "@code{emacs-ansi} defines functions that turns simple +strings to ANSI strings. Turning a string into an ANSI string can be to add +color to a text, add color in the background of a text or adding a style, such +as bold, underscore or italic.") + (license license:gpl3+))) -- 2.12.2 >From 75b5e7ae59be84680077dca4942eecca275f7c8c Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 11 May 2017 23:24:43 +0530 Subject: [PATCH 2/4] gnu: Add emacs-commander. * gnu/packages/emacs.scm (emacs-commander): New variable. --- gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index a95cf519b..e2dbb12c4 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -4673,3 +4673,29 @@ strings to ANSI strings. Turning a string into an ANSI string can be to add color to a text, add color in the background of a text or adding a style, such as bold, underscore or italic.") (license license:gpl3+))) + +;; Tests for emacs-commander have a circular dependency with ert-runner, and +;; therefore cannot be run +(define-public emacs-commander + (package + (name "emacs-commander") + (version "0.7.0") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/rejeep/commander.el/archive/v" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "196s2i15z7gwxa97l1wkxvjnfmj5n38wwm6d3g4zz15l2vqggc2y")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-dash" ,emacs-dash) + ("emacs-f" ,emacs-f) + ("emacs-s" ,emacs-s))) + (home-page "https://github.com/rejeep/commander.el") + (synopsis "Emacs command line parser") + (description "@code{emacs-commander} provides command line parsing for +Emacs.") + (license license:gpl3+))) -- 2.12.2 >From 77491a17bbbaef34d94bd37732a031988796aa66 Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 11 May 2017 23:25:27 +0530 Subject: [PATCH 3/4] gnu: Add ert-runner. * gnu/packages/emacs.scm (ert-runner): New variable. --- gnu/packages/emacs.scm | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index e2dbb12c4..e2d2e0786 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -4699,3 +4699,57 @@ as bold, underscore or italic.") (description "@code{emacs-commander} provides command line parsing for Emacs.") (license license:gpl3+))) + +;; Tests for ert-runner have a circular dependency with ecukes, and therefore +;; cannot be run +(define-public ert-runner + (let ((dependencies + `(("emacs-ansi" ,emacs-ansi) + ("emacs-commander" ,emacs-commander) + ("emacs-dash" ,emacs-dash) + ("emacs-f" ,emacs-f) + ("emacs-s" ,emacs-s) + ("emacs-shut-up" ,emacs-shut-up)))) + (package + (name "ert-runner") + (version "0.7.0") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/rejeep/ert-runner.el/archive/v" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "1657nck9i96a4xgl8crfqq0s8gflzp21pkkzwg6m3z5npjxklgwp")))) + (build-system emacs-build-system) + (inputs dependencies) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'install-executable + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (substitute* "bin/ert-runner" + (("ERT_RUNNER=\"\\$\\(dirname \\$\\(dirname \\$0\\)\\)") + (string-append "ERT_RUNNER=\"" out + "/share/emacs/site-lisp/guix.d/" + ,name "-" ,version))) + (install-file "bin/ert-runner" (string-append out "/bin")) + (wrap-program (string-append out "/bin/ert-runner") + (list "EMACSLOADPATH" ":" '= + (append + (map (lambda (name version) + (string-append + (assoc-ref inputs name) + "/share/emacs/site-lisp/guix.d/" + (substring name 6) "-" version)) + ',(map car dependencies) + ',(map (compose package-version cadr) dependencies)) + (list "")))))))))) + (home-page "https://github.com/rejeep/ert-runner.el") + (synopsis "Opinionated Ert testing workflow") + (description "@code{ert-runner} is a tool for Emacs projects tested +using ERT. It assumes a certain test structure setup and can therefore make +running tests easier.") + (license license:gpl3+)))) -- 2.12.2 >From 8b9bfa1f646d7211514395400adb1abaf4c2369c Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 11 May 2017 23:28:53 +0530 Subject: [PATCH 4/4] gnu: emacs-clojure-mode: Enable tests. * gnu/packages/emacs.scm (emacs-clojure-mode)[arguments]: Add 'check' phase. [native-inputs]: Add emacs-dash, emacs-s and ert-runner. --- gnu/packages/emacs.scm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index e2d2e0786..e45368cdd 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -2882,6 +2882,16 @@ S-expression.") (base32 "117mvjqh4nm8mvmwmmvy4qmkdg23ldlzk08y91g8b8ac8kxwqg81")))) (build-system emacs-build-system) + (native-inputs + `(("emacs-dash" ,emacs-dash) + ("emacs-s" ,emacs-s) + ("ert-runner" ,ert-runner))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'check + (lambda* (#:key inputs #:allow-other-keys) + (zero? (system* "ert-runner"))))))) (home-page "https://github.com/clojure-emacs/clojure-mode") (synopsis "Major mode for Clojure code") (description -- 2.12.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 12 17:48:29 2017 Received: (at 26889) by debbugs.gnu.org; 12 May 2017 21:48:29 +0000 Received: from localhost ([127.0.0.1]:41386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9IQH-0004QO-8X for submit@debbugs.gnu.org; Fri, 12 May 2017 17:48:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9IQF-0004QC-Sx for 26889@debbugs.gnu.org; Fri, 12 May 2017 17:48:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9IQ5-0001RL-Lv for 26889@debbugs.gnu.org; Fri, 12 May 2017 17:48:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9IQ5-0001RA-II; Fri, 12 May 2017 17:48:17 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:40278 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d9IQ4-0006bo-Qo; Fri, 12 May 2017 17:48:17 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: bug#26889: Tests for emacs-clojure-mode References: <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@mailjet.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Fri, 12 May 2017 23:48:13 +0200 In-Reply-To: <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@mailjet.com> (Arun Isaac's message of "Fri, 12 May 2017 00:01:05 +0530") Message-ID: <8737c97nmq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26889 Cc: 26889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Arun, Arun Isaac skribis: > From 52c39f301978ec7081f43466aec5211185eb43dd Mon Sep 17 00:00:00 2001 > From: Arun Isaac > Date: Thu, 11 May 2017 23:23:30 +0530 > Subject: [PATCH 1/4] gnu: Add emacs-ansi. > > * gnu/packages/emacs.scm (emacs-ansi): New variable. LGTM. > From 75b5e7ae59be84680077dca4942eecca275f7c8c Mon Sep 17 00:00:00 2001 > From: Arun Isaac > Date: Thu, 11 May 2017 23:24:43 +0530 > Subject: [PATCH 2/4] gnu: Add emacs-commander. > > * gnu/packages/emacs.scm (emacs-commander): New variable. LGTM. > From 77491a17bbbaef34d94bd37732a031988796aa66 Mon Sep 17 00:00:00 2001 > From: Arun Isaac > Date: Thu, 11 May 2017 23:25:27 +0530 > Subject: [PATCH 3/4] gnu: Add ert-runner. > > * gnu/packages/emacs.scm (ert-runner): New variable. [...] > +(define-public ert-runner > + (let ((dependencies > + `(("emacs-ansi" ,emacs-ansi) > + ("emacs-commander" ,emacs-commander) > + ("emacs-dash" ,emacs-dash) > + ("emacs-f" ,emacs-f) > + ("emacs-s" ,emacs-s) > + ("emacs-shut-up" ,emacs-shut-up)))) [...] > + (wrap-program (string-append out "/bin/ert-runner") > + (list "EMACSLOADPATH" ":" '=3D > + (append > + (map (lambda (name version) > + (string-append > + (assoc-ref inputs name) > + "/share/emacs/site-lisp/guix.d/" > + (substring name 6) "-" version)) > + ',(map car dependencies) > + ',(map (compose package-version cadr) dep= endencies)) > + (list "")))))))))) I=E2=80=99d suggest =E2=80=98match=E2=80=99 instead of car/cadr, and =E2=80= =98string-drop=E2=80=99 instead of =E2=80=98substring=E2=80=99. Also, I think we should avoid relying on the fact that input labels are equal to the corresponding package name. For instance, procedures like =E2=80=98package-for-guile-2.2=E2=80=99 mechanically rewrite packages and c= hange their names, but they do not change the labels. That gives something like ,(match dependencies (((labels packages) ...) `(map (lambda (label package version) (string-append (assoc-ref inputs label) "/share/=E2=80=A6" (string-drop package 6) "-" version)) ',labels ',(map package-name packages) ',(map package-version packages)))) Last thing: this phase should return #t after the call to =E2=80=98wrap-program=E2=80=99. OK with changes along these lines! > From 8b9bfa1f646d7211514395400adb1abaf4c2369c Mon Sep 17 00:00:00 2001 > From: Arun Isaac > Date: Thu, 11 May 2017 23:28:53 +0530 > Subject: [PATCH 4/4] gnu: emacs-clojure-mode: Enable tests. > > * gnu/packages/emacs.scm (emacs-clojure-mode)[arguments]: Add 'check' pha= se. > [native-inputs]: Add emacs-dash, emacs-s and ert-runner. LGTM. Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat May 13 01:09:07 2017 Received: (at 26889) by debbugs.gnu.org; 13 May 2017 05:09:07 +0000 Received: from localhost ([127.0.0.1]:41632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9PIg-00085Q-H2 for submit@debbugs.gnu.org; Sat, 13 May 2017 01:09:06 -0400 Received: from o120.p8.mailjet.com ([87.253.233.120]:40591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9PId-00085H-Uv for 26889@debbugs.gnu.org; Sat, 13 May 2017 01:09:04 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type; bh=gfPo+NMFfIpfMsiQ86pg70vrCuE=; b=YcOcxRN2oCu5fKd5ti8QVnJgWr4UljMXh70XkJ+1pEofuyCA/t8HEy3rS 5OltAoDSqH25L/Bv45PgFp78NjDGGOB6JuHvzGpaZqRTmTkiJ3Z4oRX90ogI NibYBVoeIpcf72v4Ox/n8GkOZvCgm6qqknZQJdnJEgVLxUETjjKLpE= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: 26889@debbugs.gnu.org Subject: Re: bug#26889: Tests for emacs-clojure-mode Date: Sat, 13 May 2017 10:38:22 +0530 In-reply-to: <8737c97nmq.fsf@gnu.org> References: <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@mailjet.com> <8737c97nmq.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAKHJIcvEAAAAAAAAAAAO9qrAAAAACwQwAAAAAAAW9WABZFpTuVYpxNfoiRmSquZrZvcvY1gAFgUc Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26889 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Here is another patch set with the suggested changes incorporated. = --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=series.patch >From 8947eda0984e3d444b0960e37e92ac622fc9ac9a Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 11 May 2017 23:23:30 +0530 Subject: [PATCH 1/4] gnu: Add emacs-ansi. * gnu/packages/emacs.scm (emacs-ansi): New variable. --- gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 21120b331..cab7f8cf8 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -4639,3 +4639,30 @@ addition of surrounding pairs, such as parantheses and quotes, in evil mode.") comment out lines of code in evil mode. It provides @code{gcc} to comment out lines, and @code{gc} to comment out the target of a motion.") (license license:gpl3+))) + +;; Tests for emacs-ansi have a circular dependency with ert-runner, and +;; therefore cannot be run +(define-public emacs-ansi + (package + (name "emacs-ansi") + (version "0.4.1") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/rejeep/ansi.el/archive/v" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "13jj4vbi98j3p17hs99bmy7g21jd5h4v3wpxk4pkvhylm3bfwjw8")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-dash" ,emacs-dash) + ("emacs-s" ,emacs-s))) + (home-page "https://github.com/rejeep/ansi.el") + (synopsis "Convert strings to ANSI") + (description "@code{emacs-ansi} defines functions that turns simple +strings to ANSI strings. Turning a string into an ANSI string can be to add +color to a text, add color in the background of a text or adding a style, such +as bold, underscore or italic.") + (license license:gpl3+))) -- 2.12.2 >From 60c83587fbccc3ca096f21772c560642c6265678 Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 11 May 2017 23:24:43 +0530 Subject: [PATCH 2/4] gnu: Add emacs-commander. * gnu/packages/emacs.scm (emacs-commander): New variable. --- gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index cab7f8cf8..b1896fdba 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -4666,3 +4666,29 @@ strings to ANSI strings. Turning a string into an ANSI string can be to add color to a text, add color in the background of a text or adding a style, such as bold, underscore or italic.") (license license:gpl3+))) + +;; Tests for emacs-commander have a circular dependency with ert-runner, and +;; therefore cannot be run +(define-public emacs-commander + (package + (name "emacs-commander") + (version "0.7.0") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/rejeep/commander.el/archive/v" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "196s2i15z7gwxa97l1wkxvjnfmj5n38wwm6d3g4zz15l2vqggc2y")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-dash" ,emacs-dash) + ("emacs-f" ,emacs-f) + ("emacs-s" ,emacs-s))) + (home-page "https://github.com/rejeep/commander.el") + (synopsis "Emacs command line parser") + (description "@code{emacs-commander} provides command line parsing for +Emacs.") + (license license:gpl3+))) -- 2.12.2 >From b4fa1ebbae2b414139fbdfb3bb44439ae6bfdb0c Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 11 May 2017 23:25:27 +0530 Subject: [PATCH 3/4] gnu: Add ert-runner. * gnu/packages/emacs.scm (ert-runner): New variable. --- gnu/packages/emacs.scm | 64 +++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index b1896fdba..a9dd3db6c 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -92,7 +92,8 @@ #:use-module (gnu packages gd) #:use-module (gnu packages fontutils) #:use-module (guix utils) - #:use-module (srfi srfi-1)) + #:use-module (srfi srfi-1) + #:use-module (ice-9 match)) (define-public emacs (package @@ -4692,3 +4693,64 @@ as bold, underscore or italic.") (description "@code{emacs-commander} provides command line parsing for Emacs.") (license license:gpl3+))) + +;; Tests for ert-runner have a circular dependency with ecukes, and therefore +;; cannot be run +(define-public ert-runner + (let ((dependencies + `(("emacs-ansi" ,emacs-ansi) + ("emacs-commander" ,emacs-commander) + ("emacs-dash" ,emacs-dash) + ("emacs-f" ,emacs-f) + ("emacs-s" ,emacs-s) + ("emacs-shut-up" ,emacs-shut-up)))) + (package + (name "ert-runner") + (version "0.7.0") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/rejeep/ert-runner.el/archive/v" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "1657nck9i96a4xgl8crfqq0s8gflzp21pkkzwg6m3z5npjxklgwp")))) + (build-system emacs-build-system) + (inputs dependencies) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'install-executable + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (substitute* "bin/ert-runner" + (("ERT_RUNNER=\"\\$\\(dirname \\$\\(dirname \\$0\\)\\)") + (string-append "ERT_RUNNER=\"" out + "/share/emacs/site-lisp/guix.d/" + ,name "-" ,version))) + (install-file "bin/ert-runner" (string-append out "/bin")) + (wrap-program (string-append out "/bin/ert-runner") + (list "EMACSLOADPATH" ":" '= + (append + ,(match dependencies + (((labels packages) ...) + `(map (lambda (label package version) + (string-append (assoc-ref inputs label) + "/share/emacs/site-lisp/guix.d/" + (string-drop package 6) + "-" version)) + ',labels + ',(map package-name packages) + ',(map package-version packages)))) + ;; empty element to include the default load path as + ;; determined by emacs' standard initialization + ;; procedure + (list "")))) + #t)))))) + (home-page "https://github.com/rejeep/ert-runner.el") + (synopsis "Opinionated Ert testing workflow") + (description "@code{ert-runner} is a tool for Emacs projects tested +using ERT. It assumes a certain test structure setup and can therefore make +running tests easier.") + (license license:gpl3+)))) -- 2.12.2 >From 8dc79fafe9e3de005a44524b2ad918ca13f75732 Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 11 May 2017 23:28:53 +0530 Subject: [PATCH 4/4] gnu: emacs-clojure-mode: Enable tests. * gnu/packages/emacs.scm (emacs-clojure-mode)[arguments]: Add 'check' phase. [native-inputs]: Add emacs-dash, emacs-s and ert-runner. --- gnu/packages/emacs.scm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index a9dd3db6c..4f5988b75 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -2876,6 +2876,16 @@ S-expression.") (base32 "117mvjqh4nm8mvmwmmvy4qmkdg23ldlzk08y91g8b8ac8kxwqg81")))) (build-system emacs-build-system) + (native-inputs + `(("emacs-dash" ,emacs-dash) + ("emacs-s" ,emacs-s) + ("ert-runner" ,ert-runner))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'check + (lambda* (#:key inputs #:allow-other-keys) + (zero? (system* "ert-runner"))))))) (home-page "https://github.com/clojure-emacs/clojure-mode") (synopsis "Major mode for Clojure code") (description -- 2.12.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 13 05:25:17 2017 Received: (at 26889) by debbugs.gnu.org; 13 May 2017 09:25:17 +0000 Received: from localhost ([127.0.0.1]:41793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9TIb-0005b1-DN for submit@debbugs.gnu.org; Sat, 13 May 2017 05:25:17 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9TIZ-0005an-3W for 26889@debbugs.gnu.org; Sat, 13 May 2017 05:25:15 -0400 Received: by mail-lf0-f65.google.com with SMTP id 99so1778570lfu.2 for <26889@debbugs.gnu.org>; Sat, 13 May 2017 02:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=VqE2ZX8yacdv6fbZeXS1YrjfxzflewZhMSht+j3mv7I=; b=JWZ5m3TLiSdDK5HVL4QMHdzoM73CQLjaf/3Kks0KGCI0FxFQrFmp/Mb4cNgaZPc82N R0ivjDYiYIXIumU0d+r5fRrrMmSpzwBGf15yPJ+Tn8eaL78NBQcZF3Z0l28KENzhcPWW 3abwsJKKqrAqHK0haST5+Iq5MWslJpkDg7LaYbBMLCtbgxzCpCridHw0aizOMNV/VW0C PElkrjNt+H3/jFvfaWAPASAA+FZuDiQJ1jStW7kLTBtHFxm6EFPOxftUkzTLIVTt6lzI D3ks70UTAuAFb1l+EW/B++xKOxaz09su8hiPPNQZCT1O2v3vf3rGwwdvMZhSVQ0L1OCU eWjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=VqE2ZX8yacdv6fbZeXS1YrjfxzflewZhMSht+j3mv7I=; b=Ts1IIiY7nAd9iHBaqTVy1Zzp5/hghpFCNMG37llxTtcVauo4drg/An+G6X+S3HOQt7 m6PsWYW0q+q9LIowW/e7QTu7X3NpldOnmEGbJ0srzRpAFnBbJLwgPKITGLYF4Pz8B1gm mFWxz8JRl8Q6VggOkzS7YMy3pIF4v7tyaCqx1mQohddJwKX3KHFucrCjcCiykb9fPOtF 4BI39UQq/6+1tbz82/IqAjfMk/rD1JUa0xZx9U/wVubmdimxaegwjPc+W4sf4haPwyr7 h9yP0DgyB2yAoE+edhqpRuF7pT3iyxVVxZbBv4qA4+hjBtW4y4YRsN2WworvznMGOdXL w1qg== X-Gm-Message-State: AODbwcB79LCQgwyU0CEeS01+xwErU6eQuwaX/c4omERqXtezeO0ktImR lHDKbfuDt3FcTQ== X-Received: by 10.46.84.22 with SMTP id i22mr2845294ljb.131.1494667509379; Sat, 13 May 2017 02:25:09 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id x7sm982364lfb.52.2017.05.13.02.25.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 May 2017 02:25:08 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26889: Tests for emacs-clojure-mode References: <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@mailjet.com> <8737c97nmq.fsf@gnu.org> Date: Sat, 13 May 2017 12:25:10 +0300 In-Reply-To: (Arun Isaac's message of "Sat, 13 May 2017 10:38:22 +0530") Message-ID: <87d1bdxg5l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26889 Cc: 26889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-05-13 10:38 +0530) wrote: > Here is another patch set with the suggested changes incorporated. I think Ludovic meant you may commit these patches. One last comment from me... [...] > From: Arun Isaac > Date: Thu, 11 May 2017 23:28:53 +0530 > Subject: [PATCH 4/4] gnu: emacs-clojure-mode: Enable tests. > > * gnu/packages/emacs.scm (emacs-clojure-mode)[arguments]: Add 'check' phase. > [native-inputs]: Add emacs-dash, emacs-s and ert-runner. > --- > gnu/packages/emacs.scm | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index a9dd3db6c..4f5988b75 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -2876,6 +2876,16 @@ S-expression.") > (base32 > "117mvjqh4nm8mvmwmmvy4qmkdg23ldlzk08y91g8b8ac8kxwqg81")))) > (build-system emacs-build-system) > + (native-inputs > + `(("emacs-dash" ,emacs-dash) > + ("emacs-s" ,emacs-s) > + ("ert-runner" ,ert-runner))) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'install 'check > + (lambda* (#:key inputs #:allow-other-keys) 'inputs' are not used, so just (lambda _ ...) here. > + (zero? (system* "ert-runner"))))))) > (home-page "https://github.com/clojure-emacs/clojure-mode") > (synopsis "Major mode for Clojure code") > (description -- Alex From debbugs-submit-bounces@debbugs.gnu.org Sat May 13 11:25:37 2017 Received: (at 26889) by debbugs.gnu.org; 13 May 2017 15:25:37 +0000 Received: from localhost ([127.0.0.1]:43102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9YvJ-00011p-CC for submit@debbugs.gnu.org; Sat, 13 May 2017 11:25:37 -0400 Received: from o135.p9.mailjet.com ([87.253.234.135]:53062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <36ba858a.ADsAAHkzzzYAAAAAAAAAAAO9qrAAAAACwQwAAAAAAAW9WABZFyVu@bnc3.mailjet.com>) id 1d9YvH-00011h-FP for 26889@debbugs.gnu.org; Sat, 13 May 2017 11:25:36 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=FC5n8s3vvN6YOLZcu+odBxEqkXA=; b=R+oqGUDUuQbJ9k0BDXAqfrGwM+2hRyM7P0g8GIvOTMe0P4L3CecfnC9oR xLVzudzVWBIW2GtS08zOdpiS8bzjx+FndT20sCvLYy+yDP2ax5XqdSlYpzx2 4gxYLjcZ4Z6DXjhie2D2b4ZGYgwXvYVInA+JJKwkwwZHizOVFj9XVQ= Message-Id: <36ba858a.ADsAAHkzzzYAAAAAAAAAAAO9qrAAAAACwQwAAAAAAAW9WABZFyVu@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: Alex Kost Subject: Re: bug#26889: Tests for emacs-clojure-mode Date: Sat, 13 May 2017 20:54:40 +0530 In-reply-to: <87d1bdxg5l.fsf@gmail.com> References: <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@mailjet.com> <8737c97nmq.fsf@gnu.org> <87d1bdxg5l.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: ADsAAHkzzzYAAAAAAAAAAAO9qrAAAAACwQwAAAAAAAW9WABZFyVuPQF_iLT_Ra2xUoyhm0dk6AAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26889 Cc: 26889@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Pushed with all changes incorporated! Alex Kost writes: > Arun Isaac (2017-05-13 10:38 +0530) wrote: > >> Here is another patch set with the suggested changes incorporated. > > I think Ludovic meant you may commit these patches. I guess that's what he meant. I was just being a little extra careful. If there was no response in about a day, I would have pushed. > 'inputs' are not used, so just (lambda _ ...) here. Anyways, I thought I'd be missing something like this. Hence the extra careful resubmission of the patch set! :-P = From debbugs-submit-bounces@debbugs.gnu.org Sun May 14 08:10:44 2017 Received: (at 26889-done) by debbugs.gnu.org; 14 May 2017 12:10:44 +0000 Received: from localhost ([127.0.0.1]:43644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9sMG-00056w-9N for submit@debbugs.gnu.org; Sun, 14 May 2017 08:10:44 -0400 Received: from o155.p9.mailjet.com ([87.253.234.155]:34401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <6aa48904.AEMAKSHSGAEAAAAAAAAAAAO94AMAAAACwQwAAAAAAAW9WABZGElB@bnc3.mailjet.com>) id 1d9sME-00056o-Nj for 26889-done@debbugs.gnu.org; Sun, 14 May 2017 08:10:43 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=E9VRVqgpHL7NrO2eVya9DD3g7ME=; b=XfFHyiVU8dmyhEJutjqZ9cGV5tFBcnjXsL5qMNEzVzBd7sciourHO3KQD uhHA4B+Qrdqe5qkTJO6foSz7ZICKndfH4S0/cA3mUaHrk/lSyf8+wFwTN0zv u96JCaV9lt+VH+PSz0cQNcCxCuTc+mECunUYtKe/zdxzFJgbujPXaU= Message-Id: <6aa48904.AEMAKSHSGAEAAAAAAAAAAAO94AMAAAACwQwAAAAAAAW9WABZGElB@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 26889-done@debbugs.gnu.org Subject: Re: bug#26889: Tests for emacs-clojure-mode Date: Sun, 14 May 2017 17:39:46 +0530 In-reply-to: References: <864f5ab5.AEAAKEHRjrgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZFK4O@mailjet.com> <8737c97nmq.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAKSHSGAEAAAAAAAAAAAO94AMAAAACwQwAAAAAAAW9WABZGElBgnkA3YlAS2KG_sPHhZClXgAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26889-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Forgot to close this bug report earlier. Closing now... = From unknown Fri Jun 20 07:17:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 12 Jun 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator