GNU bug report logs - #26860
[PATCH] Remove hard dependency on guile-json

Previous Next

Package: guix-patches;

Reported by: Alex Kost <alezost <at> gmail.com>

Date: Tue, 9 May 2017 19:54:02 UTC

Severity: important

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log


Message #19 received at 26860 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Alex Kost <alezost <at> gmail.com>, 26860 <at> debbugs.gnu.org
Subject: Re: bug#26860: [PATCH] Remove hard dependency on guile-json
Date: Wed, 17 May 2017 10:33:23 +0200
Ricardo Wurmus <rekado <at> elephly.net> skribis:

> Alex Kost <alezost <at> gmail.com> writes:
>
>> Hello.  Currently, Guix cannot be built without guile-json.  The
>> attached patch fixes it.
>>
>>>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost <at> gmail.com>
>> Date: Tue, 9 May 2017 22:44:19 +0300
>> Subject: [PATCH] build: Compile stackage only if 'guile-json' is available.
>>
>> This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642.
>>
>> * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within
>> 'if HAVE_GUILE_JSON'.
>
> Would it not work to autoload the module?
> “guix/scripts/import/stackage.scm” itself does not require guile json.
>
> Something like that is done in commit
> fad5f5fb8dffb4a1cbe40ee9d31a346b901305d1 (in the unmerged wip-installer
> branch).

Ricardo, could you take a look at this?

I’m not sure if autoloading works, unless we use the ‘module-autoload!’
hack as done in other places.

TIA.  :-)

Ludo’.




This bug report was last modified 8 years and 2 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.