From unknown Tue Jun 17 01:49:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26860: [PATCH] Remove hard dependency on guile-json Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 May 2017 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 26860@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.149435960623677 (code B ref -1); Tue, 09 May 2017 19:54:02 +0000 Received: (at submit) by debbugs.gnu.org; 9 May 2017 19:53:26 +0000 Received: from localhost ([127.0.0.1]:34531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8BCH-00069o-00 for submit@debbugs.gnu.org; Tue, 09 May 2017 15:53:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8BCE-00069b-SJ for submit@debbugs.gnu.org; Tue, 09 May 2017 15:53:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8BC7-0005cW-R2 for submit@debbugs.gnu.org; Tue, 09 May 2017 15:53:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53153) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8BC7-0005cM-N7 for submit@debbugs.gnu.org; Tue, 09 May 2017 15:53:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8BC6-0005d5-KO for guix-patches@gnu.org; Tue, 09 May 2017 15:53:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8BC3-0005bb-AT for guix-patches@gnu.org; Tue, 09 May 2017 15:53:14 -0400 Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]:34393) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8BC3-0005al-2U for guix-patches@gnu.org; Tue, 09 May 2017 15:53:11 -0400 Received: by mail-lf0-x22e.google.com with SMTP id 99so8427278lfu.1 for ; Tue, 09 May 2017 12:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=WgQzt54hjnvQCAm7XuQ43gEUYmY/OZg9dHX+BYPc6BI=; b=tlqq5ne1frIaWH0HjfQiVSBHwZ7gIUmh+15L83iDHWkQtoBtYIqs8ylCmpHpVmR1A0 NSCIc2qCPTBR+5jmB2F1WTQ1ml09EgaWwUweUh0ocxmpEZh85/eKnRvgm/hFPqdguVD/ GomS1KOZVXQuLbZOucoWajDJgpqClDNDnYhITEhJKGJhfUd6vLP6ta7hdTayIM7eQF7P 7y+yWlzF1szF2+gOspP5Rpd/c4y6ObMwRU/Rkp6xEAv+rMN71rsVX7C8hBAXUw7Ek9C9 kfg5fHGsgK2MhIsVp5kHfjqPp5I4Y81o2C+l6WrQio5f7gDIp8LZU/ZSkbeWRGm4pLfa r/jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=WgQzt54hjnvQCAm7XuQ43gEUYmY/OZg9dHX+BYPc6BI=; b=PZkty7cYHemAzagWndaGDPwanbcrGTinOI9kjoX0z8Ql1tsf8V8x0ugHvvu85KXnxE rNpIsvTlxvcDT+07YcEhJWnnY9tDwhSM6WZy6lic4ltRQ3IpfVqipUMTvFYLRhpUvHCr PXjkPpXSRn7VZbYSplMxeVUmlX/XLrncbyjGXmHq9JN3dIIxh26DGKqz7Iwont668FDZ o/ntL0lcHWpKKU/Bnb4wMspCbY9nO6gmdLZjUsBGgflN0FhPehOpeqm8Cw3FPf6k/ad+ Mr6mpnY4g8pnuf+yB07NRVfxlm+1AUu+VdWcXy7m021Wi28tZtHhd8G5HnRinCJNHTyi cvdQ== X-Gm-Message-State: AODbwcAztr0KIQ8eL3OBu9jpyHVcfcMWkuDSbccqFlZ8HJC6fGJBpqjh i5pGB0I2k6B4s1lF X-Received: by 10.25.76.5 with SMTP id z5mr975651lfa.183.1494359589282; Tue, 09 May 2017 12:53:09 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id y25sm166440lfj.31.2017.05.09.12.53.08 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 May 2017 12:53:08 -0700 (PDT) From: Alex Kost Date: Tue, 09 May 2017 22:53:07 +0300 Message-ID: <87shkdbye4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hello. Currently, Guix cannot be built without guile-json. The attached patch fixes it. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-build-Compile-stackage-only-if-guile-json-is-availab.patch >From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001 From: Alex Kost Date: Tue, 9 May 2017 22:44:19 +0300 Subject: [PATCH] build: Compile stackage only if 'guile-json' is available. This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642. * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within 'if HAVE_GUILE_JSON'. --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index f6a8f66..8ea4f4b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -159,7 +159,6 @@ MODULES = \ guix/scripts/import/gnu.scm \ guix/scripts/import/nix.scm \ guix/scripts/import/hackage.scm \ - guix/scripts/import/stackage.scm \ guix/scripts/import/elpa.scm \ guix/scripts/environment.scm \ guix/scripts/publish.scm \ @@ -184,7 +183,8 @@ MODULES += \ guix/import/stackage.scm \ guix/scripts/import/crate.scm \ guix/scripts/import/gem.scm \ - guix/scripts/import/pypi.scm + guix/scripts/import/pypi.scm \ + guix/scripts/import/stackage.scm endif -- 2.10.2 --=-=-=-- From unknown Tue Jun 17 01:49:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26860: [PATCH] Remove hard dependency on guile-json Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 May 2017 20:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alex Kost Cc: 26860@debbugs.gnu.org Received: via spool by 26860-submit@debbugs.gnu.org id=B26860.149436260928099 (code B ref 26860); Tue, 09 May 2017 20:44:01 +0000 Received: (at 26860) by debbugs.gnu.org; 9 May 2017 20:43:29 +0000 Received: from localhost ([127.0.0.1]:34563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8Byj-0007J9-3y for submit@debbugs.gnu.org; Tue, 09 May 2017 16:43:29 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:33314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8Byg-0007Iy-HU for 26860@debbugs.gnu.org; Tue, 09 May 2017 16:43:27 -0400 Received: from localhost (77.118.221.44.wireless.dyn.drei.com [77.118.221.44]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 9E0651CA02CA; Tue, 9 May 2017 22:43:24 +0200 (CEST) Date: Tue, 9 May 2017 22:43:19 +0200 From: Danny Milosavljevic Message-ID: <20170509224319.5588d02c@scratchpost.org> In-Reply-To: <87shkdbye4.fsf@gmail.com> References: <87shkdbye4.fsf@gmail.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) LGTM! From unknown Tue Jun 17 01:49:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26860: [PATCH] Remove hard dependency on guile-json Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 May 2017 06:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alex Kost Cc: 26860@debbugs.gnu.org Received: via spool by 26860-submit@debbugs.gnu.org id=B26860.149439832419858 (code B ref 26860); Wed, 10 May 2017 06:39:02 +0000 Received: (at 26860) by debbugs.gnu.org; 10 May 2017 06:38:44 +0000 Received: from localhost ([127.0.0.1]:34951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8LGl-0005AE-W0 for submit@debbugs.gnu.org; Wed, 10 May 2017 02:38:44 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8LGj-0005A4-Vb for 26860@debbugs.gnu.org; Wed, 10 May 2017 02:38:42 -0400 Received: from localhost (port-92-200-17-209.dynamic.qsc.de [92.200.17.209]) by mx.zohomail.com with SMTPS id 1494398319762307.8490291270855; Tue, 9 May 2017 23:38:39 -0700 (PDT) References: <87shkdbye4.fsf@gmail.com> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Ricardo Wurmus In-reply-to: <87shkdbye4.fsf@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 10 May 2017 08:38:37 +0200 Message-ID: <87a86li5ci.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Spam-Score: -1.8 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Alex Kost writes: > Hello. Currently, Guix cannot be built without guile-json. The > attached patch fixes it. > >>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Tue, 9 May 2017 22:44:19 +0300 > Subject: [PATCH] build: Compile stackage only if 'guile-json' is available. > > This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642. > > * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within > 'if HAVE_GUILE_JSON'. Would it not work to autoload the module? “guix/scripts/import/stackage.scm” itself does not require guile json. Something like that is done in commit fad5f5fb8dffb4a1cbe40ee9d31a346b901305d1 (in the unmerged wip-installer branch). -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From unknown Tue Jun 17 01:49:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26860: [PATCH] Remove hard dependency on guile-json Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 May 2017 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: 26860@debbugs.gnu.org Received: via spool by 26860-submit@debbugs.gnu.org id=B26860.149444389713176 (code B ref 26860); Wed, 10 May 2017 19:19:02 +0000 Received: (at 26860) by debbugs.gnu.org; 10 May 2017 19:18:17 +0000 Received: from localhost ([127.0.0.1]:37098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8X7o-0003QS-Ux for submit@debbugs.gnu.org; Wed, 10 May 2017 15:18:17 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8X7n-0003QF-Jm for 26860@debbugs.gnu.org; Wed, 10 May 2017 15:18:16 -0400 Received: by mail-wm0-f46.google.com with SMTP id b84so16025599wmh.0 for <26860@debbugs.gnu.org>; Wed, 10 May 2017 12:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=p5ib0q516ZKbRm43dhpHbciSPtSu/wIsQ0WELKtYKcI=; b=PF4UO0lr62D+9Ss5h0FgOv95PA2w885rqrqL2ufjcEg5bCcd+IYfUUsA5VzG3O9DW1 JQc2WNb1BaKNBeO1MN6KF10NDxaXY6hPso6IzVtrSBpZq8I2Kh6rPlTAX9+hSOLmevXP o1v/LXChcT6MNxG8VorflgGezaR06O+h2MQd5fpNy0Oer05kd27dHLYUZCBnI+OQc9MB HJk994bLZnC3lNK0KGjlYpb4AdrDZKG6hY7vWRg5gNH8BhQ39w05U2sjdx/4VbGP3BQs +EtgCAw4+uxXpYmsGCrF6jgiF4x48hI7no6L0MWRFB9fbPXAm9dYl+zYcdayKZIljpjc t2+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=p5ib0q516ZKbRm43dhpHbciSPtSu/wIsQ0WELKtYKcI=; b=D1rS99EuD0wXSyUzUeCn2OiIO98efV1zG1G4rV9FTAf5gj15q6i0FRZLWaoew5qYno FEn8lLDdG90E1M7HvdIHKsh3JXWVDsbuC2+ymviSue43siwWBytN8uRdeJSTh4v3oytK Pbty4qCQQo+kx0isrSltdROj+xcA297PeYvSYqZ4yVuRoy4Sm+xfAda9WBKzW/hxt9qn 8ox1cRbiTwc6ObqrM5jQaA7+d9aSxmdi8oSOFIm/K+O8T1gWoeF+Ijc7UKikxrFnTtp3 Jhs6y9lLALdRjv5yusz5mQVRi0cC5Dx66kOIwCH++wahpD7VABnRMT70RRkjz/++axwV jWtA== X-Gm-Message-State: AODbwcA5Gs0f8acJ/1lTbHd9i5ebUMQHDX27C0o/mWDzaaLFq6AYgo1f 12AQiAPc10A/Lw== X-Received: by 10.25.125.3 with SMTP id y3mr3655577lfc.141.1494443889523; Wed, 10 May 2017 12:18:09 -0700 (PDT) Received: from leviafan ([217.107.194.136]) by smtp.gmail.com with ESMTPSA id j89sm716077lfk.67.2017.05.10.12.18.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 May 2017 12:18:08 -0700 (PDT) From: Alex Kost References: <87shkdbye4.fsf@gmail.com> <87a86li5ci.fsf@elephly.net> Date: Wed, 10 May 2017 22:18:07 +0300 In-Reply-To: <87a86li5ci.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 10 May 2017 08:38:37 +0200") Message-ID: <87bmr0a5cg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Ricardo Wurmus (2017-05-10 08:38 +0200) wrote: > Alex Kost writes: > >> Hello. Currently, Guix cannot be built without guile-json. The >> attached patch fixes it. >> >>>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001 >> From: Alex Kost >> Date: Tue, 9 May 2017 22:44:19 +0300 >> Subject: [PATCH] build: Compile stackage only if 'guile-json' is availab= le. >> >> This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642. >> >> * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within >> 'if HAVE_GUILE_JSON'. > > Would it not work to autoload the module? Sorry, I have no idea, I didn't test :-) I can only say that currently the build fails if guile-json is not available, so I came up with a simple fix. > =E2=80=9Cguix/scripts/import/stackage.scm=E2=80=9D itself does not requir= e guile json. Right, it requires (guix import stackage) which requires (guix import json) which requires (json), but not directly. > Something like that is done in commit > fad5f5fb8dffb4a1cbe40ee9d31a346b901305d1 (in the unmerged wip-installer > branch). I don't know, this seems over-complicated to me. Does it really make sense to leave "guix/import/stackage.scm" inside "if HAVE_GUILE_JSON" and "guix/scripts/import/stackage.scm" outside? I would rather keep these stackage import modules in one place and avoid the autoload hack you mentioned. P.S. Sorry if this message is not very constructive, I am not concentrated now as I'm watching "Atl=C3=A9tico =E2=80=93 Real" semi-final. --=20 Alex From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 04:32:27 2017 Received: (at control) by debbugs.gnu.org; 17 May 2017 08:32:27 +0000 Received: from localhost ([127.0.0.1]:49529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAuNf-0001Lq-F4 for submit@debbugs.gnu.org; Wed, 17 May 2017 04:32:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAuNd-0001Le-VY for control@debbugs.gnu.org; Wed, 17 May 2017 04:32:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAuNU-0000Q6-Ny for control@debbugs.gnu.org; Wed, 17 May 2017 04:32:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAuNU-0000Q2-KX for control@debbugs.gnu.org; Wed, 17 May 2017 04:32:16 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:47524 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dAuNT-00078d-Sv for control@debbugs.gnu.org; Wed, 17 May 2017 04:32:16 -0400 Date: Wed, 17 May 2017 10:32:13 +0200 Message-Id: <8737c328aa.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #26860 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) severity 26860 important From unknown Tue Jun 17 01:49:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26860: [PATCH] Remove hard dependency on guile-json Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 May 2017 08:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: Alex Kost , 26860@debbugs.gnu.org Received: via spool by 26860-submit@debbugs.gnu.org id=B26860.14950100175318 (code B ref 26860); Wed, 17 May 2017 08:34:02 +0000 Received: (at 26860) by debbugs.gnu.org; 17 May 2017 08:33:37 +0000 Received: from localhost ([127.0.0.1]:49533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAuOm-0001Ni-Nx for submit@debbugs.gnu.org; Wed, 17 May 2017 04:33:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAuOl-0001NW-LO for 26860@debbugs.gnu.org; Wed, 17 May 2017 04:33:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAuOc-0000dt-II for 26860@debbugs.gnu.org; Wed, 17 May 2017 04:33:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAuOc-0000do-GD; Wed, 17 May 2017 04:33:26 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:47530 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dAuOb-0007da-N0; Wed, 17 May 2017 04:33:26 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87shkdbye4.fsf@gmail.com> <87a86li5ci.fsf@elephly.net> Date: Wed, 17 May 2017 10:33:23 +0200 In-Reply-To: <87a86li5ci.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 10 May 2017 08:38:37 +0200") Message-ID: <87y3tvzxv0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ricardo Wurmus skribis: > Alex Kost writes: > >> Hello. Currently, Guix cannot be built without guile-json. The >> attached patch fixes it. >> >>>>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001 >> From: Alex Kost >> Date: Tue, 9 May 2017 22:44:19 +0300 >> Subject: [PATCH] build: Compile stackage only if 'guile-json' is availab= le. >> >> This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642. >> >> * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within >> 'if HAVE_GUILE_JSON'. > > Would it not work to autoload the module? > =E2=80=9Cguix/scripts/import/stackage.scm=E2=80=9D itself does not requir= e guile json. > > Something like that is done in commit > fad5f5fb8dffb4a1cbe40ee9d31a346b901305d1 (in the unmerged wip-installer > branch). Ricardo, could you take a look at this? I=E2=80=99m not sure if autoloading works, unless we use the =E2=80=98modul= e-autoload!=E2=80=99 hack as done in other places. TIA. :-) Ludo=E2=80=99. From unknown Tue Jun 17 01:49:12 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Alex Kost Subject: bug#26860: closed (Re: bug#26860: [PATCH] Remove hard dependency on guile-json) Message-ID: References: <87inkzwr12.fsf@gnu.org> <87shkdbye4.fsf@gmail.com> X-Gnu-PR-Message: they-closed 26860 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 26860@debbugs.gnu.org Date: Wed, 17 May 2017 13:30:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1495027803-19525-1" This is a multi-part message in MIME format... ------------=_1495027803-19525-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #26860: [PATCH] Remove hard dependency on guile-json which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 26860@debbugs.gnu.org. --=20 26860: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26860 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1495027803-19525-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 26860-done) by debbugs.gnu.org; 17 May 2017 13:29:32 +0000 Received: from localhost ([127.0.0.1]:49751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAz19-00053q-U9 for submit@debbugs.gnu.org; Wed, 17 May 2017 09:29:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAz16-00053Z-IY for 26860-done@debbugs.gnu.org; Wed, 17 May 2017 09:29:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAz10-0000cZ-Ba for 26860-done@debbugs.gnu.org; Wed, 17 May 2017 09:29:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAz0u-0000bN-CL; Wed, 17 May 2017 09:29:16 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:47932 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dAz0t-0005ok-Ks; Wed, 17 May 2017 09:29:16 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Alex Kost Subject: Re: bug#26860: [PATCH] Remove hard dependency on guile-json References: <87shkdbye4.fsf@gmail.com> Date: Wed, 17 May 2017 15:29:13 +0200 In-Reply-To: <87shkdbye4.fsf@gmail.com> (Alex Kost's message of "Tue, 09 May 2017 22:53:07 +0300") Message-ID: <87inkzwr12.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26860-done Cc: Ricardo Wurmus , 26860-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alex Kost skribis: > Hello. Currently, Guix cannot be built without guile-json. The > attached patch fixes it. > >>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Tue, 9 May 2017 22:44:19 +0300 > Subject: [PATCH] build: Compile stackage only if 'guile-json' is availabl= e. > > This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642. > > * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within > 'if HAVE_GUILE_JSON'. After closer inspection, I applied this patch as-is. It does the same thing as we did for the other importers, which sounds good to me. Thanks, and apologies for the delay! Ludo=E2=80=99. ------------=_1495027803-19525-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 May 2017 19:53:26 +0000 Received: from localhost ([127.0.0.1]:34531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8BCH-00069o-00 for submit@debbugs.gnu.org; Tue, 09 May 2017 15:53:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8BCE-00069b-SJ for submit@debbugs.gnu.org; Tue, 09 May 2017 15:53:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8BC7-0005cW-R2 for submit@debbugs.gnu.org; Tue, 09 May 2017 15:53:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53153) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8BC7-0005cM-N7 for submit@debbugs.gnu.org; Tue, 09 May 2017 15:53:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8BC6-0005d5-KO for guix-patches@gnu.org; Tue, 09 May 2017 15:53:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8BC3-0005bb-AT for guix-patches@gnu.org; Tue, 09 May 2017 15:53:14 -0400 Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]:34393) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8BC3-0005al-2U for guix-patches@gnu.org; Tue, 09 May 2017 15:53:11 -0400 Received: by mail-lf0-x22e.google.com with SMTP id 99so8427278lfu.1 for ; Tue, 09 May 2017 12:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=WgQzt54hjnvQCAm7XuQ43gEUYmY/OZg9dHX+BYPc6BI=; b=tlqq5ne1frIaWH0HjfQiVSBHwZ7gIUmh+15L83iDHWkQtoBtYIqs8ylCmpHpVmR1A0 NSCIc2qCPTBR+5jmB2F1WTQ1ml09EgaWwUweUh0ocxmpEZh85/eKnRvgm/hFPqdguVD/ GomS1KOZVXQuLbZOucoWajDJgpqClDNDnYhITEhJKGJhfUd6vLP6ta7hdTayIM7eQF7P 7y+yWlzF1szF2+gOspP5Rpd/c4y6ObMwRU/Rkp6xEAv+rMN71rsVX7C8hBAXUw7Ek9C9 kfg5fHGsgK2MhIsVp5kHfjqPp5I4Y81o2C+l6WrQio5f7gDIp8LZU/ZSkbeWRGm4pLfa r/jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=WgQzt54hjnvQCAm7XuQ43gEUYmY/OZg9dHX+BYPc6BI=; b=PZkty7cYHemAzagWndaGDPwanbcrGTinOI9kjoX0z8Ql1tsf8V8x0ugHvvu85KXnxE rNpIsvTlxvcDT+07YcEhJWnnY9tDwhSM6WZy6lic4ltRQ3IpfVqipUMTvFYLRhpUvHCr PXjkPpXSRn7VZbYSplMxeVUmlX/XLrncbyjGXmHq9JN3dIIxh26DGKqz7Iwont668FDZ o/ntL0lcHWpKKU/Bnb4wMspCbY9nO6gmdLZjUsBGgflN0FhPehOpeqm8Cw3FPf6k/ad+ Mr6mpnY4g8pnuf+yB07NRVfxlm+1AUu+VdWcXy7m021Wi28tZtHhd8G5HnRinCJNHTyi cvdQ== X-Gm-Message-State: AODbwcAztr0KIQ8eL3OBu9jpyHVcfcMWkuDSbccqFlZ8HJC6fGJBpqjh i5pGB0I2k6B4s1lF X-Received: by 10.25.76.5 with SMTP id z5mr975651lfa.183.1494359589282; Tue, 09 May 2017 12:53:09 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id y25sm166440lfj.31.2017.05.09.12.53.08 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 May 2017 12:53:08 -0700 (PDT) From: Alex Kost To: guix-patches@gnu.org Subject: [PATCH] Remove hard dependency on guile-json Date: Tue, 09 May 2017 22:53:07 +0300 Message-ID: <87shkdbye4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hello. Currently, Guix cannot be built without guile-json. The attached patch fixes it. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-build-Compile-stackage-only-if-guile-json-is-availab.patch >From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001 From: Alex Kost Date: Tue, 9 May 2017 22:44:19 +0300 Subject: [PATCH] build: Compile stackage only if 'guile-json' is available. This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642. * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within 'if HAVE_GUILE_JSON'. --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index f6a8f66..8ea4f4b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -159,7 +159,6 @@ MODULES = \ guix/scripts/import/gnu.scm \ guix/scripts/import/nix.scm \ guix/scripts/import/hackage.scm \ - guix/scripts/import/stackage.scm \ guix/scripts/import/elpa.scm \ guix/scripts/environment.scm \ guix/scripts/publish.scm \ @@ -184,7 +183,8 @@ MODULES += \ guix/import/stackage.scm \ guix/scripts/import/crate.scm \ guix/scripts/import/gem.scm \ - guix/scripts/import/pypi.scm + guix/scripts/import/pypi.scm \ + guix/scripts/import/stackage.scm endif -- 2.10.2 --=-=-=-- ------------=_1495027803-19525-1--