GNU bug report logs - #26839
[PATCH] system: Export 'read-boot-parameters'.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26839 in the body.
You can then email your comments to 26839 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] system: Export 'read-boot-parameters'.
Date: Mon, 08 May 2017 22:40:59 +0300

[Message part 1 (text/plain, inline)]

Hello, commit 9530e73b496fefe65dcb936825b6beda79f7fdf2 removed an export
line for 'read-boot-parameters'.

That procedure was used by Emacs-Guix code, and now
"M-x guix-system-generations" fails, so do you mind if
'read-boot-parameters' will be exported again?

[0001-system-Export-read-boot-parameters.patch (text/x-diff, attachment)]

Message #8 received at 26839 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Alex Kost <alezost <at> gmail.com>
Cc: 26839 <at> debbugs.gnu.org
Subject: Re: bug#26839: [PATCH] system: Export 'read-boot-parameters'.
Date: Mon, 8 May 2017 22:25:48 +0200

Hi Alex,

On Mon, 08 May 2017 22:40:59 +0300
Alex Kost <alezost <at> gmail.com> wrote:

> Hello, commit 9530e73b496fefe65dcb936825b6beda79f7fdf2 removed an export
> line for 'read-boot-parameters'.
> 
> That procedure was used by Emacs-Guix code, and now
> "M-x guix-system-generations" fails, so do you mind if
> 'read-boot-parameters' will be exported again?

LGTM.


Be advised that these will not return all boot parameters that would actually boot a system successfully.  That was also the case before the "--load" patch series.  After the "--load" patch series, there's a new procedure "read-boot-parameters-file" that gives you all of them.

Message #11 received at 26839 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 26839 <at> debbugs.gnu.org
Subject: Re: bug#26839: [PATCH] system: Export 'read-boot-parameters'.
Date: Tue, 09 May 2017 22:11:15 +0300

Danny Milosavljevic (2017-05-08 22:25 +0200) wrote:

> Hi Alex,
>
> On Mon, 08 May 2017 22:40:59 +0300
> Alex Kost <alezost <at> gmail.com> wrote:
>
>> Hello, commit 9530e73b496fefe65dcb936825b6beda79f7fdf2 removed an export
>> line for 'read-boot-parameters'.
>> 
>> That procedure was used by Emacs-Guix code, and now
>> "M-x guix-system-generations" fails, so do you mind if
>> 'read-boot-parameters' will be exported again?
>
> Be advised that these will not return all boot parameters that would
> actually boot a system successfully.  That was also the case before the
> "--load" patch series.  After the "--load" patch series, there's a new
> procedure "read-boot-parameters-file" that gives you all of them.

I know, thanks.

-- 
Alex

Message #16 received at 26839-done <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 26839-done <at> debbugs.gnu.org
Subject: Re: bug#26839: [PATCH] system: Export 'read-boot-parameters'.
Date: Sat, 13 May 2017 12:20:35 +0300

Danny Milosavljevic (2017-05-08 22:25 +0200) wrote:

> Hi Alex,
>
> On Mon, 08 May 2017 22:40:59 +0300
> Alex Kost <alezost <at> gmail.com> wrote:
>
>> Hello, commit 9530e73b496fefe65dcb936825b6beda79f7fdf2 removed an export
>> line for 'read-boot-parameters'.
>>
>> That procedure was used by Emacs-Guix code, and now
>> "M-x guix-system-generations" fails, so do you mind if
>> 'read-boot-parameters' will be exported again?
>
> LGTM.

Committed, thanks for looking at it!

-- 
Alex

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.