From debbugs-submit-bounces@debbugs.gnu.org Mon May 08 15:14:53 2017 Received: (at submit) by debbugs.gnu.org; 8 May 2017 19:14:53 +0000 Received: from localhost ([127.0.0.1]:60079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7o7Q-0002FP-SQ for submit@debbugs.gnu.org; Mon, 08 May 2017 15:14:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7o7P-0002FC-H1 for submit@debbugs.gnu.org; Mon, 08 May 2017 15:14:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7o7J-0002Am-BX for submit@debbugs.gnu.org; Mon, 08 May 2017 15:14:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7o7J-0002Ab-87 for submit@debbugs.gnu.org; Mon, 08 May 2017 15:14:45 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d7o7I-0003Ga-RU; Mon, 08 May 2017 15:14:44 -0400 From: Glenn Morris To: submit@debbugs.gnu.org Subject: Wrong file in "autoloading failed to define" error X-Debbugs-CC: agrambot@gmail.com X-Spook: MS13 National Operations Center Merlin target Steve Case X-Ran: p~\I>]tmjyNg7;zG/=A,5)h=xv8p/eNp-c User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Package: emacs Version: 26.0.50 Severity: minor cat < bar.el (provide 'bar) EOF emacs -Q -L $PWD (autoload 'bar "bar") (bar) -> (error "Autoloading file /path/to/bar.el failed to define function bar") which is correct and good. Now: C-] ; exit debugger (bar) ; repeat -> (error "Autoloading file /path/to/help-mode.elc failed to define function bar") Ie, the wrong file name is reported after the first time round. Ref: http://lists.gnu.org/archive/html/emacs-devel/2016-10/msg00668.html From debbugs-submit-bounces@debbugs.gnu.org Mon May 08 20:05:04 2017 Received: (at 26837) by debbugs.gnu.org; 9 May 2017 00:05:04 +0000 Received: from localhost ([127.0.0.1]:60423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7seG-0004Uj-97 for submit@debbugs.gnu.org; Mon, 08 May 2017 20:05:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7seE-0004UD-It for 26837@debbugs.gnu.org; Mon, 08 May 2017 20:05:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7se8-0004CM-QU for 26837@debbugs.gnu.org; Mon, 08 May 2017 20:04:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7se8-0004CI-Mv; Mon, 08 May 2017 20:04:56 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d7se8-0007nc-93; Mon, 08 May 2017 20:04:56 -0400 From: Glenn Morris To: 26837@debbugs.gnu.org Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> X-Spook: CDMA Shell Agro Terror Tuberculosis MDA Toxic X-Ran: A9d;NnjW&{anU_'c[|kVI/~tjcB6)<9{J>Dg{-=$PLi-9hHGZ)15M/fT-gSU-M>Ng)%O>T X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 08 May 2017 20:04:56 -0400 In-Reply-To: <63h90vp3dn.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 08 May 2017 15:14:44 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26837 Cc: agrambot@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Am I mistaken in the following patch to fix this, or has load not been moving an already present file to the start of load-history since c 2005? --- a/src/lread.c +++ b/src/lread.c @@ -1885,7 +1885,7 @@ PREDICATE can also be an integer to pass to the faccessat(2) function, /* On the first cycle, we can easily test here whether we are reading the whole buffer. */ if (b && first_sexp) - whole_buffer = (PT == BEG && ZV == Z); + whole_buffer = (BUF_PT (b) == BUF_BEG (b) && BUF_ZV (b) == BUF_Z (b)); instream = stream; read_next: From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 03:27:15 2017 Received: (at 26837) by debbugs.gnu.org; 9 May 2017 07:27:15 +0000 Received: from localhost ([127.0.0.1]:60570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7zYB-00081h-6i for submit@debbugs.gnu.org; Tue, 09 May 2017 03:27:15 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:37810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7zY9-00081U-MH for 26837@debbugs.gnu.org; Tue, 09 May 2017 03:27:13 -0400 Received: by mail-it0-f41.google.com with SMTP id g126so4019478ith.0 for <26837@debbugs.gnu.org>; Tue, 09 May 2017 00:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=K3i6ophznQxysvVw7Tqgd7W/hGAf09Os7ttxQYQY+ik=; b=fNWa4oCW/Laq17WAswzNyy5Otwkabp6/FiWKFwj2qHcJpNT0QUpjFLpcE/h1VgJFMA Urq2y+4S2ARvRGYaTtpoRF+f66Y8AJz21afZGcvhKJeJ0/7ZyH+KyoR98ZTRbouYRbXb yLTdVVwDmRqyQA4akExi0ES5EbyTh3B1992o3TGwMn2j17kZABEtsf4wRmQHIkVspKl1 CAB0XSrBYe+tf9NpF03heMvt+btu8qoVcRiZNkxEQ28XMyo1nXFoFjRgWta1IfFnVYk1 wJn+uCk3WIjDemOVib0cNht5RJQpQ1dkzaI7FG2QRrYU/e4tOAPCDSMh8SP/TqCN69h2 LEUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=K3i6ophznQxysvVw7Tqgd7W/hGAf09Os7ttxQYQY+ik=; b=szuaUZMbEGHN3760JpSbI17VN2uNcoiZ6AvsGmNeaeiiI6y6HxID4rLsgCZbPMwcO9 5r7rXIsHsKuVb+Wv1oeLZI8yPFGRsK0hoaOo5IINjQNjqT0J1WBD2Ih7osTxrvsgM9+4 MWAKiynDb+IuQygO7jvVUsUuT/4tFY5y8mMJJPW9ohy2aqxowbaKRQwx8tDXLbXehyTM MpyqFeJr7677qu+g1pIuzGIRXl5Z/mgxU3xUClUOoLqOeGH81HkrQFk97sCPRN/RBZDE 9pi8Qixa56guDpqp+Fo0vJsXPKHwe7Z4mOvFhfnCFhTV9tBOsM5kNJ0DlrXju4oECzsU VoFA== X-Gm-Message-State: AODbwcDt5/L1aA9j75OtuLo9okNHn2IXmLouxNyWvnLq0GcwsxhxbQ0f uYQb1hE+39r2bk8c X-Received: by 10.36.95.144 with SMTP id r138mr30816itb.11.1494314827783; Tue, 09 May 2017 00:27:07 -0700 (PDT) Received: from lylat (S01061859339e9903.ss.shawcable.net. [70.64.86.72]) by smtp.gmail.com with ESMTPSA id c10sm2435537ioj.48.2017.05.09.00.27.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 May 2017 00:27:06 -0700 (PDT) From: Alex To: Glenn Morris Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> Date: Tue, 09 May 2017 01:26:59 -0600 In-Reply-To: (Glenn Morris's message of "Mon, 08 May 2017 20:04:56 -0400") Message-ID: <87bmr24hj0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Glenn Morris writes: > Am I mistaken in the following patch to fix this, or has load not been > moving an already present file to the start of load-history since c 2005? > > --- a/src/lread.c > +++ b/src/lread.c > @@ -1885,7 +1885,7 @@ PREDICATE can also be an integer to pass to the faccessat(2) function, > /* On the first cycle, we can easily test here > whether we are reading the whole buffer. */ > if (b && first_sexp) > - whole_buffer = (PT == BEG && ZV == Z); > + whole_buffer = (BUF_PT (b) == BUF_BEG (b) && BUF_ZV (b) == BUF_Z (b)); > > instream = stream; > read_next: I can't claim to know what is going on within that function, but your patch seems to only work for some files (e.g. your bar.el). If bar starts with a comment, then bar isn't moved to the top after evaluating (load "bar"). From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 12:33:53 2017 Received: (at 26837) by debbugs.gnu.org; 9 May 2017 16:33:53 +0000 Received: from localhost ([127.0.0.1]:34372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d885B-00081r-Ad for submit@debbugs.gnu.org; Tue, 09 May 2017 12:33:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d885A-00081e-4m for 26837@debbugs.gnu.org; Tue, 09 May 2017 12:33:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8854-00074g-82 for 26837@debbugs.gnu.org; Tue, 09 May 2017 12:33:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8852-00074N-Ps; Tue, 09 May 2017 12:33:44 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d8850-0000Y9-Td; Tue, 09 May 2017 12:33:43 -0400 From: Glenn Morris To: Alex Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> X-Spook: Ft. Meade Domestic Nuclear Detection Office domestic X-Ran: -g_YOQTd[pm+dZx_$t6@3.J&C]G0/<+(9bz2.La^Ll|qI4`xKkG_XGvcFQ'8$+OyNlG1SJ X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 09 May 2017 12:33:42 -0400 In-Reply-To: <87bmr24hj0.fsf@gmail.com> (Alex's message of "Tue, 09 May 2017 01:26:59 -0600") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alex wrote: >> - whole_buffer = (PT == BEG && ZV == Z); >> + whole_buffer = (BUF_PT (b) == BUF_BEG (b) && BUF_ZV (b) == BUF_Z (b)); [...] > I can't claim to know what is going on within that function, but your > patch seems to only work for some files (e.g. your bar.el). If bar > starts with a comment, then bar isn't moved to the top after evaluating > (load "bar"). The intent of the code seems to be to only adjust an existing load-history element for some file if the entire file is being loaded. I guess in the leading comment case, something else has already moved point looking for a significant leading comment (eg lexbind, script, prop-line). Hmmm. From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 14:39:34 2017 Received: (at 26837) by debbugs.gnu.org; 9 May 2017 18:39:34 +0000 Received: from localhost ([127.0.0.1]:34454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8A2o-0002Vb-8k for submit@debbugs.gnu.org; Tue, 09 May 2017 14:39:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8A2n-0002VO-0I for 26837@debbugs.gnu.org; Tue, 09 May 2017 14:39:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8A2g-0002oe-Q8 for 26837@debbugs.gnu.org; Tue, 09 May 2017 14:39:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8A2f-0002nv-3S; Tue, 09 May 2017 14:39:25 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d8A2e-0003OJ-JK; Tue, 09 May 2017 14:39:24 -0400 From: Glenn Morris To: Alex Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> X-Spook: Fundamentalism El Paso NASA condor Hazmat Suspicious X-Ran: ]QIy3XQVv.I5Y"do8T\~1&Inj2i7j}KM*,-g%CuYv-+F=6w%TgKp~XFDzDae>T.7%=?MXP X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 09 May 2017 14:39:24 -0400 In-Reply-To: (Glenn Morris's message of "Tue, 09 May 2017 12:33:42 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Glenn Morris wrote: >> I can't claim to know what is going on within that function, but your >> patch seems to only work for some files (e.g. your bar.el). If bar >> starts with a comment, then bar isn't moved to the top after evaluating >> (load "bar"). > > The intent of the code seems to be to only adjust an existing > load-history element for some file if the entire file is being loaded. > I guess in the leading comment case, something else has already moved > point looking for a significant leading comment (eg lexbind, script, > prop-line). Hmmm. I think it was the lexical-binding thing. Following seems to work: --- i/src/lread.c +++ w/src/lread.c @@ -1885,7 +1885,7 @@ PREDICATE can also be an integer to pass to the faccessat(2) function, /* On the first cycle, we can easily test here whether we are reading the whole buffer. */ if (b && first_sexp) - whole_buffer = (PT == BEG && ZV == Z); + whole_buffer = (BUF_PT (b) == BUF_BEG (b) && BUF_ZV (b) == BUF_Z (b)); instream = stream; read_next: @@ -2008,6 +2008,7 @@ BUFFER is the buffer to evaluate (nil means use current buffer), record_unwind_protect (save_excursion_restore, save_excursion_save ()); BUF_TEMP_SET_PT (XBUFFER (buf), BUF_BEGV (XBUFFER (buf))); specbind (Qlexical_binding, lisp_file_lexically_bound_p (buf) ? Qt : Qnil); + BUF_TEMP_SET_PT (XBUFFER (buf), BUF_BEGV (XBUFFER (buf))); readevalloop (buf, 0, filename, !NILP (printflag), unibyte, Qnil, Qnil, Qnil); unbind_to (count, Qnil); From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 15:13:50 2017 Received: (at 26837) by debbugs.gnu.org; 9 May 2017 19:13:50 +0000 Received: from localhost ([127.0.0.1]:34497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8AZy-0003Kc-Cw for submit@debbugs.gnu.org; Tue, 09 May 2017 15:13:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8AZw-0003KO-J9 for 26837@debbugs.gnu.org; Tue, 09 May 2017 15:13:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8AZo-0006NQ-9p for 26837@debbugs.gnu.org; Tue, 09 May 2017 15:13:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8AZo-0006NM-5z; Tue, 09 May 2017 15:13:40 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3586 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d8AZj-0002h0-AV; Tue, 09 May 2017 15:13:39 -0400 Date: Tue, 09 May 2017 22:12:48 +0300 Message-Id: <83inl9c09b.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: (message from Glenn Morris on Tue, 09 May 2017 14:39:24 -0400) Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org, agrambot@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Glenn Morris > Date: Tue, 09 May 2017 14:39:24 -0400 > Cc: 26837@debbugs.gnu.org > > I think it was the lexical-binding thing. Following seems to work: > > --- i/src/lread.c > +++ w/src/lread.c > @@ -1885,7 +1885,7 @@ PREDICATE can also be an integer to pass to the faccessat(2) function, > /* On the first cycle, we can easily test here > whether we are reading the whole buffer. */ > if (b && first_sexp) > - whole_buffer = (PT == BEG && ZV == Z); > + whole_buffer = (BUF_PT (b) == BUF_BEG (b) && BUF_ZV (b) == BUF_Z (b)); You are saying that set_buffer_internal didn't do its job? Of that the call was bypassed? From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 19:44:59 2017 Received: (at control) by debbugs.gnu.org; 9 May 2017 23:44:59 +0000 Received: from localhost ([127.0.0.1]:34757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8EoM-0003Or-VI for submit@debbugs.gnu.org; Tue, 09 May 2017 19:44:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8EoM-0003Od-1V for control@debbugs.gnu.org; Tue, 09 May 2017 19:44:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8EoG-0006c6-7q for control@debbugs.gnu.org; Tue, 09 May 2017 19:44:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8EoG-0006c0-4h for control@debbugs.gnu.org; Tue, 09 May 2017 19:44:52 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d8EoF-0000sG-Sb for control@debbugs.gnu.org; Tue, 09 May 2017 19:44:51 -0400 Subject: control message for bug 26837 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 09 May 2017 19:44:51 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) # db30296 close 26837 26.1 From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 19:49:28 2017 Received: (at 26837) by debbugs.gnu.org; 9 May 2017 23:49:28 +0000 Received: from localhost ([127.0.0.1]:34763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8Esg-0003W2-HT for submit@debbugs.gnu.org; Tue, 09 May 2017 19:49:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8Esf-0003Vq-4O for 26837@debbugs.gnu.org; Tue, 09 May 2017 19:49:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8EsZ-0008B3-Eu for 26837@debbugs.gnu.org; Tue, 09 May 2017 19:49:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8EsX-0008AJ-Rc; Tue, 09 May 2017 19:49:17 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d8EsX-0001A4-5G; Tue, 09 May 2017 19:49:17 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> <83inl9c09b.fsf@gnu.org> X-Spook: SRI condor Emergency response CIS AQAP DES ANZUS lynch X-Ran: avSSc5wG_N|Q^=]Nf\"[Z&OWgY%_?vO6rhEAeB!64i/S2x#@POtN`l>R8|e/'1:h2mv\g4 X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 09 May 2017 19:49:17 -0400 Message-ID: <7wpofh1the.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org, agrambot@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Eli Zaretskii wrote: >> - whole_buffer = (PT == BEG && ZV == Z); >> + whole_buffer = (BUF_PT (b) == BUF_BEG (b) && BUF_ZV (b) == BUF_Z (b)); > > You are saying that set_buffer_internal didn't do its job? Of that > the call was bypassed? When START = nil (eg when called from eval-buffer), set_buffer_internal is never called. From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 22:43:45 2017 Received: (at 26837) by debbugs.gnu.org; 10 May 2017 02:43:45 +0000 Received: from localhost ([127.0.0.1]:34828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8HbM-0004PB-US for submit@debbugs.gnu.org; Tue, 09 May 2017 22:43:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8HbL-0004Ow-8E for 26837@debbugs.gnu.org; Tue, 09 May 2017 22:43:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8HbD-0000yu-NH for 26837@debbugs.gnu.org; Tue, 09 May 2017 22:43:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8HbD-0000yq-KQ; Tue, 09 May 2017 22:43:35 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4049 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d8HbC-0007H2-PI; Tue, 09 May 2017 22:43:35 -0400 Date: Wed, 10 May 2017 05:43:20 +0300 Message-Id: <838tm5bfef.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: <7wpofh1the.fsf@fencepost.gnu.org> (message from Glenn Morris on Tue, 09 May 2017 19:49:17 -0400) Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> <83inl9c09b.fsf@gnu.org> <7wpofh1the.fsf@fencepost.gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org, agrambot@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Glenn Morris > Cc: agrambot@gmail.com, 26837@debbugs.gnu.org > Date: Tue, 09 May 2017 19:49:17 -0400 > > Eli Zaretskii wrote: > > >> - whole_buffer = (PT == BEG && ZV == Z); > >> + whole_buffer = (BUF_PT (b) == BUF_BEG (b) && BUF_ZV (b) == BUF_Z (b)); > > > > You are saying that set_buffer_internal didn't do its job? Of that > > the call was bypassed? > > When START = nil (eg when called from eval-buffer), set_buffer_internal > is never called. What's the use case when this goes together with b not being the current buffer? From debbugs-submit-bounces@debbugs.gnu.org Wed May 10 02:23:39 2017 Received: (at 26837) by debbugs.gnu.org; 10 May 2017 06:23:39 +0000 Received: from localhost ([127.0.0.1]:34923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8L2B-0004n1-G6 for submit@debbugs.gnu.org; Wed, 10 May 2017 02:23:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8L2A-0004mq-42 for 26837@debbugs.gnu.org; Wed, 10 May 2017 02:23:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8L24-0006UA-F8 for 26837@debbugs.gnu.org; Wed, 10 May 2017 02:23:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8L22-0006Tv-UE; Wed, 10 May 2017 02:23:30 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d8L20-0005go-Rv; Wed, 10 May 2017 02:23:28 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> <83inl9c09b.fsf@gnu.org> <7wpofh1the.fsf@fencepost.gnu.org> <838tm5bfef.fsf@gnu.org> X-Spook: Tamaulipas Aldergrove Yukon freedom Barrio Azteca Indigo X-Ran: U*>-,S%6x0_'Zw8dBVrQ=N9fhGne%h@|ofYM45@~.Lqi70eaPc*|{S6&c\70vFBu~)7uW0 X-Hue: brightcyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 10 May 2017 02:23:28 -0400 In-Reply-To: <838tm5bfef.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 May 2017 05:43:20 +0300") Message-ID: <88a86lp6vz.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org, agrambot@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Eli Zaretskii wrote: > What's the use case when this goes together with b not being the > current buffer? (load "file.el") -> load-source-file-function -> load-with-code-conversion -> (eval-buffer buffer ...) From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 16:11:18 2017 Received: (at 26837) by debbugs.gnu.org; 18 May 2017 20:11:18 +0000 Received: from localhost ([127.0.0.1]:53869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBRlW-0005gM-H2 for submit@debbugs.gnu.org; Thu, 18 May 2017 16:11:18 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:34700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBRlU-0005g9-Rz for 26837@debbugs.gnu.org; Thu, 18 May 2017 16:11:17 -0400 Received: by mail-it0-f67.google.com with SMTP id d68so5726338ita.1 for <26837@debbugs.gnu.org>; Thu, 18 May 2017 13:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jw1EYc4Ul7RI0wIcF9+7BrcAgGYVwO/Usupm4bqXr2E=; b=ovWPhAOwUNCJVMEMp119o4T4TjTBSkL8J5QWDaHJOWkNphCNYXuMUHqFxHCx0V1PzC EaSALG0ckVtfZE1470/cbY7cHL6dXBFu82lNDeKztGySoch91DiGOtzxa5zv63efMace IuaLBvS+h3cekIAWSf70oxckdTZmoRsN6zb3enmfFGutJ0HLIr7+bQUsR5EuuTDz1/t1 Fq5qM3S3AnQB/kGHOFd7lqfzj8M7DfHoLMyVi+hKPjCutLx517j1f0ACoZGW2AYZ8iC7 Dj0Z88iqfpswooUwWijC0QVTwUxkSgfowFBUP+R6aS6/kQ6Qfi93LbNKSJZYMCD38uvZ RzYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jw1EYc4Ul7RI0wIcF9+7BrcAgGYVwO/Usupm4bqXr2E=; b=HiOwho0nD+1uup6qDR/QdSq+8KThO0dwNHBkW8YY2wMN1zlZV9OMfxmtLPJuDwx4gM xsTvJVG2ftOqNHNQnhMYIpq541nsAxvnrLuNXDDd/4+sVPzMHgwyU+JPR9cwVxbui6jK 86/Tbfa/r3U37OuViV38lKXChAXnfK2CEnyKU8RMImuPzi4juxCBK4KGiyyYGbCEkQ8P Ap5ym+lYMEZU7Lqyrrgec8DQ/lVsa/zCZW92YFcYRMBf2ChEGAqLEcaSvJx54vMqLQol ACk/2S/uuaz8WTvxx/9dY3ngz6mjElJAQYJUuFvd1mGqaVAhu0K5/uuZQyrCajIpDR3/ LswA== X-Gm-Message-State: AODbwcDjOeADp5fvNb9N1yeDXZtK6GeFWgpSmps9xbtQLSBo5ayTPzXs jiV02b0DnTYaaw== X-Received: by 10.36.122.203 with SMTP id a194mr15917079itc.98.1495138270985; Thu, 18 May 2017 13:11:10 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id n14sm9827408itg.0.2017.05.18.13.11.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 May 2017 13:11:09 -0700 (PDT) From: Alex To: Glenn Morris Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> Date: Thu, 18 May 2017 14:11:00 -0600 In-Reply-To: (Glenn Morris's message of "Tue, 09 May 2017 14:39:24 -0400") Message-ID: <8760gyudrf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Glenn Morris writes: > Glenn Morris wrote: > > I think it was the lexical-binding thing. Following seems to work: > > --- i/src/lread.c > +++ w/src/lread.c > @@ -1885,7 +1885,7 @@ PREDICATE can also be an integer to pass to the faccessat(2) function, > /* On the first cycle, we can easily test here > whether we are reading the whole buffer. */ > if (b && first_sexp) > - whole_buffer = (PT == BEG && ZV == Z); > + whole_buffer = (BUF_PT (b) == BUF_BEG (b) && BUF_ZV (b) == BUF_Z (b)); > > instream = stream; > read_next: > @@ -2008,6 +2008,7 @@ BUFFER is the buffer to evaluate (nil means use current buffer), > record_unwind_protect (save_excursion_restore, save_excursion_save ()); > BUF_TEMP_SET_PT (XBUFFER (buf), BUF_BEGV (XBUFFER (buf))); > specbind (Qlexical_binding, lisp_file_lexically_bound_p (buf) ? Qt : Qnil); > + BUF_TEMP_SET_PT (XBUFFER (buf), BUF_BEGV (XBUFFER (buf))); > readevalloop (buf, 0, filename, > !NILP (printflag), unibyte, Qnil, Qnil, Qnil); > unbind_to (count, Qnil); That seems to work for me as well. Should it be documented that reevaluations of a file update the position of the file in load-history? I assumed this was already the case when making my autoload patch because of the "history" in load-history, but documentation would help to make that clear. PS: I realized that I was a bit careless in using SDATA without checking that the argument is necessarily a string. I don't think it matters much if your above patch is applied, but it's probably not a good idea to leave it in, just in case there's a bug somewhere else in the future. What do you think about the following diff? This removes the dependency on load-history altogether: --- a/src/eval.c +++ b/src/eval.c @@ -2021,7 +2021,10 @@ it defines a macro. */) if (!NILP (Fequal (fun, fundef))) error ("Autoloading file %s failed to define function %s", - SDATA (Fcar (Fcar (Vload_history))), + SDATA (Flocate_file_internal (Fcar (Fcdr (fundef)), + Vload_path, + Vload_suffixes, + Qnil)), SDATA (SYMBOL_NAME (funname))); else return fun; From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 19:17:40 2017 Received: (at 26837) by debbugs.gnu.org; 20 May 2017 23:17:40 +0000 Received: from localhost ([127.0.0.1]:57490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCDcx-00068x-R7 for submit@debbugs.gnu.org; Sat, 20 May 2017 19:17:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCDcw-00068k-EI for 26837@debbugs.gnu.org; Sat, 20 May 2017 19:17:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCDcq-0003P3-GJ for 26837@debbugs.gnu.org; Sat, 20 May 2017 19:17:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCDco-0003Nj-Rk; Sat, 20 May 2017 19:17:30 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dCDco-0003bM-6b; Sat, 20 May 2017 19:17:30 -0400 From: Glenn Morris To: Alex Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> <8760gyudrf.fsf@gmail.com> X-Spook: Fusion Center Evacuation Lightning blackjack kilo class X-Ran: WL]fpF0/jD`WWA-SM;P><4YWY`bi?c)z6o]p~c"SF*W.xW_'T (Alex's message of "Thu, 18 May 2017 14:11:00 -0600") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alex wrote: > That seems to work for me as well. Should it be documented that > reevaluations of a file update the position of the file in load-history? I think it's mentioned in the doc of load: Loading a file records its definitions, and its `provide' and `require' calls, in an element of `load-history' whose car is the file name loaded. See `load-history'. ^^^^^^^^^^^^^^^^^^^^^^^^^^^ but that did seem to be the only mention I found in a quick search. > PS: I realized that I was a bit careless in using SDATA without checking > that the argument is necessarily a string. I don't think it matters much > if your above patch is applied, but it's probably not a good idea to > leave it in, just in case there's a bug somewhere else in the future. In 58326f0 I check if the car is nil (though I don't see how it could be). Could add the same thing to eval.c. > What do you think about the following diff? This removes the dependency > on load-history altogether: > > --- a/src/eval.c > +++ b/src/eval.c > @@ -2021,7 +2021,10 @@ it defines a macro. */) > > if (!NILP (Fequal (fun, fundef))) > error ("Autoloading file %s failed to define function %s", > - SDATA (Fcar (Fcar (Vload_history))), > + SDATA (Flocate_file_internal (Fcar (Fcdr (fundef)), > + Vload_path, > + Vload_suffixes, > + Qnil)), > SDATA (SYMBOL_NAME (funname))); > else > return fun; I don't have an informed opinion right now. From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 19:24:48 2017 Received: (at 26837) by debbugs.gnu.org; 20 May 2017 23:24:48 +0000 Received: from localhost ([127.0.0.1]:57497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCDjs-0006JS-Ib for submit@debbugs.gnu.org; Sat, 20 May 2017 19:24:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCDjq-0006JF-Lw for 26837@debbugs.gnu.org; Sat, 20 May 2017 19:24:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCDjk-0006QQ-Mo for 26837@debbugs.gnu.org; Sat, 20 May 2017 19:24:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCDjj-0006PE-7f; Sat, 20 May 2017 19:24:39 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dCDji-0003vR-Rl; Sat, 20 May 2017 19:24:38 -0400 From: Glenn Morris To: Alex Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> <8760gyudrf.fsf@gmail.com> X-Spook: bootleg ASDIC Central Intelligence Agency Drill X-Ran: NkUzr9eymSc3a\,oRkwm0#Tc2-8Z~:zcsl/ (Glenn Morris's message of "Sat, 20 May 2017 19:17:30 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Glenn Morris wrote: > I think it's mentioned in the doc of load: > > Loading a file records its definitions, and its `provide' and > `require' calls, in an element of `load-history' whose > car is the file name loaded. See `load-history'. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Duh, re-reading that I see it doesn't say what I thought it said. So I guess it isn't documented, though it was clearly the intent of the code. I don't know if it should be mentioned explicitly. From debbugs-submit-bounces@debbugs.gnu.org Sun May 21 17:59:27 2017 Received: (at 26837) by debbugs.gnu.org; 21 May 2017 21:59:27 +0000 Received: from localhost ([127.0.0.1]:59689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCYsp-0005Di-64 for submit@debbugs.gnu.org; Sun, 21 May 2017 17:59:27 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:36133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCYsn-0005DU-JL for 26837@debbugs.gnu.org; Sun, 21 May 2017 17:59:25 -0400 Received: by mail-io0-f194.google.com with SMTP id f102so11902001ioi.3 for <26837@debbugs.gnu.org>; Sun, 21 May 2017 14:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=HH49tSnvonxrLOADf6tlk9+3eD5Xzh8YM/xOzTvNn28=; b=i6bT8Q4QVewpG/GyPraIccRybucHOiVtxnGJuzylGapGi1vUQpcMgmuLcUaT3we3UB UM6wEBxiGHpoqrqdxr9aRDaWo3QvMyUOyL304p9RgySa0Vi1boFdYXkYYkT3wL+nwq3r TD0LYGraNTp1UIIggnfm+BmQH6jzn47zsFhzTGnXNsoQEeh/D5LoqknyLUKGdmT+YMdo cvx7GyDx3qhF+kq4ieriyugbBDjWUtGwKky4OTutR3dvvirpH9ZL8uAEMQ/LICaT0vJY AI0+wx5O47dNd1k1oia3SLJFWjBPhBG9ooNMzhryX+DqoNomBWsmk7Fc1vBFEeoASxjm T9/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=HH49tSnvonxrLOADf6tlk9+3eD5Xzh8YM/xOzTvNn28=; b=ZtUGINSAqYZVVrUrbX7f3Tg7tuTAa7XjzHP3Sq3hO5+zVSMxBrw0PLkZDtHbM8OYrb uKkC0AvM+8Maf/EdnGrNF2zFl2bDR5FNHq8yswap+IDjLZyLFBBUBYu27OyxMcYNSelX SjUMZHPYil9LqYvwkDc22APVvH+QUMlYG4Q3hCy/F97ealK2dgfIB5tcGszTLAsrBlq8 edK5NWrMxyatth0uhYf0CzICyFsOaN5qsSFxQ5jldUnnKYpooRbnNELaVRV5J4OF5QJc HUYElcx2bINxplGAkI2D1XxK5JUXXCnv3mDh9v+EC+a12DwtBt7RKz7etba4w70js4NF 0fDA== X-Gm-Message-State: AODbwcCWulsmTpUcE/v+YQMc6mDH5VdNEFzSzydNHVuVjKVS3ku/2O3Z ODHlOZTbyE2xQg== X-Received: by 10.107.200.137 with SMTP id y131mr18094739iof.14.1495403959784; Sun, 21 May 2017 14:59:19 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id y7sm371824ioi.41.2017.05.21.14.59.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 May 2017 14:59:18 -0700 (PDT) From: Alex To: Glenn Morris Subject: Re: bug#26837: Wrong file in "autoloading failed to define" error References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> <8760gyudrf.fsf@gmail.com> Date: Sun, 21 May 2017 15:59:08 -0600 In-Reply-To: (Glenn Morris's message of "Sat, 20 May 2017 19:17:30 -0400") Message-ID: <871srh6fdf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26837 Cc: 26837@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Glenn Morris writes: > In 58326f0 I check if the car is nil (though I don't see how it could be). > Could add the same thing to eval.c. According to the docstring of load-history: As an exception, one of the alist elements may have FILE-NAME nil, for symbols and features not associated with any file. With your proposed patch I don't think it's really an issue anymore, but previously it could have triggered a segfault under that rare condition. > I don't know if it should be mentioned explicitly. If the intention is that someone can expect the position of files in load-history to be updated so that it provides a history of some sort (i.e. use (caar load-history) to get the last file evaluated), then I would think that there should be a line mentioning it somewhere. From unknown Mon Jun 23 23:52:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 19 Jun 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator