GNU bug report logs - #26822
[PATCH] gnu: Add git-repo.

Previous Next

Full log

Message #8 received at 26822 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 26822 <at> debbugs.gnu.org
Subject: Re: bug#26822: [PATCH] gnu: Add git-repo.
Date: Sun, 7 May 2017 19:46:45 -0400

[Message part 1 (text/plain, inline)]

On Sun, May 07, 2017 at 11:41:07PM +0200, Hartmut Goebel wrote:
> * gnu/packages/android.scm (git-repo): New variable.

Thanks!

> +     `(#:python ,python-2

If it only supports Python 2, can you say so in a comment?

> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'build
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (repo-dir (string-append out "/share/" ,name)))
> +               (substitute* "repo"
> +                 (("^repodir = '\\.repo'")
> +                  (string-append "repodir = '" repo-dir "'"))
> +                 (("^S_repo = 'repo'") "S_repo = '.'"))
> +               #t
> +               )))

For clarify, I think it should delete the build phase (since nothing is
built here) and add a new phase for this substitution.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.