GNU bug report logs - #26817
[PATCH] gnu: Add pngcrunch.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26817 in the body.
You can then email your comments to 26817 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add pngcrunch.
Date: Sun,  7 May 2017 19:24:59 +0200

* gnu/packages/image.scm (pngcrunch): New variable.
---
 gnu/packages/image.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 1a11085..3368e23 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -155,6 +155,40 @@ APNG patch provides APNG support to libpng.")
        (sha256
         (base32 "1n2lrzjkm5jhfg2bs10q398lkwbbx742fi27zgdgx0x23zhj0ihg"))))))
 
+(define-public pngcrunch
+  (package
+   (name "pngcrunch")
+   (version "1.8.11")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://sourceforge/pmt/pngcrush/"
+                                version "/pngcrush-" version ".tar.xz"))
+            (sha256 (base32
+                     "1c7m316i91jp3h1dj1ppppdv6zilm2njk1wrpqy2zj0fcll06lwd"))))
+   (build-system gnu-build-system)
+   (arguments
+    '(#:make-flags '("-f" "Makefile-nolib")
+      #:tests? #f ; no check target
+      #:phases
+      (modify-phases %standard-phases
+        (replace 'configure
+          (lambda* (#:key inputs outputs #:allow-other-keys)
+            (substitute* "Makefile-nolib"
+              (("^(PNG(INC|LIB) = )/usr/local/" line vardef)
+               (string-append vardef (assoc-ref inputs "libpng") "/"))
+              (("^(Z(INC|LIB) = )/usr/local/" line vardef)
+               (string-append vardef (assoc-ref inputs "zlib") "/"))
+              (("\\$\\(DESTDIR\\)/usr/")
+               (string-append (assoc-ref outputs "out") "/"))))))))
+   (inputs
+    `(("libpng" ,libpng)
+      ("zlib" , zlib)))
+   (home-page "https://pmt.sourceforge.net/pngcrush")
+   (synopsis "Utility to compress PNG files")
+   (description "pngcrusqh is an optimizer for PNG (Portable Network Graphics)
+files.  It can compress them as much as 40% losslessly.")
+   (license license:zlib)))
+
 (define-public libjpeg
   (package
    (name "libjpeg")
-- 
2.7.4

Message #8 received at 26817 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 26817 <at> debbugs.gnu.org
Subject: Re: bug#26817: [PATCH] gnu: Add pngcrunch.
Date: Sun, 7 May 2017 19:36:46 -0400

[Message part 1 (text/plain, inline)]

On Sun, May 07, 2017 at 07:24:59PM +0200, Hartmut Goebel wrote:
> * gnu/packages/image.scm (pngcrunch): New variable.

Thanks, LGTM overall!

> +              (("\\$\\(DESTDIR\\)/usr/")
> +               (string-append (assoc-ref outputs "out") "/"))))))))

That's strange; DESTDIR is typically an intermediate location between
the source directory and PREFIX. I assume this Makefile is written by
hand?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26817 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26817 <at> debbugs.gnu.org
Subject: Re: bug#26817: [PATCH] gnu: Add pngcrunch.
Date: Mon, 8 May 2017 09:27:36 +0200

[Message part 1 (text/plain, inline)]

Am 08.05.2017 um 01:36 schrieb Leo Famulari:
>> > +              (("\\$\\(DESTDIR\\)/usr/")
>> > +               (string-append (assoc-ref outputs "out") "/"))))))))
> That's strange; DESTDIR is typically an intermediate location between
> the source directory and PREFIX. I assume this Makefile is written by
> hand?

Yes, it is written by hand and not using e.g PREFIX :-(

Should I add a comment?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[Message part 2 (text/html, inline)]

Message #14 received at 26817 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 26817 <at> debbugs.gnu.org
Subject: Re: bug#26817: [PATCH] gnu: Add pngcrunch.
Date: Mon, 8 May 2017 13:26:39 -0400

[Message part 1 (text/plain, inline)]

On Mon, May 08, 2017 at 09:27:36AM +0200, Hartmut Goebel wrote:
> Am 08.05.2017 um 01:36 schrieb Leo Famulari:
> >> > +              (("\\$\\(DESTDIR\\)/usr/")
> >> > +               (string-append (assoc-ref outputs "out") "/"))))))))
> > That's strange; DESTDIR is typically an intermediate location between
> > the source directory and PREFIX. I assume this Makefile is written by
> > hand?
> 
> Yes, it is written by hand and not using e.g PREFIX :-(
> 
> Should I add a comment?

Yes, I think a brief comment would help other readers later on.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 26817-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 26817-close <at> debbugs.gnu.org
Cc: Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#26817: [PATCH] gnu: Add pngcrunch.
Date: Tue, 9 May 2017 20:12:33 +0200

Add a comment and pushed as
2f8b9c4648ef7b52e0bbae040914b007f565f877

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.