GNU bug report logs - #26815
[PATCH 0/3] Hybrid UEFI disk image

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 26815 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: bug#26815: [PATCH 2/3] vm: Support creating FAT partitions.
Date: Mon, 08 May 2017 16:45:27 +0200

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

>>+(define* (format-partition partition type
>>+                           #:key label)
>>+  "Create a file system TYPE on PARTITION.  If LABEL is true, use that as the
>>+volume name."
>>+  (cond
>>+   ((string-prefix? "ext" type)
>>+    (create-ext-file-system partition type #:label label))
>>+   ((string-suffix? "fat" type)
>>+    (create-fat-file-system partition #:label label))
>>+     (else (error "Unsupported file system."))))
>
>        ^^^ Indentation of the "else" is strange.
>
> Otherwise LGTM!

Same here!

Ludo'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.