GNU bug report logs - #26815
[PATCH 0/3] Hybrid UEFI disk image

Previous Next

Full log

Message #49 received at 26815 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26815 <at> debbugs.gnu.org
Subject: Re: bug#26815: [PATCH 2/3] vm: Support creating FAT partitions.
Date: Sun, 7 May 2017 22:07:51 +0200

>+(define* (format-partition partition type
>+                           #:key label)
>+  "Create a file system TYPE on PARTITION.  If LABEL is true, use that as the
>+volume name."
>+  (cond
>+   ((string-prefix? "ext" type)
>+    (create-ext-file-system partition type #:label label))
>+   ((string-suffix? "fat" type)
>+    (create-fat-file-system partition #:label label))
>+     (else (error "Unsupported file system."))))

       ^^^ Indentation of the "else" is strange.

Otherwise LGTM!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.