GNU bug report logs - #26815
[PATCH 0/3] Hybrid UEFI disk image

Previous Next

Full log

Message #156 received at 26815 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26815 <at> debbugs.gnu.org
Subject: Re: bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images.
Date: Fri, 19 May 2017 09:00:08 +0200

Marius Bakke <mbakke <at> fastmail.com> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>>> From b2236aa915bfb32e974546790a1e87ef1b268403 Mon Sep 17 00:00:00 2001
>>> From: Marius Bakke <mbakke <at> fastmail.com>
>>> Date: Thu, 18 May 2017 18:10:31 +0200
>>> Subject: [PATCH] vm: Initialize-hard-disk now takes a grub-efi parameter.
>>>
>>> * gnu/build/vm.scm (initialize-hard-disk): Learn #:grub-efi.
>>> (install-efi): Use it.
>>> * gnu/system/vm.scm (qemu-image): Pass it.
>>
>> LGTM!  I suppose you’d squash it with the initial patch?
>
> Indeed. Figured this was an easier review format, though.

Definitely.

> I'll push this series shortly, after some basic sanity checks. Thanks a
> lot for the great feedback! I'll work on a more Guixy way of creating
> the standalone GRUB image and also a system test for the next release ;-)

Awesome, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.