Subject: bug#26813: closed (Re: bug#26813: [PATCH] re2: add missing '#:modules' imports)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 07 May 2017 18:22:02 +0000

Your bug report

#26813: [PATCH] re2: add missing '#:modules' imports

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
26813: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26813
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#26813: [PATCH] re2: add missing '#:modules' imports
From: Leo Famulari <[email-masked]>
To: Sergei Trofimovich <[email-masked]>
Cc: [email-masked]
Date: Sun, 7 May 2017 14:21:29 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

On Sun, May 07, 2017 at 11:48:37AM +0100, Sergei Trofimovich wrote:
> Noticed as a 're2' build failure:
> 
> /gnu/store/...-re2-2017-03-01-guile-builder:1:2276: source expression failed
> to match any pattern in form (%modify-phases phases* (delete (quote configure)))
> 
> * gnu/packages/regex.scm (re2): add missing '#:modules' imports
> 
> Signed-off-by: Sergei Trofimovich <[email-masked]>

Pushed by Danny as 7a4a64e99e65e96a4dc3e65ae691b4c80b7642e8.

Sergei, we use the signed-off-by line to make it easier to see when
somebody has pushed a patch to Savannah on behalf of somebody else
(other projects use it in a variety of different ways). In this case,
Danny signed off on the commit for you. So, no need to sign off on your
Guix contributions :)

Subject: [PATCH] re2: add missing '#:modules' imports
From: Sergei Trofimovich <[email-masked]>
To: [email-masked]
Cc: Sergei Trofimovich <[email-masked]>
Date: Sun, 7 May 2017 11:48:37 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Noticed as a 're2' build failure:

/gnu/store/...-re2-2017-03-01-guile-builder:1:2276: source expression failed
to match any pattern in form (%modify-phases phases* (delete (quote configure)))

* gnu/packages/regex.scm (re2): add missing '#:modules' imports

Signed-off-by: Sergei Trofimovich <[email-masked]>
---
 gnu/packages/regex.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/regex.scm b/gnu/packages/regex.scm
index f55faaf04..779050525 100644
--- a/gnu/packages/regex.scm
+++ b/gnu/packages/regex.scm
@@ -41,7 +41,10 @@
                  "1s3kdcrz2mwi30k6pz9jkv5vk8b704bz65xgcr67wbn2pn3hpnqr"))))
      (build-system gnu-build-system)
      (arguments
-      `(#:test-target "test"
+      `(#:modules ((guix build gnu-build-system)
+                   (guix build utils)
+                   (srfi srfi-1))
+        #:test-target "test"
         ;; There is no configure step, but the Makefile respects a prefix.
         ;; As ./configure does not know anything about the target CXX
         ;; we need to specify TARGET-g++ explicitly.
-- 
2.12.2