GNU bug report logs - #26812
[PATCH] gnu: Add emacs-evil-commentary.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26812 in the body.
You can then email your comments to 26812 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: Add emacs-evil-commentary.
Date: Sun,  7 May 2017 15:20:05 +0530

* gnu/packages/emacs.scm (emacs-evil-commentary): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 47fe0cc84..859026659 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4622,3 +4622,26 @@ pressed simultaneously or a single key quickly pressed twice.")
     (description "@code{emacs-evil-surround} allows easy deletion, change and
 addition of surrounding pairs, such as parantheses and quotes, in evil mode.")
     (license license:gpl3+)))
+
+(define-public emacs-evil-commentary
+  (package
+    (name "emacs-evil-commentary")
+    (version "2.1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/linktohack/evil-commentary/archive/v"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1jdya0i921nwskwrzdsj0vrr3m7gm49dy6f6pk9p5nxaarfxk230"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-evil" ,emacs-evil)))
+    (home-page "https://github.com/linktohack/evil-commentary")
+    (synopsis "Comment out code in evil mode")
+    (description "@code{emacs-evil-commentary} makes it easy to comment out
+lines of code in evil mode.")
+    (license license:gpl3+)))
-- 
2.12.2

Message #8 received at 26812 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>, 26812 <at> debbugs.gnu.org
Subject: Re: bug#26812: [PATCH] gnu: Add emacs-evil-commentary.
Date: Mon, 08 May 2017 10:13:02 +0200

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * gnu/packages/emacs.scm (emacs-evil-commentary): New variable.

[...]

> +    (home-page "https://github.com/linktohack/evil-commentary")
> +    (synopsis "Comment out code in evil mode")
> +    (description "@code{emacs-evil-commentary} makes it easy to comment out
> +lines of code in evil mode.")

Could you expand on this description a little? Something like "adds
keybindings to comment out lines, selections or regions". Maybe also
mention the keybindings as in the first paragraph of the README.

Nit-pick of course, but I've come to really appreciate descriptions that
don't require me to visit the home page, dig around for READMEs or even
read the source code.. :P

LGTM either way.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26812 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26812 <at> debbugs.gnu.org
Subject: Re: bug#26812: [PATCH] gnu: Add emacs-evil-commentary.
Date: Mon, 08 May 2017 22:26:59 +0530

[Message part 1 (text/plain, inline)]

> Nit-pick of course, but I've come to really appreciate descriptions that
> don't require me to visit the home page, dig around for READMEs or even
> read the source code.. :P

I'm fine with nitpicking. It's important to maintain quality. :-)

Please find attached an updated patch. Let me know if it's fine.

[0001-gnu-Add-emacs-evil-commentary.patch (text/x-patch, inline)]

From bc9172d11dd11b4e9df888e5ffb0d928ecc292cf Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac <at> systemreboot.net>
Date: Sun, 7 May 2017 15:18:02 +0530
Subject: [PATCH] gnu: Add emacs-evil-commentary.

* gnu/packages/emacs.scm (emacs-evil-commentary): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 47fe0cc84..368e8cab5 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4622,3 +4622,27 @@ pressed simultaneously or a single key quickly pressed twice.")
     (description "@code{emacs-evil-surround} allows easy deletion, change and
 addition of surrounding pairs, such as parantheses and quotes, in evil mode.")
     (license license:gpl3+)))
+
+(define-public emacs-evil-commentary
+  (package
+    (name "emacs-evil-commentary")
+    (version "2.1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/linktohack/evil-commentary/archive/v"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1jdya0i921nwskwrzdsj0vrr3m7gm49dy6f6pk9p5nxaarfxk230"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-evil" ,emacs-evil)))
+    (home-page "https://github.com/linktohack/evil-commentary")
+    (synopsis "Comment out code in evil mode")
+    (description "@code{emacs-evil-commentary} adds keybindings to easily
+comment out lines of code in evil mode.  It provides @code{gcc} to comment out
+lines, and @code{gc} to comment out the target of a motion.")
+    (license license:gpl3+)))
-- 
2.12.2

Message #14 received at 26812 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>, 26812 <at> debbugs.gnu.org
Subject: Re: bug#26812: [PATCH] gnu: Add emacs-evil-commentary.
Date: Tue, 09 May 2017 15:30:27 +0200

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

>> Nit-pick of course, but I've come to really appreciate descriptions that
>> don't require me to visit the home page, dig around for READMEs or even
>> read the source code.. :P
>
> I'm fine with nitpicking. It's important to maintain quality. :-)
>
> Please find attached an updated patch. Let me know if it's fine.

Looks great, thanks!

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 26812-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26812-done <at> debbugs.gnu.org
Subject: Re: bug#26812: [PATCH] gnu: Add emacs-evil-commentary.
Date: Wed, 10 May 2017 16:22:54 +0530

Pushed!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.