GNU bug report logs - #26803
Java things

Previous Next

Package: guix-patches;

Reported by: Ricardo Wurmus <rekado <at> elephly.net>

Date: Sat, 6 May 2017 14:02:02 UTC

Severity: normal

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log


Message #221 received at 26803 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Roel Janssen <roel <at> gnu.org>
Cc: Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 26803 <at> debbugs.gnu.org
Subject: Re: bug#26803: [PATCH 19/36] gnu: Add java-commons-codec.
Date: Wed, 10 May 2017 16:25:52 +0200
Roel Janssen <roel <at> gnu.org> writes:

> Ricardo Wurmus writes:
>
>> From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
>>
>> * gnu/packages/java.scm (java-commons-codec): New variable.
>>
>> Co-authored-by: Ricardo Wurmus <rekado <at> elephly.net>
>> ---
[…]
>> +    (arguments
>> +     `(#:test-target "test"
>> +       #:make-flags
>> +       (let ((hamcrest (assoc-ref %build-inputs "java-hamcrest-core"))
>> +             (junit    (assoc-ref %build-inputs "java-junit")))
>> +         (list (string-append "-Djunit.jar=" junit "/share/java/junit.jar")
>> +               (string-append "-Dhamcrest.jar=" hamcrest
>> +                              "/share/java/hamcrest-core.jar")
>> +               ;; Do not append version to jar.
>> +               "-Dfinal.name=commons-codec"))
>> +       #:phases
>> +       ;; TODO: I don't like this
>> +       (modify-phases %standard-phases
>> +         (add-after 'build 'build-javadoc
>> +           ant-build-javadoc)
>> +         (replace 'install
>> +           (install-jars "dist"))
>> +         ;; TODO: do this if javadoc argument is given?
>> +         (add-after 'install 'install-doc
>> +           (install-javadoc "dist/docs/api")))))
>
> Is this a good moment to look into these TODOs?  I don't think they are
> that bad, and the output includes the Javadoc stuff, right?

Yeah, I think I don’t feel so strongly about this any more.  I’ve
removed the TODOs.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net





This bug report was last modified 8 years and 94 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.