Subject: bug#26803: [PATCH 31/36] gnu: Add java-httpcomponents-httpclient.

From: Roel Janssen <[email-masked]>
Date: Mon, 15 May 2017 23:26:51 +0200

Ricardo Wurmus writes:

> Roel Janssen <[email-masked]> writes:
>
>> Ricardo Wurmus writes:
>>
>>> * gnu/packages/java.scm (java-httpcomponents-httpclient): New variable.
>>> ---
>>>  gnu/packages/java.scm | 36 ++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 36 insertions(+)
>>>
>>> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
>>> index 19642cbfc..ee3a2bd2b 100644
>>> --- a/gnu/packages/java.scm
>>> +++ b/gnu/packages/java.scm
>>> @@ -2113,6 +2113,42 @@ NIO.")))
>>>      (description "This package provides the HttpCore benchmarking tool.  It is
>>>  an Apache AB clone based on HttpCore.")))
>>>
>>> +(define-public java-httpcomponents-httpclient
>>> +  (package
>>> +    (name "java-httpcomponents-httpclient")
>>> +    (version "4.5.3")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> +              (uri (string-append "mirror://apache/httpcomponents/httpclient/"
>>> +                                  "source/httpcomponents-client-"
>>> +                                  version "-src.tar.gz"))
>>> +              (sha256
>>> +               (base32
>>> +                "1428399s7qy3cim5wc6f3ks4gl9nf9vkjpfmnlap3jflif7g2pj1"))))
>>> +    (build-system ant-build-system)
>>> +    (arguments
>>> +     `(#:jar-name "httpcomponents-httpclient.jar"
>>> +       #:phases
>>> +       (modify-phases %standard-phases
>>> +         (add-after 'unpack 'chdir
>>> +           (lambda _ (chdir "httpclient") #t)))))
>>> +    (inputs
>>> +     `(("java-commons-logging-minimal" ,java-commons-logging-minimal)
>>> +       ("java-commons-codec" ,java-commons-codec)
>>> +       ("java-hamcrest-core" ,java-hamcrest-core)
>>> +       ("java-httpcomponents-httpcore" ,java-httpcomponents-httpcore)
>>> +       ("java-mockito" ,java-mockito-1)
>>> +       ("java-junit" ,java-junit)))
>>> +    (home-page "https://hc.apache.org/httpcomponents-client-ga/")
>>> +    (synopsis "HTTP client library for Java")
>>> +    (description "Although the @code{java.net} package provides basic
>>
>> I thought package names weren't supposed to be @code{}ed.
>
> This is a Java namespace, not a Guix package.  It is only used in import
> statements, so it’s code.  “java.net” belongs to the standard library,
> so it also doesn’t have a separate project name (unlike these Apache
> projects).

Maybe the "... @code{java.net} >>>package<<<" should be rephrased to
"... @code{java.net} namespace provided by this package ...".

Either way is fine though, this is nitpicking at its finest.. ;)

Kind regards,
Roel Janssen