Subject: Re: bug#26803: [PATCH 36/36] gnu: Add java-commons-compress.

From: Roel Janssen <[email-masked]>
Date: Thu, 11 May 2017 10:53:49 +0200

Ricardo Wurmus writes:

> * gnu/packages/java.scm (java-commons-compress): New variable.
> ---
>  gnu/packages/java.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 8ecd5bbfc..35e1c315e 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2275,6 +2275,50 @@ transfer, etc., and you can integrate its functionality into your own Java
>  programs.")
>      (license license:bsd-3)))
>  
> +(define-public java-commons-compress
> +  (package
> +    (name "java-commons-compress")
> +    (version "1.13")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://apache/commons/compress/source/"
> +                                  "commons-compress-" version "-src.tar.gz"))
> +              (sha256
> +               (base32
> +                "1vjqvavrn0babffn1kciz6v52ibwq2vwhzlb95hazis3lgllnxc8"))))
> +    (build-system ant-build-system)
> +    (arguments
> +     `(#:jar-name "commons-compress.jar"
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'delete-bad-tests
> +           (lambda _
> +             (with-directory-excursion "src/test/java/org/apache/commons/compress/"
> +               ;; FIXME: These tests really should not fail.  Maybe they are
> +               ;; indicative of problems with our Java packaging work.

We should definitely take note of this.

> +               ;; This test fails with a null pointer exception.
> +               (delete-file "archivers/sevenz/SevenZOutputFileTest.java")
> +
> +               ;; This test fails to open test resources.
> +               (delete-file "archivers/zip/ExplodeSupportTest.java")
> +
> +               ;; FIXME: This test adds a dependency on powermock, which is hard to
> +               ;; package at this point.
> +               ;; https://github.com/powermock/powermock
> +               (delete-file "archivers/sevenz/SevenZNativeHeapTest.java"))
> +             #t)))))
> +    (inputs
> +     `(("java-junit" ,java-junit)
> +       ("java-hamcrest-core" ,java-hamcrest-core)
> +       ("java-mockito" ,java-mockito-1)
> +       ("java-xz" ,java-xz)))
> +    (home-page "https://commons.apache.org/proper/commons-compress/")
> +    (synopsis "Java library for working with compressed files")
> +    (description "The Apache Commons Compress library defines an API for
> +working with compressed files such as ar, cpio, Unix dump, tar, zip, gzip, XZ,
> +Pack200, bzip2, 7z, arj, lzma, snappy, DEFLATE, lz4 and Z files.")
> +    (license license:asl2.0)))
> +
>  (define-public java-commons-cli
>    (package
>      (name "java-commons-cli")

LGTM.

I think this concludes the first batch of Java packages.

Thanks a lot for this very important work!

Kind regards,
Roel Janssen