Subject: Re: bug#26803: [PATCH 34/36] gnu: Add java-commons-net.

From: Roel Janssen <[email-masked]>
Date: Thu, 11 May 2017 10:40:19 +0200

Ricardo Wurmus writes:

> * gnu/packages/java.scm (java-commons-net): New variable.
> ---
>  gnu/packages/java.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 1639570f9..287a7ae69 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2219,6 +2219,34 @@ project in its HttpClient and HttpCore modules, which offer better performance
>  and more flexibility.")
>      (license license:asl2.0)))
>  
> +(define-public java-commons-net
> +  (package
> +    (name "java-commons-net")
> +    (version "3.6")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://apache/commons/net/source/"
> +                                  "commons-net-" version "-src.tar.gz"))
> +              (sha256
> +               (base32
> +                "0n0cmnddk9qdqhjvka8pc6hd9mn2qi3166f1s6xk32h7rfy1adxr"))))
> +    (build-system ant-build-system)
> +    (arguments
> +     `(;; FIXME: MainTest.java tries to read "examples.properties" (which
> +       ;; should be "resources/examples/examples.properties"), but gets "null"
> +       ;; instead.

This sounds fixable in a substitute construct.  But maybe I am wrong
about it.  Would you like to try that first?

> +       #:tests? #f
> +       #:jar-name "commons-net.jar"))
> +    (native-inputs
> +     `(("java-junit" ,java-junit)
> +       ("java-hamcrest-core" ,java-hamcrest-core)))
> +    (home-page "http://commons.apache.org/net/")
> +    (synopsis "Client library for many basic Internet protocols")
> +    (description "The Apache Commons Net library implements the client side of
> +many basic Internet protocols.  The purpose of the library is to provide
> +fundamental protocol access, not higher-level abstractions.")
> +    (license license:asl2.0)))
> +
>  (define-public java-commons-cli
>    (package
>      (name "java-commons-cli")

Otherwise, LGTM.

Kind regards,
Roel Janssen