Subject: Re: bug#26803: [PATCH 22/36] gnu: java-hamcrest-core: Declare test target.

From: Ricardo Wurmus <[email-masked]>
Date: Wed, 10 May 2017 18:04:10 +0200

Roel Janssen <[email-masked]> writes:

> Ricardo Wurmus writes:
>
>> * gnu/packages/java.scm (java-hamcrest-core)[arguments]: Add value for
>> test-target.
>> ---
>>  gnu/packages/java.scm | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
>> index 3271dd55c..2a5797a5c 100644
>> --- a/gnu/packages/java.scm
>> +++ b/gnu/packages/java.scm
>> @@ -1087,6 +1087,7 @@ an Ant task that extends the built-in @code{jar} task.")
>>                    (guix build utils)
>>                    (srfi srfi-1))
>>         #:make-flags (list (string-append "-Dversion=" ,version))
>> +       #:test-target "unit-test"
>>         #:build-target "core"
>>         #:phases
>>         (modify-phases %standard-phases
>
> LGTM!

Thank you very much for your review so far!  I’ve pushed the packages up
to this one.  Less than 14 to go for this patch set :)

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net