Subject: Re: bug#26803: [PATCH 19/36] gnu: Add java-commons-codec.

From: Ricardo Wurmus <[email-masked]>
Date: Wed, 10 May 2017 16:25:52 +0200

Roel Janssen <[email-masked]> writes:

> Ricardo Wurmus writes:
>
>> From: Hartmut Goebel <[email-masked]>
>>
>> * gnu/packages/java.scm (java-commons-codec): New variable.
>>
>> Co-authored-by: Ricardo Wurmus <[email-masked]>
>> ---
[…]
>> +    (arguments
>> +     `(#:test-target "test"
>> +       #:make-flags
>> +       (let ((hamcrest (assoc-ref %build-inputs "java-hamcrest-core"))
>> +             (junit    (assoc-ref %build-inputs "java-junit")))
>> +         (list (string-append "-Djunit.jar=" junit "/share/java/junit.jar")
>> +               (string-append "-Dhamcrest.jar=" hamcrest
>> +                              "/share/java/hamcrest-core.jar")
>> +               ;; Do not append version to jar.
>> +               "-Dfinal.name=commons-codec"))
>> +       #:phases
>> +       ;; TODO: I don't like this
>> +       (modify-phases %standard-phases
>> +         (add-after 'build 'build-javadoc
>> +           ant-build-javadoc)
>> +         (replace 'install
>> +           (install-jars "dist"))
>> +         ;; TODO: do this if javadoc argument is given?
>> +         (add-after 'install 'install-doc
>> +           (install-javadoc "dist/docs/api")))))
>
> Is this a good moment to look into these TODOs?  I don't think they are
> that bad, and the output includes the Javadoc stuff, right?

Yeah, I think I don’t feel so strongly about this any more.  I’ve
removed the TODOs.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net