GNU bug report logs - #26802
Single source file emacs packages get a ".el.el" extension

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26802: closed (Single source file emacs packages get a
 ".el.el" extension)
Date: Mon, 22 May 2017 23:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 23 May 2017 04:40:44 +0530
with message-id <f552e15f.AEEAK4Qr7-AAAAAAAAAAAAPCiaQAAAACwQwAAAAAAAW9WABZI3AM <at> mailjet.com>
and subject line Re: bug#26802: [PATCH 4/4] build: emacs: Fix `store-file->elisp-source-file'.
has caused the debbugs.gnu.org bug report #26802,
regarding Single source file emacs packages get a ".el.el" extension
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26802: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26802
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Subject: Single source file emacs packages get a ".el.el" extension
Date: Sat, 06 May 2017 18:21:56 +0530

[Message part 3 (text/plain, inline)]

Single source file emacs packages (such as emacs-goto-chg,
emacs-transpose-frame, emacs-key-chord, etc.) get installed with a
double extension (".el.el"). This patch fixes that.

[0001-build-emacs-Don-t-append-an-extra-.el-to-source-file.patch (text/x-patch, inline)]

From 4796890f507a126edb6020573547d37815b3241e Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac <at> systemreboot.net>
Date: Sat, 6 May 2017 18:16:36 +0530
Subject: [PATCH] build: emacs: Don't append an extra ".el" to source file
 name.

* guix/build/emacs-build-system.scm (store-file->elisp-source-file): The
  source file name already has a ".el" suffix. Don't append an extra ".el".
---
 guix/build/emacs-build-system.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-system.scm
index 44e8b0d31..3669b7d59 100644
--- a/guix/build/emacs-build-system.scm
+++ b/guix/build/emacs-build-system.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2015 Federico Beffa <beffa <at> fbengineering.ch>
 ;;; Copyright © 2016 David Thompson <davet <at> gnu.org>
 ;;; Copyright © 2016 Alex Kost <alezost <at> gmail.com>
+;;; Copyright © 2017 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -50,7 +51,7 @@ name that has been stripped of the hash and version number."
   (let-values (((name version)
                 (package-name->name+version
                  (strip-store-file-name file))))
-    (string-append name ".el")))
+    name))
 
 (define* (unpack #:key source #:allow-other-keys)
   "Unpack SOURCE into the build directory.  SOURCE may be a compressed
-- 
2.12.2

[Message part 5 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26802-done <at> debbugs.gnu.org
Cc: Alex Kost <alezost <at> gmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#26802: [PATCH 4/4] build: emacs: Fix
 `store-file->elisp-source-file'.
Date: Tue, 23 May 2017 04:40:44 +0530

> Pro tip: (string-drop-right …) can be replaced by:
>
>   (basename file ".el")

Thanks! Made this modification...

Pushed patches 1, 2 and 4.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.