From unknown Sat Sep 13 11:12:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26802 <26802@debbugs.gnu.org> To: bug#26802 <26802@debbugs.gnu.org> Subject: Status: Single source file emacs packages get a ".el.el" extension Reply-To: bug#26802 <26802@debbugs.gnu.org> Date: Sat, 13 Sep 2025 18:12:05 +0000 retitle 26802 Single source file emacs packages get a ".el.el" extension reassign 26802 guix-patches submitter 26802 Arun Isaac severity 26802 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 08:52:34 2017 Received: (at submit) by debbugs.gnu.org; 6 May 2017 12:52:34 +0000 Received: from localhost ([127.0.0.1]:57299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6zCM-0006g7-2f for submit@debbugs.gnu.org; Sat, 06 May 2017 08:52:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@bnc3.mailjet.com>) id 1d6zCK-0006fr-Fj for submit@debbugs.gnu.org; Sat, 06 May 2017 08:52:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@bnc3.mailjet.com>) id 1d6zCE-0005FS-Nr for submit@debbugs.gnu.org; Sat, 06 May 2017 08:52:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40801) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@bnc3.mailjet.com>) id 1d6zCE-0005FN-Ko for submit@debbugs.gnu.org; Sat, 06 May 2017 08:52:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@bnc3.mailjet.com>) id 1d6zCD-00078X-EH for guix-patches@gnu.org; Sat, 06 May 2017 08:52:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@bnc3.mailjet.com>) id 1d6zC9-0005Cu-I5 for guix-patches@gnu.org; Sat, 06 May 2017 08:52:25 -0400 Received: from o108.p9.mailjet.com ([87.253.234.108]:47580) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@bnc3.mailjet.com>) id 1d6zC9-0005BE-7u for guix-patches@gnu.org; Sat, 06 May 2017 08:52:21 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:x-csa-complaints: x-mj-mid:content-type; bh=yUOy6Rov202nC0k6NW5/YQ3k0HM=; b=Wasi9sgdrezEHJ/UGUWK0qRZligvBoq1G7h65Ggv+l1QCqq8gK2QFd3gI HqIZWpkXQLvR0b+AFmr4mrkicgU0+pOgyNbAahPbwxA6+EDnMkz2tW7FLH75 BhSJizUSF7okWCEgYTE1oZdP2j5BRr5YPoGgOkK7tKm4g9b/yYVuDU= Message-Id: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: guix-patches@gnu.org Subject: Single source file emacs packages get a ".el.el" extension Date: Sat, 06 May 2017 18:21:56 +0530 X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccCwaa-kWmzRUyGVAItij7qBwAFgUc Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Single source file emacs packages (such as emacs-goto-chg, emacs-transpose-frame, emacs-key-chord, etc.) get installed with a double extension (".el.el"). This patch fixes that. = --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-build-emacs-Don-t-append-an-extra-.el-to-source-file.patch Content-Transfer-Encoding: quoted-printable >From 4796890f507a126edb6020573547d37815b3241e Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Sat, 6 May 2017 18:16:36 +0530 Subject: [PATCH] build: emacs: Don't append an extra ".el" to source file name. * guix/build/emacs-build-system.scm (store-file->elisp-source-file): The source file name already has a ".el" suffix. Don't append an extra ".el= ". --- guix/build/emacs-build-system.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-s= ystem.scm index 44e8b0d31..3669b7d59 100644 --- a/guix/build/emacs-build-system.scm +++ b/guix/build/emacs-build-system.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2015 Federico Beffa ;;; Copyright =C2=A9 2016 David Thompson ;;; Copyright =C2=A9 2016 Alex Kost +;;; Copyright =C2=A9 2017 Arun Isaac ;;; ;;; This file is part of GNU Guix. ;;; @@ -50,7 +51,7 @@ name that has been stripped of the hash and version num= ber." (let-values (((name version) (package-name->name+version (strip-store-file-name file)))) - (string-append name ".el"))) + name)) =20 (define* (unpack #:key source #:allow-other-keys) "Unpack SOURCE into the build directory. SOURCE may be a compressed --=20 2.12.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 15:39:00 2017 Received: (at 26802) by debbugs.gnu.org; 9 May 2017 19:39:00 +0000 Received: from localhost ([127.0.0.1]:34521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8AyK-0005pR-78 for submit@debbugs.gnu.org; Tue, 09 May 2017 15:39:00 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:32964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8AyI-0005pA-CZ for 26802@debbugs.gnu.org; Tue, 09 May 2017 15:38:58 -0400 Received: by mail-lf0-f65.google.com with SMTP id q70so915243lfi.0 for <26802@debbugs.gnu.org>; Tue, 09 May 2017 12:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=70r57QqNCunaiUNkHHhTIJho7YcWJVe1IN1yzY+8GK8=; b=twDVDSMF11DdxfxhLkhDM2zjOewH1qkzLRKgMDDg7lSyu2NMkENZ/i0ZIXIuldRB73 YJY/8rfBsYgvESnBpccF55l2uzhQ1KbrlG1y9Xydx3E5/SENwEKbBdeCp25q2E2WGyhK 5DScQIxIKMl0vrMlsESieIJCHcAPIX1wVqKTSmD5qzZI4dNKemyhIrxyFOQXSK8ok5gB 6OcDK2RMrWoo9OTBTuL1qNUTzCR5NyXu0yUgDmcsjTcrfYWZfRYuDCcNPiJ2i/wac7xf NpPQmexkNTr0PxOicghrxKSDJTwGACue9XEdKg+MI/umCAa7aa4JMmCQchbnFRlZC50x HT5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=70r57QqNCunaiUNkHHhTIJho7YcWJVe1IN1yzY+8GK8=; b=tOIbb/UlPf57z9j/7EQdQlIUa69kMPC0lHFIiMEFrFv/QhAMo8ouWyBovDwoRgg66P vfDY55e0jDlwANJQXnIB1gy1ogfeCI/JK4vJbi5kwiiHupsg3wCM9XlJRk+li/kOCytN edzN1utx+mghCZySkx58UNusHd4RgR3KFsLe/kVegu7GgE65wRaosQeu3JOORY1Juo4V EAjGTCnY5tDEj9d3wU4pAJko0SQrm7xa0jrlWiXQtfNJc4xko4k6pINprOEAyxTbvAUT mRz5tCIOx6Yol+WS4/XU56TrLRg04YlV60qz04wt5Bs332H4U5sp+xfmhoB2qSSAhl00 rt0g== X-Gm-Message-State: AODbwcCXPLWfhytcQbOJFl1LUzXyhFVcpWVO4eRfvSpwwWd6BEDIOBX3 N/4KZM6rvWCCgtrs X-Received: by 10.46.8.2 with SMTP id 2mr868814lji.121.1494358732196; Tue, 09 May 2017 12:38:52 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id 22sm137852ljv.67.2017.05.09.12.38.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 May 2017 12:38:39 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26802: Single source file emacs packages get a ".el.el" extension References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> Date: Tue, 09 May 2017 22:38:36 +0300 In-Reply-To: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> (Arun Isaac's message of "Sat, 06 May 2017 18:21:56 +0530") Message-ID: <87wp9pbz2b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-05-06 18:21 +0530) wrote: > Single source file emacs packages (such as emacs-goto-chg, > emacs-transpose-frame, emacs-key-chord, etc.) get installed with a > double extension (".el.el"). This patch fixes that. Actually, this patch will break most of the single-file packages. Try, for example, the following command with your patch: guix build emacs-adaptive-wrap As you can see, the elisp file is called "adaptive-wrap" instead of "adaptive-wrap.el". I would rather suggest to fix the packages you mentioned (emacs-key-chord, etc.) to add 'file-name' field as it is done for the other single-file packages (emacs-web-mode, emacs-yaml-mode, etc.) -- Alex From debbugs-submit-bounces@debbugs.gnu.org Thu May 11 15:19:46 2017 Received: (at 26802) by debbugs.gnu.org; 11 May 2017 19:19:46 +0000 Received: from localhost ([127.0.0.1]:39065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8tco-0004QF-9M for submit@debbugs.gnu.org; Thu, 11 May 2017 15:19:46 -0400 Received: from o153.p8.mailjet.com ([87.253.233.153]:43869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <19fd8da9.AEMAKMfGZKsAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFLlP@bnc3.mailjet.com>) id 1d8tcn-0004Q3-0b for 26802@debbugs.gnu.org; Thu, 11 May 2017 15:19:45 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=ay7sjrD5BKz5FccyoCl3RfYAk+o=; b=U/7W9H77e3i+WXxlzTHDUF0MDcnMvKwMMvwOCNN7d84rBAA5HyiplcfIK S4YJUUTu2JKrcewmMbBIhTjpzQ8ARNh88uFT+BFf3vYiqJoO0CSU4/T3eW6S HlWVTDwmit7DzRSELhMLqdO3RHVuRIwkqtSU5HACKEkfSMnJRh7ZtA= Message-Id: <19fd8da9.AEMAKMfGZKsAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFLlP@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 26802@debbugs.gnu.org Subject: Re: bug#26802: Single source file emacs packages get a ".el.el" extension Date: Fri, 12 May 2017 00:49:11 +0530 In-reply-to: <87wp9pbz2b.fsf@gmail.com> References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> <87wp9pbz2b.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAKMfGZKsAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFLlPQSTPsO9SSlai4sSBBxTE_QAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26802 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > I would rather suggest to fix the packages you mentioned > (emacs-key-chord, etc.) to add 'file-name' field as it is done for the > other single-file packages (emacs-web-mode, emacs-yaml-mode, etc.) You're right. I'll do that. But, I think we should also have a guix lint check that makes sure the version is present in the store file name. What do you think? = From debbugs-submit-bounces@debbugs.gnu.org Sat May 13 01:24:28 2017 Received: (at 26802) by debbugs.gnu.org; 13 May 2017 05:24:28 +0000 Received: from localhost ([127.0.0.1]:41661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9PXY-0008Td-LU for submit@debbugs.gnu.org; Sat, 13 May 2017 01:24:28 -0400 Received: from o114.p9.mailjet.com ([87.253.234.114]:45246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9PXX-0008TU-7g for 26802@debbugs.gnu.org; Sat, 13 May 2017 01:24:28 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:in-reply-to:references: x-csa-complaints:x-mj-mid:mime-version:content-transfer-encoding; bh=lu1RhNXdp4iTDiRgZOwpyT20ad0=; b=PNUb4EFkIE96bi3Ho+asYfJX7gDPmtIc/JMKE/GdHOpQEzaC+7cYSv1Xx DG9g8aa11pCQz0gp/pyrqIgA15ccJG2EpJKu2J8PmLVs7yUtTPvOkNGcKwKw kD7g5xTjuBMraICQEjXmZfLTDcm7+RS0p+iSewAOCCr+vnJsPWqfx0= Message-Id: From: Arun Isaac To: 26802@debbugs.gnu.org Subject: [PATCH 3/3] gnu: emacs-key-chord: Set source file-name. Date: Sat, 13 May 2017 10:53:37 +0530 In-Reply-To: <20170513052337.14110-1-arunisaac@systemreboot.net> References: <20170513052337.14110-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAKUzVZiEAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFpiK8q0rGdzKTdq3_SNI2eehDgAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26802 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) * gnu/packages/emacs.scm (emacs-key-chord)[source]: Add file-name field. --- gnu/packages/emacs.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 1d688f8cc..8f966d057 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -4584,6 +4584,7 @@ selected frame.") (origin (method url-fetch) (uri "https://www.emacswiki.org/emacs/download/key-chord.el") + (file-name (string-append "key-chord-" version ".el")) (sha256 (base32 "03m44pqggfrd53nh9dvpdjgm0rvca34qxmd30hr33hzprzjambxg")))) --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Sat May 13 01:24:36 2017 Received: (at 26802) by debbugs.gnu.org; 13 May 2017 05:24:36 +0000 Received: from localhost ([127.0.0.1]:41664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9PXf-0008Tx-SP for submit@debbugs.gnu.org; Sat, 13 May 2017 01:24:36 -0400 Received: from o122.p8.mailjet.com ([87.253.233.122]:48777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9PXe-0008Tq-Vj for 26802@debbugs.gnu.org; Sat, 13 May 2017 01:24:35 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:in-reply-to:references: x-csa-complaints:x-mj-mid:mime-version:content-transfer-encoding; bh=dk4Wm8q6C4SQ/MUwg6j7Pveo6lI=; b=VvHgGWqjKRIQokmrF94qUFCJdH6HmVEDIasC/Q4jhL5UkTXLwwLrggOBR FHrINVGTydm155KiEEYFUOJ5aKi1cqwK/5PJPvlZndPAm/A8oajWUqZ9nGq6 Uagn5SOf+EkIgwawz+XWUSJW+bol1Tw41GAIqvtUvRUHH+BEi6cxFE= Message-Id: From: Arun Isaac To: 26802@debbugs.gnu.org Subject: [PATCH 2/3] gnu: emacs-transpose-frame: Set source file-name. Date: Sat, 13 May 2017 10:53:36 +0530 In-Reply-To: <20170513052337.14110-1-arunisaac@systemreboot.net> References: <20170513052337.14110-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAKUzVZqEAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFpiSThuSQsCETXyr8GXZQes5MAAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26802 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/emacs.scm (emacs-transpose-frame)[source]: Add file-name fie= ld. --- gnu/packages/emacs.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 8608c3907..1d688f8cc 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -4564,6 +4564,7 @@ with gnuplot.") (origin (method url-fetch) (uri "http://www.emacswiki.org/emacs/download/transpose-frame.el") + (file-name (string-append "transpose-frame-" version ".el")) (sha256 (base32 "1f67yksgw9s6j0033hmqzaxx2a93jm11sd5ys7cc3li5gfh680m4")))) --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Sat May 13 01:24:40 2017 Received: (at 26802) by debbugs.gnu.org; 13 May 2017 05:24:40 +0000 Received: from localhost ([127.0.0.1]:41667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9PXk-0008UG-4A for submit@debbugs.gnu.org; Sat, 13 May 2017 01:24:40 -0400 Received: from o108.p8.mailjet.com ([87.253.233.108]:58205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9PXi-0008U7-Kp for 26802@debbugs.gnu.org; Sat, 13 May 2017 01:24:39 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:x-csa-complaints: x-mj-mid:mime-version:content-transfer-encoding; bh=ErwDRYytig2VZcn1yLOBvkk2Dwo=; b=sS/0j/mQ8n6iGRKvCXOuuhfaVquPyJkMPfrk/raSyOYAkZGku2MFLIO7L vJBNamWi0+bDS2iXomPbYqWq4+pLHiXmEtEwQ5bq0icUOnBUEVZf7xo8UvtS G+cAGXaL7gu8SDIwzaf5zAk9TU/I2g2jtTHL9x0fTu2rdfPDcK8SBo= Message-Id: From: Arun Isaac To: 26802@debbugs.gnu.org Subject: [PATCH 1/3] gnu: emacs-goto-chg: Set source file-name. Date: Sat, 13 May 2017 10:53:35 +0530 X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAKHJiT3oAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFpiV5pnNuuB9QkqFUTjHQ7HIsAAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26802 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) * gnu/packages/emacs.scm (emacs-goto-chg)[source]: Add file-name field. --- gnu/packages/emacs.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 21120b331..8608c3907 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -3488,6 +3488,7 @@ extensions.") (method url-fetch) ;; There is no versioned source. (uri "https://www.emacswiki.org/emacs/download/goto-chg.el") + (file-name (string-append "goto-chg-" version ".el")) (sha256 (base32 "078d6p4br5vips7b9x4v6cy0wxf6m5ij9gpqd4g33bryn22gnpij")))) --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Sat May 13 04:54:36 2017 Received: (at 26802) by debbugs.gnu.org; 13 May 2017 08:54:36 +0000 Received: from localhost ([127.0.0.1]:41744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9Sou-0004qj-6s for submit@debbugs.gnu.org; Sat, 13 May 2017 04:54:36 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:36323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9Sor-0004qV-Gv for 26802@debbugs.gnu.org; Sat, 13 May 2017 04:54:35 -0400 Received: by mail-lf0-f50.google.com with SMTP id h4so11314737lfj.3 for <26802@debbugs.gnu.org>; Sat, 13 May 2017 01:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:user-agent :mime-version; bh=RMQYWAQRO5LVrcQHUhaGSnSzgJEFWut/Z8bqzfA9S/s=; b=Bmb5e5uw0h6bfzC7dMqPv7kPn3KSNkG3eq17gNo67uGpbAhHNF2g/c4XlkIolfOYIB OdkY4SYaT/t/Oir9/3VGUsw8fZ89ZF3WjzXPcgcBNj6vlCmP2UTVVqLQRmoAolCg9e9T skPaCH0yG7gqabOaXQVDayv1oCILfoMLfc9PZ9EwRjDEkmizN/34L9QR+E6ph6ld0RJi eke5vBeA5Ej5F+12HVKXtAhDBAwhEHy7/sQyr0w9ApTwFVmhzdXHbFj16Dm4EUQD/lua otrSXn6ESEHnnVDaywlo7crfqFcrRVzZZj0a4Ad84US6l4UYLHRFzrEp+v6hHJhHgHLN p3IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :user-agent:mime-version; bh=RMQYWAQRO5LVrcQHUhaGSnSzgJEFWut/Z8bqzfA9S/s=; b=BuXj4TDrD7+zGTAJdUKRfpRrx6Yj8QWeOKhnPEXIdvxZUfcteMROTq/z0hAi+U+jBx 0N0BWfmL9rxyDq4W9RDZod/tKKylxnlq5CLaTzMHP1w45+lj/Navh3+yFijaqfSIXskp P2KUtXvZAgv4wc2POLrzZSfwpqrSULTooTz0GCUkC4t0el/SgQo1vWTYE++b9MgCa9Mp SUc0ISHRv3oZMEQ0UQulGUfa4NQUOCr5DjnToWqgg3Z1fu0BeYxMb2zzam4w28cSG+on OZqg4+imrz/4i5cU5v1lm9u54Enhqa0MXJCWwhrP6qwq0AWZeAl+Vc7rYokXl2zz9YPo Dgqg== X-Gm-Message-State: AODbwcDeRK8BK3If8r848Ylevh8RkNRSVtn9WOVJ9YUHbAYviGL6ykln PfbRmtqgQhA19mIz X-Received: by 10.46.87.15 with SMTP id l15mr2989642ljb.78.1494665667274; Sat, 13 May 2017 01:54:27 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id 190sm984630ljj.4.2017.05.13.01.54.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 May 2017 01:54:26 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26802: Single source file emacs packages get a ".el.el" extension References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> <87wp9pbz2b.fsf@gmail.com> <19fd8da9.AEMAKMfGZKsAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFLlP@mailjet.com> Date: Sat, 13 May 2017 11:54:27 +0300 Message-ID: <87vap5xhks.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-05-12 00:49 +0530) wrote: >> I would rather suggest to fix the packages you mentioned >> (emacs-key-chord, etc.) to add 'file-name' field as it is done for the >> other single-file packages (emacs-web-mode, emacs-yaml-mode, etc.) > > You're right. I'll do that. But, I think we should also have a guix lint > check that makes sure the version is present in the store file > name. What do you think? It would be a linter only for *.el files, is that what you mean? AFAIK we do not have such specific linters, but yeah, why not, I think it's a good idea. P.S. Could you please keep my email in Cc? It would be easier to follow the discussion for me, thanks. -- Alex From debbugs-submit-bounces@debbugs.gnu.org Sat May 13 04:55:59 2017 Received: (at 26802) by debbugs.gnu.org; 13 May 2017 08:55:59 +0000 Received: from localhost ([127.0.0.1]:41748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9SqE-0004ss-Gk for submit@debbugs.gnu.org; Sat, 13 May 2017 04:55:59 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:35521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9SqC-0004se-T2 for 26802@debbugs.gnu.org; Sat, 13 May 2017 04:55:57 -0400 Received: by mail-lf0-f45.google.com with SMTP id j1so11308315lfh.2 for <26802@debbugs.gnu.org>; Sat, 13 May 2017 01:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cAsiQXd+FwFjWxesyj91XJOIRDLrBzF6WdiANCFTOZ4=; b=sTY8gNadtLDTeGSkq43QVK5wNocFY7VsEAiAwDUfypCRkHItPmrRiuLUtc5zV9OGz8 vOrGq0UqhXbJi725+cDLMuxqCm9YqQV75nrU7qUTk4RaTovchndOGvcvOy7N8oK+4QAI R8aUjgTrLtEhRLFZ1xES/RwtL+GmcciU0flZpFk+pg6z1WLtueSRvsPlEfRRQOQZ36Pt D1yY6a8oEln0hI2izpNZWSXmqjYSDqDVD+qqTEfrwSLh/kPnr/WCXmDsUF8UJ68Q6kIo hYcJsTpaJIm7I8r9YkiUUZXIzA66gO7QQ9wIVi5rJNwip6aPxXSNJ5/44E4GoAKat1mA +ttw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cAsiQXd+FwFjWxesyj91XJOIRDLrBzF6WdiANCFTOZ4=; b=iWQFX8tpRy6b2mPOwfmGPfHxifjmuFOJU6/R1lJVQQiWMDq4KWbizkGtOGhiNR3o9v i8JADt6sgtjKwmNwyrYrjdi3KsLlXV/eWO6uojOAKWLfOGzcYTCmkI9s61FGuPlbkvew 543CqZYIQeGE6vub+1i7WE6jWPBcyKmMk7BcpvMR8odanMlEMeZofkyKuGDQ0P+S5F7Q Keheovusbinm1moPduu1RZwZlE6UeB+572EFmgJRHBzsFGN2u1TRLhpqH3g/FVWUBh6t CJd9XYi240yuzNuaxSTEk/X7UQzwu4UOryLna2sp5fZTMytL0RmIr1EJfYxofXVMXwF+ vDBw== X-Gm-Message-State: AODbwcBULSkvwJr6Y4stsrIfUtljIAtavL4EGZ2rwAwFoibNJw7NUOQG GLVI0/F230O2zw== X-Received: by 10.25.44.21 with SMTP id s21mr3043582lfs.136.1494665751202; Sat, 13 May 2017 01:55:51 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id 34sm994731lfp.1.2017.05.13.01.55.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 May 2017 01:55:50 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26802: [PATCH 1/3] gnu: emacs-goto-chg: Set source file-name. References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> Date: Sat, 13 May 2017 11:55:52 +0300 In-Reply-To: (Arun Isaac's message of "Sat, 13 May 2017 10:53:35 +0530") Message-ID: <87r2ztxhif.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-05-13 10:53 +0530) wrote: > * gnu/packages/emacs.scm (emacs-goto-chg)[source]: Add file-name field. > --- > gnu/packages/emacs.scm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 21120b331..8608c3907 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -3488,6 +3488,7 @@ extensions.") > (method url-fetch) > ;; There is no versioned source. > (uri "https://www.emacswiki.org/emacs/download/goto-chg.el") > + (file-name (string-append "goto-chg-" version ".el")) > (sha256 > (base32 > "078d6p4br5vips7b9x4v6cy0wxf6m5ij9gpqd4g33bryn22gnpij")))) This and the other patches are uncontroversial, I think you can push them, thanks! -- Alex From debbugs-submit-bounces@debbugs.gnu.org Sat May 13 12:37:08 2017 Received: (at 26802) by debbugs.gnu.org; 13 May 2017 16:37:08 +0000 Received: from localhost ([127.0.0.1]:43164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9a2V-0004UO-Qd for submit@debbugs.gnu.org; Sat, 13 May 2017 12:37:08 -0400 Received: from o169.p9.mailjet.com ([87.253.234.169]:55679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <9b375d38.AEAAKIA9bmkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFzYx@bnc3.mailjet.com>) id 1d9a2U-0004UG-Hl for 26802@debbugs.gnu.org; Sat, 13 May 2017 12:37:07 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=eXXyAOBQ3taY4V/WoRqjTYi423A=; b=ZT/Hb/LMcUQJJtRBfCXk7DD34Z5az7V3sGGUviuu0yUweVND/mvLFkz+A gumlv0oNnBByhitO0VzCur56vzKri7i/9Bq2H8kMopcGDZHHqHeAwPF2FZNx V7Y+NYHQ+FH0POe/MqMD0EjdHwBrmqI29wCpiP1fABoCGtUYTx8dE4= Message-Id: <9b375d38.AEAAKIA9bmkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFzYx@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: Alex Kost Subject: Re: bug#26802: Single source file emacs packages get a ".el.el" extension Date: Sat, 13 May 2017 22:06:05 +0530 In-reply-to: <87vap5xhks.fsf@gmail.com> References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> <87wp9pbz2b.fsf@gmail.com> <19fd8da9.AEMAKMfGZKsAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFLlP@mailjet.com> <87vap5xhks.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAKIA9bmkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFzYxoIB_3qyFRqiStagqO5cpTQAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I've pushed the other uncontroversial patches. > It would be a linter only for *.el files, is that what you mean? AFAIK > we do not have such specific linters, but yeah, why not, I think it's a > good idea. No, it will be a linter for all packages, not just emacs packages. The following is the current linter for checking source file names. I have a couple of issues with it, in addition to the new linter feature I am suggesting. Let me explain. > (define (check-source-file-name package) > "Emit a warning if PACKAGE's origin has no meaningful file name." > (define (origin-file-name-valid? origin) > ;; Return #t if the source file name contains only a version or is #f= ; > ;; indicates that the origin needs a 'file-name' field. Isn't this logic somehow backward? Should'nt a predicate called `file-name-valid?' return #t if the file name is valid, and #f otherwise? This seems to be doing the opposite of that, returning #f if the file name is valid, and #t otherwise. > (let ((file-name (origin-actual-file-name origin)) > (version (package-version package))) > (and file-name > (not (or (string-prefix? version file-name) > ;; Common in many projects is for the filename to sta= rt > ;; with a "v" followed by the version, > ;; e.g. "v3.2.0.tar.gz". > (string-prefix? (string-append "v" version) file-name= )))))) I think this check can be done by matching against a single regexp like so: (string-match (string-append "^v?" version) file-name) In addition to this logic, we add an extra condition that makes sure the version is some substring of the source file name, like so: (string-match version file-name) With this new check, single source file packages like emacs-transpose-frame, etc. which did not have file-name fields would have raised a lint warning. > (let ((origin (package-source package))) > (unless (or (not origin) (origin-file-name-valid? origin)) > (emit-warning package > (G_ "the source file name should contain the package = name") > 'source)))) > P.S. Could you please keep my email in Cc? It would be easier to > follow the discussion for me, thanks. Sorry, I thought debbugs does some magic to send out mails to everybody involved in a specific bug. Didn't realize it was only using Cc. Will keep you in Cc for this and future mails. = From debbugs-submit-bounces@debbugs.gnu.org Sun May 14 13:15:47 2017 Received: (at 26802) by debbugs.gnu.org; 14 May 2017 17:15:47 +0000 Received: from localhost ([127.0.0.1]:45042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9x7T-0004sQ-Ej for submit@debbugs.gnu.org; Sun, 14 May 2017 13:15:47 -0400 Received: from mail-wr0-f180.google.com ([209.85.128.180]:34656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9x7Q-0004lD-MK for 26802@debbugs.gnu.org; Sun, 14 May 2017 13:15:45 -0400 Received: by mail-wr0-f180.google.com with SMTP id l9so67070019wre.1 for <26802@debbugs.gnu.org>; Sun, 14 May 2017 10:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=96qTNlHkBV7f3tuSAovHbRjByOiMvOaxizL9aeGVN5o=; b=DwnlbXER1Wf5Bp8rEaHqwE9iUkl31ZpeGbFz+NV3lftYxN9Myd5ts5vJgUPMr+44ia s9mzaGPI1OshTsN3pXcgjyBuptKniJeHPyzi6PZU8w5emjfpG3QI+e20cDv6yrvqdt3g Veok2V5MnevlxpFguQonyW+3CykJVMkNHsukb67cZU8ikEAsvdb+1hVfb7VXd+lIKESD okenJZ7eXPncvyqYgtNCR5yX5h9aV2WXm/JMnZnjTXswF0FN/gl0GhI9MbdNYTqw+pAk bf/2psfefxufmLIfm328d01YUBNWh20HQr7ppCmtcXwbpQsniD6KUckxaiJFc7XQ8pMU cLKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=96qTNlHkBV7f3tuSAovHbRjByOiMvOaxizL9aeGVN5o=; b=C+nTg/ZIf4svRDZyRxV9USP7z5vUaM7JZ767elNJs7EeXTlIqVeoWoETLSUVJ0490V 4xDQXoEcQDGV80FjIQSgLPxI6g1atn+8Lluy+YF8xFnXoAfbNyUPmwpOvGqKVP+lDaz6 p4AM44ylrsTOFnwNHrSxlM+3aCiMkA++FLQbn0Pc9bnxW/F+DMWUJX7Kih05AqcvtF0J ODWFdz+mwzC6x2Df74F/Mn+Rv5aJ5rXPE3dEUK4N8HzsBJODiYtjgKpLDAbRyMY0QlQI FOkorbF/z3sZlxzJnddSxrYcD3ud0qXyXE+L3I9c14adG4fHUHq3us3NVgc0xwgCgdfN JPCQ== X-Gm-Message-State: AODbwcBadnXMJr5wCAGVPVHY2MB0qIQme3rzhwmsb4YrHBe4FEVRb48s x03CRxK+sm5ejQ== X-Received: by 10.46.21.70 with SMTP id 6mr1036954ljv.121.1494782138902; Sun, 14 May 2017 10:15:38 -0700 (PDT) Received: from leviafan ([217.107.194.134]) by smtp.gmail.com with ESMTPSA id y2sm1728457ljd.41.2017.05.14.10.15.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 May 2017 10:15:37 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26802: Single source file emacs packages get a ".el.el" extension References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> <87wp9pbz2b.fsf@gmail.com> <19fd8da9.AEMAKMfGZKsAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFLlP@mailjet.com> <87vap5xhks.fsf@gmail.com> <9b375d38.AEAAKIA9bmkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFzYx@mailjet.com> Date: Sun, 14 May 2017 20:15:36 +0300 In-Reply-To: <9b375d38.AEAAKIA9bmkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFzYx@mailjet.com> (Arun Isaac's message of "Sat, 13 May 2017 22:06:05 +0530") Message-ID: <8737c7fjgn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Arun Isaac (2017-05-13 22:06 +0530) wrote: > I've pushed the other uncontroversial patches. > >> It would be a linter only for *.el files, is that what you mean? AFAIK >> we do not have such specific linters, but yeah, why not, I think it's a >> good idea. > > No, it will be a linter for all packages, not just emacs packages. Hm, but the ".el" source files are special: they must have "name-version.el" name, while the other sources may be named pretty arbitrary. > The following is the current linter for checking source file names. I > have a couple of issues with it, in addition to the new linter feature I > am suggesting. Let me explain. > >> (define (check-source-file-name package) >> "Emit a warning if PACKAGE's origin has no meaningful file name." >> (define (origin-file-name-valid? origin) >> ;; Return #t if the source file name contains only a version or is #= f; ^^ (it's a typo I think, should be =E2=80=98#f=E2=80=99= there) >> ;; indicates that the origin needs a 'file-name' field. > > Isn't this logic somehow backward? Should'nt a predicate called > `file-name-valid?' return #t if the file name is valid, and #f > otherwise? This seems to be doing the opposite of that, returning #f if > the file name is valid, and #t otherwise. If I understand correctly, this predicate does the right thing; it's just a typo in the commentary. >> (let ((file-name (origin-actual-file-name origin)) >> (version (package-version package))) >> (and file-name >> (not (or (string-prefix? version file-name) >> ;; Common in many projects is for the filename to st= art >> ;; with a "v" followed by the version, >> ;; e.g. "v3.2.0.tar.gz". >> (string-prefix? (string-append "v" version) file-nam= e)))))) > > I think this check can be done by matching against a single regexp like > so: > > (string-match (string-append "^v?" version) file-name) I agree, a single regexp looks better! > In addition to this logic, we add an extra condition that makes sure the > version is some substring of the source file name, like so: > > (string-match version file-name) > > With this new check, single source file packages like > emacs-transpose-frame, etc. which did not have file-name fields would > have raised a lint warning. I'm not sure, I think: - it's too much for all the sources, as the upstream source may not contain a version in the file name at all. Do we really want to raise a warning in this case? - and it's not enough for ".el" sources, I mean "something-version.el" is not enough, as the file name must exactly be "name-version.el" (as it is with ELPA single-filed sources), so the emacs-build-system will output "name.el" file which will correspond to 'name' feature provided by this file. [...] >> P.S. Could you please keep my email in Cc? It would be easier to >> follow the discussion for me, thanks. > > Sorry, I thought debbugs does some magic to send out mails to everybody > involved in a specific bug. Didn't realize it was only using Cc. Will > keep you in Cc for this and future mails. Thanks! --=20 Alex From debbugs-submit-bounces@debbugs.gnu.org Mon May 15 09:29:04 2017 Received: (at 26802) by debbugs.gnu.org; 15 May 2017 13:29:04 +0000 Received: from localhost ([127.0.0.1]:45639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAG3c-0005zS-Fd for submit@debbugs.gnu.org; Mon, 15 May 2017 09:29:04 -0400 Received: from o169.p8.mailjet.com ([87.253.233.169]:56661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAG3a-0005zJ-Tj for 26802@debbugs.gnu.org; Mon, 15 May 2017 09:29:03 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=4OCnRm1bWG87m1Slyt4i//D6b1k=; b=gbmY48FCHUgZGT+kmQgf8WcjnKxtw6RkDd5PMPA4DPTJzwjlfXrpQAIPW q+GE9MSE2O1T1KL8tsb+zD990BnpLxYKnCBRemPBiTv154772WspsY1Zj+y8 TmNc48D4uEyCCP7IyOovwk1xwhdzXoacKomLjx8bfY0lhdMQsO8HmU= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: Alex Kost Subject: Re: bug#26802: Single source file emacs packages get a ".el.el" extension Date: Mon, 15 May 2017 18:58:29 +0530 In-reply-to: <8737c7fjgn.fsf@gmail.com> References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> <87wp9pbz2b.fsf@gmail.com> <19fd8da9.AEMAKMfGZKsAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFLlP@mailjet.com> <87vap5xhks.fsf@gmail.com> <9b375d38.AEAAKIA9bmkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFzYx@mailjet.com> <8737c7fjgn.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAKZSU7kQAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZGa0dZ_E65sDPTTGFrruuyv4JpgAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > I'm not sure, I think: > > - it's too much for all the sources, as the upstream source may not > contain a version in the file name at all. Do we really want to raise a > warning in this case? > - and it's not enough for ".el" sources, I mean "something-version.el" > is not enough, as the file name must exactly be "name-version.el" (as it > is with ELPA single-filed sources), so the emacs-build-system will > output "name.el" file which will correspond to 'name' feature provided > by this file. You have a point, but... If all packages cannot be expected to have "name-version", then it is unreasonable and arbitrary to only expect single source file emacs packages to have a filename of this format. Instead, the emacs build system should be made more robust so that it can tolerate a souce file name like "web-mode.el" and still produce the correct installation path. = From debbugs-submit-bounces@debbugs.gnu.org Tue May 16 13:29:27 2017 Received: (at 26802) by debbugs.gnu.org; 16 May 2017 17:29:27 +0000 Received: from localhost ([127.0.0.1]:48995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAgHm-0005lE-WF for submit@debbugs.gnu.org; Tue, 16 May 2017 13:29:27 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:35772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAgHl-0005l2-HU for 26802@debbugs.gnu.org; Tue, 16 May 2017 13:29:25 -0400 Received: by mail-lf0-f44.google.com with SMTP id j1so23736585lfh.2 for <26802@debbugs.gnu.org>; Tue, 16 May 2017 10:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zJTFVfwEcyeTDmxNVE3yHR4E9tFAyzaWEaY713gunFY=; b=WhaGWZhp0EFbVc8hjoJKaGbr+Jenrfjt2fnNnW8qKpkmWIb15eGMr2HOcumabiyIb8 y94eVVtlVxNzEcZ24AB3vBp2q3kVNKexc/XClAUJb4cG7LM5aq5rMgW/J6a7aF3zVRvP Sdka+AFDzeCmshcWB77KQtTzxPHSNpTtueGsgkH0BszUIz9WVoiCPi4VOqHI1fK+3GVv V3dXu66eAK4MndV88oGOLVtoOBHU7YvYCHVdYO8/PsThIW4QcJ23yaBkDBgyv5zso+UZ YvRNaBC7+Eky7DO64hzmRXq5QRAZvViYglqfsPGWU9Irgj5jX26cEua8ZNdT/zBVxjYw ryfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zJTFVfwEcyeTDmxNVE3yHR4E9tFAyzaWEaY713gunFY=; b=qgFDpVAddIbP+oW9TxXQHPrZ3DOB+BgG7Peun5oT09sNGo3kOjYbqs0hprmPay3l6h QHc2uYhfJhza9jPfSXClS43wJVGMIc7dxXXIZ2PTJ4qXbhah0M/V7zUhfHWDxCne3+oJ FiWJIz61y6fEdsCGaHKRsED9/ieHnTRv66/Isv8r3nJ09xTpz6Ly0uDJdWfllwTdvglE jHXxJa52SBE75wOErmb79vTYqxRkmE1vemAr/LibPxDghd85Bq8SnVdLg1tX1tThEJrG tDhufdnRbqPaMw+x0LqnYE5w11NPNnsuiC2bXNn+q4sJdETeUsj0KusTbYlK3+Q4Lux1 meGA== X-Gm-Message-State: AODbwcBFY6M0yPSOJV1FE/7W+GAbBA2++MvdvdOVauoLn9u6wbZPcylL FcgDJd+i0+ofYsBg X-Received: by 10.25.43.203 with SMTP id r194mr3570340lfr.137.1494955759360; Tue, 16 May 2017 10:29:19 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id 25sm65592ljp.2.2017.05.16.10.29.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 May 2017 10:29:18 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26802: Single source file emacs packages get a ".el.el" extension References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> <87wp9pbz2b.fsf@gmail.com> <19fd8da9.AEMAKMfGZKsAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFLlP@mailjet.com> <87vap5xhks.fsf@gmail.com> <9b375d38.AEAAKIA9bmkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFzYx@mailjet.com> <8737c7fjgn.fsf@gmail.com> Date: Tue, 16 May 2017 20:29:17 +0300 In-Reply-To: (Arun Isaac's message of "Mon, 15 May 2017 18:58:29 +0530") Message-ID: <87a86czp5e.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Arun Isaac (2017-05-15 18:58 +0530) wrote: >> I'm not sure, I think: >> >> - it's too much for all the sources, as the upstream source may not >> contain a version in the file name at all. Do we really want to raise a >> warning in this case? > >> - and it's not enough for ".el" sources, I mean "something-version.el" >> is not enough, as the file name must exactly be "name-version.el" (as it >> is with ELPA single-filed sources), so the emacs-build-system will >> output "name.el" file which will correspond to 'name' feature provided >> by this file. > > You have a point, but... > > If all packages cannot be expected to have "name-version", then it is > unreasonable and arbitrary to only expect single source file emacs > packages to have a filename of this format. Instead, the emacs build > system should be made more robust so that it can tolerate a souce file > name like "web-mode.el" and still produce the correct installation path. Yeah, it would definitely be good to make emacs-build-system more robust. After thinking more, I came to the conclusion that expanding the linter to check any source for "name-version" is a good idea (if this is what you suggest, then I agree with you!) So if a source name has some other form, it would be linted, and can be fixed with 'file-name' field. I think such consistency in source file names would be really great. Apparently, this was your original propose (right?), now I support this idea! :-) -- Alex From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 12:53:25 2017 Received: (at 26802) by debbugs.gnu.org; 17 May 2017 16:53:25 +0000 Received: from localhost ([127.0.0.1]:51110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dB2CS-0001iN-Rx for submit@debbugs.gnu.org; Wed, 17 May 2017 12:53:25 -0400 Received: from o165.p8.mailjet.com ([87.253.233.165]:35856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <52756f2c.AEMAKY-VuQ0AAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAB@bnc3.mailjet.com>) id 1dB2CR-0001iA-Eq for 26802@debbugs.gnu.org; Wed, 17 May 2017 12:53:23 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:x-csa-complaints: x-mj-mid:mime-version:content-transfer-encoding; bh=Xg51jLnOPlsRFvwWDO9ToQdqyPk=; b=b/XOETnStCJ5c7+cVO72INuca63761GlNK/uuLZUn0XtEC6hEsFB/3BjI ozHsCLr7M259mWf8uLbwxuy/aiL1sR9jTloaz/UvfoyV68ruVxy+88cyD7Kw L1Syu7S+tw32U4N5rAg3aX/e21tCguKd3bMf+n+DTzD/sr3+HJvwkw= Message-Id: <52756f2c.AEMAKY-VuQ0AAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAB@mailjet.com> From: Arun Isaac To: 26802@debbugs.gnu.org Subject: [PATCH 1/4] gnu: lint: Fix typo. Date: Wed, 17 May 2017 22:22:43 +0530 X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAKY-VuQ0AAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIABMyUglgFFQ_SkOx-88ut6jAAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26802 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) * guix/scripts/lint.scm (check-source-file-name): Fix wrong return value in docstring. --- guix/scripts/lint.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index f2720f669..2b0071475 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -667,7 +667,7 @@ descriptions maintained upstream." (define (check-source-file-name package) "Emit a warning if PACKAGE's origin has no meaningful file name." (define (origin-file-name-valid? origin) - ;; Return #t if the source file name contains only a version or is #f; + ;; Return #f if the source file name contains only a version or is #f; ;; indicates that the origin needs a 'file-name' field. (let ((file-name (origin-actual-file-name origin)) (version (package-version package))) --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 12:53:25 2017 Received: (at 26802) by debbugs.gnu.org; 17 May 2017 16:53:25 +0000 Received: from localhost ([127.0.0.1]:51112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dB2CT-0001iP-3f for submit@debbugs.gnu.org; Wed, 17 May 2017 12:53:25 -0400 Received: from o165.p8.mailjet.com ([87.253.233.165]:55770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <71d8391d.AEAAKQk5dMAAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAB@bnc3.mailjet.com>) id 1dB2CR-0001i9-9s for 26802@debbugs.gnu.org; Wed, 17 May 2017 12:53:23 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:in-reply-to:references: x-csa-complaints:x-mj-mid:mime-version:content-transfer-encoding; bh=PTF3+GUGcstEbE6iwsqIL223t6E=; b=bLL8Z7sxpFNV10BkJkNX279SMxWdIMJWDGBMWSrtXqD72qgI6K8QKgzK+ lyblZ4yCvwkxkBKu/SxYhDSm0HiXvwCPYcny1iTe2OXtbyZzQP2KYFS51u0f U941vyP+OCDnCY9DXosO6Q7iyZP/fFDsVICkR6pvAjoG+3tO/ICZ7o= Message-Id: <71d8391d.AEAAKQk5dMAAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAB@mailjet.com> From: Arun Isaac To: 26802@debbugs.gnu.org Subject: [PATCH 2/4] guix: lint: Slightly simplify `check-source-file-name'. Date: Wed, 17 May 2017 22:22:44 +0530 In-Reply-To: <20170517165246.14042-1-arunisaac@systemreboot.net> References: <20170517165246.14042-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAKQk5dMAAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIABYqB5QmtvQICqVzAsl1-CIQAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26802 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) * guix/scripts/lint.scm (check-source-file-name): Implement file name match= ing with regular expression. --- guix/scripts/lint.scm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index 2b0071475..1d930d8c0 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -672,11 +672,10 @@ descriptions maintained upstream." (let ((file-name (origin-actual-file-name origin)) (version (package-version package))) (and file-name - (not (or (string-prefix? version file-name) - ;; Common in many projects is for the filename to star= t - ;; with a "v" followed by the version, - ;; e.g. "v3.2.0.tar.gz". - (string-prefix? (string-append "v" version) file-name)= ))))) + ;; Common in many projects is for the filename to start + ;; with a "v" followed by the version, + ;; e.g. "v3.2.0.tar.gz". + (not (string-match (string-append "^v?" version) file-name))))) =20 (let ((origin (package-source package))) (unless (or (not origin) (origin-file-name-valid? origin)) --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 12:53:40 2017 Received: (at 26802) by debbugs.gnu.org; 17 May 2017 16:53:40 +0000 Received: from localhost ([127.0.0.1]:51116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dB2Ci-0001j2-AG for submit@debbugs.gnu.org; Wed, 17 May 2017 12:53:40 -0400 Received: from o140.p8.mailjet.com ([87.253.233.140]:59230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <25c18e57.AEQAKeUK09kAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAR@bnc3.mailjet.com>) id 1dB2Cg-0001in-BR for 26802@debbugs.gnu.org; Wed, 17 May 2017 12:53:38 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:in-reply-to:references: x-csa-complaints:x-mj-mid:mime-version:content-transfer-encoding; bh=R6gLzICencjIcXEzJdfEdSJf6A0=; b=R9Z83LzYa34a8GFPDvzJu93fXM9bM3s+APDupl15ICn6O8TbJtv9aeHjO 52h+fsCvDlUAA38ahq+vU+FXXNRjMP5kyl9Zak2JA4Cdzt+6pBQgc+qxWkgU pDDsv1KF1eo2LbiILOzHczQDQi7DFf4P5Dtbtfh1cxLNt6bwqyr4Ho= Message-Id: <25c18e57.AEQAKeUK09kAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAR@mailjet.com> From: Arun Isaac To: 26802@debbugs.gnu.org Subject: [PATCH 3/4] guix: lint: Check for version in source file name. Date: Wed, 17 May 2017 22:22:45 +0530 In-Reply-To: <20170517165246.14042-1-arunisaac@systemreboot.net> References: <20170517165246.14042-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAKeUK09kAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIARC1p972vvQtaWmhUEAEfduAAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26802 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * guix/scripts/lint.scm (check-source-file-name): Check for version in sour= ce file name. --- guix/scripts/lint.scm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index 1d930d8c0..b6f73d0e6 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -667,20 +667,22 @@ descriptions maintained upstream." (define (check-source-file-name package) "Emit a warning if PACKAGE's origin has no meaningful file name." (define (origin-file-name-valid? origin) - ;; Return #f if the source file name contains only a version or is #f; - ;; indicates that the origin needs a 'file-name' field. + ;; Return #f if the source file name is #f, contains only a version, o= r + ;; does not contain a version; indicates that the origin needs a + ;; 'file-name' field. (let ((file-name (origin-actual-file-name origin)) (version (package-version package))) (and file-name ;; Common in many projects is for the filename to start ;; with a "v" followed by the version, ;; e.g. "v3.2.0.tar.gz". - (not (string-match (string-append "^v?" version) file-name))))) + (not (string-match (string-append "^v?" version) file-name)) + (string-match version file-name)))) =20 (let ((origin (package-source package))) (unless (or (not origin) (origin-file-name-valid? origin)) (emit-warning package - (G_ "the source file name should contain the package n= ame") + (G_ "the source file name should contain the package n= ame and version") 'source)))) =20 (define (check-mirror-url package) --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 12:53:42 2017 Received: (at 26802) by debbugs.gnu.org; 17 May 2017 16:53:42 +0000 Received: from localhost ([127.0.0.1]:51118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dB2Ck-0001jC-Hw for submit@debbugs.gnu.org; Wed, 17 May 2017 12:53:42 -0400 Received: from o124.p8.mailjet.com ([87.253.233.124]:41999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dB2Ch-0001ip-0y for 26802@debbugs.gnu.org; Wed, 17 May 2017 12:53:39 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:in-reply-to:references: x-csa-complaints:x-mj-mid:mime-version:content-transfer-encoding; bh=0f4JvlKFz8jn5paIQ+2SJ3EOq88=; b=njnordNxlmVXEoEaMA2rJMqzrhIkpVO4pbMmHfkh+xTWxpKat0pbr9brO XQI/faoGhGEDHcIPrGLMrslZcmTHf5kgDSiwCaliihlMQHABFEgURA7TYwJH BxtikBU0NsplvRctPQoupoiwL7+M9TEHA0XYwxdNWY4hEwNE03h7O4= Message-Id: From: Arun Isaac To: 26802@debbugs.gnu.org Subject: [PATCH 4/4] build: emacs: Fix `store-file->elisp-source-file'. Date: Wed, 17 May 2017 22:22:46 +0530 In-Reply-To: <20170517165246.14042-1-arunisaac@systemreboot.net> References: <20170517165246.14042-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAKY-XG48AAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIASdk6eI-HZSgmxXKCFs80pmQAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26802 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This prevents a ".el.el" extension for source files with no version number = in their file name. * guix/build/emacs-build-system.scm (store-file->elisp-source-file): Remove ".el" extension from file name before splitting to name and version. --- guix/build/emacs-build-system.scm | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-sys= tem.scm index 44e8b0d31..25a3beaa2 100644 --- a/guix/build/emacs-build-system.scm +++ b/guix/build/emacs-build-system.scm @@ -47,10 +47,13 @@ (define (store-file->elisp-source-file file) "Convert FILE, a store file name for an Emacs Lisp source file, into a f= ile name that has been stripped of the hash and version number." - (let-values (((name version) - (package-name->name+version - (strip-store-file-name file)))) - (string-append name ".el"))) + (let ((extension ".el")) + (let-values (((name version) + (package-name->name+version + (strip-store-file-name + (string-drop-right + file (string-length extension)))))) + (string-append name extension)))) =20 (define* (unpack #:key source #:allow-other-keys) "Unpack SOURCE into the build directory. SOURCE may be a compressed --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 13:05:00 2017 Received: (at 26802) by debbugs.gnu.org; 17 May 2017 17:05:00 +0000 Received: from localhost ([127.0.0.1]:51125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dB2Ne-0001zb-Iq for submit@debbugs.gnu.org; Wed, 17 May 2017 13:05:00 -0400 Received: from o155.p9.mailjet.com ([87.253.234.155]:46469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <0fe6a049.AEUAKMM_QnUAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIK3@bnc3.mailjet.com>) id 1dB2Nc-0001zT-HI for 26802@debbugs.gnu.org; Wed, 17 May 2017 13:04:56 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=KdGR069RrIMWmHCwvc/4j99udc8=; b=CpGgYMZ6qPddtezJFjOegYJAKXUdgfuO64Y9YmzqbVKBo/4MmHJchPtXy h473WgFUqSgG9sNu/aFYwS0xIbOz86ZR7N5TGPVYBlFE+Y90jgz+Ah4hkjWZ iRi5xvqpcjsZOwDLc7A1yBobAvUApqvSZmbGiqyExpVCDorIzXMa5E= Message-Id: <0fe6a049.AEUAKMM_QnUAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIK3@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: Alex Kost Subject: Re: bug#26802: Single source file emacs packages get a ".el.el" extension Date: Wed, 17 May 2017 22:34:19 +0530 In-reply-to: <87a86czp5e.fsf@gmail.com> References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> <87wp9pbz2b.fsf@gmail.com> <19fd8da9.AEMAKMfGZKsAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFLlP@mailjet.com> <87vap5xhks.fsf@gmail.com> <9b375d38.AEAAKIA9bmkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFzYx@mailjet.com> <8737c7fjgn.fsf@gmail.com> <87a86czp5e.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEUAKMM_QnUAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIK3M51zhfMkTwmbk0_udBELbgAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > After thinking more, I came to the conclusion that expanding the linter > to check any source for "name-version" is a good idea (if this is what > you suggest, then I agree with you!) So if a source name has some other > form, it would be linted, and can be fixed with 'file-name' field. I > think such consistency in source file names would be really great. > > Apparently, this was your original propose (right?), now I support this > idea! :-) Well, I'm totally confused now! :-P I don't know which proposal each of us is for/against. So, to make things clearer, I have sent a few patches implementing the various proposals. Patches 1 and 2 are pretty uncontroversial and have little to do with the double extension bug. These patches fix the typo in the docstring, and simplify `check-source-file-name' using a regexp, as discussed earlier. Patches 3 and 4 are two different ways to solve the double extension ".el.el" problem, only one of which we should push. Patch 3 makes the linter check for the existence of the version number somewhere in the source file name. Therefore, if there is no version in the file name, the packager will put in a file-name field, thus avoiding the double extension problem. However, modifying the linter like this will have far-reaching consequences possibly affecting other packages which build fine without lint warnings. I am currently NOT IN FAVOR of this approach. Patch 4 fixes the problem by just making the emacs-build-system (in particular, the `store-file->elisp-source-file' function) more robust, and capable of handling file names without a version number. This, I think, is the better solution. I am currently IN FAVOR of this approach. Hopefully, this settles the confusion and ambiguity. :-) WDYT -- Patch 3 or 4? = From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 07:29:06 2017 Received: (at 26802) by debbugs.gnu.org; 18 May 2017 11:29:06 +0000 Received: from localhost ([127.0.0.1]:52029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBJcA-0000R7-0l for submit@debbugs.gnu.org; Thu, 18 May 2017 07:29:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBJc8-0000QX-GV for 26802@debbugs.gnu.org; Thu, 18 May 2017 07:29:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBJby-0006sD-8l for 26802@debbugs.gnu.org; Thu, 18 May 2017 07:28:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBJby-0006s6-5L; Thu, 18 May 2017 07:28:54 -0400 Received: from [193.50.110.69] (port=58288 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBJbx-0004QU-2U; Thu, 18 May 2017 07:28:53 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: bug#26802: [PATCH 1/4] gnu: lint: Fix typo. References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> <52756f2c.AEMAKY-VuQ0AAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAB@mailjet.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 18 May 2017 13:28:49 +0200 In-Reply-To: <52756f2c.AEMAKY-VuQ0AAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAB@mailjet.com> (Arun Isaac's message of "Wed, 17 May 2017 22:22:43 +0530") Message-ID: <8760gy8kum.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Arun Isaac skribis: > * guix/scripts/lint.scm (check-source-file-name): Fix wrong return value in > docstring. LGTM! From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 07:30:27 2017 Received: (at 26802) by debbugs.gnu.org; 18 May 2017 11:30:27 +0000 Received: from localhost ([127.0.0.1]:52033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBJdT-0000rv-AY for submit@debbugs.gnu.org; Thu, 18 May 2017 07:30:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBJdR-0000kJ-31 for 26802@debbugs.gnu.org; Thu, 18 May 2017 07:30:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBJdG-0007Nv-VF for 26802@debbugs.gnu.org; Thu, 18 May 2017 07:30:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBJdG-0007No-Rz; Thu, 18 May 2017 07:30:14 -0400 Received: from [193.50.110.69] (port=58308 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBJdG-00062y-2b; Thu, 18 May 2017 07:30:14 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: bug#26802: [PATCH 2/4] guix: lint: Slightly simplify `check-source-file-name'. References: <20170517165246.14042-1-arunisaac@systemreboot.net> <71d8391d.AEAAKQk5dMAAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAB@mailjet.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 18 May 2017 13:30:12 +0200 In-Reply-To: <71d8391d.AEAAKQk5dMAAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAB@mailjet.com> (Arun Isaac's message of "Wed, 17 May 2017 22:22:44 +0530") Message-ID: <87ziea767v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Arun Isaac skribis: > * guix/scripts/lint.scm (check-source-file-name): Implement file name mat= ching > with regular expression. LGTM! BTW, for all this patch series, please make sure make check TESTS=3Dtests/lint.scm still passes. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 07:32:22 2017 Received: (at 26802) by debbugs.gnu.org; 18 May 2017 11:32:23 +0000 Received: from localhost ([127.0.0.1]:52037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBJfK-0002NW-NF for submit@debbugs.gnu.org; Thu, 18 May 2017 07:32:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBJfJ-0002N9-3s for 26802@debbugs.gnu.org; Thu, 18 May 2017 07:32:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBJf9-0007tx-4u for 26802@debbugs.gnu.org; Thu, 18 May 2017 07:32:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBJf9-0007tt-1N; Thu, 18 May 2017 07:32:11 -0400 Received: from [193.50.110.69] (port=58310 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBJf8-00008c-G2; Thu, 18 May 2017 07:32:10 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: bug#26802: [PATCH 3/4] guix: lint: Check for version in source file name. References: <20170517165246.14042-1-arunisaac@systemreboot.net> <25c18e57.AEQAKeUK09kAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAR@mailjet.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 18 May 2017 13:32:08 +0200 In-Reply-To: <25c18e57.AEQAKeUK09kAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAR@mailjet.com> (Arun Isaac's message of "Wed, 17 May 2017 22:22:45 +0530") Message-ID: <87vaoy764n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Arun Isaac skribis: > * guix/scripts/lint.scm (check-source-file-name): Check for version in so= urce > file name. [...] > (define (origin-file-name-valid? origin) > - ;; Return #f if the source file name contains only a version or is #= f; > - ;; indicates that the origin needs a 'file-name' field. > + ;; Return #f if the source file name is #f, contains only a version,= or > + ;; does not contain a version; indicates that the origin needs a > + ;; 'file-name' field. > (let ((file-name (origin-actual-file-name origin)) > (version (package-version package))) > (and file-name > ;; Common in many projects is for the filename to start > ;; with a "v" followed by the version, > ;; e.g. "v3.2.0.tar.gz". > - (not (string-match (string-append "^v?" version) file-name)))= )) > + (not (string-match (string-append "^v?" version) file-name)) > + (string-match version file-name)))) What about simply: (string-prefix? (string-append (package-name package) "-" (package-version package)) file-name) ? That=E2=80=99s a bit stricter but I think that=E2=80=99s what we expect. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 14:00:18 2017 Received: (at 26802) by debbugs.gnu.org; 18 May 2017 18:00:18 +0000 Received: from localhost ([127.0.0.1]:53747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBPik-0007Sz-C0 for submit@debbugs.gnu.org; Thu, 18 May 2017 14:00:18 -0400 Received: from o153.p8.mailjet.com ([87.253.233.153]:35580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <565a99c4.AEMAKbu972sAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHeEv@bnc3.mailjet.com>) id 1dBPii-0007Sr-Nn for 26802@debbugs.gnu.org; Thu, 18 May 2017 14:00:17 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=2QMbl/UB8UThYTccpranmB0NWps=; b=im7FEhjLGrH6xwWs0B7umW4Nq8X4xew16aQLVXHXT0PDWWIzYeZ9bNQ/Z ZK7K2CAdHxK91DSb/+disR1F96eefTkLJO5BdxV9Lu5Y6o4i2uAk20da6381 ghVklTMAAb+oyg6LZr29lV3jWWSPM5Z6oz9WQiN3YYQH7iJk9dLhcw= Message-Id: <565a99c4.AEMAKbu972sAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHeEv@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: Ludovic =?iso-8859-1?q?Court=E8s?= Subject: Re: bug#26802: [PATCH 3/4] guix: lint: Check for version in source file name. Date: Thu, 18 May 2017 23:29:53 +0530 In-reply-to: <87vaoy764n.fsf@gnu.org> References: <20170517165246.14042-1-arunisaac@systemreboot.net> <25c18e57.AEQAKeUK09kAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAR@mailjet.com> <87vaoy764n.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAKbu972sAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHeEvFDZ1DeZ3RhuoZDWFQXb-tgAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26802 Cc: Alex Kost , 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >> (define (origin-file-name-valid? origin) >> - ;; Return #f if the source file name contains only a version or is = #f; >> - ;; indicates that the origin needs a 'file-name' field. >> + ;; Return #f if the source file name is #f, contains only a version= , or >> + ;; does not contain a version; indicates that the origin needs a >> + ;; 'file-name' field. >> (let ((file-name (origin-actual-file-name origin)) >> (version (package-version package))) >> (and file-name >> ;; Common in many projects is for the filename to start >> ;; with a "v" followed by the version, >> ;; e.g. "v3.2.0.tar.gz". >> - (not (string-match (string-append "^v?" version) file-name))= ))) >> + (not (string-match (string-append "^v?" version) file-name)) >> + (string-match version file-name)))) > > What about simply: > > (string-prefix? (string-append (package-name package) "-" > (package-version package)) > file-name) This will break all those emacs, python, etc. packages that have "emacs-", "python-" prefixes in the package-name, but not in their source file names. We'll have to add the file-name field to practically every Guix package. I'm not sure this is a good idea. Couldn't we drop patch 3, and just use patch 4 to fix this bug? = From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 14:01:24 2017 Received: (at 26802) by debbugs.gnu.org; 18 May 2017 18:01:24 +0000 Received: from localhost ([127.0.0.1]:53751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBPjo-0007Uj-Kw for submit@debbugs.gnu.org; Thu, 18 May 2017 14:01:24 -0400 Received: from o163.p8.mailjet.com ([87.253.233.163]:49572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <754bb74d.AEMAKbvJ5xkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHeFx@bnc3.mailjet.com>) id 1dBPjm-0007Ub-EC for 26802@debbugs.gnu.org; Thu, 18 May 2017 14:01:23 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=36boVcJrIhFmId9bCx7YBhm0AhY=; b=Ekh8G3rmUp8yA6cQ3tRXkh9cww0oa5iroaP4K+hDpZzXLlcgcQEAdsz7h cyhUy0NMU+IOKxP9+/BX++bbWc+f+WBEW49eWpOW+OTHUcwgdJwXHanxhL2Y j1HbvRIPxsFTtEKCc/PAIxz0aYcSxW3YFHLUuEA7dDw+FGXw7QUles= Message-Id: <754bb74d.AEMAKbvJ5xkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHeFx@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: Ludovic =?iso-8859-1?q?Court=E8s?= Subject: Re: bug#26802: [PATCH 2/4] guix: lint: Slightly simplify `check-source-file-name'. Date: Thu, 18 May 2017 23:30:59 +0530 In-reply-to: <87ziea767v.fsf@gnu.org> References: <20170517165246.14042-1-arunisaac@systemreboot.net> <71d8391d.AEAAKQk5dMAAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAB@mailjet.com> <87ziea767v.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAKbvJ5xkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHeFxt4eTH80lQj-mMjWjzdvAVAAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > BTW, for all this patch series, please make sure > > make check TESTS=3Dtests/lint.scm > > still passes. Noted, thanks! = From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 17:02:09 2017 Received: (at 26802) by debbugs.gnu.org; 18 May 2017 21:02:10 +0000 Received: from localhost ([127.0.0.1]:53939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBSYj-0006xM-Nl for submit@debbugs.gnu.org; Thu, 18 May 2017 17:02:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBSYi-0006x4-H0 for 26802@debbugs.gnu.org; Thu, 18 May 2017 17:02:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBSYc-0006zd-Ok for 26802@debbugs.gnu.org; Thu, 18 May 2017 17:02:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBSYY-0006yL-JX; Thu, 18 May 2017 17:01:58 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:42980 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBSYX-000260-Tu; Thu, 18 May 2017 17:01:58 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: bug#26802: [PATCH 3/4] guix: lint: Check for version in source file name. References: <20170517165246.14042-1-arunisaac@systemreboot.net> <25c18e57.AEQAKeUK09kAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAR@mailjet.com> <87vaoy764n.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 18 May 2017 23:01:55 +0200 In-Reply-To: (Arun Isaac's message of "Thu, 18 May 2017 23:29:53 +0530") Message-ID: <87vaox98vw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26802 Cc: Alex Kost , 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Arun Isaac skribis: >>> (define (origin-file-name-valid? origin) >>> - ;; Return #f if the source file name contains only a version or is= #f; >>> - ;; indicates that the origin needs a 'file-name' field. >>> + ;; Return #f if the source file name is #f, contains only a versio= n, or >>> + ;; does not contain a version; indicates that the origin needs a >>> + ;; 'file-name' field. >>> (let ((file-name (origin-actual-file-name origin)) >>> (version (package-version package))) >>> (and file-name >>> ;; Common in many projects is for the filename to start >>> ;; with a "v" followed by the version, >>> ;; e.g. "v3.2.0.tar.gz". >>> - (not (string-match (string-append "^v?" version) file-name)= )))) >>> + (not (string-match (string-append "^v?" version) file-name)) >>> + (string-match version file-name)))) >> >> What about simply: >> >> (string-prefix? (string-append (package-name package) "-" >> (package-version package)) >> file-name) > > This will break all those emacs, python, etc. packages that have > "emacs-", "python-" prefixes in the package-name, but not in their > source file names. We'll have to add the file-name field to practically > every Guix package. I'm not sure this is a good idea. Oh right, my bad. > Couldn't we drop patch 3, and just use patch 4 to fix this bug? Well patch 3 is OK after all, if you want to push it. As for the patch 4, I prefer to let Alex reply! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun May 21 04:33:54 2017 Received: (at 26802) by debbugs.gnu.org; 21 May 2017 08:33:54 +0000 Received: from localhost ([127.0.0.1]:57695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCMJG-0007bS-20 for submit@debbugs.gnu.org; Sun, 21 May 2017 04:33:54 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:36100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCMJD-0007bD-Tx for 26802@debbugs.gnu.org; Sun, 21 May 2017 04:33:52 -0400 Received: by mail-lf0-f65.google.com with SMTP id h4so2956270lfj.3 for <26802@debbugs.gnu.org>; Sun, 21 May 2017 01:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=U4E8LG9yrwtSrULjekhwdsON9Ob3y8z1mka9fhN1bQo=; b=QpPyjI9ckZzVH7k5o0DosnjrOVMShl+LzbAco52OA6AzMhYrux9iQiwy1GNSPlUdDj lXqVTJKfJVxowkmUlj7eZ07lvDawJD8JqmsiTZH/RffPirXG8Tvdi1zsUGTOWNThJJmI Uenqsmmsa8ujeyM1T45wCeXg54x4TDdNw7ROfTaLWXJ2oR1NL/EFUCrwvIr77KaREqNh YddrRyn7eKvF4eqq5PJtZAbOjiCgH73G+1X+3BdviYcH5PTwtignRUDefwQXnWavyRDJ dsDBJjCNYroGczVOuljg0OXO6/UBpHdNzCLT4sw8Tnc/TblsZnAHoNNQFJtX0/naNDNU 9fjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=U4E8LG9yrwtSrULjekhwdsON9Ob3y8z1mka9fhN1bQo=; b=Ybetecp13VekkoXGDCNQ9DDpyzpiYFPnlOAmx9wuKgQBVgiMVVC//AaYsPlNfg+fzg vZ5IDjJrN25WfPzjfErU0JrmMmFR0MlCm42dyA8u0DJbtrsT2FP+xFke4ENh6VKzU8q4 xdMaGYDEMB3DVBp3vqG96RuTrlbfYLmcTa79TzcwaYpw3/CgmSQXMGqfQI1aqA2Ycun2 wzllMmxFJepgHRyEiakRsx+XJusg6Yprack8oFVCx336JQjGSJ1tUnraeWwtn5fsBvgW VYxV/41jWNu2mUb7IEYWbVyN1w/KRDLt+lEimqLRBP6vujCNc+ZGNC2cGjrhGIotCxhL DyGQ== X-Gm-Message-State: AODbwcBb9EbjIhP2kGDMM7Ts3F4kJSTl4SI1a7IOP/nt3yZs4ZNI0Tpx jebKDM9MwxZz5A== X-Received: by 10.46.22.93 with SMTP id 29mr1158869ljw.46.1495355625834; Sun, 21 May 2017 01:33:45 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id z10sm1274809lja.24.2017.05.21.01.33.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 May 2017 01:33:45 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26802: [PATCH 4/4] build: emacs: Fix `store-file->elisp-source-file'. References: <20170517165246.14042-1-arunisaac@systemreboot.net> Date: Sun, 21 May 2017 11:33:45 +0300 In-Reply-To: (Arun Isaac's message of "Wed, 17 May 2017 22:22:46 +0530") Message-ID: <87y3tqhamu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-05-17 22:22 +0530) wrote: > This prevents a ".el.el" extension for source files with no version number in > their file name. > > * guix/build/emacs-build-system.scm (store-file->elisp-source-file): Remove > ".el" extension from file name before splitting to name and version. > --- > guix/build/emacs-build-system.scm | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-system.scm > index 44e8b0d31..25a3beaa2 100644 > --- a/guix/build/emacs-build-system.scm > +++ b/guix/build/emacs-build-system.scm > @@ -47,10 +47,13 @@ > (define (store-file->elisp-source-file file) > "Convert FILE, a store file name for an Emacs Lisp source file, into a file > name that has been stripped of the hash and version number." > - (let-values (((name version) > - (package-name->name+version > - (strip-store-file-name file)))) > - (string-append name ".el"))) > + (let ((extension ".el")) > + (let-values (((name version) > + (package-name->name+version > + (strip-store-file-name > + (string-drop-right > + file (string-length extension)))))) > + (string-append name extension)))) > > (define* (unpack #:key source #:allow-other-keys) > "Unpack SOURCE into the build directory. SOURCE may be a compressed Wow, I don't know if removing ".el" from a file name can be written in a more simple way, but the point of the patch is great! I didn't realize this problem could be fixed so easily. It looks good to me, thanks! -- Alex From debbugs-submit-bounces@debbugs.gnu.org Sun May 21 04:44:20 2017 Received: (at 26802) by debbugs.gnu.org; 21 May 2017 08:44:20 +0000 Received: from localhost ([127.0.0.1]:57700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCMTM-0007qp-2b for submit@debbugs.gnu.org; Sun, 21 May 2017 04:44:20 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:36332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCMTL-0007qc-2e for 26802@debbugs.gnu.org; Sun, 21 May 2017 04:44:19 -0400 Received: by mail-lf0-f65.google.com with SMTP id h4so2966110lfj.3 for <26802@debbugs.gnu.org>; Sun, 21 May 2017 01:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=C8VUgOvfm8rmYUXoicE3rr4iyNvbgf1QIqZR6K63y9s=; b=FvEbSOsbmr3FWwaICZyRAoD8bi+Ph1biMq8rF/fVZ87hIfTKzViMOoRwgOMKqqD/qR hLXhk+M06G+5FWY3JSte8AnmWPXNZ4Ya9KCa2tm7T4IDJs8ZmdOApLf/kh2ekIiKSwAC SWWLU/YsbNL3IZCm66n4Cx4wS5hC9TGHiPCDRHkVi4b+B1P61lbjs16liSjbbaRcj4u4 0NniWN6WofSjV3weQXgfdatpyQsVydwJfSaOh5A8JQ/Xnv3ppzIiVz07IKWdGucGDrSG VbxATrP2qmh8XqKAZquq/njj0I+QhN2abXfSBOEr4tmsg5y3ycWHjR5e8KIW4t380HeN zYYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=C8VUgOvfm8rmYUXoicE3rr4iyNvbgf1QIqZR6K63y9s=; b=PAOZkaW0OT4Emni0ZpRndE/Hi0yRbR3nxr+aM8/g9r/h0ksqNO7lrLBHLv/3suwNiJ PPhibyP0+7a5q4GrZk1ADaaLJrc8dmfLphiBLz/5y25kO5skLWMsSqJjq82mSKgXp0Zs owEuSzsLFaJz/+pTY8TMT/7KtzEtcU45yr8wuE/WuSWt3lmHvBNYrBzj+pFOXIN/GdUU jVixulwt+2QtjClD3TrZSr2ZitcfcSbKBPGy5X8Gp5oo6A4UJve5wKLzJdbmd1qw+aOg OES0UrF5fkNSqgZpbAuZyfEyjSiTxky3Q9IjbTuWD8VeskEY5dJ9RchOXxwuVgG3i5lN 5gGA== X-Gm-Message-State: AODbwcCWokvopNM/gnJ/Y/+8ep1Fbx2FoKQNw1fPBRHxWeziUcJshaXo BkZR7GMbFDhmJg== X-Received: by 10.46.97.26 with SMTP id v26mr4374422ljb.22.1495356253231; Sun, 21 May 2017 01:44:13 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id 20sm2493659ljf.8.2017.05.21.01.44.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 May 2017 01:44:12 -0700 (PDT) From: Alex Kost To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#26802: [PATCH 3/4] guix: lint: Check for version in source file name. References: <20170517165246.14042-1-arunisaac@systemreboot.net> <25c18e57.AEQAKeUK09kAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAR@mailjet.com> <87vaoy764n.fsf@gnu.org> <87vaox98vw.fsf@gnu.org> Date: Sun, 21 May 2017 11:44:13 +0300 In-Reply-To: <87vaox98vw.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 18 May 2017 23:01:55 +0200") Message-ID: <87vaouha5e.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26802 Cc: Arun Isaac , 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Ludovic Court=C3=A8s (2017-05-18 23:01 +0200) wrote: > Arun Isaac skribis: [...] >> Couldn't we drop patch 3, and just use patch 4 to fix this bug? > > Well patch 3 is OK after all, if you want to push it. > > As for the patch 4, I prefer to let Alex reply! It sounds like I'm considered to be an expert in that part of code. Thanks, but note that it's Federico who wrote emacs-build-system, and it's David who wrote the code that Arun is modifying with this patch. Well, I mean I know something about emacs-build-system and what the topic problem is, but it's too much credits for me :-) --=20 Alex From debbugs-submit-bounces@debbugs.gnu.org Sun May 21 05:00:54 2017 Received: (at 26802) by debbugs.gnu.org; 21 May 2017 09:00:54 +0000 Received: from localhost ([127.0.0.1]:57707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCMjO-0008EN-IS for submit@debbugs.gnu.org; Sun, 21 May 2017 05:00:54 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCMjN-0008E9-8Y for 26802@debbugs.gnu.org; Sun, 21 May 2017 05:00:53 -0400 Received: by mail-lf0-f68.google.com with SMTP id h4so2982579lfj.3 for <26802@debbugs.gnu.org>; Sun, 21 May 2017 02:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IrjSV/ydxINVap+u7M8U6gkPW8499rnDT0a4G5GQPRc=; b=PkcWdcrqI3jj/aE0Uz8AGj97AxDvTGwLmHDT3o3XIynJlXIgkit4lOhQF/j5T76raY QCt18JM136ZUnPLgplKMSV8tTchsrC/8ne6WlnQ+s4nzDXiwVL9Uf3qUPcgimGXel9x4 xEUKQwPjoo4EOttmlaEk4S4Dxza7rfewyv4od4s8IypLvBRSqQJlxoGWS8Mx0Y15/BG8 NmBKJQM46TB8dTxL8vhfjPWrZbNS5LBa2WaSjJ5WLodQ6MIZELFyOdT8x6T/S3aeGiWd 8fJDVjoIvkry90KSksL3W8ADOGGN7QhY1P3hUrjFh6RUEbQ4gg6BH1TtfPAcgI3o1mCU xs3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=IrjSV/ydxINVap+u7M8U6gkPW8499rnDT0a4G5GQPRc=; b=Xy54t0UuAbcnN8HDSF8yT2GTEmP1wlHB/cLBylCrClBWSz9LCgmp30tcT7boZdxxEv /haFYZlt+0uH9J2ZlLJJYNXvqIHFqScXT0PHjb6lYWBlNneeSFpa640PzefcGPiVipcT NBiWLlVV5+dpOS7OPNZhT5EHH+wcM5prN/jsM+qyYXovqysJzmpStUSNLwc8hF2nYfQe siUU32wb1hxQy/Jl097gu9IGDACMFSwABf8VBotMp6OiWbiBchKTnY+v1E0JzA2UcKxM ydniZ8F1aSvUMZkYpQlIoeHtPk5CFJYmYZOD+IjPvtDcHoJqjWj4hrkbjcFUB2Ot+zMF ss6g== X-Gm-Message-State: AODbwcA/7TOfzO8b12VxyQOEv5s2WO7PoX9HOEv3Y2fHXg7B0JLnHU7h buz7UIiRT0d9XA== X-Received: by 10.25.21.193 with SMTP id 62mr4345243lfv.82.1495357247446; Sun, 21 May 2017 02:00:47 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id c66sm48070lfg.53.2017.05.21.02.00.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 May 2017 02:00:47 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26802: [PATCH 3/4] guix: lint: Check for version in source file name. References: <20170517165246.14042-1-arunisaac@systemreboot.net> <25c18e57.AEQAKeUK09kAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIAR@mailjet.com> <87vaoy764n.fsf@gnu.org> <565a99c4.AEMAKbu972sAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHeEv@mailjet.com> Date: Sun, 21 May 2017 12:00:47 +0300 In-Reply-To: <565a99c4.AEMAKbu972sAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHeEv@mailjet.com> (Arun Isaac's message of "Thu, 18 May 2017 23:29:53 +0530") Message-ID: <87shjyh9ds.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26802 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-05-18 23:29 +0530) wrote: >>> (define (origin-file-name-valid? origin) >>> - ;; Return #f if the source file name contains only a version or is #f; >>> - ;; indicates that the origin needs a 'file-name' field. >>> + ;; Return #f if the source file name is #f, contains only a version, or >>> + ;; does not contain a version; indicates that the origin needs a >>> + ;; 'file-name' field. >>> (let ((file-name (origin-actual-file-name origin)) >>> (version (package-version package))) >>> (and file-name >>> ;; Common in many projects is for the filename to start >>> ;; with a "v" followed by the version, >>> ;; e.g. "v3.2.0.tar.gz". >>> - (not (string-match (string-append "^v?" version) file-name))))) >>> + (not (string-match (string-append "^v?" version) file-name)) >>> + (string-match version file-name)))) >> >> What about simply: >> >> (string-prefix? (string-append (package-name package) "-" >> (package-version package)) >> file-name) > > This will break all those emacs, python, etc. packages that have > "emacs-", "python-" prefixes in the package-name, but not in their > source file names. We'll have to add the file-name field to practically > every Guix package. I'm not sure this is a good idea. Well, it will not "break" the packages, it will just add many new lint warnings. But I agree that the Ludovic's version is too strict. What I would prefer is to make this linter check for "name-version" (or for "name" and "version" separately) inside a source file name (not with 'string-prefix?', but with 'string-match'), so that the store file names will look like this: foo-0.1.tar emacs-bar-0.2.el and not like this: v0.1.tar emacs-bar.el > Couldn't we drop patch 3, and just use patch 4 to fix this bug? I think so, patch 4 is definitely a fix for the original problem, while a general file-name linting is probably for another thread. -- Alex From debbugs-submit-bounces@debbugs.gnu.org Sun May 21 05:03:10 2017 Received: (at 26802) by debbugs.gnu.org; 21 May 2017 09:03:11 +0000 Received: from localhost ([127.0.0.1]:57711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCMlZ-0008Hr-Uj for submit@debbugs.gnu.org; Sun, 21 May 2017 05:03:10 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:35177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCMlY-0008He-4Y for 26802@debbugs.gnu.org; Sun, 21 May 2017 05:03:08 -0400 Received: by mail-lf0-f47.google.com with SMTP id a5so4168188lfh.2 for <26802@debbugs.gnu.org>; Sun, 21 May 2017 02:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=d93A0A+zy0hUu9AYrDqBdu1fahDr7PVlVnqMWZxbfkw=; b=Wnaeq3uVscHyfuSoj7EirRfT1q4FG4O7SXwiwqqDiNq/ybRdC4rmj3EbbOs1tLYSfe HgR2II7kdSQVITy4CselOGTvC0rO0edlZNMWgOPj/3R/OW/HfVDSaa3wV5qwdkyPGdKN 2+G99kGSxB9N+8dzwwESSW6myAn5MFxUSW7552bA/6VDwv+ekMCGC7o20gDSEZAIhUht ipLV9xZ34CW29HbdqTSjH05CWFwp2q1Q20cbmE8eSoO3omvHwssavjcQMgWNaGJZZ62b 9a4QJDjfyiyX1XrLryFgPRZhItaLVOWkjlzPDRNo9h0QesVhasjYNb4cw+b2BJbj6NDz OtHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=d93A0A+zy0hUu9AYrDqBdu1fahDr7PVlVnqMWZxbfkw=; b=exwT9v3kzHAgOSOLTpJ7F97NE+FUtR1RxEijrEtsY4grDO35jmgH/E111koB5khIj/ yAfCw8WjgwbAN4UBoavp473m03dSoyKXPpQ0rz3lcNSx6joN7/rxunNS+rmgTAQDhM1l 8H3xDABTP9wj9EK887ABIFT5OqyraxtGAsuw81Q+bBCh6w84SALQDzGhOLxqRXDwrJsE NOK7K4GtrgJLETe3Yy63PzHFbaHe6EjylS4aQnM7Dr6SExQVY7Vmm3DVWRhD0JedKHU5 fYZWS4uuf+XB64Puqk2v542SJD23WTxwwLmmidY90NMxMuJBTKvJbjBxo1tWDgRVIS26 thVA== X-Gm-Message-State: AODbwcCnVYwWBAUaS7HoPB1JKbV3hm0Ju4M+UK3zfaVqvz+yS1XD9u3i 4u3accXsjCagkg== X-Received: by 10.25.202.27 with SMTP id a27mr4180209lfg.70.1495357382468; Sun, 21 May 2017 02:03:02 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id b71sm1897261lfg.32.2017.05.21.02.03.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 May 2017 02:03:01 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26802: Single source file emacs packages get a ".el.el" extension References: <05a79dd0.AEAAJ6TpV0QAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDccC@mailjet.com> <87wp9pbz2b.fsf@gmail.com> <19fd8da9.AEMAKMfGZKsAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFLlP@mailjet.com> <87vap5xhks.fsf@gmail.com> <9b375d38.AEAAKIA9bmkAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZFzYx@mailjet.com> <8737c7fjgn.fsf@gmail.com> <87a86czp5e.fsf@gmail.com> <0fe6a049.AEUAKMM_QnUAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIK3@mailjet.com> Date: Sun, 21 May 2017 12:03:02 +0300 In-Reply-To: <0fe6a049.AEUAKMM_QnUAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIK3@mailjet.com> (Arun Isaac's message of "Wed, 17 May 2017 22:34:19 +0530") Message-ID: <87r2zih9a1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26802 Cc: 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-05-17 22:34 +0530) wrote: [...] > Patches 3 and 4 are two different ways to solve the double extension > ".el.el" problem, only one of which we should push. Actually, I am for both (but for a modified version of the patch 3) :-) > Patch 3 makes the linter check for the existence of the version number > somewhere in the source file name. Therefore, if there is no version in > the file name, the packager will put in a file-name field, thus avoiding > the double extension problem. However, modifying the linter like this > will have far-reaching consequences possibly affecting other packages > which build fine without lint warnings. Lint warnings are just warnings after all. Having more warnings will not be a big problem I think. > I am currently NOT IN FAVOR of this approach. And I like this approach :-) As I've just written in another message, I'd like to have a linter that will check for "name" and "version" to make the store file names unambiguous. But this is a more general discussion for another topic. > Patch 4 fixes the problem by just making the emacs-build-system (in > particular, the `store-file->elisp-source-file' function) more robust, > and capable of handling file names without a version number. This, I > think, is the better solution. I am currently IN FAVOR of this approach. Right, I agree: it's a good fix for the problem, thanks! > Hopefully, this settles the confusion and ambiguity. :-) WDYT -- Patch > 3 or 4? I think patch 4 can be committed now, and patch 3 is for another discussion. -- Alex From debbugs-submit-bounces@debbugs.gnu.org Sun May 21 18:24:21 2017 Received: (at 26802) by debbugs.gnu.org; 21 May 2017 22:24:21 +0000 Received: from localhost ([127.0.0.1]:59699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCZGv-0005o0-9y for submit@debbugs.gnu.org; Sun, 21 May 2017 18:24:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCZGu-0005no-4H for 26802@debbugs.gnu.org; Sun, 21 May 2017 18:24:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCZGl-0001eK-Sh for 26802@debbugs.gnu.org; Sun, 21 May 2017 18:24:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCZGl-0001eG-PY; Sun, 21 May 2017 18:24:11 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:36252 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dCZGl-0003rz-1w; Sun, 21 May 2017 18:24:11 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Alex Kost Subject: Re: bug#26802: [PATCH 4/4] build: emacs: Fix `store-file->elisp-source-file'. References: <20170517165246.14042-1-arunisaac@systemreboot.net> <87y3tqhamu.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 3 Prairial an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Mon, 22 May 2017 00:24:08 +0200 In-Reply-To: <87y3tqhamu.fsf@gmail.com> (Alex Kost's message of "Sun, 21 May 2017 11:33:45 +0300") Message-ID: <87r2zhg86v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26802 Cc: Arun Isaac , 26802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alex Kost skribis: >> + (let ((extension ".el")) >> + (let-values (((name version) >> + (package-name->name+version >> + (strip-store-file-name >> + (string-drop-right >> + file (string-length extension)))))) >> + (string-append name extension)))) Pro tip: (string-drop-right =E2=80=A6) can be replaced by: (basename file ".el") :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon May 22 19:11:11 2017 Received: (at 26802-done) by debbugs.gnu.org; 22 May 2017 23:11:11 +0000 Received: from localhost ([127.0.0.1]:33448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCwTn-0004sJ-82 for submit@debbugs.gnu.org; Mon, 22 May 2017 19:11:11 -0400 Received: from o171.p8.mailjet.com ([87.253.233.171]:40981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCwTl-0004sC-Qp for 26802-done@debbugs.gnu.org; Mon, 22 May 2017 19:11:10 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=HcAXtSsiodRocVFIMd2J93C/hSI=; b=m8iP3KDb5yJs7CXVuJ9sfJtQGykRZKxgsLY4TWGWOYQ3SD0wtMKvykMLd zQZSBvnWBmLCCj9PCFpZP+PNKlzIW1IT2pbakiys+nwJaTjBAaFcX4gmaYa5 hFoWzuATRrvN8pf41R3E8HIsHWX0jkA+mr1GKdxtekmmHqofwbKG1s= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: 26802-done@debbugs.gnu.org Subject: Re: bug#26802: [PATCH 4/4] build: emacs: Fix `store-file->elisp-source-file'. Date: Tue, 23 May 2017 04:40:44 +0530 In-reply-to: <87r2zhg86v.fsf@gnu.org> References: <20170517165246.14042-1-arunisaac@systemreboot.net> <87y3tqhamu.fsf@gmail.com> <87r2zhg86v.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAK4Qr7-AAAAAAAAAAAAPCiaQAAAACwQwAAAAAAAW9WABZI3AM7_vr-GV8QtW3IQqkFmhfBQAFgUc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26802-done Cc: Alex Kost , Ludovic =?iso-8859-1?q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Pro tip: (string-drop-right …) can be replaced by: > > (basename file ".el") Thanks! Made this modification... Pushed patches 1, 2 and 4. From debbugs-submit-bounces@debbugs.gnu.org Mon May 22 20:52:25 2017 Received: (at 26802-done) by debbugs.gnu.org; 23 May 2017 00:52:25 +0000 Received: from localhost ([127.0.0.1]:33523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCy3k-0007Cw-V7 for submit@debbugs.gnu.org; Mon, 22 May 2017 20:52:25 -0400 Received: from o111.p8.mailjet.com ([87.253.233.111]:47352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCy3k-0007Cp-60 for 26802-done@debbugs.gnu.org; Mon, 22 May 2017 20:52:24 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=dqoBZTStzqusuyewx6Ff4ekfSyA=; b=ikk7Bks0Cwl8nzVhn+MdtiiljtA/s0QstZGSBLKQfRQPCNAL7LiMiTe7i C3cENGtslxkkfzo64oWBtKK2LyyYz4Ex6oOjdj4BckFnF7geN6BDX+Z4qYJR riDY+pd6yQSEkpPQwUzKQGAOloqzRXEAt0pK2+TqRXMQlBhbGIDPAI= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: 26802-done@debbugs.gnu.org Subject: Re: bug#26802: [PATCH 4/4] build: emacs: Fix `store-file->elisp-source-file'. Date: Tue, 23 May 2017 06:22:01 +0530 In-reply-to: References: <20170517165246.14042-1-arunisaac@systemreboot.net> <87y3tqhamu.fsf@gmail.com> <87r2zhg86v.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAKqmySzIAAAAAAAAAAAPCiaQAAAACwQwAAAAAAAW9WABZI4fHyDQ6tdMDTOSsTJiB_lCfBgAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26802-done Cc: Alex Kost , Ludovic =?iso-8859-1?q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > Pushed patches 1, 2 and 4. Looks like I made a mistake with patch 4's commit message. I should have used the prefix "build-system: emacs:", instead of "build: emacs:". Sorry! :-( = From debbugs-submit-bounces@debbugs.gnu.org Tue May 23 04:15:59 2017 Received: (at 26802-done) by debbugs.gnu.org; 23 May 2017 08:15:59 +0000 Received: from localhost ([127.0.0.1]:33891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dD4z0-0000wM-Py for submit@debbugs.gnu.org; Tue, 23 May 2017 04:15:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dD4yz-0000w8-7b for 26802-done@debbugs.gnu.org; Tue, 23 May 2017 04:15:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dD4yt-0003bo-DO for 26802-done@debbugs.gnu.org; Tue, 23 May 2017 04:15:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dD4yq-0003ZX-4I; Tue, 23 May 2017 04:15:48 -0400 Received: from [193.50.110.67] (port=50352 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dD4yp-0005Jr-D3; Tue, 23 May 2017 04:15:47 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac Subject: Re: bug#26802: [PATCH 4/4] build: emacs: Fix `store-file->elisp-source-file'. References: <20170517165246.14042-1-arunisaac@systemreboot.net> <87y3tqhamu.fsf@gmail.com> <87r2zhg86v.fsf@gnu.org> <95c4b155.AEQAKqmySzQAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZI4fH@mailjet.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Prairial an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 23 May 2017 10:15:45 +0200 In-Reply-To: <95c4b155.AEQAKqmySzQAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZI4fH@mailjet.com> (Arun Isaac's message of "Tue, 23 May 2017 06:22:01 +0530") Message-ID: <87lgpoyoni.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26802-done Cc: Alex Kost , 26802-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hey Arun, Arun Isaac skribis: >> Pushed patches 1, 2 and 4. Thank you! > Looks like I made a mistake with patch 4's commit message. I should have > used the prefix "build-system: emacs:", instead of "build: > emacs:". Sorry! :-( No big deal, that=E2=80=99s OK. Cheers, Ludo=E2=80=99. From unknown Sat Sep 13 11:12:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Jun 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator