GNU bug report logs - #26792
Fix output of --help in package fish

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26792 in the body.
You can then email your comments to 26792 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> pragmatique.xyz>
To: guix-patches <at> gnu.org
Subject: Fix output of --help in package fish
Date: Sat, 6 May 2017 00:56:54 +0000

[Message part 1 (text/plain, inline)]

Currently the output of fish --help fails if the nroff binary is not found.
The patch fixes the issue by embeding a reference to the groff provided nroff,
fish --help produces correct output after this is applied.
-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

[0001-gnu-fish-Reference-groff-to-fix-output-of-fish-help.patch (text/plain, attachment)]

Message #8 received at 26792 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> pragmatique.xyz>
To: 26792 <at> debbugs.gnu.org
Subject: Re: bug#26792: Acknowledgement (Fix output of --help in package fish)
Date: Sat, 6 May 2017 10:44:53 +0000

I just created a new user which uses fish as the login shell and
I need to update this patch. There is more to be embeded for fish.
GNU bug Tracking System transcribed 0.7K bytes:
> Thank you for filing a new bug report with debbugs.gnu.org.
> 
> This is an automatically generated reply to let you know your message
> has been received.
> 
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
> 
> Your message has been sent to the package maintainer(s):
>  guix-patches <at> gnu.org
> 
> If you wish to submit further information on this problem, please
> send it to 26792 <at> debbugs.gnu.org.
> 
> Please do not send mail to help-debbugs <at> gnu.org unless you wish
> to report a problem with the Bug-tracking system.
> 
> -- 
> 26792: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26792
> GNU Bug Tracking System
> Contact help-debbugs <at> gnu.org with problems

-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> pragmatique.xyz>
To: 26792 <at> debbugs.gnu.org
Cc: bug-guix <at> gnu.org
Subject: Re: bug#26792: Acknowledgement (Fix output of --help in package fish)
Date: Sat, 6 May 2017 11:03:53 +0000

ng0 transcribed 1.0K bytes:
> I just created a new user which uses fish as the login shell and
> I need to update this patch. There is more to be embeded for fish.

This is similar to the "mc" situation.

In a plain fish profile with no bash whatsoever, your default $PATH is:

echo $PATH
/usr /usr/bin

the major issue when logging in is:

1. grep is not found.
2. hostname is not found.

The question to think about is, how do we provide access to the basic
applications (grep, awk, hostname, etc) fish needs? Substituting a minimal
set of files where necessary seems like the best working solution for a
system which does not assume any other shell and therefore does initially
export no $PATH other than /usr and /usr/bin.

The very least I want people to experience is no error immediately after
first login. This happens at the moment.
-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

Message #17 received at 26792 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> pragmatique.xyz>
To: 26792 <at> debbugs.gnu.org
Subject: Re: bug#26792: Acknowledgement (Fix output of --help in package fish)
Date: Sat, 6 May 2017 11:36:33 +0000

ng0 transcribed 0.9K bytes:
> ng0 transcribed 1.0K bytes:
> > I just created a new user which uses fish as the login shell and
> > I need to update this patch. There is more to be embeded for fish.
> 
> This is similar to the "mc" situation.
> 
> In a plain fish profile with no bash whatsoever, your default $PATH is:
> 
> echo $PATH
> /usr /usr/bin

A correction: $PATH = /bin /usr/bin

> the major issue when logging in is:
> 
> 1. grep is not found.
> 2. hostname is not found.
> 
> The question to think about is, how do we provide access to the basic
> applications (grep, awk, hostname, etc) fish needs? Substituting a minimal
> set of files where necessary seems like the best working solution for a
> system which does not assume any other shell and therefore does initially
> export no $PATH other than /usr and /usr/bin.
> 
> The very least I want people to experience is no error immediately after
> first login. This happens at the moment.
> -- 
> https://pragmatique.xyz
> PGP: https://people.pragmatique.xyz/ng0/
> 
> 
> 

-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

Message #22 received at 26792-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: 26792-done <at> debbugs.gnu.org
Subject: Re: bug#26792: Fix output of --help in package fish
Date: Sat, 06 May 2017 15:53:17 +0200

ng0 <ng0 <at> pragmatique.xyz> skribis:

> Currently the output of fish --help fails if the nroff binary is not found.
> The patch fixes the issue by embeding a reference to the groff provided nroff,
> fish --help produces correct output after this is applied.
> -- 
> https://pragmatique.xyz
> PGP: https://people.pragmatique.xyz/ng0/
>
> From 5a22ffdccef3266f6a4050f715f304c10c259ba3 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> no-reply.pragmatique.xyz>
> Date: Sat, 6 May 2017 00:12:58 +0000
> Subject: [PATCH] gnu: fish: Reference 'groff' to fix output of 'fish --help'.
>
> * gnu/packages/shells.scm (fish)[native-inputs]: Add 'groff'.
> (arguments): Add 'nroff' substitution in 'embed-store-paths' phase.

Applied, but moving groff to ‘inputs’ since it’s needed at run time.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.