GNU bug report logs - #2678
vc-git-register not working when passed a directory argument

Previous Next

Full log

View this message in rfc822 format

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Miles Bader <miles <at> gnu.org>
Cc: 2678 <at> debbugs.gnu.org
Subject: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when  only adds are necessary
Date: Fri, 20 Mar 2009 20:50:37 -0700 (PDT)

Miles Bader <miles <at> gnu.org> writes:

  > On Sat, Mar 21, 2009 at 11:54 AM, Dan Nicolaescu <dann <at> ics.uci.edu> wrote:
  > >  >    (2) Perhaps vc-dir it should do a "revert-buffer" (or something)
  > >  > afterwards when it operations on a subdirectory or the whole
  > >  > directory, as any operation with the backend doing the recursion may
  > >  > change something other than what is displayed.  This is easy to see if
  > >  > their were unregistered subdirectories with files -- doing "v" to
  > >  > register a subdirectory adds all files in that directory, which vc-dir
  > >  > hadn't displayed before, so currently "v" doesn't properly show them
  > >  > afterwards (doing "g" shows them).
  > >
  > > It does, but there might be other things not working correctly with git,
  > > try with hg and you will see it working correctly.
  > 
  > It does what?  

vc-register creates a call to vc-start-logentry
vc-start-logentry calls vc-finish-logentry which calls vc-resynch-buffer
vc-resynch-buffer updates both the buffers that might have been
affected by the VC command and the vc-dir display (this one via the 
vc-dir-resynch-file call).

  > A revert?  Or always updates the display correctly in
  > the subdir case without a revert?  If it's the latter, what mechanism
  > does the backend use to communicate to vc-dir that more stuff has
  > shown up?  [or does the backend just do a revert itself?]



  > Thanks,
  > 
  > -Miles
  > 
  > -- 
  > Do not taunt Happy Fun Ball.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.