From miles@gnu.org Sat Mar 14 23:07:10 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 15 Mar 2009 06:07:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2F676L9000338 for ; Sat, 14 Mar 2009 23:07:08 -0700 Received: from mx10.gnu.org ([199.232.76.166]:34450) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LijV3-0005bI-Vx for emacs-pretest-bug@gnu.org; Sun, 15 Mar 2009 02:07:06 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LijV0-0002CJ-GL for emacs-pretest-bug@gnu.org; Sun, 15 Mar 2009 02:07:05 -0400 Received: from smtp11.dentaku.gol.com ([203.216.5.73]:39045) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LijUz-0002C7-L0; Sun, 15 Mar 2009 02:07:02 -0400 Received: from 218.231.175.8.eo.eaccess.ne.jp ([218.231.175.8] helo=catnip.gol.com) by smtp11.dentaku.gol.com with esmtpa (Dentaku) id 1LijUx-0001dl-6G; Sun, 15 Mar 2009 15:06:59 +0900 Received: by catnip.gol.com (Postfix, from userid 1000) id 418C1DFD8; Sun, 15 Mar 2009 15:06:56 +0900 (JST) From: Miles Bader To: emacs-pretest-bug@gnu.org Subject: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary Reply-To: Miles Bader System-Type: x86_64-unknown-linux-gnu Date: Sun, 15 Mar 2009 15:06:56 +0900 Message-ID: <87d4cjcoan.fsf@catnip.gol.com> Lines: 152 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: ClamAV GOL (outbound) X-Abuse-Complaints: abuse@gol.com X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) [Note: I have Dan's patch for fixing whole-directory vc-dir commit in Git applied, though I don't think it should affect the following, as it relates to final commit.] If I have a vc-dir buffer showing a tree where the only entries are new files (not yet registered with source-control): VC backend : Git Working dir: /tmp/zonk/ Branch : master ./ unregistered llll unregistered oiuoiu Then hitting "v" on the first line of the buffer acts strangely -- I'd expect it to simply register all these files with source control, but in fact, it simply appears to do nothing. There are actually several behaviors (though it always does nothing in the end). If this is the first time I've tried to do this, it just displays a message like "Registering (/tmp/zonk/)... done" [where "/tmp/zonk2" is the root of the working directory in question] but doesn't seem to really do it. If I then try the "v" command again, it will first show the message: Previous master file has vanished. Make a new one? (y or n) If I enter "n" it just gives an error and aborts. If I type "y", then it will either display a "Registering (/tmp/zonk/)... done" message like the initial time (and again have no real result), or show a *vc-log* buffer to prompt for an "initial comment"; in the latter case, when I then hit C-c C-c to continue, the *vc-log* buffer goes away -- but nothing further appears to happen. [I'm not sure what causes it to open a *vc-log* buffer or not ... in my initial tests it did, but when I tried again with emacs -Q, it didn't.] Anyway, the end result is always the same, no registered files. To reproduce: (1) Execute the following shell script to create a test repo in "/tmp/zonk2": #!/bin/sh cd /tmp rm -rf zonk2 mkdir zonk2 cd zonk2 git init echo plugh > ppling git add . git commit -m'Init' -a echo Fnord >> newf1 echo Chnevy >> newf2 (2) Start emacs: HOME=/tmp emacs -Q -nw (3) Start vc-dir on the test repo: C-x v d /tmp/zonk2 RET (4) Without moving the cursor, try to register the new files: v (5) It will exhibit one of the faulty behaviors described above, resulting in no file registration being done. Thanks, -Miles If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/local/share/emacs/23.0.91/etc/DEBUG for instructions. In GNU Emacs 23.0.91.11 (x86_64-unknown-linux-gnu, GTK+ Version 2.15.5) of 2009-03-13 on catnip Windowing system distributor `The X.Org Foundation', version 11.0.10599902 Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ja_JP.UTF-8 value of $XMODIFIERS: @im=SCIM locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Message Minor modes in effect: diff-auto-refine-mode: t shell-dirtrack-mode: t mml-mode: t rcirc-track-minor-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: SPC y o u SPC n g i v e h s p e c i f y SPC ( a n d SPC l e a v e s SPC a n y SPC o t h e r s SPC a l o n e ) - C-x d C-x b * G r SPC K g C-c C-SPC C-c C-SPC C-c C-SPC K g n n n n n n n p p p p p p SPC SPC q n n SPC q n = SPC n n n q C-x b * v c SPC - d SPC r SPC / SPC C-n C-n C-n C-n C-n C-n C-p C-n m C-u C-p C-p v w a c k y C-c C-c x v z o i n k c C-c C-c C-c C-g C-a C-n C-p C-p v y z o i n k C-c C-c g g g C-h f C-g C-h e > C-x d C-n C-n C-n v y a o i n C-c C-c C-u C-p c v y v o i n C-c C-c C-n C-a C-n C-n C-n v C-c C-c C-u C-p C-p v p l o o n C-c C-c C-a C-a C-x C-v p l C-g C-x C-v n e w f SPC 4 l C-x C-s C-x k C-u C-p v k o k C-c C-c x C-x C-v l l l l l k j C-x C-s C-x k C-p C-p v n C-a C-x h w C-x b * s e SPC m SPC SPC < 2 SPC x r e p o SPC r SPC e SPC Recent messages: Checking in /tmp/zonk/...done (New file) Saving file /tmp/zonk/llll... Wrote /tmp/zonk/llll xding Previous master file has vanished. Make a new one? (y or n) xding vc-register: Aborted Mark set [2 times] Making completion list... [2 times] -- Zeal, n. A certain nervous disorder afflicting the young and inexperienced. From dann@godzilla.ics.uci.edu Sun Mar 15 08:00:08 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 15 Mar 2009 15:00:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2FF05oJ017517 for <2678@emacsbugs.donarmstrong.com>; Sun, 15 Mar 2009 08:00:06 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n2FExplK009383; Sun, 15 Mar 2009 07:59:51 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2FExoGk017512; Sun, 15 Mar 2009 07:59:50 -0700 (PDT) Date: Sun, 15 Mar 2009 07:59:50 -0700 (PDT) Message-Id: <200903151459.n2FExoGk017512@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Miles Bader Cc: 2678@debbugs.gnu.org Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary References: <87d4cjcoan.fsf@catnip.gol.com> X-Debbugs-No-Ack: yes In-Reply-To: <87d4cjcoan.fsf@catnip.gol.com> (Miles Bader's message of "Sun, 15 Mar 2009 15:06:56 +0900") Lines: 29 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2FExplK009383 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Miles Bader writes: > [Note: I have Dan's patch for fixing whole-directory vc-dir commit in > Git applied, though I don't think it should affect the following, as it > relates to final commit.] > > If I have a vc-dir buffer showing a tree where the only entries are new > files (not yet registered with source-control): > > VC backend : Git > Working dir: /tmp/zonk/ > Branch : master > > ./ > unregistered llll > unregistered oiuoiu > > Then hitting "v" on the first line of the buffer acts strangely -- I'd > expect it to simply register all these files with source control, but in > fact, it simply appears to do nothing. > > There are actually several behaviors (though it always does nothing in > the end). If this is the first time I've tried to do this, it just > displays a message like "Registering (/tmp/zonk/)... done" [where > "/tmp/zonk2" is the root of the working directory in question] but > doesn't seem to really do it. This is a vc-git.el problem, vc-git-register does not register the files. Try the same thing with, say, mercurial and it work. From lekktu@gmail.com Mon Mar 16 03:01:04 2009 Received: (at control) by emacsbugs.donarmstrong.com; 16 Mar 2009 10:01:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.3 required=4.0 tests=MISSING_SUBJECT,NOSUBJECT, VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f176.google.com (mail-ew0-f176.google.com [209.85.219.176]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2GA10nD005328 for ; Mon, 16 Mar 2009 03:01:02 -0700 Received: by ewy24 with SMTP id 24so3587653ewy.1 for ; Mon, 16 Mar 2009 03:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=i6IWS3kEaldcXATEjc4+iRbM405bcENCpisDOFppCtw=; b=Hr41hZGojSatEArIZiK6b8DP19WSH9hAXKffgR6KgAJpGEukaxRUpwJ2DYKQy4tiaL Qaxj23iT5EY+IDYJQ46T5m4o4YXz7xoLVqOhFuYx9C8cf9ApPR+MptKVIZJ0EnZhm6Gi 8OwdesaKCHqzyoP8Q0uOVfsDg+AGB3msdo2WI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=bTr3uyoFB+I4PLEOs8dBEFc59Tbb5Caeyg90qH/jwLrLsX0vZAEKYo+OA2+b6VDzSY pzBAjl2JY0En+h4GH2SmjNF9FxUNGUNButic4TKhyrI6eqTKgC/oxVCCnYIhKMMD8fec 6BqVXQCjaqlc017pT/JkNNloTxNOqSe+yF4Tg= MIME-Version: 1.0 Received: by 10.210.136.10 with SMTP id j10mr3422472ebd.24.1237197655309; Mon, 16 Mar 2009 03:00:55 -0700 (PDT) Date: Mon, 16 Mar 2009 11:00:55 +0100 Message-ID: Subject: From: Juanma Barranquero To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit reassign 2682 spam reassign 2641 emacs,vc-dir reassign 2652 emacs,vc-dir reassign 2675 emacs,vc-dir reassign 2676 emacs,vc-dir reassign 2678 emacs,vc-dir reassign 2662 emacs,ns reassign 2663 emacs,ns quit From lekktu@gmail.com Tue Mar 17 02:22:15 2009 Received: (at control) by emacsbugs.donarmstrong.com; 17 Mar 2009 09:22:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.3 required=4.0 tests=MISSING_SUBJECT,NOSUBJECT, VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f176.google.com (mail-ew0-f176.google.com [209.85.219.176]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2H9MCD0005523 for ; Tue, 17 Mar 2009 02:22:14 -0700 Received: by ewy24 with SMTP id 24so3991757ewy.1 for ; Tue, 17 Mar 2009 02:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=8kg3xZo7LkfeWm8/N+Bb5gCTHDvSowOAk/GT0NUKjNc=; b=sS/XKophFfzDqrpZxSKYexjpSHOEBgWFBIntADHTWgLQ7xAkX2LJay0VW5/a9alnYU JqK5mkqwrC9L2Iu+b+OHuLWMs4dh1ivw0p3TpVFe4KfkhmlI8VYyhAH9+vGdgV/V/aj8 ZjrZbQHD9z3NgdBNX9dcvrhXE1JDzicWFM4Uo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=epHiHh4jTH8hNQ3Z9W+sdmPMWG5K8t56w3EIXDv+nyc7uMUO0OebD87ssmj47nN/8V gEn2T5weZyGT7QqOtX3mDXQokeXZQjhWmeLaUkSzN5IXPiPJhZ8VSTSKiUUROU4m5YrP Wm9HxlDTvoTR98dZx15fhqd+5ewRn1t26NJDo= MIME-Version: 1.0 Received: by 10.210.139.15 with SMTP id m15mr4357553ebd.9.1237281726835; Tue, 17 Mar 2009 02:22:06 -0700 (PDT) Date: Tue, 17 Mar 2009 10:22:06 +0100 Message-ID: Subject: From: Juanma Barranquero To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit reassign 337 emacs,vc reassign 768 emacs,vc reassign 927 emacs,vc reassign 996 emacs,vc reassign 1098 emacs,vc reassign 1163 emacs,vc reassign 1256 emacs,vc reassign 1257 emacs,vc reassign 1408 emacs,vc reassign 1429 emacs,vc reassign 1589 emacs,vc reassign 1647 emacs,w32,vc reassign 1741 emacs,vc reassign 2093 emacs,vc reassign 2110 emacs,vc reassign 2117 emacs,vc reassign 2157 emacs,vc reassign 2338 emacs,vc reassign 2553 emacs,vc reassign 2598 emacs,vc reassign 2604 emacs,vc reassign 2612 emacs,vc reassign 2641 emacs,vc reassign 2652 emacs,vc reassign 2675 emacs,vc reassign 2676 emacs,vc reassign 2678 emacs,vc quit From dann@godzilla.ics.uci.edu Fri Mar 20 09:15:22 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 20 Mar 2009 16:15:22 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.9 required=4.0 tests=FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2KGFJ1p025294 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 09:15:20 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id n2KGF8Gr015400; Fri, 20 Mar 2009 09:15:08 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2KGF70T023133; Fri, 20 Mar 2009 09:15:07 -0700 (PDT) Date: Fri, 20 Mar 2009 09:15:07 -0700 (PDT) Message-Id: <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Miles Bader Cc: 2678@debbugs.gnu.org Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary References: <87d4cjcoan.fsf@catnip.gol.com> X-Debbugs-No-Ack: yes In-Reply-To: <87d4cjcoan.fsf@catnip.gol.com> (Miles Bader's message of "Sun, 15 Mar 2009 15:06:56 +0900") Lines: 75 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2KGF8Gr015400 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Miles Bader writes: > [Note: I have Dan's patch for fixing whole-directory vc-dir commit in > Git applied, though I don't think it should affect the following, as it > relates to final commit.] > > If I have a vc-dir buffer showing a tree where the only entries are new > files (not yet registered with source-control): > > VC backend : Git > Working dir: /tmp/zonk/ > Branch : master > > ./ > unregistered llll > unregistered oiuoiu > > Then hitting "v" on the first line of the buffer acts strangely -- I'd > expect it to simply register all these files with source control, but in > fact, it simply appears to do nothing. > > There are actually several behaviors (though it always does nothing in > the end). If this is the first time I've tried to do this, it just > displays a message like "Registering (/tmp/zonk/)... done" [where > "/tmp/zonk2" is the root of the working directory in question] but > doesn't seem to really do it. > > If I then try the "v" command again, it will first show the message: > > Previous master file has vanished. Make a new one? (y or n) > > If I enter "n" it just gives an error and aborts. > > If I type "y", then it will either display a "Registering > (/tmp/zonk/)... done" message like the initial time (and again have no > real result), or show a *vc-log* buffer to prompt for an "initial > comment"; in the latter case, when I then hit C-c C-c to continue, the > *vc-log* buffer goes away -- but nothing further appears to happen. > [I'm not sure what causes it to open a *vc-log* buffer or not ... in my > initial tests it did, but when I tried again with emacs -Q, it didn't.] > > Anyway, the end result is always the same, no registered files. > > > To reproduce: > > (1) Execute the following shell script to create a test repo in > "/tmp/zonk2": > > #!/bin/sh > cd /tmp > rm -rf zonk2 > mkdir zonk2 > cd zonk2 > git init > echo plugh > ppling > git add . > git commit -m'Init' -a > echo Fnord >> newf1 > echo Chnevy >> newf2 Given that you are familiar with git, the function to fix to get this working is the one liner `vc-git-register': (defun vc-git-register (files &optional rev comment) "Register FILE into the git version-control system." (vc-git-command nil 0 files "update-index" "--add" "--")) just add the correct command(s) to run to vc-git-command, and it should work. In case above vc-git-register is called like this: (vc-git-register "/tmp/zonk2/") From snogglethorpe@gmail.com Fri Mar 20 19:28:16 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 21 Mar 2009 02:28:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.30]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2L2SCk6025492 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 19:28:14 -0700 Received: by yw-out-2324.google.com with SMTP id 5so873145ywh.31 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 19:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=9ZPf7f98T7AN3GqO8aKJfH8LA38RmctjHFbpiRm2O9c=; b=h67HLQrGjAwHItFbgYdoYYltzAJP3Gs7m9lqqvqE6028QCZoVL8fd8Krc1etMzHI0K PP+IIwQHTwBug7Mv+T+sjAiju0Kfu0tKFCXkZvfryvqN0bNm9MRNuXSSpDX0JoAoZaH7 8buDVKPSNCqU4FXDD9TmNX8pVoyInk2/hFIQs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=xmzG3JyF03mCvpI+HDX+XcojZ/RP8yA1rJnCzoL3gjLdtFzfFRK7jSUUHqeQaJvM9p DQWSctq7csR3e3NusXgZVS2qdzqweWM0Urlm6NP5AiaACZTAJK/pq/0D1GWhBJjy8di7 YMtQLcNVYiouL/U2BXIXylsDGQrzutzlEMOig= MIME-Version: 1.0 Sender: snogglethorpe@gmail.com Received: by 10.150.215.16 with SMTP id n16mr7644546ybg.144.1237602492336; Fri, 20 Mar 2009 19:28:12 -0700 (PDT) In-Reply-To: <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> Date: Sat, 21 Mar 2009 11:28:12 +0900 X-Google-Sender-Auth: c02811403beacf86 Message-ID: Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary From: Miles Bader To: Dan Nicolaescu Cc: 2678@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sat, Mar 21, 2009 at 1:15 AM, Dan Nicolaescu wrote: > Given that you are familiar with git, the function to fix to get this > working is the one liner `vc-git-register': > > (defun vc-git-register (files &optional rev comment) > =A0"Register FILE into the git version-control system." > =A0(vc-git-command nil 0 files "update-index" "--add" "--")) ... > (vc-git-register "/tmp/zonk2/") The obvious solution is to use "add" instead of "update-index --add". [I tested it, it works.] However, it'd be nice to ask whoever wrote this function originally whether there was a reason for using "update-index" instead of "add", given that vc.el apparently expects higher-level level functionality (recursion) from the register hook. I suppose update-index is the more conservative choice, since it's officially "plumbing", but I'm not aware of any problems with using the higher-level git-add in this case. [The git backend already uses "add" in other places too.] Also, I wonder: (1) Given that vc-dir already has a list of files presented in the directory listing, how come it doesn't give the backend that list, instead of just the directory (having the backend do the recursion seems more likely to yield unexpected results)? (2) Perhaps vc-dir it should do a "revert-buffer" (or something) afterwards when it operations on a subdirectory or the whole directory, as any operation with the backend doing the recursion may change something other than what is displayed. This is easy to see if their were unregistered subdirectories with files -- doing "v" to register a subdirectory adds all files in that directory, which vc-dir hadn't displayed before, so currently "v" doesn't properly show them afterwards (doing "g" shows them). thanks, -miles --=20 Do not taunt Happy Fun Ball. From dann@godzilla.ics.uci.edu Fri Mar 20 19:54:19 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 21 Mar 2009 02:54:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.9 required=4.0 tests=FOURLA,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2L2sG2J031815 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 19:54:17 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id n2L2s5ut023742; Fri, 20 Mar 2009 19:54:05 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2L2s5ep029446; Fri, 20 Mar 2009 19:54:05 -0700 (PDT) Date: Fri, 20 Mar 2009 19:54:05 -0700 (PDT) Message-Id: <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Miles Bader Cc: 2678@debbugs.gnu.org Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Miles Bader's message of "Sat, 21 Mar 2009 11:28:12 +0900") Lines: 51 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2L2s5ut023742 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Miles Bader writes: > On Sat, Mar 21, 2009 at 1:15 AM, Dan Nicolaescu wrot= e: > > Given that you are familiar with git, the function to fix to get this > > working is the one liner `vc-git-register': > > > > (defun vc-git-register (files &optional rev comment) > > =C2=A0"Register FILE into the git version-control system." > > =C2=A0(vc-git-command nil 0 files "update-index" "--add" "--")) > ... > > (vc-git-register "/tmp/zonk2/") >=20 > The obvious solution is to use "add" instead of "update-index --add". >=20 > [I tested it, it works.] >=20 > However, it'd be nice to ask whoever wrote this function originally > whether there was a reason for using "update-index" instead of "add", I'd assume it would be the vc-git.el author. > given that vc.el apparently expects higher-level level functionality > (recursion) from the register hook. I suppose update-index is the > more conservative choice, since it's officially "plumbing", but I'm > not aware of any problems with using the higher-level git-add in this > case. [The git backend already uses "add" in other places too.] >=20 > Also, I wonder: >=20 > (1) Given that vc-dir already has a list of files presented in the > directory listing, how come it doesn't give the backend that list, > instead of just the directory (having the backend do the recursion > seems more likely to yield unexpected results)? When the point is on the "./" entry (or before), and nothing is selected it means that you are asking for an action to be performed on the directory, that is gets sent to the VC command. If you want a list of files to be sent, mark a list of files and that is what will be sent. > (2) Perhaps vc-dir it should do a "revert-buffer" (or something) > afterwards when it operations on a subdirectory or the whole > directory, as any operation with the backend doing the recursion may > change something other than what is displayed. This is easy to see if > their were unregistered subdirectories with files -- doing "v" to > register a subdirectory adds all files in that directory, which vc-dir > hadn't displayed before, so currently "v" doesn't properly show them > afterwards (doing "g" shows them). It does, but there might be other things not working correctly with git, try with hg and you will see it working correctly. From snogglethorpe@gmail.com Fri Mar 20 20:00:24 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 21 Mar 2009 03:00:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.30]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2L30Lg8001786 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 20:00:22 -0700 Received: by yx-out-2324.google.com with SMTP id 8so882668yxm.31 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 20:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=FgSuC2j/pa1qxtiB6oE2GOWvMTZEdwBq3/8bstn++YU=; b=TuUrjUNtNBFJ72AxWCRTaWL3YQBiauk0vHeHpXv9y0hCqKSTZcsHmY5lQs6gGijbQk Qp5MENTLFaN+vsNQRY0PP2HyY+KPjalVMr2QIYdG+Hr0XTlNJ2RezaKuXwZ+TNZu8u24 ApkWDB5dDLZVk3nq4gIBu/isroedCGCWR/HUM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=GHM2wKpnE1KdnYlJMPEICEhMi9lhFkEBvpEfQdm+4/WWwOmVZ0Je1nO+eOjZdYk0DW D3UbSo4FF1NLztUU/tR+oD4gtDiI7hO3NYh2d0pUmht0olY9SJvHlwdtdXoHo9rKniR2 AaQGFoocLq/48UISXlEA8uuK/0SpeEQIoRrb4= MIME-Version: 1.0 Sender: snogglethorpe@gmail.com Received: by 10.150.228.12 with SMTP id a12mr7725313ybh.13.1237604420624; Fri, 20 Mar 2009 20:00:20 -0700 (PDT) In-Reply-To: <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> Date: Sat, 21 Mar 2009 12:00:20 +0900 X-Google-Sender-Auth: 9618a8c143f8599b Message-ID: Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary From: Miles Bader To: Dan Nicolaescu Cc: 2678@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sat, Mar 21, 2009 at 11:54 AM, Dan Nicolaescu wrote: > =A0> =A0 =A0(2) Perhaps vc-dir it should do a "revert-buffer" (or somethi= ng) > =A0> afterwards when it operations on a subdirectory or the whole > =A0> directory, as any operation with the backend doing the recursion may > =A0> change something other than what is displayed. =A0This is easy to se= e if > =A0> their were unregistered subdirectories with files -- doing "v" to > =A0> register a subdirectory adds all files in that directory, which vc-d= ir > =A0> hadn't displayed before, so currently "v" doesn't properly show them > =A0> afterwards (doing "g" shows them). > > It does, but there might be other things not working correctly with git, > try with hg and you will see it working correctly. It does what? A revert? Or always updates the display correctly in the subdir case without a revert? If it's the latter, what mechanism does the backend use to communicate to vc-dir that more stuff has shown up? [or does the backend just do a revert itself?] Thanks, -Miles --=20 Do not taunt Happy Fun Ball. From dann@godzilla.ics.uci.edu Fri Mar 20 20:50:51 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 21 Mar 2009 03:50:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2L3om6I015198 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 20:50:49 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n2L3obYK021969; Fri, 20 Mar 2009 20:50:37 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2L3obrZ000098; Fri, 20 Mar 2009 20:50:37 -0700 (PDT) Date: Fri, 20 Mar 2009 20:50:37 -0700 (PDT) Message-Id: <200903210350.n2L3obrZ000098@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Miles Bader Cc: 2678@debbugs.gnu.org Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Miles Bader's message of "Sat, 21 Mar 2009 12:00:20 +0900") Lines: 36 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2L3obYK021969 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Miles Bader writes: > On Sat, Mar 21, 2009 at 11:54 AM, Dan Nicolaescu wro= te: > > =C2=A0> =C2=A0 =C2=A0(2) Perhaps vc-dir it should do a "revert-buffer= " (or something) > > =C2=A0> afterwards when it operations on a subdirectory or the whole > > =C2=A0> directory, as any operation with the backend doing the recurs= ion may > > =C2=A0> change something other than what is displayed. =C2=A0This is = easy to see if > > =C2=A0> their were unregistered subdirectories with files -- doing "v= " to > > =C2=A0> register a subdirectory adds all files in that directory, whi= ch vc-dir > > =C2=A0> hadn't displayed before, so currently "v" doesn't properly sh= ow them > > =C2=A0> afterwards (doing "g" shows them). > > > > It does, but there might be other things not working correctly with g= it, > > try with hg and you will see it working correctly. >=20 > It does what?=20=20 vc-register creates a call to vc-start-logentry vc-start-logentry calls vc-finish-logentry which calls vc-resynch-buffer vc-resynch-buffer updates both the buffers that might have been affected by the VC command and the vc-dir display (this one via the=20 vc-dir-resynch-file call). > A revert? Or always updates the display correctly in > the subdir case without a revert? If it's the latter, what mechanism > does the backend use to communicate to vc-dir that more stuff has > shown up? [or does the backend just do a revert itself?] > Thanks, >=20 > -Miles >=20 > --=20 > Do not taunt Happy Fun Ball. From snogglethorpe@gmail.com Fri Mar 20 21:14:38 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 21 Mar 2009 04:14:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-gx0-f171.google.com (mail-gx0-f171.google.com [209.85.217.171]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2L4EYCj021123 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 21:14:35 -0700 Received: by gxk19 with SMTP id 19so3902135gxk.1 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 21:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=fD6m+cP7kyX/DsCkOVev+foItNMgKfG8L+l+kz4b4ro=; b=nhlpnzimkk5LKo4EyJkEgvPyrmQcT/LqMjZUSPDwbR7hgx4OHCXCCQ6blGVVvMoVRL E+jfBG3W0Ac2DG34pAyNcdYwIAhQ8pbRFeHT+w0qU5d72LQNCu7nBXpHo0x3rHI1+z1D tpXMYaKvAlzCgN0aTqvrMnu8V2gOMv3dK4lX4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=WuJ+ZO4HiStMknMTAZ9N2v/vrQmpQ1Zmkn+JFEqdAnEbgRpQ7K92JDyI2MIIODowKM nc7h5HPUzPxZdbAcy1FklkE8uRnOUeUrb2m6U3eeq+8FLewrRZBnJR3ulE3kghynQj4L RICyACYZLL3E0JNBMw4DlDyDHMmrtQRTYWkC8= MIME-Version: 1.0 Sender: snogglethorpe@gmail.com Received: by 10.151.8.8 with SMTP id l8mr7168042ybi.49.1237608869046; Fri, 20 Mar 2009 21:14:29 -0700 (PDT) In-Reply-To: <200903210350.n2L3obrZ000098@godzilla.ics.uci.edu> References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> <200903210350.n2L3obrZ000098@godzilla.ics.uci.edu> Date: Sat, 21 Mar 2009 13:14:29 +0900 X-Google-Sender-Auth: bb5bb79aad853f12 Message-ID: Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary From: Miles Bader To: Dan Nicolaescu Cc: 2678@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sat, Mar 21, 2009 at 12:50 PM, Dan Nicolaescu wrote: > =A0> > It does, but there might be other things not working correctly wit= h git, > =A0> > try with hg and you will see it working correctly. > =A0> > =A0> It does what? > > vc-register creates a call to vc-start-logentry > vc-start-logentry calls vc-finish-logentry which calls vc-resynch-buffer > vc-resynch-buffer updates both the buffers that might have been > affected by the VC command and the vc-dir display (this one via the > vc-dir-resynch-file call). Oh, incidentally -- that's another problem with the vc register stuff, it prompts for a log message, which is useless for git (is it useful for any non-cvs system?). Is there a way for the backend to suppress that behavior? Thanks, -Miles --=20 Do not taunt Happy Fun Ball. From dann@godzilla.ics.uci.edu Fri Mar 20 21:30:58 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 21 Mar 2009 04:30:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2L4UtYw026122 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 21:30:57 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n2L4UWag027520; Fri, 20 Mar 2009 21:30:32 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2L4UWTf000579; Fri, 20 Mar 2009 21:30:32 -0700 (PDT) Date: Fri, 20 Mar 2009 21:30:32 -0700 (PDT) Message-Id: <200903210430.n2L4UWTf000579@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Miles Bader Cc: 2678@debbugs.gnu.org Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> <200903210350.n2L3obrZ000098@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Miles Bader's message of "Sat, 21 Mar 2009 13:14:29 +0900") Lines: 24 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2L4UWag027520 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Miles Bader writes: > On Sat, Mar 21, 2009 at 12:50 PM, Dan Nicolaescu wro= te: > > =C2=A0> > It does, but there might be other things not working correc= tly with git, > > =C2=A0> > try with hg and you will see it working correctly. > > =C2=A0> > > =C2=A0> It does what? > > > > vc-register creates a call to vc-start-logentry > > vc-start-logentry calls vc-finish-logentry which calls vc-resynch-buf= fer > > vc-resynch-buffer updates both the buffers that might have been > > affected by the VC command and the vc-dir display (this one via the > > vc-dir-resynch-file call). >=20 > Oh, incidentally -- that's another problem with the vc register stuff, > it prompts for a log message, which is useless for git (is it useful > for any non-cvs system?).=20=20 Probably not... > Is there a way for the backend to suppress that behavior? I've never seen this happen, so I don't know of the top of my head how to avoid it. Can you describe what you do so that I can reproduce it? From snogglethorpe@gmail.com Fri Mar 20 21:39:37 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 21 Mar 2009 04:39:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-gx0-f171.google.com (mail-gx0-f171.google.com [209.85.217.171]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2L4dXin027437 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 21:39:35 -0700 Received: by gxk19 with SMTP id 19so3916398gxk.1 for <2678@emacsbugs.donarmstrong.com>; Fri, 20 Mar 2009 21:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=yUigCQSqhnMn2r3qRepjTuC74Tc4xaJd1nX1lhwIvIw=; b=lEJqOOYHPjwj2PHFr+Q9BSUbHzb3ozKnKh0fPjIlcC5V7GlUIcv1AHPT3T6+fgTCg9 vE1i/twET6eEfuwz3rG5kFox7riQ/W/LoJlFb+aaPZi1hJoWgMtzJawTQ+CsjG78s8m2 GmMfZOANmn7VRR4tLLDsOPKcKbaCnz8TG0fxQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=JniNzXV357XgryhOQTq+jwMdnJUarKstByzWouya9wtxXVp+P0QCD0qazUGBm65dUq vsdz7rLtj4ShRLBaJWQ7zvZ7f7hyN63hMkZRwYs/t9zvjDJjX+m+nCrgfk8KOpseZkac IXrvLR7zWSyf2VsH1actfbSXRgOxx0q7DnzMg= MIME-Version: 1.0 Sender: snogglethorpe@gmail.com Received: by 10.151.6.15 with SMTP id j15mr7809452ybi.200.1237610368363; Fri, 20 Mar 2009 21:39:28 -0700 (PDT) In-Reply-To: <200903210430.n2L4UWTf000579@godzilla.ics.uci.edu> References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> <200903210350.n2L3obrZ000098@godzilla.ics.uci.edu> <200903210430.n2L4UWTf000579@godzilla.ics.uci.edu> Date: Sat, 21 Mar 2009 13:39:28 +0900 X-Google-Sender-Auth: 41a799dd7858fca8 Message-ID: Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary From: Miles Bader To: Dan Nicolaescu Cc: 2678@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable > =A0> Oh, incidentally -- that's another problem with the vc register stuf= f, > =A0> it prompts for a log message, which is useless for git (is it useful > =A0> for any non-cvs system?). > > Probably not... > > =A0> Is there a way for the backend to suppress that behavior? > > I've never seen this happen, so I don't know of the top of my head how > to avoid it. =A0Can you describe what you do so that I can reproduce it? Hmm, actually it seems to be my configuration -- I have `vc-initial-comment' customized to `t'. Perhaps it should be ignored for backends where it's pointless, but for now I'll just change my configuration ... :-) -Miles --=20 Do not taunt Happy Fun Ball. From monnier@iro.umontreal.ca Sat Mar 21 07:10:00 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 21 Mar 2009 14:10:00 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2LE9uN9017273 for <2678@emacsbugs.donarmstrong.com>; Sat, 21 Mar 2009 07:09:58 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAOaRxElFxIZP/2dsb2JhbACBUNMUg34GhGeCLA X-IronPort-AV: E=Sophos;i="4.38,399,1233550800"; d="scan'208";a="35478923" Received: from 69-196-134-79.dsl.teksavvy.com (HELO pastel.home) ([69.196.134.79]) by ironport2-out.teksavvy.com with ESMTP; 21 Mar 2009 10:09:50 -0400 Received: by pastel.home (Postfix, from userid 20848) id 5B8757F74; Sat, 21 Mar 2009 10:10:09 -0400 (EDT) From: Stefan Monnier To: Dan Nicolaescu Cc: 2678@debbugs.gnu.org, Miles Bader Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary Message-ID: References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> <200903210350.n2L3obrZ000098@godzilla.ics.uci.edu> Date: Sat, 21 Mar 2009 10:10:09 -0400 In-Reply-To: <200903210350.n2L3obrZ000098@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Fri, 20 Mar 2009 20:50:37 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > vc-register creates a call to vc-start-logentry > vc-start-logentry calls vc-finish-logentry which calls vc-resynch-buffer BTW, this trip via vc-start-logentry should be removed. It's a remnant from old times when vc-register had an opportunity to provide a message linked to the file's addition, but nowadays it's just extra baggage that makes the code less readable. Stefan From dann@godzilla.ics.uci.edu Sat Mar 21 08:40:02 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 21 Mar 2009 15:40:02 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.9 required=4.0 tests=FOURLA,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2LFdxqF007659 for <2678@emacsbugs.donarmstrong.com>; Sat, 21 Mar 2009 08:40:00 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id n2LFdlko005931; Sat, 21 Mar 2009 08:39:47 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2LFdlZ5008069; Sat, 21 Mar 2009 08:39:47 -0700 (PDT) Date: Sat, 21 Mar 2009 08:39:47 -0700 (PDT) Message-Id: <200903211539.n2LFdlZ5008069@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: 2678@debbugs.gnu.org, Miles Bader Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> <200903210350.n2L3obrZ000098@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Sat, 21 Mar 2009 10:10:09 -0400") Lines: 11 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2LFdlko005931 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > > vc-register creates a call to vc-start-logentry > > vc-start-logentry calls vc-finish-logentry which calls vc-resynch-buffer > > BTW, this trip via vc-start-logentry should be removed. It's a remnant > from old times when vc-register had an opportunity to provide a message > linked to the file's addition, but nowadays it's just extra baggage that > makes the code less readable. Note on this added to vc.el TODO. From dann@godzilla.ics.uci.edu Mon Mar 23 09:32:08 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 23 Mar 2009 16:32:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2NGW5Ok006219 for <2678@emacsbugs.donarmstrong.com>; Mon, 23 Mar 2009 09:32:06 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id n2NGVbas025672; Mon, 23 Mar 2009 09:31:37 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2NGVaHf010862; Mon, 23 Mar 2009 09:31:36 -0700 (PDT) Date: Mon, 23 Mar 2009 09:31:36 -0700 (PDT) Message-Id: <200903231631.n2NGVaHf010862@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: 2678@debbugs.gnu.org, Miles Bader Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> <200903210350.n2L3obrZ000098@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Sat, 21 Mar 2009 10:10:09 -0400") Lines: 11 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2NGVbas025672 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > > vc-register creates a call to vc-start-logentry > > vc-start-logentry calls vc-finish-logentry which calls vc-resynch-buffer > > BTW, this trip via vc-start-logentry should be removed. It's a remnant > from old times when vc-register had an opportunity to provide a message > linked to the file's addition, but nowadays it's just extra baggage that > makes the code less readable. Would such a change be acceptable for 23.1? It's straight forward to do... From monnier@IRO.UMontreal.CA Mon Mar 23 10:25:13 2009 Received: (at 2678) by emacsbugs.donarmstrong.com; 23 Mar 2009 17:25:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2NHP8l2020591 for <2678@emacsbugs.donarmstrong.com>; Mon, 23 Mar 2009 10:25:10 -0700 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n2NHP7Hp020998; Mon, 23 Mar 2009 13:25:07 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id C4B0880B49; Mon, 23 Mar 2009 13:25:07 -0400 (EDT) From: Stefan Monnier To: Dan Nicolaescu Cc: 2678@debbugs.gnu.org, Miles Bader Subject: Re: bug#2678: 23.0.91; vc-next-action in vc-dir acts strangely when only adds are necessary Message-ID: References: <87d4cjcoan.fsf@catnip.gol.com> <200903201615.n2KGF70T023133@godzilla.ics.uci.edu> <200903210254.n2L2s5ep029446@godzilla.ics.uci.edu> <200903210350.n2L3obrZ000098@godzilla.ics.uci.edu> <200903231631.n2NGVaHf010862@godzilla.ics.uci.edu> Date: Mon, 23 Mar 2009 13:25:07 -0400 In-Reply-To: <200903231631.n2NGVaHf010862@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 23 Mar 2009 09:31:36 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3236=0 >> > vc-register creates a call to vc-start-logentry >> > vc-start-logentry calls vc-finish-logentry which calls vc-resynch-buffer >> BTW, this trip via vc-start-logentry should be removed. It's a remnant >> from old times when vc-register had an opportunity to provide a message >> linked to the file's addition, but nowadays it's just extra baggage that >> makes the code less readable. > Would such a change be acceptable for 23.1? It's straight forward to do... No, we want to stick to bug-fixes only. Stefan From dann@godzilla.ics.uci.edu Tue Apr 7 09:26:39 2009 Received: (at control) by emacsbugs.donarmstrong.com; 7 Apr 2009 16:26:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8,ONEWORD, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n37GQaKl024097 for ; Tue, 7 Apr 2009 09:26:37 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n37GQJeA013969 for ; Tue, 7 Apr 2009 09:26:19 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n37GQIRq022682; Tue, 7 Apr 2009 09:26:18 -0700 (PDT) Date: Tue, 7 Apr 2009 09:26:18 -0700 (PDT) Message-Id: <200904071626.n37GQIRq022682@godzilla.ics.uci.edu> From: Dan Nicolaescu To: control@debbugs.gnu.org Subject: commands X-Debbugs-No-Ack: yes Lines: 9 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n37GQJeA013969 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu close 1098 tags 2065 + patch close 2110 close 2117 close 2604 close 2652 close 2675 retitle 2678 vc-git-register not working when passed a directory argument merge 1589 2641 From dann@godzilla.ics.uci.edu Fri Dec 4 16:24:42 2009 Received: (at control) by emacsbugs.donarmstrong.com; 5 Dec 2009 00:24:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,MURPHY_DRUGS_REL8,ONEWORD, VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from colin-baker-v0.ics.uci.edu (colin-baker-v0.ics.uci.edu [128.195.1.153]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nB50OeSp011656 for ; Fri, 4 Dec 2009 16:24:42 -0800 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nB50OUJP015067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 4 Dec 2009 16:24:30 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nB50OU5V011260; Fri, 4 Dec 2009 16:24:30 -0800 (PST) Date: Fri, 4 Dec 2009 16:24:30 -0800 (PST) Message-Id: <200912050024.nB50OU5V011260@godzilla.ics.uci.edu> From: Dan Nicolaescu To: control@debbugs.gnu.org Subject: control X-Debbugs-No-Ack: yes Lines: 10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nB50OUJP015067 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=1.057, required 5, autolearn=disabled, ALL_TRUSTED -1.44, LOCALPART_IN_SUBJECT 2.50) X-ICS-MailScanner-SpamScore: s X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu tags 1589 3261 3462 + patch retitle 4529 --enable-ns should be on by default on macs close 4568 close 2678 close 3789 close 3968 close 4454 close 3644 forcemerge 1589 3088 quit From unknown Sat Jun 14 03:56:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 29 Jan 2010 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator