From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 11:23:50 2017 Received: (at submit) by debbugs.gnu.org; 4 May 2017 15:23:50 +0000 Received: from localhost ([127.0.0.1]:54680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6Ibd-0002D8-VB for submit@debbugs.gnu.org; Thu, 04 May 2017 11:23:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6Daf-0007ts-4K for submit@debbugs.gnu.org; Thu, 04 May 2017 06:02:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6DaU-00057z-Q2 for submit@debbugs.gnu.org; Thu, 04 May 2017 06:02:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50, MSGID_FROM_MTA_HEADER autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48581) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6DaU-00057s-NG for submit@debbugs.gnu.org; Thu, 04 May 2017 06:02:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6DaJ-0007VX-NQ for bug-coreutils@gnu.org; Thu, 04 May 2017 06:02:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6DaE-00051g-PN for bug-coreutils@gnu.org; Thu, 04 May 2017 06:02:07 -0400 Received: from dionis.factor-ts.ru ([194.154.76.131]:6790 helo=factor-ts.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6DaE-0004yz-8s; Thu, 04 May 2017 06:02:02 -0400 Received: by dionis.factor-ts.ru; Thu, 04 May 2017 12:55:08 +0300 (MSK) Message-Id: Received: from [192.168.33.154] ([192.168.33.154]=) by dionis.factor-ts.ru with SMTP; Thu, 04 May 2017 12:55:05 +0300 (MSK) (envelope-from voronov@factor-ts.ru) To: bug-coreutils@gnu.org From: =?UTF-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= Subject: expr length Message-ID: <14a6713f-ff95-4baf-5dca-0f047a5f03a5@factor-ts.ru> Date: Thu, 4 May 2017 12:59:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (barebone) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 04 May 2017 11:23:47 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, I have the bug in expr utility when it perform operation of the calculating length of the string in my multi-byte encoding ru_RU.UTF-8. When I run: "expr length Привет" it return me the number 12. But in the russian word "Hello" the length is 2 times shorter: exactly 6 characters. May you register and fix this problem? expr --version expr (GNU coreutils) 8.25 God bless you From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 11:43:27 2017 Received: (at 26779) by debbugs.gnu.org; 4 May 2017 15:43:27 +0000 Received: from localhost ([127.0.0.1]:54693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6Iuc-0002fh-Qt for submit@debbugs.gnu.org; Thu, 04 May 2017 11:43:27 -0400 Received: from mail.magicbluesmoke.com ([82.195.144.49]:32906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6Iub-0002fZ-DA for 26779@debbugs.gnu.org; Thu, 04 May 2017 11:43:25 -0400 Received: from localhost.localdomain (mobile-166-170-40-43.mycingular.net [166.170.40.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id 65B639840; Thu, 4 May 2017 16:43:23 +0100 (IST) Subject: Re: bug#26779: expr length To: =?UTF-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= , 26779@debbugs.gnu.org References: From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: Date: Thu, 4 May 2017 08:43:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26779 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 04/05/17 02:59, Андрей Воронов wrote: > Hello, > > I have the bug in expr utility when it perform operation of the > calculating length of the string in my multi-byte encoding ru_RU.UTF-8. > When I run: "expr length Привет" > it return me the number 12. > But in the russian word "Hello" the length is 2 times shorter: exactly 6 > characters. > May you register and fix this problem? expr is listed in the plan here: http://www.pixelbeat.org/docs/coreutils_i18n/ thanks Pádraig From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 03:05:08 2017 Received: (at 26779) by debbugs.gnu.org; 9 May 2017 07:05:08 +0000 Received: from localhost ([127.0.0.1]:60554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7zCl-0007Vi-R3 for submit@debbugs.gnu.org; Tue, 09 May 2017 03:05:08 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:34594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7zCi-0007VB-FX for 26779@debbugs.gnu.org; Tue, 09 May 2017 03:05:04 -0400 Received: by mail-qt0-f195.google.com with SMTP id l39so12598603qtb.1 for <26779@debbugs.gnu.org>; Tue, 09 May 2017 00:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=+5I49SVw/kNvRqCheHteRbUh2y5ox3F/ci4GJbzzfJw=; b=EbmbH4jVdckTlOqLv1Rs+WX9L9NXHbHryojXE4lohG3gxCJ9o+RXoXhnmjqUfidwmr wTIGpMD1Px4KB+HZ/T0SmcREy3xZyb74NK4XDfzdEBj7+2+V0FbT13W7v50w+kicvwp4 4+U2gQ7IpC+awMzndOXPdXI3gf3dsp+x+HMriaIO6xUCKwgl4Ci+QtEot1QwswtZvFDS 4lZZRj2w9iKMdvtovR6tHMxytbJLrPJoCN2vdhme1w2/bnWqd4R3Zt0vIp1qR341O1Ug xGNrCA97dsY86cRgY0qUF8DpHraFA27TvrQCGIMgwcmXWMwktEDbTt+s2dRXBkwLRyKe rK/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=+5I49SVw/kNvRqCheHteRbUh2y5ox3F/ci4GJbzzfJw=; b=aFf0moucWFqepD7vs3v18nQcSkuJK6URQeudhgyQj7yXG3QaA2DebPn7KjFgkv2l66 qZ4bI68Lzt0ailu8iLelqLdBKZw9phCLkTJNyV85t/wmBCGuBYFID+YToeYytnk5ZyBV zT+u9kMmz5yLW3ypf6+RrKMWVW0wRqlCmFZU9b5bscsnP+fTxUarcNiM0gujoENxtwkG VyCItEeFFp1ktOxFAzCXa21cw47CzrNqX0gvJ0TYu9huBWRv4zmSa+v37mrsRLqcO9gv eWpqI4t1sQv8xAqrHdNq6gVzDwROekeZul/znB/5KkTvGKUfYIvJFim5VfaCMcG8a9+l S2gA== X-Gm-Message-State: AN3rC/47AgKD/WTMBnAQyeeWACL1Fh8HshfppoRMrgxDVfd4T+MVOIjP ABB0pJBqCgrWRw== X-Received: by 10.237.53.205 with SMTP id d13mr32146151qte.149.1494313499006; Tue, 09 May 2017 00:04:59 -0700 (PDT) Received: from ix.home (pool-100-37-92-116.nycmny.fios.verizon.net. [100.37.92.116]) by smtp.gmail.com with ESMTPSA id x31sm2612561qtx.12.2017.05.09.00.04.57 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 May 2017 00:04:57 -0700 (PDT) Content-Type: multipart/mixed; boundary="Apple-Mail=_681762F9-660D-4B0B-85B1-19CCFD77EE8E" Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#26779: expr length From: Assaf Gordon In-Reply-To: Date: Tue, 9 May 2017 03:04:56 -0400 Message-Id: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> References: To: =?utf-8?Q?P=C3=A1draig_Brady?= X-Mailer: Apple Mail (2.2102) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26779 Cc: 26779@debbugs.gnu.org, =?utf-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --Apple-Mail=_681762F9-660D-4B0B-85B1-19CCFD77EE8E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hello, > On May 4, 2017, at 11:43, P=C3=A1draig Brady wrote: >=20 > On 04/05/17 02:59, =D0=90=D0=BD=D0=B4=D1=80=D0=B5=D0=B9 =D0=92=D0=BE=D1=80= =D0=BE=D0=BD=D0=BE=D0=B2 wrote: >> I have the bug in expr utility when it perform operation of the=20 >> calculating length of the string in my multi-byte encoding = ru_RU.UTF-8. >=20 > expr is listed in the plan here: > http://www.pixelbeat.org/docs/coreutils_i18n/ Attached a draft patch implementing multibyte support for 'expr' (it doesn't need any code from my previous multibyte stuff, so I'm = sending it separately). Specifically, the length/index/substr operators are adjusted. The regex engine for the 'match' operator already supported multibyte = characters (only minor adjustment needed to return matched character = count instead of matched byte count). The string comparison already used 'strcoll' so I assumed they work with = multibyte strings. Comments welcomed, - assaf --Apple-Mail=_681762F9-660D-4B0B-85B1-19CCFD77EE8E Content-Disposition: attachment; filename=0001-expr-add-multibyte-support.patch.gz Content-Type: application/x-gzip; name="0001-expr-add-multibyte-support.patch.gz" Content-Transfer-Encoding: base64 H4sICMxnEVkAAzAwMDEtZXhwci1hZGQtbXVsdGlieXRlLXN1cHBvcnQucGF0Y2gArTzpcttIc7/D p5ilXR9JEzzAm/JKn2mZslWfDkek9ojlsEBwSCIGASwOSlpbqUpSlSfIi+RnUnmG3WfIm6R7ZgAM QJAUd8PdFcGZ6Z7unp6+ZrBnrr0ic7091zrNnqo22x29q7bq9b6qTru9znSmtzstOpvpdbXXJJe2 RUbUIWqX1OtH7F/SqNfV3BmgOSIDz9Pm5L3tzmDc9xr+WrAfbxYrzTCrur06yb3TfHpExgFVSJ9c ao+AANE1j1rNo3aHlOvwyY2C6T9R3T8inz4OxqcfPhP64LhHRJvNyCowfWP66FPiBY5ju34u94pM bdv3fFdzYA5rDpTAwIUVmMaUrOxZYFKPrKaeSS0FvvSlWwUYz9VriLaqkyK0Tkx7YeiaOfGCKaAq HZErek/mgaX7BrDj28SlfuBaRCN8hGEtclPNozMC3QKY6EvN1XSfusSxPQMhPVI0LM+nGoybEyTc K1VziRl1z7FgvpGxMkzNxakAPTbWkFr4Vsg08MX8HrGC1RQmsOe5jVk9kpoLvuce9cWE/MfEtycI 4W3nMZoiZCwnTTE3fB+Yh6lAFgtjTa3UVDNbt00bWbqhuEJkpfn6EgS1n14PwOlaMzsAfGa7BJZs 4S9rXOI1w5rRB2I71NWYaBUSeDQDay6NFf4SGGIi2f6SEm1qrymxJOY9VAkY6Xu1leEJzXBMxgLV fALAvJvcG/6SWLZVOYWZASlFuc2oD/pKNOsx59KFSz1vC85KpL8MO8pfQhsrt2E5gR/Ds5mqqy9c tS0BBUth0mquUqnkUluAJD/f4L8GKedkpd/8fION3SflnZ8KmyxJVMZkKk62i3UY1Wh09kyW+Gzg QyyJWRt1wge2mWA81AhrQWcKaal11DTqsqUulksKUXuwaCblDZVSjugurDNFe0GJWq93Wq2dDORy M2M+J5XKwoB1r6XEP0015LjqNus67TTUarU1m3a7WlNMhCu4gSMHrGziefOGVNR2WwHR4VePQAO3 dBNh6Y7zORDHaurC3hFPvn2v80dPM42FlSuzZzCE4ika6t0bM3/JnulKB+umr5zwF4xOsCzp0lT6 EbLaavXmeq9a7WqNXl1Vk6xKwzmbUgOy2Owih/AXGcyRF4almwEsTH5m0OoyL7dQ17XdVBtYn0XF dvjGhq5y3LWaBgbYiFQrt+cpLNAIhhAkkGp/gA7fNlkrX5B+gy1Iv6WobRWXxPPBQum4KU2wFSsb dMtdgCtY28as9DqX7A/AthR/GFzcDsmrtdSLg4kDhPnrZH+unCvXXuHakTOQNjNpc8MFg2DreuC6 1NLRgrD22CNxHslofHN+9R5NI1iruJth2wYzOD0dfhxXcV4YdWo7BljzOcYOXPcKzL9yV8UMmX8P NhGUhTJavCMGp1bBmnIfpla46wy9JJLDOZjbAXAUUaAQ8AK/UtcmxhwkKfqrDF8jxAeIwGcEwLPH 6N/0xkwnFXJ1PU76Ks7Q8EFbOWZIJtsHCedcLCypadoFpaAVSoQcn5D63pFLMVLdO9KmMPRZI+EP G9kUdJ9b5HZ8VumRu4fT4d3DWxUFAPEJLJkpr2IRPBL9Aj7MWWql7UyGWKY6zBX+2EdbAkiP6HtV y5WFGnvGr3Ti58ppWFIEiwYrjnSSVxOuagqRGzVdp45fypW/4vwcETFmD+SY1F9zIYBaFPmwT/XP 5PiYFO7qhRInV0Qz4dDaK/KeWhA8gGaA9lUJQSo5isu3k9Pbm8nl4CcC3Ar4r4JrgkZjgmZD820X SYBHgRQ/c9DRIh9jgWksGkxxBUel1xxcW0MMzPuiptlaw63KG0shOmli/JTLwPFruQUJXk0nYLXF tLDpQyQoArUkj06hixGgAwiFp5BXJEQ1cfwIXSkNGkk1TRQhT/JPanp0DxVpqWopsYaftHg1Ll+h HK83KQxxC5FrXOY7xoXroKUXIimwCf0lAOWRZM4BFJJehQwUzxPcU8w+qGtk8ISmSljqAgeDjYX9 VYLmdqDCDB4PVRVpXthnawiIBD4woZJhxJA2NNEi6M6ywhJVfNeKHerB/hQpDClGGzu9XoKRcMAn 7zP5Kyl6ZbVEjki9FPP3xP0dmGkfDRoz8VEOhp5jpHBntGH3GYrIx3y8HoHPm5GL4ZWULHBfwp3P ZvqGFlXlQ2Rwl4JrQyltJh8KE5ANz74XOphbBzDRBwO2GUjXI+vKiYfQyAkG8yL8YGPHiTayMhZL n0wpoSvHf0T5Ax01pEFz0cmD4zPQH0oGF2l5lbS3XFxJiwuUivUCZqNnMCqhveXD1mAa1qaxEhsz sdBTNEFsrZkt8sCwwTpxhWOZm9CQBJDJgSSTewJL/lcRhyIWWH/EzJCFApbwhTabIfoeqSffvrEv sH11fGYzJJ9H5/8wxLmSrgFDuVngkGI+X4q9hJSfwiLptvMo+BAcrDkHl+dXQASFmIdRUmEklMH6 Sq4pZvL4eMOtwFQjaY+iU5K21BqmeFhB4mnrEDjiDAK36IY1gREQmTs6EFiEdcLZkYYKURVGZGm/ kbiMUs5oeqn37Pyny+ER6ClsA/j3XoO8eh6YVTKyVxTntl3MrC1UUE9bMysCAgssrBBIxmZp35MV xps8HUe9Z0UB1HBJ2hi+Oo+yXRFcJmTB1Q6EQUqSt9jio3lnHDocq1Fjttv2Up5iw3mTv/yFCfek njUw4dIV7ry3eXZc/y+GQ1BcJrmnoJWavuT2zddcVmWJDFEsE/ygbgHm76E75WtgrwFgQFOOFOY6 RUW2LTkyTCKtVJCvBFdpLWMNSlaogI3ZIYks0CdJIV8J5BixsSFiU65fxzafB/jcUKaLUjEfoFJF kIRnTM3HuIjCBeMvsXzDbGWUAoWJDrf612ejlL0WCQEOYwE2j5nzdw/Dxt1D/93dw6Cbx/2Qvy03 up0uubkeD8bDd+Ts4vpmcEE+DAc3Y/L29uJiOM5Xw1CdLysjYEpN+17BFqALabMtIByTJqmIhWBg moSb4KS2xAYqopcQk98vDVAatnUM6GqKIeiqCg+FKN5nsTvbmlgAFH6+mODp4fHXvEJaLIZvbI3h U1XEbU7FnnuhI9m6NcVQ/Zhvpa0b8rAIOtpjnDBQUUxFYZ4ZavKm5oK99CIVxY01Oznm1IdaO4WN +SUaUi7rsl0VWquHWgv/sNQ9RwJPWyBtls9S+gBQAnFYMWi1+lgxaPc7vITj20Iz4jw/J/YL/suR si1MXWD3B9QKsLqAmS5gT7DsF/KZcLe4AaoUBEkQcnmwJHMNbD+2zEGCgStSH5KoQzC62t2W0iXl bqOpqE0kTNRyI7o8cDPi0QlpFJaCBwITnokXPYhxgip6JJdOXLrwqsykfVI/YwUjNgfigTmniowL eAtxMVchubMsQwobLK6e8mjXU6IgN3I4WK4Xqn8cGxRelk/F7GF8Fo0KEUixY8qAJuIcIxnkoP/H KEfwkpmNSJ8jkrnXhFgVkiWTDcEZSdMbf6G4eVIj0GCIVFHFgnId7bTrqAu9ehu+oIHV5UmR1azw OdDQxAoAMYcL84tx0ZBouWMlx2yskklxGEq6jE3JdaRVQgSL8TgxydyldM1nCGmKvIrgnzHX7ShY L+41VUXt7WHv2XyZe5hlMWqcGpliLQUT22TCh30CYMyQRJAp50gh4s0Ky8YM2dLEKCItQfMgmco6 ZdEH2OrAeZ6nHflSpCaCQSkTiFCau0RsqDt7G89fHkGBmcxczFA+JMIJjHzn25qL5cyiAXsXcgmp oVGSrF/K9rFkgmlZv4faVe61VWW/kkmS4eu5gJAEfuP0SJ8hW04iJWyJoY1oaGxP/1S+JGHJ5lQa kDTjiTVPkb0/h0rBiWyUZaKprkR2gPjBWLNKeXpc5cR/dChnATQiawD6rOy8Kz02nX+JrWaGfi+d iaXgk9FvovNp06eI6Cq1ycO0PtzmLJHPdAqyZ850wFt3vYG8Jw5+Uqd/01SDOACaz+ZNOptXq7Qz 6/dn8+QBUAqEHwKlGnEHNXosUMIv5oRgWSb8wPT47/Bzh9TK53TWuoIHKlVvmdX74EBYXHXMTFB+ psi7yhtdidO/DPA5hAS2uwU376w4EDiAnm+hjkVpFR4phiMyBL/lQHW6szvHDrsNM3HAKVaqzj/V ande76vNKVui2oyuayjJxNpsQY4rVVfAnaoKnuq+eZMrv/iuFnhubWpYNYe6gOUFZFUQvBrgJBBB 5oE3xrkvWJ7qsrJX8bTE74ecgS6SkT337zFbOsPqI7sCoEDcp1c52BiLFI5rL1xthckZ6i/xBMwR ebQDVqlw6czA7T8NcFY8s5/VIO8AsRjzR8QDbYAey3sQ/UGUt/Iw+MMf769uoxOEj8HUhMj5wtCp BSxpMDW2eEtWA0E8CLGdbmpg9kcgOsWrApC1iTkEQjz3QiRFSF6Bcog/2WlmiR3amZofg27hPmZy Fma7SxtsH0uHgcV7wzSxahN4WNBREAVeMvnxfPzh+nZMBlc/kx8HNzeDq/HPr9la2dBL8bIHojIg PcYzQGDL1Sz/EW+jAIbL4c3pBwAZvD2/OB//jFXjs/Px1XA0ImfXN2RAPkJifH56ezG4IR9vbz5e j4aQiowokkURwQ4Jz9kigRRn1IcsxhN8/wzL6gFx5owstTWWUHRqYCFK44W7vUuHSDQ8MBYnl5Ic gbZzVu/Gsi0l3y993zmq1e7v76sLK6ja7qJmciRe7YTRg/dRUO66z8ovxdUjeXk5BPv7sg5Z9T8T 71v1Ve3bN9aJfeACDF+4evFcROONfbfnV2NwwJPrs4vrHxEFH1A5+ZroeYpnEmRPLG1Fs+YMx6DX wT1YiOngN1kAZnj1w9eL69PBxXBydjO5HZ/1cILvQOpzA08JwqEQKYSP9BdSsGyLFtBqYtnhNMCy 1tGRh8Wt/MuogsjurLj0l8DAis3ZTQXRi2Ttzsq/5tnzsWPPcuX//Z//+O2/f//33//lt//8/d9+ +6/f/xVCuy/O0tU8w8OMPY8M8Hs2eVTwgaUbFBLt93jUCWtxrKM5Qd7igcBf/u7hq3qmtp7gu/l2 wL5OO/xL5Y3867TJf/X5r8ZTSN6LF3iMPMQ7RLAjuC8S+eYR6x2zpqiAx7SqsJoW+JZjSvoVpHx8 kr84nQwuLo6FHPNPDFybzUDMPPlcES3w7RXm6OA3HoFt4ARMpseKRpHxrGhoXqrbZ/dgdjYxq0Gh djBzy3a8MAQM2A0sYfuiy024nqGt8NkVmRkaO+lsyRMT4wpTS5vizRssTEBkra2RhtMaW2cmKja0 iHuZwkrCRLq9Aq9oePwOAKwV1XEKwWepKjT0DefrGFWsyIKbF4BIHArEK+xhsyjivQBOLcPHOw5U /8KaPsE6VEy1oJCCANWmOmg2NECkCnYPFqWTf/qsiNGe/8zRYsJBePYe+zX5DgIT/5QuDMsSJ1dx TVBgkE/y+dk+yip/W66DYpL3N8Ph38joErSGXAzH4yHY1IuPHwZ5ibsGkJcX9MaH80B2fgeTzwLq HszrypjNTLqL0VYWo60sRt8NL8YJRpsSzbAwIcLdjD4L6HBGqTXL4JLT2ZKmnNOZPg0FvIvOZwGl 6RSngfIdWTC2lk4latqJlX6rapomo2yl6Hje8JACrEjihjapT1NUsDtJmr9XWh15gTQN2d5F3/OG /z/S15UmlFyLPGkvReMzQNRoKUNiwbrx6Pww42Ywc8UhubUi86lssBpJ4p47Xkw6opqrL9lWDe8Z VdjRiUQBsyUcY2xK4o1Gpvkd5BwE3JSAcebmHuBdluEw4N42qWTYiKoYJY6AQs+qcP3ioKJChTFS 7GPxPCg6l2IopIt+cx4fFJHCkihNe4mbgAAYajH39vItAy6w1h6ew8cdO/AP4VAT4jvPNFvyJUaZ fkUWUXTZjbErs9ZOknUwW4fCH8pSYuH38vQi63wjPEAU6Q8EaJbNNUHhKXb4xgDGcOweqSeQ4VUe hTVjfmtYGh4YslARL6lUdFYigNwTMiHwcZCmnf9UkoXb2bvmSeHU808KBL0/ncMPNSnnQ1ElA67h bEEreHHhaIvzYyJ/ez3+kKVKAgnKIWtVjrgUhXjneNNW4/KVZdHNZiBJPMlwSZGdF1W8wwy9xwy3 ABWWu0GasumGxqRSHwIjzcRssoDKXCOVJMKSKFRJTv5H0GzQ0tyHpEkaMpKoK0XMoXim+gYprX0o WpliSVNyKJpNQtr7MTSyCKEpSg7Fo2euUGcflk6Sn3mKikPhY5FKRHT3IekmkWy1Twdjos/0A55E bW/LHEIRmymhb67cIQh4+4YRYnbtQBu0YvaEQwpzou0KNg8aj/gbG+Pzd0VtelfKy1DaNDXNYWCC RbxR49IFRtwWZOiRW+V40DkUqoXkbZytwR6nntkYDp6pOVUwKkpWLIs8HAS86V8lpmyH3SGL0nBY 4bVhB7wcd8Rf1bCxZsT5ZVeR2MRS0BmHouwa1cbFYpnt1j7K95AeieAwRMlU75KBsZBm4dqBg9F1 JQ6tgOGQXze+YRZzKbHT3kNF4e6uWJ3e3ZX0QkxMNDK1qn8I2bbF3WFcWKUQdVkwiVeS+bTGZhwp 0BVZnBfWZ1fU8kuSGDpJyjepBqJ30RyJ4EBEso8RhJ5G1Rfd1DyPekdRvSlxmZVnWIk9zYqbng8R nxdrt0sT782kdzWVi3fw+4uUkIXX+jjkrpk9Sr3UNkq8aiUQMo4If62mwO/wibdwKjxO9bNyPSux Abs7lYwJ+VPY8XlT2puh25/FGO/MUlhEJwPHoSygtui9iQICyyrqLuwSbFQJLgCeQpy7YkUfD1fm Nr8s+9InRV4cZtoqroXhKM1d4K2Rl37l5JP6+XXcQcVzhIICipd+dP9Lulr2klZOkJEnUsWzAysv n6sbc3wPAMHxBOTDYPSBrxjkUFirjmCjw3h2rv8USuDMxqt86c3IXqsOXzbGyjoOlQ8cYNWHNzeT 0e3b0fiIn/wBAfgSpDiM4C83F6lao40abdZoqySkKYatwMNrC1alj6oRiGjJy/XCuv8S2IlKZ3Ew Oj0/J/WHRhdzwRfx22dyPSM1Azs5CCA9QwBSuBiejcno/Or9xZD8/S1emj2/viKXg5u/FQgp3pYb dbVXgofxWe8IZho24E+vDn/6vRLHcHP+/sNWFBxDPxtDn2EY2fyetWPCxuYlFOYkNE83jCTrmniz MjxyQV4QRRwQRDrKuY50FC/bhIdjoNmF00JKN9+A0qeUkOl1QpVTqggDii99PNorgVa/YZtA0kTR hwd+tX9cTWuJ24ypV6+cwFsiBoUU8SQKr/tunEUpSRDp8zVSPwbo1e4eaOMOpAwmoN+D//qfa4Xa Iv+UvIXylLULkGt8b2Di05XjheeP74Zvb98/iQPLNXWnthedTf4wvHl7PRo+RUeXeKUVOt3AEhdD iolzUIUfeSrkjotWkSdUIvRIK9Y+OL7MCy+JF883LkTgNQhxnaIza6sqrVb1+qwz7+p42aLbbicu viTAMi9YhNcqGi12/6WlqHW8/5JxhIthHkYw9nzOt6Lxqxa+U0sfqB74eCZX8AiYD/Y/FSBvUJC/ 3BcvBlfvbwfvhwQfCNeA0hNeW0WVJQ+kyV42xjnxbv/zz4jj0XhMHP/aOClO4IVJcVUZj1MDWWSf Qr/X7TV6/W4DHhrNFvxt4mO/AQ8tFIAAmDgqg9kJ0JYBvIDdwFL73Xan3e232v1uq9Xpw98OPLZ7 bXjoF16Ll7xV/pJ3W2k0cCmyPFCk6/yPMAUxk5vW4AV5FzimoeP/e4C//YGH5GuK94UUojEviVY5 X1lN82H6wcaw7Q5CDPGI/8EBjN3Y1BEB+aco8LCdR4V4Nr8Qck9DLKBca2OG/bAz8Po6VrURgF0o sSv8eJp5LfHWEhYLHc1fiqDoT9g3BJv4G9aNgQJYeK/BWxpzXwxOvOXC7Rq0K+RTPgZBySlivLJT OJ+TrjrEKAxHxNVTqKWbpms0+GE4GQ8vP46ehJ5ttV8ELALJNapqvdrI5f4PqcWVDIpHAAA= --Apple-Mail=_681762F9-660D-4B0B-85B1-19CCFD77EE8E-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 03:26:21 2017 Received: (at 26779) by debbugs.gnu.org; 9 May 2017 07:26:21 +0000 Received: from localhost ([127.0.0.1]:60566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7zXI-000800-V7 for submit@debbugs.gnu.org; Tue, 09 May 2017 03:26:21 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:36365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7zXI-0007zn-0O for 26779@debbugs.gnu.org; Tue, 09 May 2017 03:26:20 -0400 Received: by mail-qk0-f196.google.com with SMTP id y128so13384293qka.3 for <26779@debbugs.gnu.org>; Tue, 09 May 2017 00:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=3gx/fzdlSdwmB2yGGjRoKurD037uPm2fAFu+4iHi++Y=; b=YBt88FvpHmv+9aWmuuTxgQlHcvfcu0TnOe7JSli6ao95k5iXDRNr4QkGN5G+3q4jYP kNyIHEjUPtT3Gaof5mlsROd5mRJ2sdr12/7rHgxR61fPF388ZVKBoW55ma4ergoWgfh2 0iXDmfAbSE82K9TQKIK4uQ/gfR+GUudjEKhJjcDvVSOlMTcNlh+FFoZWN2qeCEtdcN5x gsVTQ+g6NcqptDcOztX7p3XwcEC8gc7fc98hkNKea3X1ubKpTSwUJAtexoEy+YAL1mtb Qaf111dmshw8VfQB76tLVjiawaJNLdrh9va0ZMqVUguvetEZ7WTCZFLeiJ5IN5ylLSwn TmdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=3gx/fzdlSdwmB2yGGjRoKurD037uPm2fAFu+4iHi++Y=; b=Rs480NXN543H8l1xgPJw42bBZasc55N5hUiDaSjg42pTcOwGba5rV7IDdwCXNSitbB uJIMfxzaQiOX6Rf6Dr0ktC2lV3alOm0sNwoJb+YFMCsPz+rpw3SNq1z022ci3RSE9KEQ GKEPkKaIKjL+56Nkuf4u/PJu0kUZW8w2f/UudfH96/Z/11jmaECGzGXK/V25jBnN8cZP PqdX3Wro3NqeA1gAD5mCD/Oxhi0WV0/7qe75xnYlvtXa0NZSsQM++WHV3aCXiIABPjCg c+rF0vn1Y7RaSQ5kgQFWNjdeQ1ZgdX0qKDPz5GEPP0SxUyJrNOB6qX7x4bRaIuOkWXxT I/mg== X-Gm-Message-State: AN3rC/7JH6MLrzLud3HmThu0io+hlCNhAT20Tb8KW4XtvUjb06y7eo/L 4664NrndSHh2Qg== X-Received: by 10.55.204.16 with SMTP id r16mr30725171qki.169.1494314774436; Tue, 09 May 2017 00:26:14 -0700 (PDT) Received: from ix.home (pool-100-37-92-116.nycmny.fios.verizon.net. [100.37.92.116]) by smtp.gmail.com with ESMTPSA id p184sm11204014qkb.17.2017.05.09.00.26.13 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 May 2017 00:26:13 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#26779: expr length From: Assaf Gordon In-Reply-To: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> Date: Tue, 9 May 2017 03:26:12 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> To: =?utf-8?Q?P=C3=A1draig_Brady?= X-Mailer: Apple Mail (2.2102) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26779 Cc: 26779@debbugs.gnu.org, =?utf-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > On May 9, 2017, at 03:04, Assaf Gordon wrote: >=20 > Attached a draft patch implementing multibyte support for 'expr' > (it doesn't need any code from my previous multibyte stuff, so I'm = sending it separately). > [...] >=20 > <0001-expr-add-multibyte-support.patch.gz> Re-reading the patch, I see there's a memory leak when = 'mbs_logical_substr' is called. I'll send updated version soon (if you have more comments, please send). From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 08:31:08 2017 Received: (at 26779) by debbugs.gnu.org; 9 May 2017 12:31:08 +0000 Received: from localhost ([127.0.0.1]:60727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d84IG-00005e-27 for submit@debbugs.gnu.org; Tue, 09 May 2017 08:31:08 -0400 Received: from mail.magicbluesmoke.com ([82.195.144.49]:41088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d84ID-00005T-Vs for 26779@debbugs.gnu.org; Tue, 09 May 2017 08:31:06 -0400 Received: from localhost.localdomain (unknown [109.77.106.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id 747AF949C; Tue, 9 May 2017 13:31:04 +0100 (IST) Subject: Re: bug#26779: expr length To: Assaf Gordon References: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: Date: Tue, 9 May 2017 05:31:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26779 Cc: 26779@debbugs.gnu.org, =?UTF-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 09/05/17 00:04, Assaf Gordon wrote: > Hello, > >> On May 4, 2017, at 11:43, Pádraig Brady wrote: >> >> On 04/05/17 02:59, Андрей Воронов wrote: >>> I have the bug in expr utility when it perform operation of the >>> calculating length of the string in my multi-byte encoding ru_RU.UTF-8. >> >> expr is listed in the plan here: >> http://www.pixelbeat.org/docs/coreutils_i18n/ > > Attached a draft patch implementing multibyte support for 'expr' > (it doesn't need any code from my previous multibyte stuff, so I'm sending it separately). > > Specifically, the length/index/substr operators are adjusted. > The regex engine for the 'match' operator already supported multibyte characters (only minor adjustment needed to return matched character count instead of matched byte count). > The string comparison already used 'strcoll' so I assumed they work with multibyte strings. Definitely needs a NEWS entry and mention of this bug in the commit message. Perf isn't a huge concern for expr use cases, so I'd rather not address in this patch if at all, but for future reference it might be nice to pass in to mbschr() etc. whether the current locale is UTF8. Maybe some global similar to MB_CUR_MAX. Then mbschr() could be optimized in the UTF8 case as per pseudo code at: http://www.pixelbeat.org/docs/utf8_programming.html s/sequnce/sequence/ I notice expr isn't handled in the rhat/suse i18n patch, so there is nothing to consider there. Excellent work on the tests. I've updated status in http://www.pixelbeat.org/docs/coreutils_i18n/ as this is ready to land I think. thanks! Pádraig From debbugs-submit-bounces@debbugs.gnu.org Wed May 10 21:24:44 2017 Received: (at 26779) by debbugs.gnu.org; 11 May 2017 01:24:44 +0000 Received: from localhost ([127.0.0.1]:37362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8cqR-0003Xm-Qn for submit@debbugs.gnu.org; Wed, 10 May 2017 21:24:43 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8cqQ-0003XY-9I for 26779@debbugs.gnu.org; Wed, 10 May 2017 21:24:42 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1DD7F160076; Wed, 10 May 2017 18:24:35 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id WVfE9hnFCkr4; Wed, 10 May 2017 18:24:34 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5F5B61600C3; Wed, 10 May 2017 18:24:34 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Cstu0GGgTvSZ; Wed, 10 May 2017 18:24:34 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 3A439160076; Wed, 10 May 2017 18:24:34 -0700 (PDT) Subject: Re: bug#26779: expr length To: Assaf Gordon , =?UTF-8?Q?P=c3=a1draig_Brady?= References: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <7e7d15ef-a48b-5bfe-e9a4-32dc2235c2bb@cs.ucla.edu> Date: Wed, 10 May 2017 18:24:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26779 Cc: 26779@debbugs.gnu.org, =?UTF-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) A couple of things. First, since performance doesn't matter here, wouldn't it be simpler to convert to wide character form by using mbstowcs, do the work in wide-character form, and then convert back via wcstombs? The resulting code should be easier to maintain, I'd think. Also, please stick to GNU style for operator spacing and parenthesization. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 00:10:08 2017 Received: (at 26779) by debbugs.gnu.org; 19 May 2017 04:10:09 +0000 Received: from localhost ([127.0.0.1]:54196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBZEu-0001er-IC for submit@debbugs.gnu.org; Fri, 19 May 2017 00:10:08 -0400 Received: from mail-qt0-f174.google.com ([209.85.216.174]:34161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBZEs-0001eG-Br for 26779@debbugs.gnu.org; Fri, 19 May 2017 00:10:07 -0400 Received: by mail-qt0-f174.google.com with SMTP id c13so49918335qtc.1 for <26779@debbugs.gnu.org>; Thu, 18 May 2017 21:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=onePKL5gesr7742AL2Rn6fenlIZbdQMRpLrk2ovvtts=; b=U5PqhVecLjacoTAvlmGQ+C1rl8dRHEC4MQmhs9uX4ejnggNbamsGJtyPtQfHN4dnhr HRqoVK/wuw1/hH4+94hO1Nd6lRwKTunw4CcvCoiKqzkckj/Or6Le37mLVZgjSw9FguWv 0YPPCAlvc+TR7QdkQ4/3KmAHDR35ss48mjBvMZ/dIMub0R1yzde+pIUnubYtKvbWav9y ycFCTwUSnct7jiKvPWPeJEZyhr0tTiE4vQg49dx0dK9IyHGJeMSVPPBo4s/fnbQLV8jn h5wmaQeRqSwaxrVIsyZzcBu4YOWG02aOmePEG4prs01Nuzjg7+PB6+EFn3XdGXN5syrF LxPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=onePKL5gesr7742AL2Rn6fenlIZbdQMRpLrk2ovvtts=; b=O7PVneq61t/4EwrEL7ET2DnMscOfijYFvyfHRIcFiTE6pLqBHshkEXaQiFvSSy4YdU xA8TYwQChU1IvydGGqzPwW4nrmkhKOgrSdTnG+Haxw4L9n3wWTNfwRvwxVb6AVmh4Sa2 rGCqtAF1BHWd4xYfd3bKC4iAX4dDgmtfatpuaxnn0pY5v0zm8inmq3Aik8YjB3lq6B/T BFztiWFLF6Yznx491GSfSwPp0qycaz7mL2DmubsEhe3zXbckMuaPjKSADpXW0jSo7uwV 8G9LUNQ9zs6yT5ocxYJjnm8W1lLYQ4f1OjhOVFfLUBvKo4hi8fYp6qtd9GOfVmR4GRx3 SXRQ== X-Gm-Message-State: AODbwcDrwwKAwvX5WWXYU7HFn08ItqKC8LJzORPRu6MfIt8FoalxtZ60 PqA1vDp7KQ652g== X-Received: by 10.200.54.228 with SMTP id b33mr6790313qtc.228.1495167000708; Thu, 18 May 2017 21:10:00 -0700 (PDT) Received: from ix.home (pool-100-37-92-116.nycmny.fios.verizon.net. [100.37.92.116]) by smtp.gmail.com with ESMTPSA id z53sm5239810qth.43.2017.05.18.21.09.59 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 May 2017 21:09:59 -0700 (PDT) Content-Type: multipart/mixed; boundary="Apple-Mail=_8C41C755-6037-4557-9435-0416A566D310" Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#26779: expr length From: Assaf Gordon In-Reply-To: <7e7d15ef-a48b-5bfe-e9a4-32dc2235c2bb@cs.ucla.edu> Date: Fri, 19 May 2017 00:09:58 -0400 Message-Id: <7115F2F1-4855-489C-AC3E-80787F63C30C@gmail.com> References: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> <7e7d15ef-a48b-5bfe-e9a4-32dc2235c2bb@cs.ucla.edu> To: Paul Eggert , =?utf-8?Q?P=C3=A1draig_Brady?= X-Mailer: Apple Mail (2.2102) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26779 Cc: 26779@debbugs.gnu.org, =?utf-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --Apple-Mail=_8C41C755-6037-4557-9435-0416A566D310 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hello, Attached an updated version of the 'expr/multibyte' patch. > On May 9, 2017, at 08:31, P=C3=A1draig Brady wrote: > Definitely needs a NEWS entry > and mention of this bug in the commit message. I added two NEWS entries: one for the bug fix and one for the new = multibyte support. I could not find an exact version where this bug was 'introduced'. 'expr' never had a notion of multibyte strings, it was gnulib's = "re_match" which gained multibyte support. The earliest gnulib mention of re_match and multibyte I could find is = this: commit 42f97e3f0c576afb94226c8493f3567b44352ca8 Author: Richard Stallman Date: Fri Apr 3 07:33:13 1998 +0000 > On May 10, 2017, at 21:24, Paul Eggert wrote: >=20 > A couple of things. First, since performance doesn't matter here, = wouldn't it be simpler to convert to wide character form by using = mbstowcs, do the work in wide-character form, and then convert back via = wcstombs? The resulting code should be easier to maintain, I'd think. The downside of 'mbstowcs' is that it fails and does not continue when it encounters invalid multibyte sequences, whereas keeping the string as 'char*' and using mbschr (with the additional code) does handle invalid sequences fine (and the tests include such cases). What do you think ? I can work on a different patch with wide-char strings if this is deemed = worthwhile. > Also, please stick to GNU style for operator spacing and = parenthesization. I fixed the one case I spotted - if I missed any, please let me know ("make syntax-check" passes, but there could be others). regards, - assaf --Apple-Mail=_8C41C755-6037-4557-9435-0416A566D310 Content-Disposition: attachment; filename=0001-expr-add-multibyte-support.patch.gz Content-Type: application/x-gzip; name="0001-expr-add-multibyte-support.patch.gz" Content-Transfer-Encoding: base64 H4sICJBvHlkAAzAwMDEtZXhwci1hZGQtbXVsdGlieXRlLXN1cHBvcnQucGF0Y2gArTzbctvIcs/h V8zSrkNSAi/gnfTKa1qmbNXRxRGpvcRyWCA4JHEMAlwMQEnrVaqSVOUL8iN5TCrfsPsN+ZN0zwyA AXgTdw/LlkBguqe7p68zDZ157oJUmq1Kh+pGk9ZrNWNMW7Ri6BVdb0/0qllptJvTRqXRNOvk0nXI gC6J3iKVSpf/I9VKRc+cAZou6TFmTMl715vAuG8N/DbjX97MFoZll0x38TrzzvBpl5x5lkb0Drk0 HgED4qt1651utUaOK/DJDILx36jpd8mnj73h6YfPhD4svS4xJhOyCGzfGj/6lLBguXQ9P5N5ZzEz YIxOiOWQue8vWbdcHgczVpo5Qcn1ZuVqs9XqkFImc0Su+j8MuuSSOr4FZPpzSqzF0nNXdAG3SjBg 7Lo+8z1jCQQ7U2ALJgU8tjUmC3cS2JSRxZjZ1NHglzn3EIZ5ZhlJLJkkD3dHtjuzTMMesWAMqApd ckXvyTRwTDGpSzzqB55DDCJGWM4sMzaQA3gsgYk5NzzD9KlHli6zEJKRvOUwnxowbkpQCKxQyiRm NNnSgfkG1sKyDQ+nAvR4s4zUwm+NjANfzs+IEyzGMIE7zazNykhqLvg9ZdSXE4ovI98dIQTbzmM0 RchYRpliavk+MI8LZ5CZtaJOaqqJa7q2iyzdUFxtsjB8cw6C2k8vA3C6MuwmAJ+5HoElm/nzspB4 2XIm9IG4S+oZXLQaCRjdgDWTxgo/CQyxkWxUH2MMykMchXmGKgEjfVZegGoKzVjanAVq+ASAxWNy b/lz4rhO8RRmBqQU5TahPug+MZzHjEdnHmVsC85iZAscO8pfQRsbiuUsAz+G5zOVFl+EajsSCpbC pqVMsVjMcBsh2z6/wv8GOc6kDGXDqCqOUkxjEy4d7PJ456fISUqSvmEyHSfbJSAYVa0290yW+Kzh QyyJWasVIgY2ufgY6o0zoxON1PUG6iP1uELkjwvg79qwtDYVN4qFDDE90AaKXoUSvVJpNRo7Gchk JtZ0SorFmQXaUeaLNOa/MkKZW2a9Xu1MSiU6pU2zVkekzXod11SOzwCxIcybN6RYq2ggEfjZIfD1 /dUtMV2PBr5ls91KoHyKR0XiBj7YA8XrDNwyGFiG4efQJEE3mAUW5PhCLdFkqnUydwPwTtaCkqnr gU2j9U1KCPwJPDfA+R44W1P49IioYqtU+ZwhmWPCIwKYzv26K1NdQugtVL+JNHkemBiiiaGEcUuA giA2x7/myrluTroKF5CCe1OiEPfeYJ6gBUdHwgnCsgZgt0Ao4YQazoTg/8CRX5BuGb4IW1LTmj6i OzEc6fhQKMQ3xoDdXTKxVB1cqnpVa/9dl4otbdAmSQsDJ4z+oFic04ciC6ZT64GyTydTiO+fQQCh Z5eKK1QeBYWYbPceBGlCFCMAbUyAqwV40hCLRlgck1AJikWQPfUsM5pIzlBSFjgibE3gXEToScV3 xZOHS3Eex3W5FIsVzLqi3tgFInENJqCZABxYbA7Te9QxQCFxgUx3+ZhAmTC9lOcbp25Ic6xVTNqs 6qVSfTJutYxa0hxTIMIwUzdx3fVGAxcef/GVF6nISKYiJ1nO19iD4CavfPfeFJfMsK2Zg7IUmYq8 ioaye2si1m5BF7hw5mIZfoPRCZYVNz5WvoSs1uvtqdkulYxmfVKDLDDBqjJcsKnc4Krd4l6opbWA wQx5AQZqB+ATsxOLluZZ9Q71PNdL3YP0YFYUqsPw0XH8aDEOLPADKQCQMKgeMJu6/wAPfNfmd4Xs O1Uu+05N0xs6Sp/5oBAmhj4bFGgBFmh4oIv5lWtNCq8yyecBaGf++97FbZ8crZSnOJgsQWv9VfI5 KO5x+QiXiZyBYLmZTC0PgrNrmgH4LMfEaM7vx9mhNIDB8Ob86j16Msgc4scc2zaY3ulp/+MQDQZH nbpLC3wlWrtUsxzPdUXaKLz3PeQnoBeU08K6HE4vQWYjnLBeFGlsmLEiOYKDqRugXYUUaATM9xfq ucSagiTl8xLHVw3xASLI3wLgmXH61zNjrn4auboeJvNGwVD/wVgs7ZBMrvKJRJnkc3Nq225Oyxm5 AiEnr0ll/9C5HKrvH+pSGPu8ofCDD61J2s8dcjs8K7bJ3cNp/+7hrY5CgHoBls1WVzIPGSL9Ap5w OTcKOxgN0YxNmCz8spe6BJQZUXhUzhxLZWbWL3QEoXQdGCO/zyklRyOhcBpRbxqmSZd+IXP8FQkQ iIg1eSAnpPJKiAGUIy+Gfap8JicnJHdXyRUEvbK+CIeWj8h76oDHtnkQKhGCVAoUl29Hp7c3o8ve jwTYlfBfJdsEvcQI/QSGdyQBLiVS/GCgyYsxDvjCvMXVV3JUeCXAjRWUuOJZdGuyMtBgxc1CiE6Z GD/Hx8DxK/UOErwYj8BNy2nB9EMkKAK9oI5OoYsRoMcPhaeRIxKiGi39CF0hDRpJNU0UIU/qV2oz uoeKtFSNlFjDT1q8hpCvVI5X6xSGuKXIDSHzHePCdTDSC5EU2Ij+HIDyKDIXABpJr8IGFM8T3FPM Pqhr5PakpipYKhIHh42F/VWBFp6gyN2eKB41ZV6wM0h0wkIfHKniHjEDCx21LIM3+WKFKmG10kIZ 2KfcVCD5yLDT6yUZCQd8Yp/JdyTPjvUC6ZJKIebvSUQ9cNY+ujTu6KNdEYwfA02EpDXvz1FEkebj 9YCnbhf9K6UCEBFFhKD1DRX0qboYooJ7UEDxPHV9O0DjAnLh2mdhmLldAib6YIGZgXQZWRVfszDL xXRasCKmGSbukYU1m/tkTAldLP1HlD/QUUYaDA9DPYQ/C6Oi4nCRlqOkvxXiSnpcnnDz9QJmo2tw KqG/FcNW4BpWtrWQhplY6DG6IL7W3BcxcGywTkLh+F6K1JAEkC2AFJf7Gpb8O5l4IhZYf8TMkYUC VvCFPpsj+hapJ7/+yn+B76vgNZ8heT04/6c+zpUMDZjQTYIlyWezhThKKOUh1jKY6Qs+JAcrwcHl +RUQQSHz4ZQUOQnH4H2V0BQzeXKyFlZgqoFio7wyik1qBVM8QIEEpgvpI84gccvHsCYwAlLxpQkE 5mGdcHakoUh0jRNZ2O8kLqOyKZpeeXp2/uNlvwt6CmYA/+4NqJGngV0iAxfqIJjb9XCvy0EFZcaK exEQWOBg0aQ4mzmUUgvMOkUNjXrPC2fUcEXamMQuH1W/IrlMyEKoHQiDFJRosSVGi4dx6nCiRzc3 h22WihRrwZv85S9cuK8rmwYmQromgve2yI7r/8VaEhSXTe4paKVhig0QMGWP73tGjiiWCX5QtwDz t/A4FWvA1gAwoKlACnOd8pLVUXPDJFIofdHs1FtpLeM3tE2pAt7cnJKoAn1SFPJIIseMjQ+RRrl6 Fft8keYLR5neJo75AJXKgySYNbYf440AIRjcZ5K+MiqEwnJHeP3rs0HKX8uyAIfxFFtkzdm7h371 7qHz7u6h18qiPWRvj6utZovcXA97w/47cnZxfdO7IB/6vZsheXt7cdEfZkthsi6WlRMwprZ7r+Ed oAtpcx0gHEsnZVsZwcA1yTAhSK1LA8pjlJCT388tUBpuOhY8qskhGKpyD7ko4+fJOzdN3JKXcT6f 4Onh8ZesRuo8h69uzeFT+/rbgoo7ZWEg2Wqacqh5Ikxpq0EelkFHNiYIAxXFghTmmaAmr2su+EsW qSga1uT1iaA+1NoxGOaXaMjxsan6Vam1Zqi1uLmEBXyGBMyYIW2Ozwv7AFACcbhvUK/zzbpGR+7Z +K7UjLjaz0h7wX8CKTdh6gG736NWgNcFzHQGNsFrYKhnQmvxAlQpSJIg5WKwJFMDfD/emYIEA0+W PiSxG8HparTqWosct6pVTa8jYfJ0JaKLQZiRl8uQRukpRCIwEvV4nkGOE5QwInl05NEZK3GX9kn/ jPsYsTuQFzw4FVVcwFuIi4cKJZxtcqTn6paryHaZFiW5UcDBAzSp+iepnd10zh7mZ9GoEIGSO6Yc aCLPsZJJDsT/jRVI9PmOhHzuHtclG61QClyLsBSSgSwlUyvpleNfuBKi3pF4MHsq6nKthfo2GxVU k3alwXfkCD9EI3m+qYXXgYHeVwLIOTyYX46LhkSaEOs/FmrFjRSHWabH+VS4S2uLzCPjcXKSqUfp SswQ0hQFHMk/Z67V1PDYpl3TNb29h71n82XvYZanr3HVZMvFlExsk4kY9gmAsXiS+adaPoWI1zdf 1mbYLE1MMNIStA+SqapTDn0ALwCcZ0VFki1EaiIZVIqECKW9S8SWvvNp9fnLIymwk0WNHcqHRDiB kW981/BwvzNvQfECZYZyo1pQHGPKLfI6g2tZp43addxu6Np+JVMkI9ZzBtkKfMfpkT5LdapEqeUS Q6vR0NjV/qlSSsGymVNlQNLDJ9Y8Rfb+8ioFJwtVXqSmHiUKB8QPfpxvpafHFV/7j0sqWACN2DQA w9nmkiw9Nl2aSVOzw5CYLtJS8MnEOPHwaT3cyMQrZeRhxR+aOa/xUzF0PWhvjM1brd5C3hOHQKlD +HHqhjwMmk6mNTqZlkq0Oel0JqnDoBSIOBBK3UQLqrZ5DoW/eBCCZRmJ7oaTf8DPHVKrHpc7qyKe uJTYfNNTfu5aWtobQcXRvnh0vPYocQi/AXwK2YLrbcEtHhaXkFOAnm+hjidwRZFEhiM2CH5LX8N4 5+MM70yx7ESfgVypiviUSm06bU/rFb5E5QldlVGSibXZghxXqqJBONU1bK548yZz/OKbcsC88thy ykvqAZYXUHBBXmtBkOBnupu6UzAFfsFLWI/viOVPC6Ix7Ax0kQzcqX+PhdQZbkzyI1kNUkKzJMCG uH+x9NyZZyywbkP9JUzCdMmjG/BNDI/ica9njQOcFRtsJmUoSUAs1vQR8cA9QI87f5AYQgK4YJgX 4hc8bg8PFz4GYxuS6gvLpA6wZMDUeIfN+fYI4kGI7XRTCwtDAokr9vVAQSfnkAjxYAyR5KGufcQm CXGyWeCnerbhx6BbuI+ZnISF8NwF38crZQu7MGwbN3QChns9GqLAjrAfzocfrm+HpHf1E/mhd3PT uxr+9IqvlQtPKXZmyWY5Gw8JgS3PcPxHbB0DDJf9m9MPANJ7e35xPvwJN5TPzodX/cGAnF3fkB75 CDXz+entRe+GfLy9+Xg96EOVMqBIFkUEOyQ85YsEUpxQHwocJvn+CZaVAXH2hMyNFe6umNTCPSpD nt7vWzpEYuDhcdiYEssRaDvnW+G4o0vJt9hU2C2X7+/vo5ZCWyBh5decHmweQ7mbPt+ZyS8eycvL PvjflxUouP+FsF9LR+Vff+UP8RmEAMuXoV5e59F547Pb86shBODR9dnF9Q+IQgwovv6aePIUzyTJ HvH+hQ1zhmMw6qAN5mI6RNsZwPSvvv96cX3au+iPzm5Gt8OzNk7wDUh9auEBQjgUMoXwkv5Mco7r 0Bx6TdyROA1wx6vbZbjvlX0ZbS7yBjOP/hxYuJlzdlNE9LKOu3Oyr0RhfbJ0J5nj//vf//ztf37/ j9//9bf/+v3ff/vv3/8NUrsvy7lnMIthMZ9FBkRTXBYVvOeYFnYXvcdzUFiLExPdCfIWDwT+sncP X/Uzvf4Ev2tve/zXaVP80sVN8eu0Jr51xLfqU0jeixd4ztzHhj+wCBGLZCna5U+H/Fa0tyc7iMY5 YXJcSb+ClE9eZy9OR72LixMpx+wTBzcmExCzqEsXxAh8d4HlO8SNR2AbOAGXyfh+UuQ8iwa6l9L2 2RnMzifm21OoHdzdcouXjoADe4EjfV/UiYjrGfoKnzf8TNDZKcdOTE6MK0wdY4zdQLhnAZm1sUIa Tst8nbmo+NA82jKFlcROIXcBUdFiokkA1oqaOIXks1CSGvpG8HWCKpbnyc0LQCTPC+IVZnhb7u+9 AE4dy8cmCGp+4bc+wToUbT2nkZwENcYmaDbcgEwV/B4sSjP79FmTo5n/zNFywl54MB/HNbVJgYt/ TGeW48hDrXi7UGJQj/nFwT/KKnt7XAHFJO9v+v2/ksElaA256A+HffCpFx8/9LIKd1UgLyvpjc/t gezsDiafBdQ6mNeFNZnYdBej9U2M1jcx+q5/MUwwWlNohoUJEe5m9FlAhzNKnckGLgWddWXKKZ2Y 41DAu+h8FlCaTnlQqHbJgbPFFh2FnEZiqd/qhmGoOOspQp43PCTB4W2VuK3u0w1kEMPfK66mukKG gXzvou95w/+O9LWUCZXYok7aTtH4DBA9WsuQWHBvIj0/zLtZ3F8JSOGuyHSseqxqkrjnjpeTDqjh mXPRdRkGAX6solDAnYnAGPuS2NLIOLuDnIOAawowzlzbA7zLNRwG3N4mlQ1OoiRHyeOhMLRqQr8E qNyiwiQpDrJ4VhSdWXEUSivgVCQIeaSwILetWaJXEABDLRbhXu1AEAKr7+E5vNxhgX8Ih54Q3/lW vxX6V5V+TRVR1ArH2VVZayTJOpitQ+EPZSmx8Ht5erHp7CM8XJT1zxi7mYUmaKLGDpviMYnjnaZM IsM2H43fxgLXcgxftnDzBpaiyfcIoPiEUgiCHNRp5z8WVOE29655UjiV7JMGWe+P5/BFT8r5UFTJ jKs/mdEiNjV0d0Q/8vZ6+GGTKkkkKIdNq9KV3edCvFPsxTWEfFVZtDYzkCSebAhJkZ+X23iHOXrG HbcElZ67Smqq64abSaU+BEaZiftkCbVxjXSSyEuiXCU5+R9Bs0ZLbR+SGqmqSKJHKWIOxTM210ip 70NR3yiWNCWHolknpLEfQ3UTITRFyaF4zI0r1NyHpZnkZ5qi4lD4WKQKEa19SFpJJFv908GY6DPj AFOobW+ZQypiLSX09ZU7BIG4v+aEuF870ActuD8RkNKdGLuSzYPGI/7q2vjsXd4Y3xWyKpQxTk1z GJhkEbttPDrDjNuZ4btR0u8LPBgccqVcslNna7InqOc+RoBv1JwSOBVtUy6LPBwEvB5fFabcJe8v i+pwWOGV5QZiP64rXuZwcdNI8MvblPjEStIZp6K8xWqt6Vhlu76P8j2kRyI4DFGy1LvkYDylmXlu sMTsuhinVsBwyK8Xd5/FXCrsNPZQkbu7y5fGd3cFMxcTE41MreofQrZtcXc4F75ViLosmcR2ZTGt tZ5HSnR5nueFG7T4wlxBEUMzSfk61UD0LpojERyISI0xktDTaPvFtA3GKOtGG06JRldRYSVsmu9u Mh8yPhZrt0cTb9WkrZqqu3fw/YtSkIUtfwJy18yMUpYyo8TLWBIh50i+cpMT/X3yFZ2iyFP9TbWe kzDA1k4l40L+FD74vC7t9dTtz2KMLbMQ7qKT3nJJeULt0Hv+Kip4Vrnvwhtko63gHODJxbUrbunj 6crUFY20L32SF7vDXFtlyxiOMrwZto289IuvP+mfX8UPqLyOUFBA8dKPesOUtrOXtPgaGXkiJTw8 cLLqwbo1xXcEEByPQD70Bh/EikENhZvVEWx0Gs8P9p9CCZy52OaXNkb+RxDCPw2AW+s4VD1xgFXv 39yMBrdvB8OuOPoDAvCNSHkaIf4UQZ7qZVot01qZ1gtSmnLYAiK8MePb9NFuBCKai/166d1/DtzE Vme+Nzg9PyeVh2oLa8EX8btp6n5GagZ+dBBAeYYAJHfRPxuSwfnV+4s++cdbbKg9v74il72bv+YI yd8eVyt6uwAXw7N2F2bqV+FHuwI/Ou2CwHBz/v7DVhQCQ2czhg7HMHBFD/bSBsMWWyg8SBjMtKwk 64Z89zI8c0FeEEWcEEQ6KriOdBS7bcLTMdDs3GkupZtvQOlTSsj1OqHKKVWEAfmXPp7tFUCr33Aj UDRRPsMTv/I/L8blRKdj6rWsZcDmiEEjeTyKwlbgtcMoLQmifL5G6scBWfnugVbvQMrgAjpt+N/5 XM6VZ9mnZBvK0yYrQK7xnYKRTxdLFh5Avuu/vX3/JE8swze15bPv+zdvrwf9p+jsEttd4aEXOLIz JJ84CNXEmadG7oRoNXVCLUKPtOLeh8C3seMl8Qcg1joisA9C9lM0Jw1dp6WSWZk0py0z7LZQO18S YBs7LMK+imqdN8DUNb2CDTAbznAxzcMMxp1OhSlavxjhW7f0gZqBj4dyOYYv/fM/AULeoCB/vs9f 9K7e3/be9wleEKEBhSdsaUWVJQ+kxl9Hxjmx7//5h8TxaDwnjr+tHRUn8MKkuKqcx7GFLPJPrtNu tavtTqsKF9VaHX7W8LJThYs6CkACjJY6h9kJ0FABWMBbsPROq9FstDr1RqdVrzc78LMJl412Ay46 uVfyNXBdvAbe0KpVXIpNESjSdfFDuoKYyXVv8IK8C5a2ZeKfUhBvhuAp+Ypiw5BGDB4l0Stni4tx Niw/+JjwzxSEeOQfGoGxa0YdEZB9ihIPd/moEeaKjpB7GmLBv5ZgTfA5WAa2tvM/QgEAvKPELYrz aR615BtNuFm4NPy5TIr+hH9DsJG/5t04KICFjQ1sbk19OTjxBozwa3BfI5+yMQhKTpPjtZ3C+ZwM 1SFG6Tgirp5CLV13XYPe9/3RsH/5cfAk9Wyr/yLgEUimWtIrpWom8/9sCdFfhUsAAA== --Apple-Mail=_8C41C755-6037-4557-9435-0416A566D310-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 01:47:43 2017 Received: (at 26779) by debbugs.gnu.org; 19 May 2017 05:47:43 +0000 Received: from localhost ([127.0.0.1]:54226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBalL-0004IT-Bs for submit@debbugs.gnu.org; Fri, 19 May 2017 01:47:43 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBalJ-0004IG-PS for 26779@debbugs.gnu.org; Fri, 19 May 2017 01:47:42 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C87431600B4; Thu, 18 May 2017 22:47:34 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Ye4vkycUsGxf; Thu, 18 May 2017 22:47:34 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1D02D1600B5; Thu, 18 May 2017 22:47:34 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xJG57HXUh0Ih; Thu, 18 May 2017 22:47:34 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id EFCAF1600B4; Thu, 18 May 2017 22:47:33 -0700 (PDT) Subject: Re: bug#26779: expr length To: Assaf Gordon , =?UTF-8?Q?P=c3=a1draig_Brady?= References: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> <7e7d15ef-a48b-5bfe-e9a4-32dc2235c2bb@cs.ucla.edu> <7115F2F1-4855-489C-AC3E-80787F63C30C@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <2fc23ee4-c0d5-639e-53ed-59ccc44d2b5a@cs.ucla.edu> Date: Thu, 18 May 2017 22:47:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <7115F2F1-4855-489C-AC3E-80787F63C30C@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26779 Cc: 26779@debbugs.gnu.org, =?UTF-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Assaf Gordon wrote: > The downside of 'mbstowcs' is that it fails and does not continue > when it encounters invalid multibyte sequences, It's OK for expr to report an error and exit in that case, which should b= e simple. It's not a big deal. > I fixed the one case I spotted - if I missed any, please let me know > ("make syntax-check" passes, but there could be others). char* -> char * MB_CUR_MAX=3D=3D1 -> MB_CUR_MAX =3D=3D 1 mbs_logical_cspn ('hello','a') -> mbs_logical_cspn ('hello', 'a') [in a c= omment] const char *_string -> const char *string * mbui_cur_ptr (iter) -> *mbui_cur_ptr (iter) (s+1) -> s + 1 Put */ at end of last line of comment, not at start of next. MB_CUR_MAX>1 -> MB_CUR_MAX > 1 xmalloc ( blen + 1 ) -> xmalloc (blen + 1) idx idx < pos mempcpy ( vlim -> mempcpy (vlim d>=3Dofs -> d >=3D ofs size_t c=3D0; -> size_t c =3D 0; No need to use "const" on locals, unless perhaps you take their address. Probably more instances; got tired of looking.... From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 27 21:41:52 2017 Received: (at 26779) by debbugs.gnu.org; 28 Jun 2017 01:41:52 +0000 Received: from localhost ([127.0.0.1]:41344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQ1zM-0002g0-8N for submit@debbugs.gnu.org; Tue, 27 Jun 2017 21:41:52 -0400 Received: from mail-qt0-f170.google.com ([209.85.216.170]:34454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQ1zK-0002fn-Ca for 26779@debbugs.gnu.org; Tue, 27 Jun 2017 21:41:50 -0400 Received: by mail-qt0-f170.google.com with SMTP id 32so39014459qtv.1 for <26779@debbugs.gnu.org>; Tue, 27 Jun 2017 18:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OyeloFrQKMBgBYTNbkNQpH0tqlG8cQHBkF5PzEQyFT8=; b=Zl68UbEwIWP9K3mBSaUoCfNuBIwIz5QLWLTT5zCtGRnzGYYWmQWgVSO4/nIYe37EBJ EU01Jy4DeVjbdldsMDl9NwNtdS7saToM0iUU4PqGBLI6lr302xo4ZsxJA9p6sW5u3rl5 aPmM3CR+tVEb/583ONdxuDKB/EcR+1MzPxHSP/uoaJVCLQgjyiF0CkVR+Y+05q/W0a9L 9gftADFK+8t6rY3RonlHnZm6hH4Dyt9JZ2SBx7fduTsZjpXFhOI70pFhVWZWtYx/jQzO n7Cnhq4hLfThpv6+oyuIU4WdYeom0Ew13Kj8UCp56wibF+BnvVwwTDNcg4hdw6kDxIAd V+jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OyeloFrQKMBgBYTNbkNQpH0tqlG8cQHBkF5PzEQyFT8=; b=erODW4iwM40s5aer0P9DYBnJ/SFfcXvJ6EXjvOI3md4n24gXeEyon3JwRkftyrmf1G 9qMKF5bXp66UGQwywT93UT7VOeYVnD/03RURyNdvVnGPDrIzMaIBUrWbvRqO/x/n/RNR 0XekBALthTS0QS7vtOuZHXjSQITf+S2mKSInLZuMfExqiZx6a9iGziqQW9FtP+7VGLA9 CuLQmPDvtQcpTYxZgjfL3yJNTc5+svDZKTbJtiw3dBYZDb8oeL3Td91aX4Jg7shVfb8/ SGFdAcuJovb8s3SVp8UfSN4UI7W7P7d3KSg80nLkluRJ+IYiZjYuEHnsA24aS96+F9d2 Q8EA== X-Gm-Message-State: AKS2vOyKRZL36v6xLn8ft5qzJoVYm0bFZVR2YckdBPZZd4/NIX7weX2q t19AGdXMZeEpEw== X-Received: by 10.237.37.116 with SMTP id w49mr10672131qtc.14.1498614104725; Tue, 27 Jun 2017 18:41:44 -0700 (PDT) Received: from gmail.com (housegordon.org. [104.236.108.240]) by smtp.gmail.com with ESMTPSA id w28sm741546qth.8.2017.06.27.18.41.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jun 2017 18:41:43 -0700 (PDT) Date: Wed, 28 Jun 2017 01:41:05 +0000 From: Assaf Gordon To: Paul Eggert Subject: Re: bug#26779: expr length Message-ID: <20170628014104.GC12440@gmail.com> References: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> <7e7d15ef-a48b-5bfe-e9a4-32dc2235c2bb@cs.ucla.edu> <7115F2F1-4855-489C-AC3E-80787F63C30C@gmail.com> <2fc23ee4-c0d5-639e-53ed-59ccc44d2b5a@cs.ucla.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="v9Ux+11Zm5mwPlX6" Content-Disposition: inline In-Reply-To: <2fc23ee4-c0d5-639e-53ed-59ccc44d2b5a@cs.ucla.edu> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26779 Cc: 26779@debbugs.gnu.org, =?utf-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= , =?iso-8859-1?Q?P=E1draig?= Brady X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --v9Ux+11Zm5mwPlX6 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Hi, Attached work-in-progress for expr/multibyte, hopefully fixing all (most?) of the coding style issues (Internal conversion to wide strings not yet implemented). Comments welcomed, - assaf --v9Ux+11Zm5mwPlX6 Content-Type: application/gzip Content-Disposition: attachment; filename="0001-expr-add-multibyte-support.patch.gz" Content-Transfer-Encoding: base64 H4sICC0HU1kAAzAwMDEtZXhwci1hZGQtbXVsdGlieXRlLXN1cHBvcnQucGF0Y2gArDzrcuLI er/DU/TiqQOYqwADZtY+w3jwDDm+TAw+u5vxlEsSDeiMkFi1hO2dcaqSVOUJ8iL5mVSeYfcZ 8ib5vu6W1BI3s2epWaNL99ff/dbNnnvunOjHk7pBj4wJNevwp9Mya50jrd1pN7T68XGr2Wrr raMGpeTSdciQLojWJrVal/8j9VpNy5wDmC7pMaZPyHvXG8O473W8m/KbN9O5btkV052fZt7p Pu2SH+i4ROod8o+BAxAQntatN7pHdVKswSczDIy/UdPvkk8fe6OzD58JfVx4XaKPx2Qe2L5l PPmUsGCxcD0/k3lnMTNgjI6J5ZCZ7y9Yt1o1gimrTJ2g4nrTar3Vbh+TSiZzSK76Pwy75JI6 vgVo+jNKrPnCc5d0Do8qMMBwXZ/5nr4AhJ0JkAWLAhzbMsjcHQc2ZWRuMJs6JfgyZx7OYZ5Z RRQrJsnD03vbnVqmbt+zwABQhS65og9kEjimWNQlHvUDzyE6ESMsZ5oxdKQAXsvJxJzpnm76 1CMLl1k4k5G85TCf6jBuQpAJrFDJJFY02cKB9YbW3LJ1D5cC8PiwitjCd4kYgS/XZ8QJ5gYs 4E4yK6sykloLvieM+nJBcXPvu/c4g22mMVoiJCyjLDGxfB+IR8HpZGotqZNaauyaru0iSTcU pU3mum/OgFG78WUwnS51uwWTz12PgMim/qwqOF61nDF9JO6CejpnbYkEjK6BmklDhb8EhtiI NqqPboDyEEchnqFKwEifVeegmkIzFjYngeo+gcniNXmw/BlxXKd8BisDUIp8G1MfdJ/ozlPG o1OPMrYBZjmyBQ4d+a+AjQ3FchaBH8/nK1XmX4RqO3IWiMKmlUy5XM5wGyGbPt/gvyNSzKQM Zc2oOo5STGMdLK3dJMVtnzLHKIn5mrU0XGsbf2BUvd7avlbyswIPoSRWrdeIGNji3GOoNs4U fVtTq6E6Uo/rQ75YKBGtA5K1qXhQLmSI6YEyUHQqlGi1WvvoaCsBmczYmkxIuTy1QDmqXEYG /8oIXa61NYM2jUrF6DSaE11DoK1mE0Uqx2cA2XDOmzek3GyWgCPw95jA7furW2K6Hg18y2bb dUD5lA/LxA18MAeK1xl4pDMwDN3PoUWCajALDMjxhVaixdSbZOYG4JysOSUT1wOTRuMbV3Dy J3DcMM/3wNeawqVHSJXbldrnDMkUCQ8IYDkPq55M9Qihs1DdJuLkeWBhCCaeJWxbTigIZHP8 NlfNdXPSU7gAFLybEoS48wbrBC04PBQ+EMQagNkCooQjqjtjgv8FjrxBvGX0ImxBTWvyhN5E d6TfQ6YQXzcAurtgXFRHDRTVUavU+UNFxRY2aJPEhYEPRndQLs/oY5kFk4n1SNmnkwmE98/A gNCxS8UVKo+MQki2+wCMNCGIEZitj4GqOTjSEEqJsDgkoRKUy8B76llmtJBcoaIIOEJsheGc RehIxb3iyENRDOKwLkUxX8KqS+oZLiCJMhiDZsLkwGIzWN6jjg4KiQIy3cVTAmTC9FKOz0g9 kObYqJm0VdcqlebYaLf1RtIcU1OEYaYeoty1oyMUPH5xyYtM5F5mIidZTpfhQWyTV777YIpL ptvW1EFeikRFXkVD2YM1FrKb0zkKzpwvwjsYnSBZ8eKGchOS2mx2JmanUmkfH2nNmpkkVRku yFQeIImNNlIIf9tAYIYcgIHaAfjE7NiilVlWfUI9z/VSzyA7mJaF6jB8VYxfzY3AAj+QmgAc BtUDYlPPH+GF79r8qeD9cZ3z/rhR0pqc+8wHhTAx8tmgQHOwQN0DXcwvXWtceJ1Jvg9AO/N/ 7V3c9snhUnmLg8kCtNZfJt+D4harhygmcg6M5WYysTyIza5pBuCzHBODOX8eJ4fSAIajm8HV e/RkkDjErzm0TXN6Z2f9jyM0GBx15i4s8JVo7VLNcjzVFVmj8N4PkJ6AXlCOC+vyeVoFEhvh hLWyyGLDhBXRERRM3ADtKsSgRMB8f6GeS6wJcFK+r3B49RAeAIL0LQCaGcd/NTHm6lciV9ej ZNooCOo/6vOFHaLJVT6RJ5N8bkZt282VcnquQMjJKantHjqTQ7XdQ10KY182FP7woQ2J+8Ah t6PzcofcPZ717x7fasgEKBdAbLYqyTwkiPQLeMLFTC9sITQEY5iwWHizE7vELFNiSA6rmaLU ZWb9Qu8hkq7OxcDvc0TJIXh/9VY3TbrwC5niV1xZgCDW+JGckNprQT9oRV4M+1T7TE5OSO6u lisIRGVdEQ6tHpL31AFXbfPoUyEcPwHi8u392e3N/WXvRwJ0yvlfJb0E3cM9OgiM64gCXEqg +MEIkxdjHHCCeYvrLSu8FhP1JRS14mn0aLzU0UbFw0IISFkSP8Ui0PpafYKozo178MxyQbD2 EAgSrxXU0SlwMQB08iHbSuQwhHS/8CNohfTMiJ1pnAh5Vm+pzegOJNLs1FP8DD9pvuqCsVIr Xq9iGMKWHNcFy7eMC8Wgp+WQ5Nc9/TkArVFYLiaUSFoIa0C8jHHPMfmgp5GjkyqqQKlJGHxu zOyvymxh+2Xu6ES1WFLWBQOD1Cas7MF1Kg4Rc67QNcu6d533VbAKjRJMUvYPSJ6tykgin2ef rM/kzzC8CIVYl9QKMTXPIqqBM/bRZXFHHjU9MD4MSyLkrHh3DiKKJB+vhzw1u+hfKRm+iBgi xKz2S9BnamKIOt2jEMCQJ6vVfomzw4Vrn4Vh5HYBkOijBTYFvGRkWT5lYRaL6bIgRSwzSjwj c2s684lBCZ0v/CfkNuBRRRx0D0M5hDdL8l06VOEhkw5VsGvFpUoZAbHRNXiQ0K2KYUvwA0vb mkszlMMM9DRcstzloEsDCQnF4k0SqQkhVDE87U1B4CKdRAggdYTKAYVsVWCFDpmD+h5xJt++ 8S9wbzW85mskr4eDf+7jakm/j2naOFiQfDZbiEOAUvRhhYL5e4KGpaDhcnAFSFDIZzgmZY4C KG1BiTsKmYrvVS1xqFgir3hiw1nCIo9Q+ICBQlqIa0jo8jXIAkZAir0wAcU8yAfXRyzKRCtx NAu7XcFlVA5Fyytvzwc/Xva7oJ+g/vDvQYfadxLYFTJ0ob6BtV0PW1gOKibTl9xXAMsCB4sh xaXMoESaYzYpamPUd14Qo2Yr/MbkdPGkeg9JZYIXhsKLHQE46YLGjyda9HBjTE544JX4TP70 J6EBp5GjTQxNxO2SiNCbwjfK/4u1IMgumzxQ0EvdFI0NsGGPtzMjBxTzBD+oXZjncANIxRQw bpga0FTAhNXOeDHqqFlfEiwUtWh66qMVPYP7OKwpGQE+XJ94qDx9VjTyUMLGjIwPkXa5fB07 e5G/Cw+Zbv/GZIBO5YERzDLsp7jCF3zBBpJ0klGFE9Yxwt1fnw9Tjlrm+ziM584iHc7ePfbr d4/H7+4ee+0sGkT2tlhvt9rk5nrUG/XfkfOL65veBfnQ792MyNvbi4v+KFsJs3AhV46AQW33 oYRPAC/EzXUAcayJlHYxTgPvJOODQLUpLSiP4UEu/jCzQGu47VjwqiGHYIzKPeaiVJ5n5dw2 sdUuw3k+QdPj0y/ZEmny5LxONmXnqX79pmjiTlgYQTZapxxqynz9D8uUIzMD9cQqE9YYoxKv ai04SxapJ1rVmJyeSNxDnTXALr9Eg4pFU3WrUmfNUGexZ4R1eYYETJ8iXo7P6/UAQAJivAXX bpbapNjW2iWtid0AuTcRFfEMvLm8XCwLGcW4lyLa3otyNs8ghQgq6Pg9eu/RKatwz/FJ+4xt gNjo5AWPAWUVFmAXwuIeWYka6/zVQO1YitRRlGQ8Y4z8Om4/SQU7STVG0wlwmP5Eo0IASmqW 8lJKSpkOsWtTefj8mYTUbRrRJWt1WzK4FM0vJCNEiodW0tfFX8h5USxIOIhuWZOyFWrROqqh WnRqNd7AInzLCeId9oDwOtDRp8kJcg0P1pfjoiGR5H1X+ps8VjnltRiHqZvH6VSoS2uHTNDi cXKRiUfpUqwQ4hS5cUk/J67dKuEuR6feKmmdHeS9mC57B7E8L4wLD1sKUxKxiSdi2CeYjLWI TOzUaiQEvNqsWFlhPTcxaqc5aO/FU1WnHPoIVg+UZ0WCny1EaiIJVPLvCKS9jcWWtvVt/eXi kRjYyUrBDvlDIphAyHe+q3vYHsxbUBVA/q48qBcUR5hygzyB51p23EHtKnaacn9jq5IpnBHy nEIOAPe4POJnqU6UKKVRYmg9Ghq71r+rRlGgrKdUGZD06AmZp9DeXbek5sm6j9d8qVeJfBzh g9/mnef0uPKp/7SgggTQiHUDMHytr3TSY9OZqDQ1OwyB6donNT+ZbiZeJhpUMpFJmXdYOocG zovlVLRcDc9ro/BGe7eQ6sRuSWq32kg9kLsmLU2r006nUqk3jgzToMldk9QUsXOSeoi2Uz+u 4SYFfvHwAwK5F6cATv4BP3eIrbqv7CzLuDVRYbN1b/kGZWVhr50q9sDFq+LKq8Ru9ZrpE8gL XG8DbPGyvIDsATR8A3YTHeymLNKycMQaxm84AGBsfZ3hJzgsO7EhH+6si0+l0qGTzqRZ4yKq jumyipxMyGYDcJRUrQSBVCvhKYQ3bzLFg++qAfOqhuVUF9QDKAdQwFDPtCA88M3Pdac4MFM9 4BWhx1tL+bOCOEB1DroI9f3Ef8DC5Bz7eXzvsgTJn1kR00bYEFh47tTT51gHof4SJud0yZMb 8K6AR3Ff1LOMAFfFgyjjKiT4wBZr8oRw4BmAxxYapICQ6s0ZZoB4g/vSYTP+Y2DYUINcWCZ1 gCQdlsYnbMb7DQgHZ2zGm1pYaBFIUfH8CxRIcg0JEHeQEEge6sQnPE0gtgALfPvL1v146gbq YyLHYWE5c8Hr8crTwuMKto0dkoBh86SEIPDk1A+D0Yfr2xHpXf1Efujd3PSuRj+95rJy4S3F E0zyUJmNu2lAlqc7/hMesQIIl/2bsw8wpfd2cDEY/YR92PPB6Ko/HJLz6xvSIx+hBh2c3V70 bsjH25uP18N+hZAhRbQoAtjC4QkXEnBxTH0ouJik+ycQKwPk7DGZ6UtsV5jUwqaPLre5d4kO gei4yxqe4Ij5CLgNeAcZW6OUfI+H77rV6sPDQ3T0zhZAWPWU44OHrJDvps8bHfn5E3l12Qf/ +6oGBey/EPatclj99o2/xHfg/C1fBnl5nUfnje9uB1cjCL3311DA/4AgxIDy6dfEm+d4JYn2 Pd/oX7NmOAbjDdpgLsZDHM+COf2rv369uD7rXfTvz2/ub0fnHVzgO+D6xMK+ezgUcoTwkv5M co7r0Bx6TazwzwJsIXW7DBtJ2VdRt44fxPLoz4GFzZHzmzKClxXbnZN9LUrVk4U7zhT/73// 89f/+e0/fvvXX//rt3//9b9/+zdI6r4sZp7OLIYFchYJEIfHsqjgPce08BjOe9wwBFmcmOhO kLZ4INCXvXv8qp1rzWf4brzt8a+zlvjSxEPxddYQd8firv4condwgBuyfTwYBxYhYpEsOrv8 7Yg/ippl8qiNkRMmx5X0K3D55DR7cXbfu7g4kXzMPvPp+ngMbBYV6Jzoge/OsdsBceMJyAZK wGUy3p+JnGdZR/dS2bw6g9X5wrzdg9rB3S23eOkI+GQvcKTvi07soTxDX+HzkzFjdHbKbg2T C6OEqaMbeGwGqgpw+lRfIg5nVS5nzio+NI+2TEGSeKTGnUNUtJjYTQdZUROXkHQWKlJD3wi6 TlDF8jy5OQBAsgUfS5jhY9kvOwBKHcvH0wLU/MIffQI5lG0tVyI5OVU3TNBseAA5Kvg9EEor +/y5JEcz/4Wj5YK9cAc7jmvqbj5nv0GnluPI3aG4/SYhqPvhYocceZW9LdZAMcn7m37/L2R4 CVpDLvqjUR986sXHD72sQl0d0MtKfOMNbkA7u4XIF01q703r3BqPbbqN0OY6QpvrCH3Xvxgl CG0oOINgQoDbCX3RpP0Jpc54DZUCz6ay5ISOTSNk8DY8XzQpjafccVOPk4GzxbMsCjpHCVG/ 1XRdV2E2U4i8bHiIgsPPH2Kb2qdr0CC6v5NdLVVCuo50b8PvZcP/QPzayoJKbFEX7aRwfMEU LZJliCy4N5Ge7+fdLO6vxEzhrsjEUD1WPYncS8fLRYdU98yZOJ4YBgG+TaFgwJ2JgBj7ktjS iJHdgs5ekxvKZFy5sWPyNtew3+TOJq6scRIVOUput4ShtST0S0yVzSlMkuIgi3sv0R4QB6Gc mZuIBCGPGBZkg5olDtXBxFCLRbhXt/IFw5o7aA4vt1jg74KhJdg32Oi3Qv+q4l9SWRSdGePk qqQdJdHam6x95+9LUkLwO2k6WLfLEW7WyfrHwGO/QhNKosYOT49jEsePZDIJDE/HlPhjLHAt R/flWWd+EqRs8h4BFJ9QCkGQgzpt8GNBZW5rp8yTzKlln0uQ9f44gBstyed9QSUzrv54Sst4 SqC7JfqRt9ejD+tUSQJBPqyTSlce0xbsneChVV3wV+VFez0BSeTJmpAU+XnZxtvP0TPuuOVU 6bnrpKG6bniYVOp95igrcZ8sZ62VkUYSeUmUqyQX/z1gVnBp7ALSIHUVSPQqhcy+cAxzBZXm LhDNtWxJY7IvmFVEjnZDqK9DhKYw2ReOuVZCrV1QWkl6Jiks9p0fs1RBor0LSDsJZKN/2hsS fWEcYAq2nQ1rSEVspJi+Krl9AIjnK06I+7U9fdCc+xMxU7oTfVuyudd4hF9fGZ+9y+vGXSGr ztKN1DL7TZMk4ukVj04x43am+CMi6fcFHAwOuUouefJlY7InsOc+RkxfqzkVcCqldbks0rDX 5NX4qhDlLviBragOBwkvLTcQ/biu+NWDi00jQS8/9sMXVpLOOBXlR5ZWzuqqZDd3Yb4D9YgF +wFKlnqXfBpPaaaeGywwuy7HqRUQHNLrxae5YioVco52YJG7u8tXjLu7gpmLkYlGpqT6u4Bt Eu4W58JbhajLkkg89yuWtVbzSAkuz/O8sEGLvywrKGxoJTFfxRqQ3oZzxII9AakxRiJ6FrVf TFtnjLJu1HBKnBwVFVbCpnl3k/mQ8bFYuz2a+PlJ2qqp2r2D+y9KQRYeoRMzt63MKGUpM0r8 akkC5BTJ36bkxHk5+VuWsshT/XW1npMwwPZWJeNM/hS++LzK7dXU7e+FGFtmIeyik95iQXlC 7dAH/ptN8Kyy78JPnEat4BzAycW1K7b0cXdl4oqTqa98khfdYa6t8nAYjtK9KR4YeeWXTz9p n1/HL6i8jkBQAPHKj06BKQfMXtHyKRLyTCq4eeBk1Y11a4KH7XE6boF86A0/CIlBDYXN6mhu tBvPt/SfQw6cu55JV4yR/88Cwp/QY2sdh6o7DiD1/s3N/fD27XDUFVt/gAD+dFDuRoif7Oep VqX1Km1UabMguSmHzSHC61Pepo+6EQhoJvr10rv/HLiJVme+NzwbDEjtsd7GWvAg/hGX2s9I rcC3DgIoz3ACyV30z0dkOLh6f9En/3SLB1QH11fksnfzlxwh+dtivaZ1CnAxOu90YaV+Hf50 avDnuFMQEG4G7z9sBCEgHK+HcMwhDF1xqHlhg2GLFgoPEjozLStJui5/pBjuuSAtCCJOCCId FVRHOornbMLdMdDs/y/l2lrbhqHwe36FyAZOQY1rxzcxBklXk5etG8val6ULudiLYSEedtps xf99+nRxrNgrgxkilFjn2JKPjhR/3znWO+vMNsfc6M+MUNi1YcpnpsgbDF6XwPYuuFWPxSRo WKI6B8TP/rZb2Qan8SyaKT8UW2igZAAoCtTaFhhFTZHG8VybnxAs7Pkxced8lLkLYBH/sAfb sr/3K5OGUnXNAvQaJP1FmezyQgOQN/H13bRSiKUOaVbn7uPP1x9ncVVjlynot2+BXSlmyMAA QqnEPCmZy6GlzQvSWj3uFe8+pL5OxouRKaHFiAAPQvEpgo3vOMlwuL7aBGm41myLJvPFEOtk WGhehSuyGPDSuQIBpgPDxTYPO5h9msqpmP1e6vDU5JisDyVAOatAdLxIlUHGGMifT4P3k9vp 3WQaE1SItICLChRWmCw5kpGI28U1waP/d5D41Bo48elbCyo29PKL4qmKPq4ydFEcFovCyI1Y 6PKKO/J4OUKVubziYQCUwCJ3hMyLAn5ToDgI8pXDQj/wQ+b5LPS8gPEy4FU/8nmFWW9UvLQj 46V96rp4FF0rUG3rslCu4NTJtjd4RW4O+Y9sjZwDMtQCKPljAsIQJUuxSsIr9y93q77++yHa 6Hh+rUdl5OBtW5O6voF+VW889vkvSoq9ZIQ8JVoL0gpkG5znMwNkcZGtgQsIRsn+UuLTYtVS IUJ4WZgvy63aFP2Hf4PYomx5NyHKxTSxodhmaakaGwEl0q/x3yn52j+JYOSoak9fHJwHc6nW GpXjqHtVaSttu67Z5D5efIk/fJpVys7+6r8I9wik5w6dodfr/QGgRN+srEoAAA== --v9Ux+11Zm5mwPlX6-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 28 12:33:03 2017 Received: (at 26779) by debbugs.gnu.org; 28 Jun 2017 16:33:03 +0000 Received: from localhost ([127.0.0.1]:42822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQFtn-0007tG-4j for submit@debbugs.gnu.org; Wed, 28 Jun 2017 12:33:03 -0400 Received: from mail.magicbluesmoke.com ([82.195.144.49]:35556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQFtl-0007sr-PJ for 26779@debbugs.gnu.org; Wed, 28 Jun 2017 12:33:02 -0400 Received: from localhost.localdomain (unknown [73.93.154.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id B1AB6949E; Wed, 28 Jun 2017 17:32:59 +0100 (IST) Subject: Re: bug#26779: expr length To: Assaf Gordon References: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> <7e7d15ef-a48b-5bfe-e9a4-32dc2235c2bb@cs.ucla.edu> <7115F2F1-4855-489C-AC3E-80787F63C30C@gmail.com> <2fc23ee4-c0d5-639e-53ed-59ccc44d2b5a@cs.ucla.edu> <20170628014104.GC12440@gmail.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <2ddefdc1-1664-0a63-ffd8-e559066a6005@draigBrady.com> Date: Wed, 28 Jun 2017 09:32:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170628014104.GC12440@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26779 Cc: 26779@debbugs.gnu.org, =?UTF-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 27/06/17 18:41, Assaf Gordon wrote: > Hi, > > Attached work-in-progress for expr/multibyte, > hopefully fixing all (most?) of the coding style issues > (Internal conversion to wide strings not yet implemented). > > Comments welcomed, > - assaf > Excellent work. This looks to have sufficient testing and is ready to push. We can look at using wide strings internally in a further patch. thanks! Pdraig. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 28 21:20:17 2017 Received: (at 26779-done) by debbugs.gnu.org; 29 Jun 2017 01:20:17 +0000 Received: from localhost ([127.0.0.1]:43197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQO81-00058k-JX for submit@debbugs.gnu.org; Wed, 28 Jun 2017 21:20:17 -0400 Received: from mail-qt0-f172.google.com ([209.85.216.172]:34264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQO80-00058X-6p for 26779-done@debbugs.gnu.org; Wed, 28 Jun 2017 21:20:16 -0400 Received: by mail-qt0-f172.google.com with SMTP id 32so63598748qtv.1 for <26779-done@debbugs.gnu.org>; Wed, 28 Jun 2017 18:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=X3NUadUkayJA0hV7oVAYHh4+6Fu5GRortct1sOPWn+g=; b=smww10PQ90HweEKMv3ANJoiHHXO1we+w7jRhgmLhbiie9vEWsQExtgp8iWmMD5hdVL 1vkAVCNy3PhNZRTAYEH+5Qr0utZnXhqn63Ms0SWXlFeDlB49kiLxKZVMxg1e86t7z5qK HxtiDskH3zo2WoSN6wN7I24QGxjPsAauwoDWpTa1MI43fGgSPx+n3d1w5KNJuwV6rAjC vftTMJNeX67EgYZDKIL1LrJw0eVE81Bm9Kim28dxySRaDWGsqVDt6SZwE+67HBgnfNhZ Ul4HpJrseen4wobZRUK0OBl/QgfZUAypivu2fVwi+p/wHLaSQNbGTEw3G8352jbi25TJ ZBOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=X3NUadUkayJA0hV7oVAYHh4+6Fu5GRortct1sOPWn+g=; b=AwY6KaLaJorIwFDzd+dYrigQHrt6zvK1HTNdUDe929SDCVJ6w99Iia9GVvgrYbOtMq /A9Ru2xKZRR22PWXlTUjEmz4WjrhJor6cW2dYQg7kho63/jlU5W9Ey/Nx1K09A4tBPv6 baBNDSTri3Rb78cZn9ZUu4RJMWUA2U9tBrh1WmHDWOfjBqK9h2ZOp5gaX6Mk21rrj1aR XRd1bxHWWJzaox2vrtLBw1hteVfKqiAHIFzfP0+uUOXjzL0bDD/7pRM3hZtyujGcwS1u 0CA/oTs4xAj8ktrtVwp0xcOBO8yz88ZWzS/ckBM86lwdXBmhpKDIPCp8/be1lH30Zinc MpxQ== X-Gm-Message-State: AKS2vOxCo8iGJAk3KAFtM2ixHeWggyDyJ6ymeC7C1ydspdmSepf4wCmH XR5PcaJF8Kc4sg== X-Received: by 10.237.50.4 with SMTP id y4mr16207977qtd.225.1498699210585; Wed, 28 Jun 2017 18:20:10 -0700 (PDT) Received: from [172.31.99.244] (rrcs-24-103-75-91.nyc.biz.rr.com. [24.103.75.91]) by smtp.gmail.com with ESMTPSA id 20sm2796283qke.10.2017.06.28.18.20.07 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Jun 2017 18:20:09 -0700 (PDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#26779: expr length From: Assaf Gordon In-Reply-To: <2ddefdc1-1664-0a63-ffd8-e559066a6005@draigBrady.com> Date: Wed, 28 Jun 2017 21:20:05 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <4E3ABDE6-8203-4803-B62B-4C7C4CABA89D@gmail.com> References: <201B3EE1-306C-45DB-A20C-EC68C1297469@gmail.com> <7e7d15ef-a48b-5bfe-e9a4-32dc2235c2bb@cs.ucla.edu> <7115F2F1-4855-489C-AC3E-80787F63C30C@gmail.com> <2fc23ee4-c0d5-639e-53ed-59ccc44d2b5a@cs.ucla.edu> <20170628014104.GC12440@gmail.com> <2ddefdc1-1664-0a63-ffd8-e559066a6005@draigBrady.com> To: =?windows-1252?Q?P=E1draig_Brady?= X-Mailer: Apple Mail (2.2102) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26779-done Cc: 26779-done@debbugs.gnu.org, =?utf-8?B?0JDQvdC00YDQtdC5INCS0L7RgNC+0L3QvtCy?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > On Jun 28, 2017, at 12:32, P=E1draig Brady wrote: >=20 > On 27/06/17 18:41, Assaf Gordon wrote: >> Attached work-in-progress for expr/multibyte, > This looks to have sufficient testing and is ready to push. > We can look at using wide strings internally in a further patch. Thanks, pushed here: = https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=3Da9f2be5bfec2b= fe86c08 I'm thus closing this bug report (but of course discussion can continue by replying to this thread). regards, - assaf From unknown Fri Sep 19 06:16:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 27 Jul 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator