GNU bug report logs - #26776
[PATCH] gnu: Add Parcimonie.

Previous Next

Full log

Message #8 received at 26776 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Petter <petter <at> mykolab.ch>
Cc: 26776 <at> debbugs.gnu.org
Subject: Re: bug#26776: [PATCH] gnu: Add Parcimonie.
Date: Thu, 11 May 2017 23:31:10 +0200

Hi Petter,

Petter <petter <at> mykolab.ch> skribis:

> From fdf2b751d19a1c9397535cb5054557b1fd711d23 Mon Sep 17 00:00:00 2001
> From: Petter <petter <at> mykolab.ch>
> Date: Sun, 30 Apr 2017 11:40:06 +0200
> Subject: [PATCH] gnu: Add Parcimonie.
>
> * gnu/packages/gnupg.scm: New variables.
> * gnu/packages/perl.scm: Same.
> * gnu/packages/web.scm: Same.
> * gnu/packages/xml.scm: Same.

Overall this looks good to me, and a useful addition!  There are a few
“cosmetic” things that I think should be addressed:

[...]

> +    (synopsis "Lorem Ipsum")
> +    (description "Lorem Ipsum")

Could you fix this?  :-)

> +(define-public perl-archive-extract
> +(package
> +  (name "perl-archive-extract")
> +  (version "0.80")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "mirror://cpan/authors/id/B/BI/BINGOS/Archive-Extract-"
> +             version
> +             ".tar.gz"))
> +      (sha256
> +        (base32
> +          "1x15j1q6w6z8hqyqgap0lz4qbq2174wfhksy1fdd653ccbaw5jr5"))))
> +  (build-system perl-build-system)
> +  (home-page
> +    "http://search.cpan.org/dist/Archive-Extract")
> +  (synopsis "Generic archive extracting mechanism")
> +  (description "It allows you to extract any archive file of the type .tar, .tar.gz, .gz, .Z, tar.bz2, .tbz, .bz2, .zip, .xz,, .txz, .tar.xz or .lzma without having to worry how it does so, or use different interfaces for each type by using either perl modules, or commandline tools on your system.")
> +  (license (package-license perl))))

Please run:

  ./etc/indent-code.el gnu/packages/perl.scm perl-archive-extract
  ./pre-inst-env guix lint perl-archive-extract

Likewise for the other packages here.

Last thing: we usually submit one package per patch.  Do you think you
could split the patch?  If not, if there are no objections (Ricardo?),
we could consider making an exception…

Thanks in advance!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.