GNU bug report logs - #26772
[PATCH 0/3] Fix guix refresh errors.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: bug#26772: closed (Re: bug#26772: [PATCH 2/3] import: cran:
 Robustify cran-package?.)
Date: Sat, 13 May 2017 10:46:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#26772: [PATCH 0/3] Fix guix refresh errors.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 26772 <at> debbugs.gnu.org.

-- 
26772: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26772
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26772-done <at> debbugs.gnu.org
Subject: Re: bug#26772: [PATCH 2/3] import: cran: Robustify cran-package?.
Date: Sat, 13 May 2017 12:44:57 +0200

Hi Ludo !

Thanks for the review.

> This can be written as:
>
>   (and start end (substring url …))

Done.

>
>> @@ -415,6 +417,9 @@ dependencies."
>>  (define (cran-package? package)
>>    "Return true if PACKAGE is an R package from CRAN."
>>    (and (string-prefix? "r-" (package-name package))
>> +       ;; Check if the upstream name can be extracted from package uri.
>> +       (package->upstream-name package)
>> +       ;; Check if package uri(s) are prefixed by "mirror://cran".
>>         (match (and=> (package-source package) origin-uri)
>>           ((? string? uri)
>>            (string-prefix? "mirror://cran" uri))
>
> OK!
>
> Do you think you could add this specific case (r-minimal) as a test case
> for ‘cran-package?’ in tests/cran.scm?  That would be awesome.
>
> Otherwise LGTM, thanks!

Sure I pushed this patch with the change above and a new test in
tests/cran.scm :

--8<---------------cut here---------------start------------->8---
(test-equal "r-mininal is not a cran package"
  #f
  ((@@ (guix import cran) cran-package?) r-minimal))
--8<---------------cut here---------------end--------------->8---

I also pushed the two other patches of the serie.

Mathieu

[Message part 3 (message/rfc822, inline)]

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH 0/3] Fix guix refresh errors.
Date: Thu,  4 May 2017 12:04:41 +0200

Hi Guix,

This serie fixes problems I ran into when running
guix refresh.

Thanks,

Mathieu

Mathieu Othacehe (3):
  gnu: python-termcolor: Fix uri.
  import: cran: Robustify cran-package?.
  import: pypi: Robustify latest-release.

 gnu/packages/python.scm     |  2 +-
 gnu/packages/statistics.scm |  1 +
 guix/import/cran.scm        |  7 ++++++-
 guix/import/pypi.scm        | 21 ++++++++++++---------
 4 files changed, 20 insertions(+), 11 deletions(-)

-- 
2.12.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.