GNU bug report logs - #26750
25.2; js-mode missing keywords

Previous Next

Full log

Message #11 received at 26750 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Ruslan Bekenev <furyinbox <at> gmail.com>
Cc: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>, 26750 <at> debbugs.gnu.org
Subject: Re: bug#26750: [PATCH] add missing keywords to js-mode
Date: Sat, 28 Apr 2018 17:08:09 -0400

forcemerge 26750 31306
quit

Ruslan Bekenev <furyinbox <at> gmail.com> writes:

> Hi. It is my first contribution. 
> I hope everything is correct with this PATCH and submission itself. 
> In this patch added two missed keywords to `js--keyword-re` which are `as` and `of`. 
> `async` and `await` are already there. 

Hi, sorry your patch was overlooked for so long.  Unfortunately, I think
just adding keywords to js--keyword-re will not quite do the right
thing, based on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31306#5:

    Specially, "as" and "from" should only be highlighted in an import
    statement. "of" should only be highlighted in a for statement. Any other
    occurrances of "as", "from" and "of" should not be highlighted as they
    are legal identifiers outside of import and for statements respectively.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.