Subject: Re: bug#26738: Build failures

From: Mathieu Lirzin <[email-masked]>
Date: Fri, 19 Jan 2018 12:31:47 +0100

Mathieu Lirzin <[email-masked]> writes:

> ‘hammer’ and ‘spanner’ are not found when running ‘make distcheck’
> because they are not ditributed in the tarball.  Those scripts are
> declared in the DEJATOOL special variable.  So I am wondering if the
> contents of this variable should be automatically distributed or not.
> If not here is a update for the test:
>
> diff --git a/t/check12.sh b/t/check12.sh
> index 34007896c..111f43318 100644
> --- a/t/check12.sh
> +++ b/t/check12.sh
> @@ -59,6 +59,7 @@ cat >> Makefile.am << 'END'
>  AUTOMAKE_OPTIONS += dejagnu
>  DEJATOOL = hammer spanner
>  AM_RUNTESTFLAGS = HAMMER=$(srcdir)/hammer SPANNER=$(srcdir)/spanner
> +EXTRA_DIST += $(DEJATOOL)
>  EXTRA_DIST += hammer.test/hammer.exp
>  EXTRA_DIST += spanner.test/spanner.exp
>  END

On second thought, I realize that distributing DEJATOOL automatically
would require handling ‘nodist_’ prefix in ‘automake’ since the content
of this variable could be generated scripts.  Given that this would
require a non negligeable amount of work, that seems more valuable to
require the package maintainers to add this variable to EXTRA_DIST
manually.

Let's apply this patch in a first step, and wait for a feature request
with a rationale before considering the other possibilty.

Commited in a0c7e40cf64d4512cc21ee5cdb9ba1341055f11c.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37