Subject: bug#26731: [PATCH 1/2] gnu: Add python-oauth2client.

From: Marius Bakke <[email-masked]>
Date: Mon, 01 May 2017 16:57:52 +0200

Danny Milosavljevic <[email-masked]> writes:

> * gnu/packages/python.scm (python-oauth2client): New variable.
> ---
>  gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 164c1f49b..dd83f2dd7 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -14011,3 +14011,30 @@ exception message with a traceback that points to the culprit.")
>  
>  (define-public python2-fudge
>    (package-with-python2 python-fudge))
> +
> +(define-public python-oauth2client
> +  (package
> +    (name "python-oauth2client")
> +    (version "4.0.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "oauth2client" version))
> +       (sha256
> +        (base32
> +         "1irqqap2zibysf8dba8sklfqikia579srd0phm5n754ni0h59gl0"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f))                    ; Django not found.

Please add a TODO here, maybe including the error message.

> +    (propagated-inputs
> +     `(("python-httplib2" ,python-httplib2)
> +       ("python-pyasn1" ,python-pyasn1)
> +       ("python-pyasn1-modules" ,python-pyasn1-modules)
> +       ("python-rsa" ,python-rsa)
> +       ("python-six" ,python-six)))
> +    (home-page
> +     "http://github.com/google/oauth2client/")

The line break here is unnecessary.

> +    (synopsis "OAuth 2.0 client library")
> +    (description "@code{python-oauth2client} provides an OAuth 2.0 client
> +library for Python")

...and this misses a punctuation

> +    (license license:asl2.0)))