GNU bug report logs - #26722
[PATCH] Add tailon.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26722: closed ([PATCH] Add tailon.)
Date: Mon, 01 May 2017 22:08:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 02 May 2017 00:07:48 +0200
with message-id <87pofsfcy3.fsf <at> fastmail.com>
and subject line Re: bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado.
has caused the debbugs.gnu.org bug report #26722,
regarding [PATCH] Add tailon.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26722: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26722
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add tailon.
Date: Sun, 30 Apr 2017 22:40:35 +0100

[Message part 3 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Christopher Baines <mail <at> cbaines.net>, 26722-done <at> debbugs.gnu.org
Subject: Re: bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado.
Date: Tue, 02 May 2017 00:07:48 +0200

[Message part 4 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> On 01/05/17 15:46, Marius Bakke wrote:
>> Hello Chris!
>> 
>> Christopher Baines <mail <at> cbaines.net> writes:
>> 
>>> * gnu/packages/python.scm (python-sockjs-tornado): New variable.
>> 
>> [...]
>> 
>>> +(define-public python-sockjs-tornado
>>> +  (package
>>> +    (name "python-sockjs-tornado")
>>> +    (version "1.0.3")
>>> +    (source
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri (string-append
>>> +             "https://pypi.python.org/packages/source/"
>>> +             "s/sockjs-tornado/sockjs-tornado-" version ".tar.gz"))
>> 
>> Please use 'pypi-uri' here.
>> 
>>> +       (sha256
>>> +        (base32
>>> +         "16cff40nniqsyvda1pb2j3b4zwmrw7y2g1vqq78lp20xpmhnwwkd"))))
>>> +    (build-system python-build-system)
>>> +    (inputs
>>> +     `(("python-tornado" ,python-tornado)))
>> 
>> Python does not have a good mechanism for specifying exact versions of
>> runtime dependencies, so they should normally be propagated. If the
>> package does not import this at runtime (e.g. only needed for tests) it
>> should be a 'native-input'.
>> 
>> LGTM with those changes.
>
> Thanks for the review Marius, I've now sent some updated patches.

Cheers! Pushed as 99aa2dce5d376b6612aab0971985f6320c03ecd2 :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.