Subject: Re: bug#26722: [PATCH 2/3] gnu: python-tornado: Update to 4.5.1.

From: Christopher Baines <[email-masked]>
Date: Mon, 1 May 2017 20:28:33 +0100

On 01/05/17 15:49, Marius Bakke wrote:
> Christopher Baines <[email-masked]> writes:
> 
>> * gnu/packages/python.scm (python-tornado): Update to 4.5.1.
>> ---
>>  gnu/packages/python.scm | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index 5fbc012b7..d01aa2f56 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -6135,13 +6135,13 @@ It is written entirely in Python.")
>>  (define-public python-tornado
>>    (package
>>      (name "python-tornado")
>> -    (version "4.3")
>> +    (version "4.5.1")
>>      (source
>>       (origin
>>         (method url-fetch)
>>         (uri (pypi-uri "tornado" version))
>>         (sha256
>> -        (base32 "1gzgwayl6hmc9jfcl88bni4jcsk2jcca9dn1rvrfsvnijcjx7hn9"))))
>> +        (base32 "1zbkgcdfq81k298awrm8p0xwbwwn2p3nbizdglzfbkskhai082fv"))))
> 
> LGTM, assuming the few dependent packages (from `guix refresh -l
> python{,2}-tornado`) still builds.

Thanks for pointing this out. I didn't spot any problems in existing
packages, although I did spot that the python2-sockjs-tornado failed to
build regardless of the version of python2-tornado. I think the issue
was the setup.py test command being run and pulling in some random
packages, which can be resolved by disabling the tests, as there are no
tests to run.