Subject: bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado.

From: Marius Bakke <[email-masked]>
Date: Mon, 01 May 2017 16:46:22 +0200

Hello Chris!

Christopher Baines <[email-masked]> writes:

> * gnu/packages/python.scm (python-sockjs-tornado): New variable.

[...]

> +(define-public python-sockjs-tornado
> +  (package
> +    (name "python-sockjs-tornado")
> +    (version "1.0.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://pypi.python.org/packages/source/"
> +             "s/sockjs-tornado/sockjs-tornado-" version ".tar.gz"))

Please use 'pypi-uri' here.

> +       (sha256
> +        (base32
> +         "16cff40nniqsyvda1pb2j3b4zwmrw7y2g1vqq78lp20xpmhnwwkd"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("python-tornado" ,python-tornado)))

Python does not have a good mechanism for specifying exact versions of
runtime dependencies, so they should normally be propagated. If the
package does not import this at runtime (e.g. only needed for tests) it
should be a 'native-input'.

LGTM with those changes.

> +    (home-page "http://github.com/mrjoes/sockjs-tornado/")
> +    (synopsis
> +     "SockJS python server implementation on top of Tornado framework")
> +    (description
> +     "SockJS-tornado provides the server side counterpart to a SockJS client
> +library, through the Tornado framework.
> +
> +SockJS provides a low latency, full duplex, cross-domain communication channel
> +between a web browser and web server.")
> +    (license license:expat)))
> +
> +(define-public python2-sockjs-tornado
> +  (package-with-python2 python-sockjs-tornado))
> +
>  (define-public python-socksipy-branch
>    (package
>      (name "python-socksipy-branch")
> -- 
> 2.12.2