Subject: bug#26717: closed (Re: bug#26717: [PATCH] gnu: gitolite: Avoid references to the store in authorized_keys.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 03 May 2017 19:48:03 +0000

Your bug report

#26717: Avoid references to the store in authorized_keys

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
26717: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26717
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#26717: [PATCH] gnu: gitolite: Avoid references to the store in authorized_keys.
From: Clément Lassieur <[email-masked]>
To: ng0 <[email-masked]>
Cc: [email-masked]
Date: Wed, 03 May 2017 21:47:26 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

ng0 <[email-masked]> writes:

> Clément Lassieur transcribed 1.3K bytes:
>> * gnu/packages/version-control.scm (gitolite)[arguments]: Substitute
>> '$glshell' with 'gitolite-shell' in ssh-authkeys.
>> ---
>>  gnu/packages/version-control.scm | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
>> index e0770dc58..1cad0f285 100644
>> --- a/gnu/packages/version-control.scm
>> +++ b/gnu/packages/version-control.scm
>> @@ -628,7 +628,13 @@ also walk each side of a merge and test those changes individually.")
>>                          ;; invokes Perl.
>>                          (substitute* (find-files "." ".*")
>>                            ((" perl -")
>> -                           (string-append " " perl " -"))))))
>> +                           (string-append " " perl " -")))
>> +
>> +                        ;; Avoid references to the store in authorized_keys.
>> +                        ;; This works because gitolite-shell is in the PATH.
>> +                        (substitute* "src/triggers/post-compile/ssh-authkeys"
>> +                          (("\\$glshell \\$user")
>> +                           "gitolite-shell $user")))))
>>                    (replace 'install
>>                      (lambda* (#:key outputs #:allow-other-keys)
>>                        (let* ((output (assoc-ref outputs "out"))
>> -- 
>> 2.12.2
>> 
>> 
>> 
>> 
>
> This looks good. I have yet to test it. Do you think we could fix the hook files of gitolite like this too?

Thank you :)  I pushed it.

Subject: Avoid references to the store in authorized_keys
From: Clément Lassieur <[email-masked]>
To: [email-masked]
Date: Sun, 30 Apr 2017 18:30:57 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Note that if gitolite is already installed, one has to remove the
references from authorized_keys manually first, because otherwise the
old (bugged) gitolite will be used instead of the one in the PATH, and
authorized_keys will never be updated.