GNU bug report logs - #26716
Test nginx configuration

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Clément Lassieur <clement <at> lassieur.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26716: closed (Test nginx configuration)
Date: Thu, 11 May 2017 15:54:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 11 May 2017 17:53:46 +0200
with message-id <87tw4rs839.fsf <at> lassieur.org>
and subject line Re: bug#26716: Test nginx configuration
has caused the debbugs.gnu.org bug report #26716,
regarding Test nginx configuration
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26716: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26716
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: Test nginx configuration
Date: Sun, 30 Apr 2017 12:04:53 +0200

[Message part 3 (text/plain, inline)]

Hi, here are two patches to react to Christopher's experience. I added
two simple tests that check the presence of the certificate and the key
passed to nginx configuration.

If the error log file cannot be created at startup, error messages
about the configuration file are logged only on stderr. The second
patch makes sure the log file can be created.

[0001-gnu-services-nginx-Test-certificate-presence.patch (text/x-patch, attachment)]

[0002-gnu-services-Create-logs-directory.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Clément Lassieur <clement <at> lassieur.org>
To: Christopher Allan Webber <cwebber <at> dustycloud.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 26716-done <at> debbugs.gnu.org
Subject: Re: bug#26716: Test nginx configuration
Date: Thu, 11 May 2017 17:53:46 +0200

Christopher Allan Webber <cwebber <at> dustycloud.org> writes:

> Julien Lepiller writes:
>
>>> So is the goal here that it will raise an exception if it doesn't
>>> exist, like so?
>>> 
>>>   ERROR: In procedure lstat: No such file or directory:
>>> "/tmp/no-such-file"
>>> 
>>> That does seem like useful information to spit out.
>>> 
>>> Maybe add a comment before the lstat explaining the call?  If I didn't
>>> know that's why lstat was being used here I would have been confused.
>> exactly, I added a comment.
>
> Great!
>
>>> Oh, that's interesting.  So in my experience earlier, it was proably
>>> *trying* to log some information, and failing I guess.
>>> 
>>> It would be even nicer if they wrote to the same file by default, but
>>> I guess this probably isn't easy to do without actually patching nginx
>>> itself, which isn't likely worth it... is that right?
>> I tried using the -g option to give it some configuration options
>> (including error_log), but it doesn't seem to change that behaviour, so
>> I think we'll have to fix nginx to use the same configuration file.
>>
>> Of course it would be better to fail at reconfigure when the generated
>> configuration is not correct. That's what I'm trying to do with the
>> first patch, but that's only one possible mistake.
>
> Cool... yes I agree it's only one possible mistake. :)
>
> Looks good.  I assume you've tried testing building with it?  Assuming
> all builds and things also error out right now in the new and expected
> ways when the configuration needs updating, I say push it!

Closing it as it has been pushed.  Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.