Subject: bug#26712: other-window/frame versions of find-library

From: Eli Zaretskii <[email-masked]>
Date: Tue, 16 May 2017 22:36:36 +0300

> From: "Charles A. Roelli" <[email-masked]>
> Date: Tue, 16 May 2017 21:08:07 +0200
> 
> Attached is a revised patch with Philipp's other suggestions taken into 
> account.

Thanks.  A few comments:

> +** Two new commands 'find-library-other-window' and
> +'find-library-other-frame'.

This is too terse.  A few words regarding what these do would be much
better.

> +(defun find-library (library)
> +  "Find the Emacs Lisp source of the LIBRARY near point.

This is confusing, IMO.  Suggest to reword:

    Find the Emacs Lisp source of LIBRARY.
  Interactively, prompt for LIBRARY using the one at or near point as
  the default.

> +(defun read-library-name ()
> +  "Read and return a library name, defaulting to the one near point."

I would explain here what constitutes a "library name", i.e. how does
the function determine the library name at point.

> +(defun find-library-other-window (library)
> +  "Find, in another window, the file defining LIBRARY at or near point.

Any reason why the wording is different from that of find-library?