GNU bug report logs - #26709
Tests failing.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26709: closed (Tests failing.)
Date: Sun, 30 Apr 2017 04:00:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 29 Apr 2017 20:59:24 -0700
with message-id <faef5213-1349-c83c-cf60-66fbc7093266 <at> draigBrady.com>
and subject line Re: bug#26709: Tests failing.
has caused the debbugs.gnu.org bug report #26709,
regarding Tests failing.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26709: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26709
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Григорий Резников
 <grikukan <at> mail.ru>
To: Bug-coreutils <at> gnu.org
Subject: Tests failing.
Date: Sat, 29 Apr 2017 11:37:27 +0300

[Message part 3 (text/plain, inline)]

I've tried to improve tests coverage, so I've built and ran tests using following commands:

./configure CFLAGS="-g -fprofile-arcs -ftest-coverage"
make -j8
sudo make check -j8

After that I got FAIL on tests/mv/sticky-to-xpart and tests/rm/fail-2eperm.

Best regards,
Grigory Reznikov.

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Григорий Резников
 <grikukan <at> mail.ru>, 26709-done <at> debbugs.gnu.org
Subject: Re: bug#26709: Tests failing.
Date: Sat, 29 Apr 2017 20:59:24 -0700

On 29/04/17 01:37, Григорий Резников wrote:
> 
> I've tried to improve tests coverage, so I've built and ran tests using following commands:
> 
> ./configure CFLAGS="-g -fprofile-arcs -ftest-coverage"
> make -j8
> sudo make check -j8
> 
> After that I got FAIL on tests/mv/sticky-to-xpart and tests/rm/fail-2eperm.

Note there was a recently exposed race due to the extra steps to write the coverage files.
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.26-36-gc95c0a0
But your case is a permissions issue as the two root tests in question operate
as the "nobody" user by default, and thus can't rewrite the coverage files.

Note I can reproduce with `make coverage` (which uses these settings):
https://github.com/coreutils/gnulib/blob/94386a13/top/maint.mk#L1483-L1508

To avoid the issue you can use the NON_ROOT_USERNAME setting as described at:
https://github.com/coreutils/coreutils/blob/7ea15a57/README#L116-L136

So a recipe to generate coverage is:

  $ make -j8 coverage
    Overall coverage rate:
      lines......: 81.4% (43883 of 53881 lines)
      functions..: 89.5% (2335 of 2608 functions)
  $ sudo make -j8 build-coverage NON_ROOT_USERNAME=$USER SUBDIRS=.
  $ make gen-coverage
    Overall coverage rate:
      lines......: 82.5% (44476 of 53881 lines)
      functions..: 90.9% (2370 of 2608 functions)

You can view the html report with:
  xdg-open doc/coverage/index.html

I've updated the HACKING instructions as above and pushed.

cheers,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.